OFBiz › OFBiz - Dev

[PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 5 messages Options
Shi Jinghai-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

[PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Shi Jinghai-3
Hi there,

While typing implementation, runtimeOnly and etc. in build.gradle, I find they can be changed to comma separated style, as the build.gradle is a groovy file, for example:

implementation 'xerces:xercesImpl:2.11.0'
implementation 'com.google.zxing:core:3.4.0'
implementation 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2'
implementation 'com.googlecode.ez-vcard:ez-vcard:0.9.10'
implementation 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'

EQUALS to

implementation 'xerces:xercesImpl:2.11.0',
               'com.google.zxing:core:3.4.0',
               'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2',
               'com.googlecode.ez-vcard:ez-vcard:0.9.10',
               'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'

Just the same as
  int a, b
equals to
  int a
  int b

What do you think?

Kind Regards,

Shi Jinghai

Eugen Stan
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Eugen Stan
Hi Shi Jinghai,

What are the benefits?

Why do all this work?

It seems to me they are only mild cosmetic improvements (arguably an
improvement).

In my apps I usually copy dependencies from maven (the copy button) and
they include the 'implementation' word, as most similar sites do.

Example:
https://search.maven.org/artifact/org.huihoo/ofbiz-smart-framework/0.9.5/jar



La 30.06.2020 06:05, Shi Jinghai a scris:

> Hi there,
>
> While typing implementation, runtimeOnly and etc. in build.gradle, I find they can be changed to comma separated style, as the build.gradle is a groovy file, for example:
>
> implementation 'xerces:xercesImpl:2.11.0'
> implementation 'com.google.zxing:core:3.4.0'
> implementation 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2'
> implementation 'com.googlecode.ez-vcard:ez-vcard:0.9.10'
> implementation 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>
> EQUALS to
>
> implementation 'xerces:xercesImpl:2.11.0',
>                'com.google.zxing:core:3.4.0',
>                'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2',
>                'com.googlecode.ez-vcard:ez-vcard:0.9.10',
>                'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>
> Just the same as
>   int a, b
> equals to
>   int a
>   int b
>
> What do you think?
>
> Kind Regards,
>
> Shi Jinghai
>
>
--
Eugen Stan
+40720 898 747 / netdava.com


eugen_stan.vcf (181 bytes) Download Attachment
signature.asc (499 bytes) Download Attachment
Shi Jinghai-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Shi Jinghai-3
Hi Eugen,

I agree this proposal is mild cosmetic :)


发件人: Eugen Stan<mailto:[hidden email]>
发送时间: 2020年6月30日 17:07
收件人: [hidden email]<mailto:[hidden email]>; Shi Jinghai<mailto:[hidden email]>
主题: Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Hi Shi Jinghai,

What are the benefits?

Why do all this work?

It seems to me they are only mild cosmetic improvements (arguably an
improvement).

In my apps I usually copy dependencies from maven (the copy button) and
they include the 'implementation' word, as most similar sites do.

Example:
https://search.maven.org/artifact/org.huihoo/ofbiz-smart-framework/0.9.5/jar



La 30.06.2020 06:05, Shi Jinghai a scris:

> Hi there,
>
> While typing implementation, runtimeOnly and etc. in build.gradle, I find they can be changed to comma separated style, as the build.gradle is a groovy file, for example:
>
> implementation 'xerces:xercesImpl:2.11.0'
> implementation 'com.google.zxing:core:3.4.0'
> implementation 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2'
> implementation 'com.googlecode.ez-vcard:ez-vcard:0.9.10'
> implementation 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>
> EQUALS to
>
> implementation 'xerces:xercesImpl:2.11.0',
>                'com.google.zxing:core:3.4.0',
>                'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2',
>                'com.googlecode.ez-vcard:ez-vcard:0.9.10',
>                'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>
> Just the same as
>   int a, b
> equals to
>   int a
>   int b
>
> What do you think?
>
> Kind Regards,
>
> Shi Jinghai
>
>
--
Eugen Stan
+40720 898 747 / netdava.com


Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Jacques Le Roux
Administrator
Hi Jinghai,

Actually I prefer the current version. I find it easier to maintain: eg when you add a line you simply copy the line above and don't need to worry
about the comma.

I can't remember the number of cases I forgot a comma in the Buildbot config file :)

Jacques

Le 30/06/2020 à 11:19, Shi Jinghai a écrit :

> Hi Eugen,
>
> I agree this proposal is mild cosmetic :)
>
>
> 发件人: Eugen Stan<mailto:[hidden email]>
> 发送时间: 2020年6月30日 17:07
> 收件人: [hidden email]<mailto:[hidden email]>; Shi Jinghai<mailto:[hidden email]>
> 主题: Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?
>
> Hi Shi Jinghai,
>
> What are the benefits?
>
> Why do all this work?
>
> It seems to me they are only mild cosmetic improvements (arguably an
> improvement).
>
> In my apps I usually copy dependencies from maven (the copy button) and
> they include the 'implementation' word, as most similar sites do.
>
> Example:
> https://search.maven.org/artifact/org.huihoo/ofbiz-smart-framework/0.9.5/jar
>
>
>
> La 30.06.2020 06:05, Shi Jinghai a scris:
>> Hi there,
>>
>> While typing implementation, runtimeOnly and etc. in build.gradle, I find they can be changed to comma separated style, as the build.gradle is a groovy file, for example:
>>
>> implementation 'xerces:xercesImpl:2.11.0'
>> implementation 'com.google.zxing:core:3.4.0'
>> implementation 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2'
>> implementation 'com.googlecode.ez-vcard:ez-vcard:0.9.10'
>> implementation 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>>
>> EQUALS to
>>
>> implementation 'xerces:xercesImpl:2.11.0',
>>                 'com.google.zxing:core:3.4.0',
>>                 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2',
>>                 'com.googlecode.ez-vcard:ez-vcard:0.9.10',
>>                 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>>
>> Just the same as
>>    int a, b
>> equals to
>>    int a
>>    int b
>>
>> What do you think?
>>
>> Kind Regards,
>>
>> Shi Jinghai
>>
>>
> --
> Eugen Stan
> +40720 898 747 / netdava.com
>
>
Shi Jinghai-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Shi Jinghai-3
Hi Jacques,

OK, agree.

发件人: Jacques Le Roux<mailto:[hidden email]>
发送时间: 2020年6月30日 21:23
收件人: [hidden email]<mailto:[hidden email]>
主题: Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?

Hi Jinghai,

Actually I prefer the current version. I find it easier to maintain: eg when you add a line you simply copy the line above and don't need to worry
about the comma.

I can't remember the number of cases I forgot a comma in the Buildbot config file :)

Jacques

Le 30/06/2020 à 11:19, Shi Jinghai a écrit :

> Hi Eugen,
>
> I agree this proposal is mild cosmetic :)
>
>
> 发件人: Eugen Stan<mailto:[hidden email]>
> 发送时间: 2020年6月30日 17:07
> 收件人: [hidden email]<mailto:[hidden email]>; Shi Jinghai<mailto:[hidden email]>
> 主题: Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma separated style?
>
> Hi Shi Jinghai,
>
> What are the benefits?
>
> Why do all this work?
>
> It seems to me they are only mild cosmetic improvements (arguably an
> improvement).
>
> In my apps I usually copy dependencies from maven (the copy button) and
> they include the 'implementation' word, as most similar sites do.
>
> Example:
> https://search.maven.org/artifact/org.huihoo/ofbiz-smart-framework/0.9.5/jar
>
>
>
> La 30.06.2020 06:05, Shi Jinghai a scris:
>> Hi there,
>>
>> While typing implementation, runtimeOnly and etc. in build.gradle, I find they can be changed to comma separated style, as the build.gradle is a groovy file, for example:
>>
>> implementation 'xerces:xercesImpl:2.11.0'
>> implementation 'com.google.zxing:core:3.4.0'
>> implementation 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2'
>> implementation 'com.googlecode.ez-vcard:ez-vcard:0.9.10'
>> implementation 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>>
>> EQUALS to
>>
>> implementation 'xerces:xercesImpl:2.11.0',
>>                 'com.google.zxing:core:3.4.0',
>>                 'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2',
>>                 'com.googlecode.ez-vcard:ez-vcard:0.9.10',
>>                 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
>>
>> Just the same as
>>    int a, b
>> equals to
>>    int a
>>    int b
>>
>> What do you think?
>>
>> Kind Regards,
>>
>> Shi Jinghai
>>
>>
> --
> Eugen Stan
> +40720 898 747 / netdava.com
>
>

Free forum by Nabble Edit this page