Patch to add support for Postgresql with TEXT type fields

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch to add support for Postgresql with TEXT type fields

Philip W. Dalrymple
Postgres does not require any extra cycles to support very long text
fields, see the manuals at 8.3. Character Types.

    Tip:  There are no performance differences between these three types, apart from increased storage
      size when using the blank-padded type, and a few extra cycles to check the length when storing
      into a length-constrained column. While character(n) has performance advantages in some other
      database systems, it has no such advantages in PostgreSQL. In most situations text or character
      varying should be used instead.

This is a feature that I have always (well from 7.x where it was added) and in general use TEXT for
all of my strings.

Attached is a patch that I have build wrt OfBiz r685532 that adds a new field type file that is a
copy of the postgresql types except that all of the varchar fields are changed to text.

I have installed this on a new copy of OfBiz and ran the system in demo/test and it appears not to
have any problems. The only limit on this is that data dumps from such a system may not be loadable
on a system running another fieldtype file.

The nature of this change is very simple but if it is necessary for me to file a copyright assigment
let me know.

--
This email, and any files transmitted with it, is confidential
and intended solely for the use of the individual or entity to
whom they are addressed.  If you have received this email in error,
please advise [hidden email] <mailto:[hidden email]>.

New MDT Software Headquarters (As of July 1, 2008):
3480 Preston Ridge Road
Suite 450
Alpharetta, GA 30005


Philip W. Dalrymple III <[hidden email]>
MDT Software - The Change Management Company
+1 678 297 1001
Fax +1 678 297 1003

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add support for Postgresql with TEXT type fields

BJ Freeman
Please use the Jira to submit patches.
it has a field for copyright.
https://issues.apache.org/jira/browse/OFBIZ



Philip W. Dalrymple sent the following on 8/14/2008 4:34 AM:

> Postgres does not require any extra cycles to support very long text
> fields, see the manuals at 8.3. Character Types.
>
>     Tip:  There are no performance differences between these three types, apart from increased storage
>       size when using the blank-padded type, and a few extra cycles to check the length when storing
>       into a length-constrained column. While character(n) has performance advantages in some other
>       database systems, it has no such advantages in PostgreSQL. In most situations text or character
>       varying should be used instead.
>
> This is a feature that I have always (well from 7.x where it was added) and in general use TEXT for
> all of my strings.
>
> Attached is a patch that I have build wrt OfBiz r685532 that adds a new field type file that is a
> copy of the postgresql types except that all of the varchar fields are changed to text.
>
> I have installed this on a new copy of OfBiz and ran the system in demo/test and it appears not to
> have any problems. The only limit on this is that data dumps from such a system may not be loadable
> on a system running another fieldtype file.
>
> The nature of this change is very simple but if it is necessary for me to file a copyright assigment
> let me know.
>

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add support for Postgresql with TEXT type fields

Philip W. Dalrymple
It is now in jirta under the framework Component (my best guess as
to where it should go) as

https://issues.apache.org/jira/browse/OFBIZ-1920


----- Original Message -----
From: "BJ Freeman" <[hidden email]>
To: [hidden email]
Sent: Thursday, August 14, 2008 9:04:10 AM GMT -05:00 US/Canada Eastern
Subject: Re: Patch to add support for Postgresql with TEXT type fields

Please use the Jira to submit patches.
it has a field for copyright.
https://issues.apache.org/jira/browse/OFBIZ



Philip W. Dalrymple sent the following on 8/14/2008 4:34 AM:

> Postgres does not require any extra cycles to support very long text
> fields, see the manuals at 8.3. Character Types.
>
>     Tip:  There are no performance differences between these three types, apart from increased storage
>       size when using the blank-padded type, and a few extra cycles to check the length when storing
>       into a length-constrained column. While character(n) has performance advantages in some other
>       database systems, it has no such advantages in PostgreSQL. In most situations text or character
>       varying should be used instead.
>
> This is a feature that I have always (well from 7.x where it was added) and in general use TEXT for
> all of my strings.
>
> Attached is a patch that I have build wrt OfBiz r685532 that adds a new field type file that is a
> copy of the postgresql types except that all of the varchar fields are changed to text.
>
> I have installed this on a new copy of OfBiz and ran the system in demo/test and it appears not to
> have any problems. The only limit on this is that data dumps from such a system may not be loadable
> on a system running another fieldtype file.
>
> The nature of this change is very simple but if it is necessary for me to file a copyright assigment
> let me know.
>



--
This email, and any files transmitted with it, is confidential
and intended solely for the use of the individual or entity to
whom they are addressed.  If you have received this email in error,
please advise [hidden email] <mailto:[hidden email]>.

New MDT Software Headquarters (As of July 1, 2008):
3480 Preston Ridge Road
Suite 450
Alpharetta, GA 30005


Philip W. Dalrymple III <[hidden email]>
MDT Software - The Change Management Company
+1 678 297 1001
Fax +1 678 297 1003