Please review the attached patch fro the HtmlFormRenderer class

[David E Jones-2]

On Jan 9, 2007, at 8:58 AM, Adrian Crum wrote:

> One of the things I noticed about this java file is that it doesn't  
> follow the current OFBiz formatting guidelines. I would like to  
> reformat the entire file to bring it up to standard. What do you  
> think?

If you do anything like this, please try to make it a separate  
submission from any functional changes.

-David

[Jacques Le Roux]

Adrian,

From: "Adrian Crum" <[hidden email]>

> Jacopo,
>
> Thanks for taking a look at this! Comments inline:
>
> Jacopo Cappellato wrote:
> > in your patch there are many lines changed just to suppress unnecessary
> > blanks; this is fine but it could hide the real mods you did and make
> > the review a bit more complex... I hope that this will not refrain the
> > other committers, and most of all David Jones, that is the master of
> > widgets :-) to read your patch and comment.
>
> I'm not doing any reformatting manually - my editor must be doing that without
> my knowledge. I don't know how to make it stop. I apologize for any confusion it
> causes.

If you are using AnyEdit in Eclipse, you might take a look at Preferences/General/Editors/AnyEditTools

You may also look at http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions?focusedCommentId=693#comment-693 and sequel

HTH

Jacques

[Adrian Crum]

Will do!

David E Jones wrote:

>
> On Jan 9, 2007, at 8:58 AM, Adrian Crum wrote:
>
>> One of the things I noticed about this java file is that it doesn't  
>> follow the current OFBiz formatting guidelines. I would like to  
>> reformat the entire file to bring it up to standard. What do you  think?
>
>
> If you do anything like this, please try to make it a separate  
> submission from any functional changes.
>
> -David
>