Possible bug in createInvoiceForOrderAllItems service definition

[Cimballi]

Hi,

I think there is a bug in the definition of the
"createInvoiceForOrderAllItems" service .
Here is the current definition :
    <service name="createInvoiceForOrderAllItems" engine="java"
        location="org.ofbiz.accounting.invoice.InvoiceServices"
invoke="createInvoiceForOrderAllItems">
        <description>
            Create an invoice from existing order using all order items
            orderId = The orderId to associate the invoice with
        </description>
        <attribute name="orderId" type="String" mode="IN" optional="false"/>
        <attribute name="invoiceId" type="String" mode="OUT" optional="true"/>
    </service>

But in the service method, there is this :
            Map resp = ServiceUtil.returnSuccess();
            resp.put("invoiceId", invoiceId);
            resp.put("invoiceTypeId", invoiceType);
            return resp;

And so it generates the following error :
(OUT) Required test error:
org.ofbiz.service.ServiceValidationException: Unknown parameter found:
[createInvoiceForOrderAllItems.invoiceTypeId]

Version : ofbiz-rel9.04-2009-09-25-v818777

Cimballi

[Scott Gray-2]

Could you please create a jira issue for it?

Thanks
Scott

HotWax Media
http://www.hotwaxmedia.com

On 8/10/2009, at 8:30 AM, Cimballi wrote:

> Hi,
>
> I think there is a bug in the definition of the
> "createInvoiceForOrderAllItems" service .
> Here is the current definition :
>    <service name="createInvoiceForOrderAllItems" engine="java"
>        location="org.ofbiz.accounting.invoice.InvoiceServices"
> invoke="createInvoiceForOrderAllItems">
>        <description>
>            Create an invoice from existing order using all order items
>            orderId = The orderId to associate the invoice with
>        </description>
>        <attribute name="orderId" type="String" mode="IN"  
> optional="false"/>
>        <attribute name="invoiceId" type="String" mode="OUT"  
> optional="true"/>
>    </service>
>
> But in the service method, there is this :
>            Map resp = ServiceUtil.returnSuccess();
>            resp.put("invoiceId", invoiceId);
>            resp.put("invoiceTypeId", invoiceType);
>            return resp;
>
> And so it generates the following error :
> (OUT) Required test error:
> org.ofbiz.service.ServiceValidationException: Unknown parameter found:
> [createInvoiceForOrderAllItems.invoiceTypeId]
>
> Version : ofbiz-rel9.04-2009-09-25-v818777
>
> Cimballi

[Cimballi-2]

Done here : https://issues.apache.org/jira/browse/OFBIZ-3010

Cimballi


On Wed, Oct 7, 2009 at 6:20 PM, Scott Gray <[hidden email]> wrote:

> Could you please create a jira issue for it?
>
> Thanks
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 8/10/2009, at 8:30 AM, Cimballi wrote:
>
>> Hi,
>>
>> I think there is a bug in the definition of the
>> "createInvoiceForOrderAllItems" service .
>> Here is the current definition :
>>   <service name="createInvoiceForOrderAllItems" engine="java"
>>       location="org.ofbiz.accounting.invoice.InvoiceServices"
>> invoke="createInvoiceForOrderAllItems">
>>       <description>
>>           Create an invoice from existing order using all order items
>>           orderId = The orderId to associate the invoice with
>>       </description>
>>       <attribute name="orderId" type="String" mode="IN" optional="false"/>
>>       <attribute name="invoiceId" type="String" mode="OUT"
>> optional="true"/>
>>   </service>
>>
>> But in the service method, there is this :
>>           Map resp = ServiceUtil.returnSuccess();
>>           resp.put("invoiceId", invoiceId);
>>           resp.put("invoiceTypeId", invoiceType);
>>           return resp;
>>
>> And so it generates the following error :
>> (OUT) Required test error:
>> org.ofbiz.service.ServiceValidationException: Unknown parameter found:
>> [createInvoiceForOrderAllItems.invoiceTypeId]
>>
>> Version : ofbiz-rel9.04-2009-09-25-v818777
>>
>> Cimballi
>
>