Possible enhancement in setInvoiceStatus ECA in secas_ledger.xml

[Cimballi]

Hi,

There is a possible enhancement in the "secas_ledger.xml" file, for
the 2 "setInvoiceStatus" ECAs.
There are 2 ECAs, one for Purchase Invoice and one for Sales Invoice.
The point is, these ECAs don't check the type of the invoice. In fact
the type is checked in the called service.
So maybe it can be useful to test the type of the invoice in the ECA,
to not call the service for nothing.

Version : ofbiz-rel9.04-2009-09-25-v818777

Cimballi

[Jacques Le Roux]

Right but there is no field to identify the invoice type from the ECA, I guess this is the reason

Jacques

From: "Cimballi" <[hidden email]>

> Hi,
>
> There is a possible enhancement in the "secas_ledger.xml" file, for
> the 2 "setInvoiceStatus" ECAs.
> There are 2 ECAs, one for Purchase Invoice and one for Sales Invoice.
> The point is, these ECAs don't check the type of the invoice. In fact
> the type is checked in the called service.
> So maybe it can be useful to test the type of the invoice in the ECA,
> to not call the service for nothing.
>
> Version : ofbiz-rel9.04-2009-09-25-v818777
>
> Cimballi
>

[Cimballi-2]

Ok, so "possible" was appropriate. :-)

Cimballi

On Sun, Nov 15, 2009 at 11:15 AM, Jacques Le Roux
<[hidden email]> wrote:

> Right but there is no field to identify the invoice type from the ECA, I
> guess this is the reason
>
> Jacques
>
> From: "Cimballi" <[hidden email]>
>>
>> Hi,
>>
>> There is a possible enhancement in the "secas_ledger.xml" file, for
>> the 2 "setInvoiceStatus" ECAs.
>> There are 2 ECAs, one for Purchase Invoice and one for Sales Invoice.
>> The point is, these ECAs don't check the type of the invoice. In fact
>> the type is checked in the called service.
>> So maybe it can be useful to test the type of the invoice in the ECA,
>> to not call the service for nothing.
>>
>> Version : ofbiz-rel9.04-2009-09-25-v818777
>>
>> Cimballi
>>
>
>