Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
250 posts
|
Hi,
I just wanted to have a look at the new FoFormRenderer and got the following error: org.xml.sax.SAXParseException: The entity "nbsp" was referenced, but not declared. A simple fix is to replace with   (patch attached) -- Christian Index: framework/widget/src/org/ofbiz/widget/form/ModelFormField.java =================================================================== --- framework/widget/src/org/ofbiz/widget/form/ModelFormField.java (Revision 430292) +++ framework/widget/src/org/ofbiz/widget/form/ModelFormField.java (Arbeitskopie) @@ -1712,7 +1712,7 @@ retVal = modelFormField.getEntry(context); } if (retVal == null || retVal.length() == 0) { - retVal = " "; + retVal = " "; } else if ("currency".equals(type)) { Locale locale = (Locale) context.get("locale"); if (locale == null) locale = Locale.getDefault(); @@ -1826,7 +1826,7 @@ retVal = fieldValue; } if (retVal == null || retVal.length() == 0) { - retVal = " "; + retVal = " "; } return retVal; } |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
1743 posts
|
Christian,
thanks for the patch, it's in svn with rev. 430317 However, I think that the ModelFormField class shouldn't contain html (or xml) specific encodings and tags... this is something we should fix sooner or later. I'm trying to fix other small issues about the PDF generation right now, so if you see something wrong please send me patches! Thanks, Jacopo Christian Geisert wrote: > Hi, > > I just wanted to have a look at the new FoFormRenderer and got the > following error: > > org.xml.sax.SAXParseException: The entity "nbsp" was referenced, but not > declared. > > A simple fix is to replace with   (patch attached) > > > > ------------------------------------------------------------------------ > > Index: framework/widget/src/org/ofbiz/widget/form/ModelFormField.java > =================================================================== > --- framework/widget/src/org/ofbiz/widget/form/ModelFormField.java (Revision 430292) > +++ framework/widget/src/org/ofbiz/widget/form/ModelFormField.java (Arbeitskopie) > @@ -1712,7 +1712,7 @@ > retVal = modelFormField.getEntry(context); > } > if (retVal == null || retVal.length() == 0) { > - retVal = " "; > + retVal = " "; > } else if ("currency".equals(type)) { > Locale locale = (Locale) context.get("locale"); > if (locale == null) locale = Locale.getDefault(); > @@ -1826,7 +1826,7 @@ > retVal = fieldValue; > } > if (retVal == null || retVal.length() == 0) { > - retVal = " "; > + retVal = " "; > } > return retVal; > } ... [show rest of quote]
|
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
1141 posts
|
jacopo,
have you looked at upgrading fop.jar? I plan on looking at that in the next couple of weeks. There are quite a few things that don't get ignored entirely in the .2x release that's in svn. Just dropping in the latest beta doesn't build and that's what I was going to look into. --- Jacopo Cappellato <[hidden email]> wrote: > Christian, > > thanks for the patch, it's in svn with rev. 430317 > However, I think that the ModelFormField class > shouldn't contain html > (or xml) specific encodings and tags... this is > something we should fix > sooner or later. > I'm trying to fix other small issues about the PDF > generation right now, > so if you see something wrong please send me > patches! > > Thanks, > > Jacopo > > > Christian Geisert wrote: > > Hi, > > > > I just wanted to have a look at the new > FoFormRenderer and got the > > following error: > > > > org.xml.sax.SAXParseException: The entity "nbsp" > was referenced, but not > > declared. > > > > A simple fix is to replace with > (patch attached) > > > > > > > > > ... [show rest of quote] ------------------------------------------------------------------------
> > > > Index: > framework/widget/src/org/ofbiz/widget/form/ModelFormField.java > > > =================================================================== > > --- > framework/widget/src/org/ofbiz/widget/form/ModelFormField.java > (Revision 430292) > > +++ > framework/widget/src/org/ofbiz/widget/form/ModelFormField.java > (Arbeitskopie) > > @@ -1712,7 +1712,7 @@ > > retVal = > modelFormField.getEntry(context); > > } > > if (retVal == null || retVal.length() > == 0) { > > - retVal = " "; > > + retVal = " "; > > } else if ("currency".equals(type)) { > > > Locale locale = (Locale) > context.get("locale"); > > if (locale == null) locale = > Locale.getDefault(); > > @@ -1826,7 +1826,7 @@ > > retVal = fieldValue; > > } > > if (retVal == null || retVal.length() > == 0) { > > - retVal = " "; > > + retVal = " "; > > } > > return retVal; > > } > ... [show rest of quote] |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
1743 posts
|
Chris,
I think we are using the latest stable release: 0.20.5 Jacopo Chris Howe wrote: > jacopo, > have you looked at upgrading fop.jar? I plan on > looking at that in the next couple of weeks. There > are quite a few things that don't get ignored entirely > in the .2x release that's in svn. > > Just dropping in the latest beta doesn't build and > that's what I was going to look into. > |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
250 posts
|
In reply to this post by cjhowe
Chris Howe schrieb:
> jacopo, > have you looked at upgrading fop.jar? I plan on > looking at that in the next couple of weeks. There > are quite a few things that don't get ignored entirely > in the .2x release that's in svn. > Just dropping in the latest beta doesn't build and > that's what I was going to look into. Yes, there was a big API change (but it should be stable now). I'd be happy to make the changes in OFBiz but I'd like to propose to use JAXG[1] which would make it simple to switch between different implementations (FOP 0.20.5, 0.92 or even other products). Christian [1]http://www.jeremias-maerki.ch/development/jaxg/ |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
250 posts
|
In reply to this post by Jacopo Cappellato
Jacopo Cappellato schrieb:
> Chris, > > I think we are using the latest stable release: 0.20.5 Umm, yeah 0.20.5 is labled as stable and 0.92 just beta and it will take some month until Apache FOP 1.0 is released but in fact I can't think of any reason to stick with the old 0.20.5. Some of the new features: -PNGs will work without extra jars -page-position="last" is implemented -RTF-Renderer is included -new AFP-Renderer -keep-* properties are working on blocks -PostScript-Extensions (for example tray selection) -AutoTableLayout will be coming soon (GSoC project) and a lot more .. There could be some minor problems with some stylesheets .. erm .. templates .. because 0.92 is more strict (conformant to the spec) than 0.20.5. So if want a FOP upgrade (and I hope you do ;-) I'm happy to make all the necessary changes (including comparing all pdf reports) and send a patch. -- Christian |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
1141 posts
|
+1
0.20.5 has particular problems ignoring some styles. and i don't think wee have many fo.ftl's that wouldn't be conforming to the standard, so i don't think it would break any current ones. thanks Christian! --- Christian Geisert <[hidden email]> wrote: > Jacopo Cappellato schrieb: > > Chris, > > > > I think we are using the latest stable release: > 0.20.5 > > Umm, yeah 0.20.5 is labled as stable and 0.92 just > beta > and it will take some month until Apache FOP 1.0 is > released but in fact I can't think of any reason to > stick with the old 0.20.5. > > Some of the new features: > -PNGs will work without extra jars > -page-position="last" is implemented > -RTF-Renderer is included > -new AFP-Renderer > -keep-* properties are working on blocks > -PostScript-Extensions (for example tray selection) > -AutoTableLayout will be coming soon (GSoC project) > and a lot more .. > > There could be some minor problems with some > stylesheets .. erm .. > templates .. because 0.92 is more strict (conformant > to the spec) than > 0.20.5. > > So if want a FOP upgrade (and I hope you do ;-) I'm > happy to make all > the necessary changes (including comparing all pdf > reports) and send a > patch. > -- > Christian > ... [show rest of quote] |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
1743 posts
|
Ok,
now I understand why Chris asked to upgrade. For me it's ok to go on with the upgrade, too. Jacopo Chris Howe wrote: > +1 > 0.20.5 has particular problems ignoring some styles. > and i don't think wee have many fo.ftl's that wouldn't > be conforming to the standard, so i don't think it > would break any current ones. thanks Christian! > > --- Christian Geisert <[hidden email]> > wrote: > >> Jacopo Cappellato schrieb: >>> Chris, >>> >>> I think we are using the latest stable release: >> 0.20.5 >> >> Umm, yeah 0.20.5 is labled as stable and 0.92 just >> beta >> and it will take some month until Apache FOP 1.0 is >> released but in fact I can't think of any reason to >> stick with the old 0.20.5. >> >> Some of the new features: >> -PNGs will work without extra jars >> -page-position="last" is implemented >> -RTF-Renderer is included >> -new AFP-Renderer >> -keep-* properties are working on blocks >> -PostScript-Extensions (for example tray selection) >> -AutoTableLayout will be coming soon (GSoC project) >> and a lot more .. >> >> There could be some minor problems with some >> stylesheets .. erm .. >> templates .. because 0.92 is more strict (conformant >> to the spec) than >> 0.20.5. >> >> So if want a FOP upgrade (and I hope you do ;-) I'm >> happy to make all >> the necessary changes (including comparing all pdf >> reports) and send a >> patch. >> -- >> Christian >> ... [show rest of quote]
|
Free forum by Nabble | Edit this page |