Product base promotion calculation

[Arvind singh tomar]

Hi Everyone,

I found the behavior of product base promotion calculation a bit strange. Need your advice on whether it is correct behaviour or need some improvement in promotion calculation.

The promotion which I used was to give 30% discount for the item (i.e. RAM1GB_BRAND). I created a sales order with 10 quantity of the product. During the promotion calculation, OFBiz created 10 OrderAdjustments, one for each quantity for the same promotion type.

I was expecting that in the case if same Promotion is applicable for more than one quantity of a product then a single OrderAdjustment should be created instead of creating one for each quantity. It is also messing up the UI.

Attached the screenshots for the same.

Thanks and Regards

--

Arvind Singh Tomar

[Mridul Pathak-4]

Hi Arvind,

Seems like you missed attaching the screenshot.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 7:16 PM, Arvind singh tomar <[hidden email]> wrote:
>
> Hi Everyone,
>
> I found the behavior of product base promotion calculation a bit strange. Need your advice on whether it is correct behaviour or need some improvement in promotion calculation.
>
> The promotion which I used was to give 30% discount for the item (i.e. RAM1GB_BRAND). I created a sales order with 10 quantity of the product. During the promotion calculation, OFBiz created 10 OrderAdjustments, one for each quantity for the same promotion type.
>
> I was expecting that in the case if same Promotion is applicable for more than one quantity of a product then a single OrderAdjustment should be created instead of creating one for each quantity. It is also messing up the UI.
>
> Attached the screenshots for the same.
>
>
> Thanks and Regards
> --
> Arvind Singh Tomar

[Arvind singh tomar]

Hi Mridul

I have attached the screenshots but it seems like attachments are being omitted on the mailing list. Sending them again as inline images in case if it works.

​

On 15 June 2016 at 19:19, Mridul Pathak <[hidden email]> wrote:

Hi Arvind,

Seems like you missed attaching the screenshot.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 15, 2016, at 7:16 PM, Arvind singh tomar <[hidden email]> wrote:
>
> Hi Everyone,
>
> I found the behavior of product base promotion calculation a bit strange. Need your advice on whether it is correct behaviour or need some improvement in promotion calculation.
>
> The promotion which I used was to give 30% discount for the item (i.e. RAM1GB_BRAND). I created a sales order with 10 quantity of the product. During the promotion calculation, OFBiz created 10 OrderAdjustments, one for each quantity for the same promotion type.
>
> I was expecting that in the case if same Promotion is applicable for more than one quantity of a product then a single OrderAdjustment should be created instead of creating one for each quantity. It is also messing up the UI.
>
> Attached the screenshots for the same.
>
>
> Thanks and Regards
> --
> Arvind Singh Tomar

At 99.99% you have no chances that an image get through ANY ASF ML. If you need to share you must find another way, easiest are Jira (if you need to
create an issue anyway), then Nabble, else a lot of other options ;)

Jacques


Le 15/06/2016 à 15:59, Arvind singh tomar a écrit :

> Hi Mridul
>
> I have attached the screenshots but it seems like attachments are being omitted on the mailing list. Sending them again as inline images in case if
> it works.
>
>
>
>
> ​
>
> On 15 June 2016 at 19:19, Mridul Pathak <[hidden email] <mailto:[hidden email]>> wrote:
>
>     Hi Arvind,
>
>     Seems like you missed attaching the screenshot.
>
>     --
>     Thanks & Regards,
>     Mridul Pathak
>     Senior Manager
>     HotWax Systems
>     http://www.hotwaxsystems.com
>
>     > On Jun 15, 2016, at 7:16 PM, Arvind singh tomar <[hidden email] <mailto:[hidden email]>> wrote:
>     >
>     > Hi Everyone,
>     >
>     > I found the behavior of product base promotion calculation a bit strange. Need your advice on whether it is correct behaviour or need some
>     improvement in promotion calculation.
>     >
>     > The promotion which I used was to give 30% discount for the item (i.e. RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
>     During the promotion calculation, OFBiz created 10 OrderAdjustments, one for each quantity for the same promotion type.
>     >
>     > I was expecting that in the case if same Promotion is applicable for more than one quantity of a product then a single OrderAdjustment should
>     be created instead of creating one for each quantity. It is also messing up the UI.
>     >
>     > Attached the screenshots for the same.
>     >
>     >
>     > Thanks and Regards
>     > --
>     > Arvind Singh Tomar
>
>

[Pranay Pandey-3]

Hi Arvind,

Yes I agree, If it's the promotion for one product than orderAdjustment
should also be one. Also please create a JIRA issue and attach your
screenshots there.


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
[hidden email]> wrote:

> Hi Everyone,
>
> I found the behavior of product base promotion calculation a bit strange.
> Need your advice on whether it is correct behaviour or need some
> improvement in promotion calculation.
>
> The promotion which I used was to give 30% discount for the item (i.e.
> RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
> During the promotion calculation, OFBiz created 10 OrderAdjustments, one
> for each quantity for the same promotion type.
>
> I was expecting that in the case if same Promotion is applicable for more
> than one quantity of a product then a single OrderAdjustment should be
> created instead of creating one for each quantity. It is also messing up
> the UI.
>
> Attached the screenshots for the same.
>
>
> Thanks and Regards
> --
> Arvind Singh Tomar
>

[Mridul Pathak-4]

Hi Arvind,

While I agree that current behavior can be improved as per your suggestion but at the same time considering different behaviors of the range of promotions we have, implementing a proper fix would be tricky. I think a JIRA ticket can be logged and solution can be discussed over there. If you have patch available please provide it on the ticket you create.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com

> On Jun 16, 2016, at 12:21 PM, Pranay Pandey <[hidden email]> wrote:
>
> Hi Arvind,
>
> Yes I agree, If it's the promotion for one product than orderAdjustment
> should also be one. Also please create a JIRA issue and attach your
> screenshots there.
>
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
> [hidden email]> wrote:
>
>> Hi Everyone,
>>
>> I found the behavior of product base promotion calculation a bit strange.
>> Need your advice on whether it is correct behaviour or need some
>> improvement in promotion calculation.
>>
>> The promotion which I used was to give 30% discount for the item (i.e.
>> RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
>> During the promotion calculation, OFBiz created 10 OrderAdjustments, one
>> for each quantity for the same promotion type.
>>
>> I was expecting that in the case if same Promotion is applicable for more
>> than one quantity of a product then a single OrderAdjustment should be
>> created instead of creating one for each quantity. It is also messing up
>> the UI.
>>
>> Attached the screenshots for the same.
>>
>>
>> Thanks and Regards
>> --
>> Arvind Singh Tomar
>>

[Pranay Pandey-3]

+1 Mridul.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Jun 16, 2016 at 1:32 PM, Mridul Pathak <
[hidden email]> wrote:

> Hi Arvind,
>
> While I agree that current behavior can be improved as per your suggestion
> but at the same time considering different behaviors of the range of
> promotions we have, implementing a proper fix would be tricky. I think a
> JIRA ticket can be logged and solution can be discussed over there. If you
> have patch available please provide it on the ticket you create.
>
> --
> Thanks & Regards,
> Mridul Pathak
> Senior Manager
> HotWax Systems
> http://www.hotwaxsystems.com
>
> > On Jun 16, 2016, at 12:21 PM, Pranay Pandey <
> [hidden email]> wrote:
> >
> > Hi Arvind,
> >
> > Yes I agree, If it's the promotion for one product than orderAdjustment
> > should also be one. Also please create a JIRA issue and attach your
> > screenshots there.
> >
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
> >
> > On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
> > [hidden email]> wrote:
> >
> >> Hi Everyone,
> >>
> >> I found the behavior of product base promotion calculation a bit
> strange.
> >> Need your advice on whether it is correct behaviour or need some
> >> improvement in promotion calculation.
> >>
> >> The promotion which I used was to give 30% discount for the item (i.e.
> >> RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
> >> During the promotion calculation, OFBiz created 10 OrderAdjustments, one
> >> for each quantity for the same promotion type.
> >>
> >> I was expecting that in the case if same Promotion is applicable for
> more
> >> than one quantity of a product then a single OrderAdjustment should be
> >> created instead of creating one for each quantity. It is also messing up
> >> the UI.
> >>
> >> Attached the screenshots for the same.
> >>
> >>
> >> Thanks and Regards
> >> --
> >> Arvind Singh Tomar
> >>
>
>

[Arvind singh tomar]

Thanks for your approval Mridul and Pranay. Also thank you, Jacques for
your image upload related suggestion :) .

Added a JIRA task and Here <http://Hi Everyone, Added a ticket for the
improvement and attached the screenshots over there> is the link for the
same.

On 16 June 2016 at 13:51, Pranay Pandey <[hidden email]>
wrote:

> +1 Mridul.
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Thu, Jun 16, 2016 at 1:32 PM, Mridul Pathak <
> [hidden email]> wrote:
>
> > Hi Arvind,
> >
> > While I agree that current behavior can be improved as per your
> suggestion
> > but at the same time considering different behaviors of the range of
> > promotions we have, implementing a proper fix would be tricky. I think a
> > JIRA ticket can be logged and solution can be discussed over there. If
> you
> > have patch available please provide it on the ticket you create.
> >
> > --
> > Thanks & Regards,
> > Mridul Pathak
> > Senior Manager
> > HotWax Systems
> > http://www.hotwaxsystems.com
> >
> > > On Jun 16, 2016, at 12:21 PM, Pranay Pandey <
> > [hidden email]> wrote:
> > >
> > > Hi Arvind,
> > >
> > > Yes I agree, If it's the promotion for one product than orderAdjustment
> > > should also be one. Also please create a JIRA issue and attach your
> > > screenshots there.
> > >
> > >
> > > Best regards,
> > >
> > > Pranay Pandey
> > > HotWax Systems
> > > http://www.hotwaxsystems.com/
> > >
> > > On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
> > > [hidden email]> wrote:
> > >
> > >> Hi Everyone,
> > >>
> > >> I found the behavior of product base promotion calculation a bit
> > strange.
> > >> Need your advice on whether it is correct behaviour or need some
> > >> improvement in promotion calculation.
> > >>
> > >> The promotion which I used was to give 30% discount for the item (i.e.
> > >> RAM1GB_BRAND). I created a sales order with 10 quantity of the
> product.
> > >> During the promotion calculation, OFBiz created 10 OrderAdjustments,
> one
> > >> for each quantity for the same promotion type.
> > >>
> > >> I was expecting that in the case if same Promotion is applicable for
> > more
> > >> than one quantity of a product then a single OrderAdjustment should be
> > >> created instead of creating one for each quantity. It is also messing
> up
> > >> the UI.
> > >>
> > >> Attached the screenshots for the same.
> > >>
> > >>
> > >> Thanks and Regards
> > >> --
> > >> Arvind Singh Tomar
> > >>
> >
> >
>

[Arvind singh tomar]

Link for the issue: https://issues.apache.org/jira/browse/OFBIZ-7359

On 16 June 2016 at 14:03, Arvind singh tomar <[hidden email]>
wrote:

> Thanks for your approval Mridul and Pranay. Also thank you, Jacques for
> your image upload related suggestion :) .
>
> Added a JIRA task and Here is the link for the same.
>
> On 16 June 2016 at 13:51, Pranay Pandey <[hidden email]>
> wrote:
>
>> +1 Mridul.
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>> On Thu, Jun 16, 2016 at 1:32 PM, Mridul Pathak <
>> [hidden email]> wrote:
>>
>> > Hi Arvind,
>> >
>> > While I agree that current behavior can be improved as per your
>> suggestion
>> > but at the same time considering different behaviors of the range of
>> > promotions we have, implementing a proper fix would be tricky. I think a
>> > JIRA ticket can be logged and solution can be discussed over there. If
>> you
>> > have patch available please provide it on the ticket you create.
>> >
>> > --
>> > Thanks & Regards,
>> > Mridul Pathak
>> > Senior Manager
>> > HotWax Systems
>> > http://www.hotwaxsystems.com
>> >
>> > > On Jun 16, 2016, at 12:21 PM, Pranay Pandey <
>> > [hidden email]> wrote:
>> > >
>> > > Hi Arvind,
>> > >
>> > > Yes I agree, If it's the promotion for one product than
>> orderAdjustment
>> > > should also be one. Also please create a JIRA issue and attach your
>> > > screenshots there.
>> > >
>> > >
>> > > Best regards,
>> > >
>> > > Pranay Pandey
>> > > HotWax Systems
>> > > http://www.hotwaxsystems.com/
>> > >
>> > > On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
>> > > [hidden email]> wrote:
>> > >
>> > >> Hi Everyone,
>> > >>
>> > >> I found the behavior of product base promotion calculation a bit
>> > strange.
>> > >> Need your advice on whether it is correct behaviour or need some
>> > >> improvement in promotion calculation.
>> > >>
>> > >> The promotion which I used was to give 30% discount for the item
>> (i.e.
>> > >> RAM1GB_BRAND). I created a sales order with 10 quantity of the
>> product.
>> > >> During the promotion calculation, OFBiz created 10 OrderAdjustments,
>> one
>> > >> for each quantity for the same promotion type.
>> > >>
>> > >> I was expecting that in the case if same Promotion is applicable for
>> > more
>> > >> than one quantity of a product then a single OrderAdjustment should
>> be
>> > >> created instead of creating one for each quantity. It is also
>> messing up
>> > >> the UI.
>> > >>
>> > >> Attached the screenshots for the same.
>> > >>
>> > >>
>> > >> Thanks and Regards
>> > >> --
>> > >> Arvind Singh Tomar
>> > >>
>> >
>> >
>>
>
>