ProductStoreEmailSetting code duplication

[Adam Heath-2]

I was noticing several cases where code was fetching a
ProductStoreEmailSetting, then doing various setup work, before
calling sendEmailFromScreen.  None of the setup blocks are the same,
the set of features they support are not unified.

I'd like to move all these separate calls into a single shared worker
method.

Then, the second phase, would add a feature that would call a service
to send the email, instead of always forcing it to be a screen.

Anyone else agree with this?

[Rishi Solanki]

+1.
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.


On Wed, Mar 10, 2010 at 5:31 AM, Adam Heath <[hidden email]> wrote:

> I was noticing several cases where code was fetching a
> ProductStoreEmailSetting, then doing various setup work, before
> calling sendEmailFromScreen.  None of the setup blocks are the same,
> the set of features they support are not unified.
>
> I'd like to move all these separate calls into a single shared worker
> method.
>
> Then, the second phase, would add a feature that would call a service
> to send the email, instead of always forcing it to be a screen.
>
> Anyone else agree with this?
>

[awdesh parihar]

+1
--
Thanks & Regards
Awdesh Singh Parihar
Hotwax Media
http://www.hotwaxmedia.com
[hidden email]
-------------------------------------------------
direct: +91 - 989.335.1789