Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

[deepak nigam-2]

Hello Devs,

While creating the sales order from the backend, if we set the 'Ship Before
Date' it will be stored in OrderItemShipGroup.shipByDate field and same
will be propagated to OrderItemShipGrpInvRes.promisedDateTime
and OrderItemShipGrpInvRes.currentPromisedDate fields.

On updating the 'Ship Before Date' from the order view page later, the
value gets updated in OrderItemShipGroup entity but remains the same in
OrderItemShipGroupInvRes entity.

Is this the expected behaviour or OrderItemShipGroupInvRes should also get
updated? OrderItemShipGrpInvRes.promisedDateTime &
OrderItemShipGrpInvRes.currentPromisedDate is used in many services like
'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
'reserveProductInventory' etc.


Thanks & Regards
--
Deepak Nigam

[Suraj Khurana]

Hello Deepak,

This is interesting case. IMO, currentPromisedDate should also be updated
after updating 'Ship Before Date'.
Also, in mentioned services, I propose we should use currentPromisedDate
instead of promisedDateTime field.

--
Best Regards,
Suraj Khurana | Omni-channel OMS Technical Expert
Cell phone: [phone]


On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <[hidden email]>
wrote:

> Hello Devs,
>
> While creating the sales order from the backend, if we set the 'Ship Before
> Date' it will be stored in OrderItemShipGroup.shipByDate field and same
> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
> and OrderItemShipGrpInvRes.currentPromisedDate fields.
>
> On updating the 'Ship Before Date' from the order view page later, the
> value gets updated in OrderItemShipGroup entity but remains the same in
> OrderItemShipGroupInvRes entity.
>
> Is this the expected behaviour or OrderItemShipGroupInvRes should also get
> updated? OrderItemShipGrpInvRes.promisedDateTime &
> OrderItemShipGrpInvRes.currentPromisedDate is used in many services like
> 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
> 'reserveProductInventory' etc.
>
>
> Thanks & Regards
> --
> Deepak Nigam
>

[Jacques Le Roux]

Hi Suraj, Deepak,

I agree, I see no reasons why it would be created and not update.
While at it, using currentPromisedDate in services seems also better indeed.

Jacques

Le 08/08/2018 à 11:17, Suraj Khurana a écrit :

> Hello Deepak,
>
> This is interesting case. IMO, currentPromisedDate should also be updated
> after updating 'Ship Before Date'.
> Also, in mentioned services, I propose we should use currentPromisedDate
> instead of promisedDateTime field.
>
> --
> Best Regards,
> Suraj Khurana | Omni-channel OMS Technical Expert
> Cell phone: [phone]
>
>
> On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <[hidden email]>
> wrote:
>
>> Hello Devs,
>>
>> While creating the sales order from the backend, if we set the 'Ship Before
>> Date' it will be stored in OrderItemShipGroup.shipByDate field and same
>> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
>> and OrderItemShipGrpInvRes.currentPromisedDate fields.
>>
>> On updating the 'Ship Before Date' from the order view page later, the
>> value gets updated in OrderItemShipGroup entity but remains the same in
>> OrderItemShipGroupInvRes entity.
>>
>> Is this the expected behaviour or OrderItemShipGroupInvRes should also get
>> updated? OrderItemShipGrpInvRes.promisedDateTime &
>> OrderItemShipGrpInvRes.currentPromisedDate is used in many services like
>> 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
>> 'reserveProductInventory' etc.
>>
>>
>> Thanks & Regards
>> --
>> Deepak Nigam
>>

[deepak nigam-2]

Here is the JIRA ticket for addressing this issue:

https://issues.apache.org/jira/browse/OFBIZ-10538

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <[hidden email]>
wrote:

> Hi Suraj, Deepak,
>
> I agree, I see no reasons why it would be created and not update.
> While at it, using currentPromisedDate in services seems also better
> indeed.
>
> Jacques
>
> Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
> > Hello Deepak,
> >
> > This is interesting case. IMO, currentPromisedDate should also be updated
> > after updating 'Ship Before Date'.
> > Also, in mentioned services, I propose we should use currentPromisedDate
> > instead of promisedDateTime field.
> >
> > --
> > Best Regards,
> > Suraj Khurana | Omni-channel OMS Technical Expert
> > Cell phone: [phone]
> >
> >
> > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
> [hidden email]>
> > wrote:
> >
> >> Hello Devs,
> >>
> >> While creating the sales order from the backend, if we set the 'Ship
> Before
> >> Date' it will be stored in OrderItemShipGroup.shipByDate field and same
> >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
> >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
> >>
> >> On updating the 'Ship Before Date' from the order view page later, the
> >> value gets updated in OrderItemShipGroup entity but remains the same in
> >> OrderItemShipGroupInvRes entity.
> >>
> >> Is this the expected behaviour or OrderItemShipGroupInvRes should also
> get
> >> updated? OrderItemShipGrpInvRes.promisedDateTime &
> >> OrderItemShipGrpInvRes.currentPromisedDate is used in many services like
> >> 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity',
> >> 'reserveProductInventory' etc.
> >>
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >>
>
>

[taher]

Hi Deepak,

I could be wrong but the JIRA seems to more like a question, not a bug
report.

Perhaps it would be better to issue a JIRA when:
- you have identified and confirmed a bug
- you can provide an explanation for it.
- you can provide _repeat_ steps for others to replicate.

On Fri, Aug 24, 2018, 9:24 AM deepak nigam <[hidden email]>
wrote:

> Here is the JIRA ticket for addressing this issue:
>
> https://issues.apache.org/jira/browse/OFBIZ-10538
>
> Thanks & Regards
> --
> Deepak Nigam
> HotWax Systems Pvt. Ltd.
>
>
> On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <
> [hidden email]>
> wrote:
>
> > Hi Suraj, Deepak,
> >
> > I agree, I see no reasons why it would be created and not update.
> > While at it, using currentPromisedDate in services seems also better
> > indeed.
> >
> > Jacques
> >
> > Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
> > > Hello Deepak,
> > >
> > > This is interesting case. IMO, currentPromisedDate should also be
> updated
> > > after updating 'Ship Before Date'.
> > > Also, in mentioned services, I propose we should use
> currentPromisedDate
> > > instead of promisedDateTime field.
> > >
> > > --
> > > Best Regards,
> > > Suraj Khurana | Omni-channel OMS Technical Expert
> > > Cell phone: [phone]
> > >
> > >
> > > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
> > [hidden email]>
> > > wrote:
> > >
> > >> Hello Devs,
> > >>
> > >> While creating the sales order from the backend, if we set the 'Ship
> > Before
> > >> Date' it will be stored in OrderItemShipGroup.shipByDate field and
> same
> > >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
> > >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
> > >>
> > >> On updating the 'Ship Before Date' from the order view page later, the
> > >> value gets updated in OrderItemShipGroup entity but remains the same
> in
> > >> OrderItemShipGroupInvRes entity.
> > >>
> > >> Is this the expected behaviour or OrderItemShipGroupInvRes should also
> > get
> > >> updated? OrderItemShipGrpInvRes.promisedDateTime &
> > >> OrderItemShipGrpInvRes.currentPromisedDate is used in many services
> like
> > >> 'getOrderItemShipGroupEstimatedShipDate',
> 'getItemBackOrderedQuantity',
> > >> 'reserveProductInventory' etc.
> > >>
> > >>
> > >> Thanks & Regards
> > >> --
> > >> Deepak Nigam
> > >>
> >
> >
>

[taher]

Or alternatively, perhaps update the description to propose that the date
_should_ be updated

On Fri, Aug 24, 2018, 9:32 AM Taher Alkhateeb <[hidden email]>
wrote:

> Hi Deepak,
>
> I could be wrong but the JIRA seems to more like a question, not a bug
> report.
>
> Perhaps it would be better to issue a JIRA when:
> - you have identified and confirmed a bug
> - you can provide an explanation for it.
> - you can provide _repeat_ steps for others to replicate.
>
> On Fri, Aug 24, 2018, 9:24 AM deepak nigam <[hidden email]>
> wrote:
>
>> Here is the JIRA ticket for addressing this issue:
>>
>> https://issues.apache.org/jira/browse/OFBIZ-10538
>>
>> Thanks & Regards
>> --
>> Deepak Nigam
>> HotWax Systems Pvt. Ltd.
>>
>>
>> On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <
>> [hidden email]>
>> wrote:
>>
>> > Hi Suraj, Deepak,
>> >
>> > I agree, I see no reasons why it would be created and not update.
>> > While at it, using currentPromisedDate in services seems also better
>> > indeed.
>> >
>> > Jacques
>> >
>> > Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
>> > > Hello Deepak,
>> > >
>> > > This is interesting case. IMO, currentPromisedDate should also be
>> updated
>> > > after updating 'Ship Before Date'.
>> > > Also, in mentioned services, I propose we should use
>> currentPromisedDate
>> > > instead of promisedDateTime field.
>> > >
>> > > --
>> > > Best Regards,
>> > > Suraj Khurana | Omni-channel OMS Technical Expert
>> > > Cell phone: [phone]
>> > >
>> > >
>> > > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
>> > [hidden email]>
>> > > wrote:
>> > >
>> > >> Hello Devs,
>> > >>
>> > >> While creating the sales order from the backend, if we set the 'Ship
>> > Before
>> > >> Date' it will be stored in OrderItemShipGroup.shipByDate field and
>> same
>> > >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
>> > >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
>> > >>
>> > >> On updating the 'Ship Before Date' from the order view page later,
>> the
>> > >> value gets updated in OrderItemShipGroup entity but remains the same
>> in
>> > >> OrderItemShipGroupInvRes entity.
>> > >>
>> > >> Is this the expected behaviour or OrderItemShipGroupInvRes should
>> also
>> > get
>> > >> updated? OrderItemShipGrpInvRes.promisedDateTime &
>> > >> OrderItemShipGrpInvRes.currentPromisedDate is used in many services
>> like
>> > >> 'getOrderItemShipGroupEstimatedShipDate',
>> 'getItemBackOrderedQuantity',
>> > >> 'reserveProductInventory' etc.
>> > >>
>> > >>
>> > >> Thanks & Regards
>> > >> --
>> > >> Deepak Nigam
>> > >>
>> >
>> >
>>
>

[deepak nigam-2]

Thanks, Taher.

Update the description in the ticket.

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.


On Fri, Aug 24, 2018 at 12:04 PM Taher Alkhateeb <[hidden email]>
wrote:

> Or alternatively, perhaps update the description to propose that the date
> _should_ be updated
>
> On Fri, Aug 24, 2018, 9:32 AM Taher Alkhateeb <[hidden email]>
> wrote:
>
> > Hi Deepak,
> >
> > I could be wrong but the JIRA seems to more like a question, not a bug
> > report.
> >
> > Perhaps it would be better to issue a JIRA when:
> > - you have identified and confirmed a bug
> > - you can provide an explanation for it.
> > - you can provide _repeat_ steps for others to replicate.
> >
> > On Fri, Aug 24, 2018, 9:24 AM deepak nigam <[hidden email]>
> > wrote:
> >
> >> Here is the JIRA ticket for addressing this issue:
> >>
> >> https://issues.apache.org/jira/browse/OFBIZ-10538
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Nigam
> >> HotWax Systems Pvt. Ltd.
> >>
> >>
> >> On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <
> >> [hidden email]>
> >> wrote:
> >>
> >> > Hi Suraj, Deepak,
> >> >
> >> > I agree, I see no reasons why it would be created and not update.
> >> > While at it, using currentPromisedDate in services seems also better
> >> > indeed.
> >> >
> >> > Jacques
> >> >
> >> > Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
> >> > > Hello Deepak,
> >> > >
> >> > > This is interesting case. IMO, currentPromisedDate should also be
> >> updated
> >> > > after updating 'Ship Before Date'.
> >> > > Also, in mentioned services, I propose we should use
> >> currentPromisedDate
> >> > > instead of promisedDateTime field.
> >> > >
> >> > > --
> >> > > Best Regards,
> >> > > Suraj Khurana | Omni-channel OMS Technical Expert
> >> > > Cell phone: [phone]
> >> > >
> >> > >
> >> > > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
> >> > [hidden email]>
> >> > > wrote:
> >> > >
> >> > >> Hello Devs,
> >> > >>
> >> > >> While creating the sales order from the backend, if we set the
> 'Ship
> >> > Before
> >> > >> Date' it will be stored in OrderItemShipGroup.shipByDate field and
> >> same
> >> > >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
> >> > >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
> >> > >>
> >> > >> On updating the 'Ship Before Date' from the order view page later,
> >> the
> >> > >> value gets updated in OrderItemShipGroup entity but remains the
> same
> >> in
> >> > >> OrderItemShipGroupInvRes entity.
> >> > >>
> >> > >> Is this the expected behaviour or OrderItemShipGroupInvRes should
> >> also
> >> > get
> >> > >> updated? OrderItemShipGrpInvRes.promisedDateTime &
> >> > >> OrderItemShipGrpInvRes.currentPromisedDate is used in many services
> >> like
> >> > >> 'getOrderItemShipGroupEstimatedShipDate',
> >> 'getItemBackOrderedQuantity',
> >> > >> 'reserveProductInventory' etc.
> >> > >>
> >> > >>
> >> > >> Thanks & Regards
> >> > >> --
> >> > >> Deepak Nigam
> >> > >>
> >> >
> >> >
> >>
> >
>

[deepak nigam-2]

*Updated the description.* :)

Thanks & Regards
--
Deepak Nigam
HotWax Systems Pvt. Ltd.

On Fri, Aug 24, 2018 at 1:17 PM deepak nigam <[hidden email]>
wrote:

> Thanks, Taher.
>
> Update the description in the ticket.
>
> Thanks & Regards
> --
> Deepak Nigam
> HotWax Systems Pvt. Ltd.
>
>
> On Fri, Aug 24, 2018 at 12:04 PM Taher Alkhateeb <
> [hidden email]> wrote:
>
>> Or alternatively, perhaps update the description to propose that the date
>> _should_ be updated
>>
>> On Fri, Aug 24, 2018, 9:32 AM Taher Alkhateeb <[hidden email]
>> >
>> wrote:
>>
>> > Hi Deepak,
>> >
>> > I could be wrong but the JIRA seems to more like a question, not a bug
>> > report.
>> >
>> > Perhaps it would be better to issue a JIRA when:
>> > - you have identified and confirmed a bug
>> > - you can provide an explanation for it.
>> > - you can provide _repeat_ steps for others to replicate.
>> >
>> > On Fri, Aug 24, 2018, 9:24 AM deepak nigam <[hidden email]>
>> > wrote:
>> >
>> >> Here is the JIRA ticket for addressing this issue:
>> >>
>> >> https://issues.apache.org/jira/browse/OFBIZ-10538
>> >>
>> >> Thanks & Regards
>> >> --
>> >> Deepak Nigam
>> >> HotWax Systems Pvt. Ltd.
>> >>
>> >>
>> >> On Wed, Aug 8, 2018 at 9:42 PM Jacques Le Roux <
>> >> [hidden email]>
>> >> wrote:
>> >>
>> >> > Hi Suraj, Deepak,
>> >> >
>> >> > I agree, I see no reasons why it would be created and not update.
>> >> > While at it, using currentPromisedDate in services seems also better
>> >> > indeed.
>> >> >
>> >> > Jacques
>> >> >
>> >> > Le 08/08/2018 à 11:17, Suraj Khurana a écrit :
>> >> > > Hello Deepak,
>> >> > >
>> >> > > This is interesting case. IMO, currentPromisedDate should also be
>> >> updated
>> >> > > after updating 'Ship Before Date'.
>> >> > > Also, in mentioned services, I propose we should use
>> >> currentPromisedDate
>> >> > > instead of promisedDateTime field.
>> >> > >
>> >> > > --
>> >> > > Best Regards,
>> >> > > Suraj Khurana | Omni-channel OMS Technical Expert
>> >> > > Cell phone: [phone]
>> >> > >
>> >> > >
>> >> > > On Tue, Aug 7, 2018 at 11:29 AM, deepak nigam <
>> >> > [hidden email]>
>> >> > > wrote:
>> >> > >
>> >> > >> Hello Devs,
>> >> > >>
>> >> > >> While creating the sales order from the backend, if we set the
>> 'Ship
>> >> > Before
>> >> > >> Date' it will be stored in OrderItemShipGroup.shipByDate field and
>> >> same
>> >> > >> will be propagated to OrderItemShipGrpInvRes.promisedDateTime
>> >> > >> and OrderItemShipGrpInvRes.currentPromisedDate fields.
>> >> > >>
>> >> > >> On updating the 'Ship Before Date' from the order view page later,
>> >> the
>> >> > >> value gets updated in OrderItemShipGroup entity but remains the
>> same
>> >> in
>> >> > >> OrderItemShipGroupInvRes entity.
>> >> > >>
>> >> > >> Is this the expected behaviour or OrderItemShipGroupInvRes should
>> >> also
>> >> > get
>> >> > >> updated? OrderItemShipGrpInvRes.promisedDateTime &
>> >> > >> OrderItemShipGrpInvRes.currentPromisedDate is used in many
>> services
>> >> like
>> >> > >> 'getOrderItemShipGroupEstimatedShipDate',
>> >> 'getItemBackOrderedQuantity',
>> >> > >> 'reserveProductInventory' etc.
>> >> > >>
>> >> > >>
>> >> > >> Thanks & Regards
>> >> > >> --
>> >> > >> Deepak Nigam
>> >> > >>
>> >> >
>> >> >
>> >>
>> >
>>
>