[Proposal] - Using CommonErrorUiLabels.xml for common UiLabels

[Pallavi Goyal]

Hello Dev,

While working on OFBIZ-7737
<https://issues.apache.org/jira/browse/OFBIZ-7737> to improve service level
error messages for missing required fields, I observed there are
many UiLabels for missing fields which are common throughout OFBiz such as
Postal Code, City, Order Id etc.

So, should we proceed to put these common UiLabels in
CommonErrorUiLabels.xml file instead of making multiple component specific
copies in ErrorUiLabels.xml.

Thanks and Regards
Pallavi Goyal

[Vaibhav Jain]

Hello Pallavi,

Yes, we can create error message UI labels in CommonErrorUiLabels.xml for
the common errors (like City, Postal code etc).

No need to create duplicate UI label for same error in every component.

Thanks & Regards

Vaibhav Jain
Hotwax Systems,
[hidden email]

On Sat, Jul 22, 2017 at 12:54 PM, Pallavi Goyal <[hidden email]>
wrote:

> Hello Dev,
>
> While working on OFBIZ-7737
> <https://issues.apache.org/jira/browse/OFBIZ-7737> to improve service
> level
> error messages for missing required fields, I observed there are
> many UiLabels for missing fields which are common throughout OFBiz such as
> Postal Code, City, Order Id etc.
>
> So, should we proceed to put these common UiLabels in
> CommonErrorUiLabels.xml file instead of making multiple component specific
> copies in ErrorUiLabels.xml.
>
> Thanks and Regards
> Pallavi Goyal
>

[taher]

+1

DRY is my favorite principle. Sometimes I wish if the keyboard would zap
developer fingers when performing a copy-paste :)

On Jul 22, 2017 10:33 AM, "Vaibhav Jain" <[hidden email]>
wrote:

> Hello Pallavi,
>
> Yes, we can create error message UI labels in CommonErrorUiLabels.xml for
> the common errors (like City, Postal code etc).
>
> No need to create duplicate UI label for same error in every component.
>
> Thanks & Regards
>
> Vaibhav Jain
> Hotwax Systems,
> [hidden email]
>
> On Sat, Jul 22, 2017 at 12:54 PM, Pallavi Goyal <[hidden email]>
> wrote:
>
> > Hello Dev,
> >
> > While working on OFBIZ-7737
> > <https://issues.apache.org/jira/browse/OFBIZ-7737> to improve service
> > level
> > error messages for missing required fields, I observed there are
> > many UiLabels for missing fields which are common throughout OFBiz such
> as
> > Postal Code, City, Order Id etc.
> >
> > So, should we proceed to put these common UiLabels in
> > CommonErrorUiLabels.xml file instead of making multiple component
> specific
> > copies in ErrorUiLabels.xml.
> >
> > Thanks and Regards
> > Pallavi Goyal
> >
>

[Pallavi Goyal-2]

Thanks Vaibhav and Taher for your inputs.

Best Regards
Pallavi Goyal

On Sat, Jul 22, 2017 at 1:09 PM, Taher Alkhateeb <[hidden email]
> wrote:

> +1
>
> DRY is my favorite principle. Sometimes I wish if the keyboard would zap
> developer fingers when performing a copy-paste :)
>
> On Jul 22, 2017 10:33 AM, "Vaibhav Jain" <[hidden email]>
> wrote:
>
> > Hello Pallavi,
> >
> > Yes, we can create error message UI labels in CommonErrorUiLabels.xml for
> > the common errors (like City, Postal code etc).
> >
> > No need to create duplicate UI label for same error in every component.
> >
> > Thanks & Regards
> >
> > Vaibhav Jain
> > Hotwax Systems,
> > [hidden email]
> >
> > On Sat, Jul 22, 2017 at 12:54 PM, Pallavi Goyal <
> [hidden email]>
> > wrote:
> >
> > > Hello Dev,
> > >
> > > While working on OFBIZ-7737
> > > <https://issues.apache.org/jira/browse/OFBIZ-7737> to improve service
> > > level
> > > error messages for missing required fields, I observed there are
> > > many UiLabels for missing fields which are common throughout OFBiz such
> > as
> > > Postal Code, City, Order Id etc.
> > >
> > > So, should we proceed to put these common UiLabels in
> > > CommonErrorUiLabels.xml file instead of making multiple component
> > specific
> > > copies in ErrorUiLabels.xml.
> > >
> > > Thanks and Regards
> > > Pallavi Goyal
> > >
> >
>

--
Thanks and Regards
Pallavi Goyal
Enterprise Software Engineer
Hotwax Systems Pvt Ltd
www.hotwaxsystems.com