Proposal for a small change to the header template
Locked
Proposal for a small change to the header template
 
|
Hi all,
what do you think about the attached patch that will slightly modify the information in the top right corner of each OFBiz screen? It basically change the information from: "Welcome Jacopo Cappellato!" to: "Username: jacopoc Jacopo Cappellato" Do you like it? Can I commit? Jacopo Index: framework/common/webcommon/includes/header.ftl =================================================================== --- framework/common/webcommon/includes/header.ftl (revision 429656) +++ framework/common/webcommon/includes/header.ftl (working copy) @@ -52,13 +52,16 @@ <td align="left" width="1%"><img alt="${layoutSettings.companyName}" src="<@ofbizContentUrl>${layoutSettings.headerImageUrl}</@ofbizContentUrl>"/></td> </#if> <td align="right" width="1%" nowrap="nowrap" <#if layoutSettings.headerRightBackgroundUrl?has_content>background="${layoutSettings.headerRightBackgroundUrl}"</#if>> + <div class="insideHeaderText"> + <#if userLogin?exists>${uiLabelMap.CommonUsername}: ${userLogin.userLoginId?if_exists} </#if> <#if person?has_content> - <div class="insideHeaderText">${uiLabelMap.CommonWelcome} ${person.firstName?if_exists} ${person.lastName?if_exists}!</div> + ${person.firstName?if_exists} ${person.lastName?if_exists} <#elseif partyGroup?has_content> - <div class="insideHeaderText">${uiLabelMap.CommonWelcome} ${partyGroup.groupName?if_exists}!</div> + ${partyGroup.groupName?if_exists} <#else> - <div class="insideHeaderText">${uiLabelMap.CommonWelcome}!</div> + ${uiLabelMap.CommonWelcome}! </#if> + </div> <div class="insideHeaderText"> ${Static["org.ofbiz.base.util.UtilDateTime"].nowTimestamp().toString()}</div> <div class="insideHeaderText"> <form method="post" action="<@ofbizUrl>setSessionLocale</@ofbizUrl>" style="margin: 0;"> |
Re: Proposal for a small change to the header template
|
|
Is the objective to show the userLoginId as well as the first/last or group name of the user? Perhaps it would be better to just add the userLoginId in parenthesis. Something like: "Welcome Jacopo Cappellato! (jacopoc)" -David On Aug 9, 2006, at 10:33 AM, Jacopo Cappellato wrote: > Hi all, > > what do you think about the attached patch that will slightly > modify the information in the top right corner of each OFBiz screen? > > It basically change the information from: > > "Welcome Jacopo Cappellato!" > > to: > > "Username: jacopoc Jacopo Cappellato" > > Do you like it? Can I commit? > > Jacopo > Index: framework/common/webcommon/includes/header.ftl > =================================================================== > --- framework/common/webcommon/includes/header.ftl (revision 429656) > +++ framework/common/webcommon/includes/header.ftl (working copy) > @@ -52,13 +52,16 @@ > <td align="left" width="1%"><img alt="$ > {layoutSettings.companyName}" src="<@ofbizContentUrl>$ > {layoutSettings.headerImageUrl}</@ofbizContentUrl>"/></td> > </#if> > <td align="right" width="1%" nowrap="nowrap" <#if > layoutSettings.headerRightBackgroundUrl?has_content>background="$ > {layoutSettings.headerRightBackgroundUrl}"</#if>> > + <div class="insideHeaderText"> > + <#if userLogin?exists>$ > {uiLabelMap.CommonUsername}: ${userLogin.userLoginId?if_exists} > </#if> > <#if person?has_content> > - <div class="insideHeaderText">$ > {uiLabelMap.CommonWelcome} ${person.firstName?if_exists} $ > {person.lastName?if_exists}!</div> > + ${person.firstName?if_exists} ${person.lastName? > if_exists} > <#elseif partyGroup?has_content> > - <div class="insideHeaderText">$ > {uiLabelMap.CommonWelcome} ${partyGroup.groupName?if_exists}!</ > div> > + ${partyGroup.groupName?if_exists} > <#else> > - <div class="insideHeaderText">$ > {uiLabelMap.CommonWelcome}!</div> > + ${uiLabelMap.CommonWelcome}! > </#if> > + </div> > <div class="insideHeaderText"> ${Static > ["org.ofbiz.base.util.UtilDateTime"].nowTimestamp().toString()}</div> > <div class="insideHeaderText"> > <form method="post" > action="<@ofbizUrl>setSessionLocale</@ofbizUrl>" style="margin: 0;"> |
Re: Proposal for a small change to the header template
|
|
My vote would be for David's response. I think it's actually more clear.
Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 David E. Jones wrote: > > Is the objective to show the userLoginId as well as the first/last or > group name of the user? > > Perhaps it would be better to just add the userLoginId in parenthesis. > Something like: > > "Welcome Jacopo Cappellato! (jacopoc)" > > -David > > > On Aug 9, 2006, at 10:33 AM, Jacopo Cappellato wrote: > >> Hi all, >> >> what do you think about the attached patch that will slightly modify >> the information in the top right corner of each OFBiz screen? >> >> It basically change the information from: >> >> "Welcome Jacopo Cappellato!" >> >> to: >> >> "Username: jacopoc Jacopo Cappellato" >> >> Do you like it? Can I commit? >> >> Jacopo >> Index: framework/common/webcommon/includes/header.ftl >> =================================================================== >> --- framework/common/webcommon/includes/header.ftl (revision 429656) >> +++ framework/common/webcommon/includes/header.ftl (working copy) >> @@ -52,13 +52,16 @@ >> <td align="left" width="1%"><img >> alt="${layoutSettings.companyName}" >> src="<@ofbizContentUrl>${layoutSettings.headerImageUrl}</@ofbizContentUrl>"/></td> >> >> </#if> >> <td align="right" width="1%" nowrap="nowrap" <#if >> layoutSettings.headerRightBackgroundUrl?has_content>background="${layoutSettings.headerRightBackgroundUrl}"</#if>> >> >> + <div class="insideHeaderText"> >> + <#if >> userLogin?exists>${uiLabelMap.CommonUsername}: ${userLogin.userLoginId?if_exists} </#if> >> >> <#if person?has_content> >> - <div >> class="insideHeaderText">${uiLabelMap.CommonWelcome} ${person.firstName?if_exists} ${person.lastName?if_exists}!</div> >> >> + >> ${person.firstName?if_exists} ${person.lastName?if_exists} >> <#elseif partyGroup?has_content> >> - <div >> class="insideHeaderText">${uiLabelMap.CommonWelcome} ${partyGroup.groupName?if_exists}!</div> >> >> + ${partyGroup.groupName?if_exists} >> <#else> >> - <div >> class="insideHeaderText">${uiLabelMap.CommonWelcome}!</div> >> + ${uiLabelMap.CommonWelcome}! >> </#if> >> + </div> >> <div >> class="insideHeaderText"> ${Static["org.ofbiz.base.util.UtilDateTime"].nowTimestamp().toString()}</div> >> >> <div class="insideHeaderText"> >> <form method="post" >> action="<@ofbizUrl>setSessionLocale</@ofbizUrl>" style="margin: 0;"> |
Re: Proposal for a small change to the header template
|
|
I agree with you.
But do we really need the "Welcome" and "!"? Jacopo Tim Ruppert wrote: > My vote would be for David's response. I think it's actually more clear. > > Cheers, > Tim > > -- > Tim Ruppert > HotWax Media > http://www.hotwaxmedia.com > > o:801.649.6594 > f:801.649.6595 > > David E. Jones wrote: >> >> Is the objective to show the userLoginId as well as the first/last or >> group name of the user? >> >> Perhaps it would be better to just add the userLoginId in parenthesis. >> Something like: >> >> "Welcome Jacopo Cappellato! (jacopoc)" >> >> -David >> |
Re: Proposal for a small change to the header template
|
|
I might lose the "!" just because no one's really that excited ;)
-- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 Jacopo Cappellato wrote: > I agree with you. > But do we really need the "Welcome" and "!"? > > Jacopo > > Tim Ruppert wrote: >> My vote would be for David's response. I think it's actually more >> clear. >> >> Cheers, >> Tim >> >> David E. Jones wrote: >>> >>> Is the objective to show the userLoginId as well as the first/last >>> or group name of the user? >>> >>> Perhaps it would be better to just add the userLoginId in >>> parenthesis. Something like: >>> >>> "Welcome Jacopo Cappellato! (jacopoc)" >>> >>> -David >>> |
Re: Proposal for a small change to the header template
|
|
+1
The ! seemed a little overboard to me the first time I used OFBiz. Tim Ruppert wrote: > I might lose the "!" just because no one's really that excited ;) > > -- > Tim Ruppert > HotWax Media > http://www.hotwaxmedia.com > > o:801.649.6594 > f:801.649.6595 > > Jacopo Cappellato wrote: > >> I agree with you. >> But do we really need the "Welcome" and "!"? >> >> Jacopo >> >> Tim Ruppert wrote: >> >>> My vote would be for David's response. I think it's actually more >>> clear. >>> >>> Cheers, >>> Tim >>> >>> David E. Jones wrote: >>> >>>> >>>> Is the objective to show the userLoginId as well as the first/last >>>> or group name of the user? >>>> >>>> Perhaps it would be better to just add the userLoginId in >>>> parenthesis. Something like: >>>> >>>> "Welcome Jacopo Cappellato! (jacopoc)" >>>> >>>> -David >>>> > |
Re: Proposal for a small change to the header template
Administrator
|
It appears on every screen (in the header) : it seems more suitable not to show "Welcome" on each page as well.
Jacques > +1 > > The ! seemed a little overboard to me the first time I used OFBiz. > > > Tim Ruppert wrote: > > I might lose the "!" just because no one's really that excited ;) > > > > -- > > Tim Ruppert > > HotWax Media > > http://www.hotwaxmedia.com > > > > o:801.649.6594 > > f:801.649.6595 > > > > Jacopo Cappellato wrote: > > > >> I agree with you. > >> But do we really need the "Welcome" and "!"? > >> > >> Jacopo > >> > >> Tim Ruppert wrote: > >> > >>> My vote would be for David's response. I think it's actually more > >>> clear. > >>> > >>> Cheers, > >>> Tim > >>> > >>> David E. Jones wrote: > >>> > >>>> > >>>> Is the objective to show the userLoginId as well as the first/last > >>>> or group name of the user? > >>>> > >>>> Perhaps it would be better to just add the userLoginId in > >>>> parenthesis. Something like: > >>>> > >>>> "Welcome Jacopo Cappellato! (jacopoc)" > >>>> > >>>> -David > >>>> > > |
Re: Proposal for a small change to the header template
|
|
I'd like to clarify that the reason behind my proposal is to put in the
header of the backoffice applications (not ecommerce) more "traditional" information... and also add the userLoginId, that is an important information I think, especially if more than one userLogin are associated (with different rights) to the same party. However it's not so important for me and if there is not a general consensus (as it seems), well for me it's ok to keep the existing greetings message (maybe simply adding the login id as suggested by David). Jacopo Jacques Le Roux wrote: > It appears on every screen (in the header) : it seems more suitable not to show "Welcome" on each page as well. > > Jacques > > >> +1 >> >> The ! seemed a little overboard to me the first time I used OFBiz. >> >> >> Tim Ruppert wrote: >>> I might lose the "!" just because no one's really that excited ;) >>> >>> -- >>> Tim Ruppert >>> HotWax Media >>> http://www.hotwaxmedia.com >>> >>> o:801.649.6594 >>> f:801.649.6595 >>> >>> Jacopo Cappellato wrote: >>> >>>> I agree with you. >>>> But do we really need the "Welcome" and "!"? >>>> >>>> Jacopo >>>> >>>> Tim Ruppert wrote: >>>> >>>>> My vote would be for David's response. I think it's actually more >>>>> clear. >>>>> >>>>> Cheers, >>>>> Tim >>>>> >>>>> David E. Jones wrote: >>>>> >>>>>> Is the objective to show the userLoginId as well as the first/last >>>>>> or group name of the user? >>>>>> >>>>>> Perhaps it would be better to just add the userLoginId in >>>>>> parenthesis. Something like: >>>>>> >>>>>> "Welcome Jacopo Cappellato! (jacopoc)" >>>>>> >>>>>> -David >>>>>> |
Re: Proposal for a small change to the header template
|
Administrator
|
Why not a vote, it costs merely nothing ?
Jacques ----- Original Message ----- From: "Jacopo Cappellato" <[hidden email]> To: <[hidden email]> Sent: Thursday, August 10, 2006 7:32 AM Subject: Re: Proposal for a small change to the header template > I'd like to clarify that the reason behind my proposal is to put in the > header of the backoffice applications (not ecommerce) more "traditional" > information... and also add the userLoginId, that is an important > information I think, especially if more than one userLogin are > associated (with different rights) to the same party. > However it's not so important for me and if there is not a general > consensus (as it seems), well for me it's ok to keep the existing > greetings message (maybe simply adding the login id as suggested by David). > > Jacopo > > Jacques Le Roux wrote: > > It appears on every screen (in the header) : it seems more suitable not to show "Welcome" on each page as well. > > > > Jacques > > > > > >> +1 > >> > >> The ! seemed a little overboard to me the first time I used OFBiz. > >> > >> > >> Tim Ruppert wrote: > >>> I might lose the "!" just because no one's really that excited ;) > >>> > >>> -- > >>> Tim Ruppert > >>> HotWax Media > >>> http://www.hotwaxmedia.com > >>> > >>> o:801.649.6594 > >>> f:801.649.6595 > >>> > >>> Jacopo Cappellato wrote: > >>> > >>>> I agree with you. > >>>> But do we really need the "Welcome" and "!"? > >>>> > >>>> Jacopo > >>>> > >>>> Tim Ruppert wrote: > >>>> > >>>>> My vote would be for David's response. I think it's actually more > >>>>> clear. > >>>>> > >>>>> Cheers, > >>>>> Tim > >>>>> > >>>>> David E. Jones wrote: > >>>>> > >>>>>> Is the objective to show the userLoginId as well as the first/last > >>>>>> or group name of the user? > >>>>>> > >>>>>> Perhaps it would be better to just add the userLoginId in > >>>>>> parenthesis. Something like: > >>>>>> > >>>>>> "Welcome Jacopo Cappellato! (jacopoc)" > >>>>>> > >>>>>> -David > >>>>>> |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |