Question about bulk approve items.

[Jacopo Cappellato-4]

 From the search result page of the "find orders screen" it is  
possible to bulk "Approve orders" (selecting the proper action from  
the drop down field in the top right part of the list.
However the event calls a service that only changes the order items to  
"approved", the order header is left in the "created" status.
Wouldn't be better to change the code to call the "changeOrderStatus"  
service instead? This service is the one called from the "approve"  
link of the order detail screen and it approves both the header and  
the items.

Jacopo

[Scott Gray-2]

+1, you can just change the code as follows though right?
-  return massChangeItemStatus(dctx, context, "ITEM_APPROVED");
+ return massChangeOrderStatus(dctx, context, "ORDER_APPROVED");

Regards
Scott

On 21/07/2009, at 11:55 PM, Jacopo Cappellato wrote:

> From the search result page of the "find orders screen" it is  
> possible to bulk "Approve orders" (selecting the proper action from  
> the drop down field in the top right part of the list.
> However the event calls a service that only changes the order items  
> to "approved", the order header is left in the "created" status.
> Wouldn't be better to change the code to call the  
> "changeOrderStatus" service instead? This service is the one called  
> from the "approve" link of the order detail screen and it approves  
> both the header and the items.
>
> Jacopo
>

[Jacopo Cappellato-4]

yeah,

Scott, you are mostly right... but we need to set the setItemStatus in  
parameter to Y if we want that the changeOrderStatus service will  
update order items.
I'd say we can assume it as the default behavior for all the  
masschange service and probably we will not need to add the parameter  
to the masschange services.

Jacopo


On Jul 21, 2009, at 2:20 PM, Scott Gray wrote:

> +1, you can just change the code as follows though right?
> -  return massChangeItemStatus(dctx, context, "ITEM_APPROVED");
> + return massChangeOrderStatus(dctx, context, "ORDER_APPROVED");
>
> Regards
> Scott
>
> On 21/07/2009, at 11:55 PM, Jacopo Cappellato wrote:
>
>> From the search result page of the "find orders screen" it is  
>> possible to bulk "Approve orders" (selecting the proper action from  
>> the drop down field in the top right part of the list.
>> However the event calls a service that only changes the order items  
>> to "approved", the order header is left in the "created" status.
>> Wouldn't be better to change the code to call the  
>> "changeOrderStatus" service instead? This service is the one called  
>> from the "approve" link of the order detail screen and it approves  
>> both the header and the items.
>>
>> Jacopo
>>
>

[Vikas Mayur-2]

checkOrderItemStatus service is triggered everytime changeOrderItemStatus
service is invoked and this should move the status of order to approved once
every item on order goes into approved status?
Vikas

On Tue, Jul 21, 2009 at 6:34 PM, Jacopo Cappellato <
[hidden email]> wrote:

> yeah,
>
> Scott, you are mostly right... but we need to set the setItemStatus in
> parameter to Y if we want that the changeOrderStatus service will update
> order items.
> I'd say we can assume it as the default behavior for all the masschange
> service and probably we will not need to add the parameter to the masschange
> services.
>
> Jacopo
>
>
>
> On Jul 21, 2009, at 2:20 PM, Scott Gray wrote:
>
>  +1, you can just change the code as follows though right?
>> -  return massChangeItemStatus(dctx, context, "ITEM_APPROVED");
>> + return massChangeOrderStatus(dctx, context, "ORDER_APPROVED");
>>
>> Regards
>> Scott
>>
>> On 21/07/2009, at 11:55 PM, Jacopo Cappellato wrote:
>>
>>  From the search result page of the "find orders screen" it is possible to
>>> bulk "Approve orders" (selecting the proper action from the drop down field
>>> in the top right part of the list.
>>> However the event calls a service that only changes the order items to
>>> "approved", the order header is left in the "created" status.
>>> Wouldn't be better to change the code to call the "changeOrderStatus"
>>> service instead? This service is the one called from the "approve" link of
>>> the order detail screen and it approves both the header and the items.
>>>
>>> Jacopo
>>>
>>>
>>
>

[Jacopo Cappellato-4]

actually there is code in place (by David) that prevents this (see  
line 1781 of OrderServices.java).

Jacopo

On Jul 21, 2009, at 3:32 PM, Vikas Mayur wrote:

> checkOrderItemStatus service is triggered everytime  
> changeOrderItemStatus
> service is invoked and this should move the status of order to  
> approved once
> every item on order goes into approved status?
> Vikas
>
> On Tue, Jul 21, 2009 at 6:34 PM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>> yeah,
>>
>> Scott, you are mostly right... but we need to set the setItemStatus  
>> in
>> parameter to Y if we want that the changeOrderStatus service will  
>> update
>> order items.
>> I'd say we can assume it as the default behavior for all the  
>> masschange
>> service and probably we will not need to add the parameter to the  
>> masschange
>> services.
>>
>> Jacopo
>>
>>
>>
>> On Jul 21, 2009, at 2:20 PM, Scott Gray wrote:
>>
>> +1, you can just change the code as follows though right?
>>> -  return massChangeItemStatus(dctx, context, "ITEM_APPROVED");
>>> + return massChangeOrderStatus(dctx, context, "ORDER_APPROVED");
>>>
>>> Regards
>>> Scott
>>>
>>> On 21/07/2009, at 11:55 PM, Jacopo Cappellato wrote:
>>>
>>> From the search result page of the "find orders screen" it is  
>>> possible to
>>>> bulk "Approve orders" (selecting the proper action from the drop  
>>>> down field
>>>> in the top right part of the list.
>>>> However the event calls a service that only changes the order  
>>>> items to
>>>> "approved", the order header is left in the "created" status.
>>>> Wouldn't be better to change the code to call the  
>>>> "changeOrderStatus"
>>>> service instead? This service is the one called from the  
>>>> "approve" link of
>>>> the order detail screen and it approves both the header and the  
>>>> items.
>>>>
>>>> Jacopo
>>>>
>>>>
>>>
>>