R: Re: R: Re: svn commit: r1068120 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java

Hi Scott,

agreed I will try to reduce at minimum the use of FIXME in case of unused
variable but sometimes it's not easy to understand if it's correct to remove it
or not.

Thanks
Marco

>----Messaggio originale----
>Da: [hidden email]
>Data: 08/02/2011 12.57
>A: <[hidden email]>
>Ogg: Re: R: Re: svn commit: r1068120 -
/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>
>To me it seems like a wasted effort, what do we gain by removing warnings and
adding FIXMEs?  It seems like all we get are unneeded comments and a few more
chunks to review.
>
>But please don't take my comments as criticism, I appreciate the effort
you're putting in and have spent many hours doing similar work myself over the
years.

>
>Regards
>Scott
>
>HotWax Media
>http://www.hotwaxmedia.com
>
>On 9/02/2011, at 12:52 AM, [hidden email] wrote:
>
>> What I have to do it in this case leave the compilation warning or remove

it
>> putting a //FIXME ?
>>
>> I would like to before to remove all the compilation warning and then we
could

>> work on the //FIXME later.
>>
>> What did you think of it ?
>>
>> Thanks
>> Marco
>>
>>> ----Messaggio originale----
>>> Da: [hidden email]
>>> Data: 08/02/2011 8.29
>>> A: <[hidden email]>
>>> Ogg: Re: svn commit: r1068120 -
>> /ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>>>
>>> Maybe there is a reason? Because I saw Marco fixing a lot of them...
>>>
>>> Jacques
>>>
>>> From: "Adrian Crum" <[hidden email]>
>>>> It would be nice if we fixed the warnings instead of just hiding them.
>>>>
>>>> -Adrian
>>>>
>>>> On 2/7/2011 12:46 PM, [hidden email] wrote:
>>>>> Author: mrisaliti
>>>>> Date: Mon Feb  7 20:46:53 2011
>>>>> New Revision: 1068120
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1068120&view=rev
>>>>> Log:
>>>>> Remove compilation warnings of an unused private method in

JNDIConfigUtil

>> (OFBIZ-4102)
>>>>>
>>>>> Modified:
>>>>>     ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>> java
>>>>>
>>>>> Modified:
>> ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.java
>>>>> URL:
>>>>> http://svn.apache.
>>

org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>> java?rev=1068120&r1=1068119&r2=1068120&view=diff
>>>>>
>>
==============================================================================

>>>>> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>> java (original)
>>>>> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/config/JNDIConfigUtil.
>> java Mon Feb  7 20:46:53 2011
>>>>> @@ -43,6 +43,7 @@ public class JNDIConfigUtil {
>>>>>          }
>>>>>      }
>>>>>
>>>>> +    @SuppressWarnings("unused")
>>>>>      private static Document getXmlDocument() throws
>> GenericConfigException {
>>>>>          try {
>>>>>              return ResourceLoader.getXmlDocument(JNDIConfigUtil.
>> JNDI_CONFIG_XML_FILENAME);
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>
>>
>
>