ROUND_CEILING in TaxAuthorityServices

[Jacques Le Roux]

Hi,

I wonder why we still have a ROUND_CEILING in TaxAuthorityServices. I suspect it comes from  https://issues.apache.org/jira/browse/OFBIZ-164.

But then why David did you not put in line 333 : (this was in code inline in comment not in the patch).

                // taxRate is in percentage, so needs to be divided by 100
                BigDecimal taxAmount = (taxable.multiply(taxRate)).divide(PERCENT_SCALE, 3, BigDecimal.ROUND_CEILING);

is it intentionally, and if yes, why ?

I would prefer to use somehting like this, what do you think ?

                // taxRate is in percentage, so needs to be divided by 100
                BigDecimal taxAmount = (taxable.multiply(taxRate)).divide(PERCENT_SCALE, salestaxCalcDecimals, salestaxRounding);

Thanks

Jacques