Re: Theme bootstrap

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
33 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

Florient
Hi Julien, Adrian, Community,

Le 23/10/2014 08:46, Adrian Crum a écrit :

> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>> For this point I suggest to work on this way : Create tool to delegate
>> HTML widget structure (and other structure) into theme framework.
>> To be clear, I suggest to not integrate bootstrap only but modify the
>> framework to allow any other HTML/CSS frameworks integration without
>> modifying the OFBiz framework.
>> But we'll do it for bootstrap first.
>
>
> You don't need to modify the framework. The screen widgets allow you
> to substitute alternate macros for the rendering engine. See
> widget.properties.
>
>
> Adrian Crum

correct me if I'm wrong,
but if we use widget's properties, we will not be able to provide a
hot-swap between them, except by creating new output type.
It sounds like duplicate each actual view-map definition using 'screen'
type to the new one, as the CSV rendering.
or am I missing the way that widget allow us to substitute macros
rendering ?

Regards,
Florient.

       

Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

Adrian Crum-3
It is important to understand the screen widget architecture:

Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV, or...)

The Widget Models and Renderer are output agnostic - they don't "know"
what type of output is being generated. So those artifacts do not need
to be changed to support Bootstrap.

The only things that need to be changed to support Bootstrap are the
FreeMarker macros - so that they output Bootstrap HTML + CSS instead of
the current OFBiz-specific HTML + CSS.

You can still use the visual themes functionality, but they will be
different themes - since the HTML being styled is completely different.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 10/23/2014 10:29 PM, Florient wrote:

> Hi Julien, Adrian, Community,
>
> Le 23/10/2014 08:46, Adrian Crum a écrit :
>> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>> For this point I suggest to work on this way : Create tool to delegate
>>> HTML widget structure (and other structure) into theme framework.
>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>> framework to allow any other HTML/CSS frameworks integration without
>>> modifying the OFBiz framework.
>>> But we'll do it for bootstrap first.
>>
>>
>> You don't need to modify the framework. The screen widgets allow you
>> to substitute alternate macros for the rendering engine. See
>> widget.properties.
>>
>>
>> Adrian Crum
>
> correct me if I'm wrong,
> but if we use widget's properties, we will not be able to provide a
> hot-swap between them, except by creating new output type.
> It sounds like duplicate each actual view-map definition using 'screen'
> type to the new one, as the CSV rendering.
> or am I missing the way that widget allow us to substitute macros
> rendering ?
>
> Regards,
> Florient.
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

taher
Hi Julien, everyone!

I suggest we move forward in this project. First things first, we need to
integrate bootstrap into the framework. So I think the following steps are
to be done next:

1- copy the resources to the images component (CSS, JS, and Fonts) and
include them in the base CommonScreens.xml
2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
3- Ensure that our jQuery dependencies are adequately met

We can then have a few test screens to make sure everything is working more
or less!

Julien, can we proceed with the above suggested? Do we need to open the
JIRA first, and who should do that?

Taher Alkhateeb.

On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
[hidden email]> wrote:

> It is important to understand the screen widget architecture:
>
> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
> or...)
>
> The Widget Models and Renderer are output agnostic - they don't "know"
> what type of output is being generated. So those artifacts do not need to
> be changed to support Bootstrap.
>
> The only things that need to be changed to support Bootstrap are the
> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of the
> current OFBiz-specific HTML + CSS.
>
> You can still use the visual themes functionality, but they will be
> different themes - since the HTML being styled is completely different.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 10/23/2014 10:29 PM, Florient wrote:
>
>> Hi Julien, Adrian, Community,
>>
>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>
>>> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>
>>>> For this point I suggest to work on this way : Create tool to delegate
>>>> HTML widget structure (and other structure) into theme framework.
>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>> framework to allow any other HTML/CSS frameworks integration without
>>>> modifying the OFBiz framework.
>>>> But we'll do it for bootstrap first.
>>>>
>>>
>>>
>>> You don't need to modify the framework. The screen widgets allow you
>>> to substitute alternate macros for the rendering engine. See
>>> widget.properties.
>>>
>>>
>>> Adrian Crum
>>>
>>
>> correct me if I'm wrong,
>> but if we use widget's properties, we will not be able to provide a
>> hot-swap between them, except by creating new output type.
>> It sounds like duplicate each actual view-map definition using 'screen'
>> type to the new one, as the CSV rendering.
>> or am I missing the way that widget allow us to substitute macros
>> rendering ?
>>
>> Regards,
>> Florient.
>>
>>
>>
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

JulienNicolas
Hi Taher,



Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
> Hi Julien, everyone!
>
> I suggest we move forward in this project. First things first, we need to
> integrate bootstrap into the framework. So I think the following steps are
> to be done next:
>
> 1- copy the resources to the images component (CSS, JS, and Fonts) and
> include them in the base CommonScreens.xml
I think it could be better to use themes for that. The goal is to allow
including any others CSS/HTML framework (like Zurb framework).
> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
I don't know how the CSS pre-processor could work in OFBiz Framework.
Could you explain how we will use it ?
> 3- Ensure that our jQuery dependencies are adequately met
>
> We can then have a few test screens to make sure everything is working more
> or less!
>
> Julien, can we proceed with the above suggested? Do we need to open the
> JIRA first, and who should do that?
I was thinking that we start with following points that you already
suggest as first steps :

- Identify the major milestones or objectives
- Discuss and decide upon the best methodology for implementation of the
above objectives
- Decide on a collaboration platform (in addition to what exists) if any.
- Dive into code directly and just hand off tasks to volunteers who find
them interesting / appealing from the team


I think that we are already in the first step "Identify the major
milestones and objectives".

It could be a good thing if any volunteers explain his opinion about
objectives.

I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
is the best way. I would prefer to work to allow any CSS/HTML framework
working with OFBiz thanks to themes manager (suggested by Richard
Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
can solve issues like this Jira
https://issues.apache.org/jira/browse/OFBIZ-5040.

In my opinion, objectives are :
     - Identify how to modify framework to allow bootstrap working
(bootstrap included in a theme)
     - Create bootstrap basic theme
     - Modify framework for working with bootstrap (or other framework)
     - identify all screens that are not working and correct theme or
ofbiz framework.


>
> Taher Alkhateeb.
>
> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
> [hidden email]> wrote:
>
>> It is important to understand the screen widget architecture:
>>
>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>> or...)
>>
>> The Widget Models and Renderer are output agnostic - they don't "know"
>> what type of output is being generated. So those artifacts do not need to
>> be changed to support Bootstrap.
>>
>> The only things that need to be changed to support Bootstrap are the
>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of the
>> current OFBiz-specific HTML + CSS.
>>
>> You can still use the visual themes functionality, but they will be
>> different themes - since the HTML being styled is completely different.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 10/23/2014 10:29 PM, Florient wrote:
>>
>>> Hi Julien, Adrian, Community,
>>>
>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>
>>>> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>
>>>>> For this point I suggest to work on this way : Create tool to delegate
>>>>> HTML widget structure (and other structure) into theme framework.
>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>> modifying the OFBiz framework.
>>>>> But we'll do it for bootstrap first.
>>>>>
>>>>
>>>> You don't need to modify the framework. The screen widgets allow you
>>>> to substitute alternate macros for the rendering engine. See
>>>> widget.properties.
>>>>
>>>>
>>>> Adrian Crum
>>>>
>>> correct me if I'm wrong,
>>> but if we use widget's properties, we will not be able to provide a
>>> hot-swap between them, except by creating new output type.
>>> It sounds like duplicate each actual view-map definition using 'screen'
>>> type to the new one, as the CSV rendering.
>>> or am I missing the way that widget allow us to substitute macros
>>> rendering ?
>>>
>>> Regards,
>>> Florient.
>>>
>>>
>>>
>>>
>>>

Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

Gavin Mabie-2
Julien, Taher

You're both making good points.  I like the generic approach proposed by
Julien, but this could well be a longer term objective.  In fact starting
with Bootstrap does not necessarily imply that other frameworks will be
excluded. Also, inline with Adrian's comment, we should stay away from the
core framework as far as possible for now and focus on the MacroLibraries
as defined in widget.properties.  This is not to say that there will not be
any modifications to the framework - there might well be.
There is enough interest in Bootstrap to suggest that we start with it as a
way forward.

1. I therefore agree with Taher that we create the following setup under
the images app to begin with.  I believe that this will be within the
frontendNewTheme branch alluded to by Jacques.

bootstrap/
├── css/
│   ├── bootstrap.css
│   ├── bootstrap.min.css
│   ├── bootstrap-theme.css
│   └── bootstrap-theme.min.css
├── js/
│   ├── bootstrap.js
│   └── bootstrap.min.js
└── fonts/
    ├── glyphicons-halflings-regular.eot
    ├── glyphicons-halflings-regular.svg
    ├── glyphicons-halflings-regular.ttf
    └── glyphicons-halflings-regular.woff

2. Create a new theme component as an Admin Template app - I suggest
that we clone Tomahawk. Maybe we can call it Vanilla Bootstrap.

3. Add screens and widgets to the new app - much like the current
Example app.  This can be used as an admin template -See
http://demo.onokumus.com/metis/.

4. Like the Example app we can use the Admin Template app to demo
Ofbiz-Bootstrap.

5.  The Admin Template app is used in the normal way, i.e, create jiras etc.

If this approach is acceptable then someone with the appropriate
credentials can get the ball rolling by completing step 1.

Regards

Gavin



On Mon, Oct 27, 2014 at 10:58 AM, Julien NICOLAS <[hidden email]>
wrote:

> Hi Taher,
>
>
>
> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>
>> Hi Julien, everyone!
>>
>> I suggest we move forward in this project. First things first, we need to
>> integrate bootstrap into the framework. So I think the following steps are
>> to be done next:
>>
>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>> include them in the base CommonScreens.xml
>>
> I think it could be better to use themes for that. The goal is to allow
> including any others CSS/HTML framework (like Zurb framework).
>
>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
>>
> I don't know how the CSS pre-processor could work in OFBiz Framework.
> Could you explain how we will use it ?
>
>> 3- Ensure that our jQuery dependencies are adequately met
>>
>> We can then have a few test screens to make sure everything is working
>> more
>> or less!
>>
>> Julien, can we proceed with the above suggested? Do we need to open the
>> JIRA first, and who should do that?
>>
> I was thinking that we start with following points that you already
> suggest as first steps :
>
> - Identify the major milestones or objectives
> - Discuss and decide upon the best methodology for implementation of the
> above objectives
> - Decide on a collaboration platform (in addition to what exists) if any.
> - Dive into code directly and just hand off tasks to volunteers who find
> them interesting / appealing from the team
>
>
> I think that we are already in the first step "Identify the major
> milestones and objectives".
>
> It could be a good thing if any volunteers explain his opinion about
> objectives.
>
> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz is
> the best way. I would prefer to work to allow any CSS/HTML framework
> working with OFBiz thanks to themes manager (suggested by Richard Siddall
> http://markmail.org/message/vn6ptu2izykvov6n). In this way we can solve
> issues like this Jira https://issues.apache.org/jira/browse/OFBIZ-5040.
>
> In my opinion, objectives are :
>     - Identify how to modify framework to allow bootstrap working
> (bootstrap included in a theme)
>     - Create bootstrap basic theme
>     - Modify framework for working with bootstrap (or other framework)
>     - identify all screens that are not working and correct theme or ofbiz
> framework.
>
>
>
>
>> Taher Alkhateeb.
>>
>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>> [hidden email]> wrote:
>>
>>  It is important to understand the screen widget architecture:
>>>
>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>> or...)
>>>
>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>> what type of output is being generated. So those artifacts do not need to
>>> be changed to support Bootstrap.
>>>
>>> The only things that need to be changed to support Bootstrap are the
>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of
>>> the
>>> current OFBiz-specific HTML + CSS.
>>>
>>> You can still use the visual themes functionality, but they will be
>>> different themes - since the HTML being styled is completely different.
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>
>>>  Hi Julien, Adrian, Community,
>>>>
>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>
>>>>  On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>
>>>>>  For this point I suggest to work on this way : Create tool to delegate
>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>> modifying the OFBiz framework.
>>>>>> But we'll do it for bootstrap first.
>>>>>>
>>>>>>
>>>>> You don't need to modify the framework. The screen widgets allow you
>>>>> to substitute alternate macros for the rendering engine. See
>>>>> widget.properties.
>>>>>
>>>>>
>>>>> Adrian Crum
>>>>>
>>>>>  correct me if I'm wrong,
>>>> but if we use widget's properties, we will not be able to provide a
>>>> hot-swap between them, except by creating new output type.
>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>> type to the new one, as the CSV rendering.
>>>> or am I missing the way that widget allow us to substitute macros
>>>> rendering ?
>>>>
>>>> Regards,
>>>> Florient.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

gomola
In reply to this post by JulienNicolas
Hey all, I worked on the tomahawk theme a while back with Bruno. I was wanting to make a clean responsive version of ofbiz and would be able to help out on a theme look and feel.

Thanks
Erik



----- Original Message -----
From: "Julien NICOLAS" <[hidden email]>
To: [hidden email]
Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
Subject: Re: Theme bootstrap

Hi Taher,



Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
> Hi Julien, everyone!
>
> I suggest we move forward in this project. First things first, we need to
> integrate bootstrap into the framework. So I think the following steps are
> to be done next:
>
> 1- copy the resources to the images component (CSS, JS, and Fonts) and
> include them in the base CommonScreens.xml
I think it could be better to use themes for that. The goal is to allow
including any others CSS/HTML framework (like Zurb framework).
> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
I don't know how the CSS pre-processor could work in OFBiz Framework.
Could you explain how we will use it ?
> 3- Ensure that our jQuery dependencies are adequately met
>
> We can then have a few test screens to make sure everything is working more
> or less!
>
> Julien, can we proceed with the above suggested? Do we need to open the
> JIRA first, and who should do that?
I was thinking that we start with following points that you already
suggest as first steps :

- Identify the major milestones or objectives
- Discuss and decide upon the best methodology for implementation of the
above objectives
- Decide on a collaboration platform (in addition to what exists) if any.
- Dive into code directly and just hand off tasks to volunteers who find
them interesting / appealing from the team


I think that we are already in the first step "Identify the major
milestones and objectives".

It could be a good thing if any volunteers explain his opinion about
objectives.

I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
is the best way. I would prefer to work to allow any CSS/HTML framework
working with OFBiz thanks to themes manager (suggested by Richard
Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
can solve issues like this Jira
https://issues.apache.org/jira/browse/OFBIZ-5040.

In my opinion, objectives are :
     - Identify how to modify framework to allow bootstrap working
(bootstrap included in a theme)
     - Create bootstrap basic theme
     - Modify framework for working with bootstrap (or other framework)
     - identify all screens that are not working and correct theme or
ofbiz framework.


>
> Taher Alkhateeb.
>
> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
> [hidden email]> wrote:
>
>> It is important to understand the screen widget architecture:
>>
>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>> or...)
>>
>> The Widget Models and Renderer are output agnostic - they don't "know"
>> what type of output is being generated. So those artifacts do not need to
>> be changed to support Bootstrap.
>>
>> The only things that need to be changed to support Bootstrap are the
>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of the
>> current OFBiz-specific HTML + CSS.
>>
>> You can still use the visual themes functionality, but they will be
>> different themes - since the HTML being styled is completely different.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 10/23/2014 10:29 PM, Florient wrote:
>>
>>> Hi Julien, Adrian, Community,
>>>
>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>
>>>> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>
>>>>> For this point I suggest to work on this way : Create tool to delegate
>>>>> HTML widget structure (and other structure) into theme framework.
>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>> modifying the OFBiz framework.
>>>>> But we'll do it for bootstrap first.
>>>>>
>>>>
>>>> You don't need to modify the framework. The screen widgets allow you
>>>> to substitute alternate macros for the rendering engine. See
>>>> widget.properties.
>>>>
>>>>
>>>> Adrian Crum
>>>>
>>> correct me if I'm wrong,
>>> but if we use widget's properties, we will not be able to provide a
>>> hot-swap between them, except by creating new output type.
>>> It sounds like duplicate each actual view-map definition using 'screen'
>>> type to the new one, as the CSV rendering.
>>> or am I missing the way that widget allow us to substitute macros
>>> rendering ?
>>>
>>> Regards,
>>> Florient.
>>>
>>>
>>>
>>>
>>>




--

Erik A. Schuessler
Brainfood Inc.
tel: 214.720.0700 e323
fax: 214.720.0703
Email: [hidden email]
Web: www.brainfood.com
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

JulienNicolas
Thanks Erik,

Welcome in the team :)

Julien.

Le 27/10/2014 17:21, Erik Schuessler a écrit :

> Hey all, I worked on the tomahawk theme a while back with Bruno. I was wanting to make a clean responsive version of ofbiz and would be able to help out on a theme look and feel.
>
> Thanks
> Erik
>
>
>
> ----- Original Message -----
> From: "Julien NICOLAS" <[hidden email]>
> To: [hidden email]
> Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
> Subject: Re: Theme bootstrap
>
> Hi Taher,
>
>
>
> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>> Hi Julien, everyone!
>>
>> I suggest we move forward in this project. First things first, we need to
>> integrate bootstrap into the framework. So I think the following steps are
>> to be done next:
>>
>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>> include them in the base CommonScreens.xml
> I think it could be better to use themes for that. The goal is to allow
> including any others CSS/HTML framework (like Zurb framework).
>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
> I don't know how the CSS pre-processor could work in OFBiz Framework.
> Could you explain how we will use it ?
>> 3- Ensure that our jQuery dependencies are adequately met
>>
>> We can then have a few test screens to make sure everything is working more
>> or less!
>>
>> Julien, can we proceed with the above suggested? Do we need to open the
>> JIRA first, and who should do that?
> I was thinking that we start with following points that you already
> suggest as first steps :
>
> - Identify the major milestones or objectives
> - Discuss and decide upon the best methodology for implementation of the
> above objectives
> - Decide on a collaboration platform (in addition to what exists) if any.
> - Dive into code directly and just hand off tasks to volunteers who find
> them interesting / appealing from the team
>
>
> I think that we are already in the first step "Identify the major
> milestones and objectives".
>
> It could be a good thing if any volunteers explain his opinion about
> objectives.
>
> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
> is the best way. I would prefer to work to allow any CSS/HTML framework
> working with OFBiz thanks to themes manager (suggested by Richard
> Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
> can solve issues like this Jira
> https://issues.apache.org/jira/browse/OFBIZ-5040.
>
> In my opinion, objectives are :
>       - Identify how to modify framework to allow bootstrap working
> (bootstrap included in a theme)
>       - Create bootstrap basic theme
>       - Modify framework for working with bootstrap (or other framework)
>       - identify all screens that are not working and correct theme or
> ofbiz framework.
>
>
>> Taher Alkhateeb.
>>
>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>> [hidden email]> wrote:
>>
>>> It is important to understand the screen widget architecture:
>>>
>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>> or...)
>>>
>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>> what type of output is being generated. So those artifacts do not need to
>>> be changed to support Bootstrap.
>>>
>>> The only things that need to be changed to support Bootstrap are the
>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of the
>>> current OFBiz-specific HTML + CSS.
>>>
>>> You can still use the visual themes functionality, but they will be
>>> different themes - since the HTML being styled is completely different.
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>
>>>> Hi Julien, Adrian, Community,
>>>>
>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>
>>>>> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>
>>>>>> For this point I suggest to work on this way : Create tool to delegate
>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>> modifying the OFBiz framework.
>>>>>> But we'll do it for bootstrap first.
>>>>>>
>>>>> You don't need to modify the framework. The screen widgets allow you
>>>>> to substitute alternate macros for the rendering engine. See
>>>>> widget.properties.
>>>>>
>>>>>
>>>>> Adrian Crum
>>>>>
>>>> correct me if I'm wrong,
>>>> but if we use widget's properties, we will not be able to provide a
>>>> hot-swap between them, except by creating new output type.
>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>> type to the new one, as the CSV rendering.
>>>> or am I missing the way that widget allow us to substitute macros
>>>> rendering ?
>>>>
>>>> Regards,
>>>> Florient.
>>>>
>>>>
>>>>
>>>>
>>>>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

taher
Hi Julien & Team,

Okay so great ideas so far. We need to reach consensus now to move forward.
If I may attempt to summarize we need to implement the following:

1- create a sub-directory called bootstrap under the image webapp to put
the resources over there (js, css and fonts) as indicated earlier by Gavin.
2- check to make sure that the current version of jQuery is compatible with
the installed version or upgrade it accordingly
3- Create a new theme based on one of the existing themes as suggested by
Julien and Gavin
4- Test the theme by switching to it and handle major bugs / issues.
5- Start to make a few test screens utilizing Bootstrap

To that end, we prefer the FlatGrey theme because it supports RTL (which is
an advantage to us as we provide Arabic support in OFBiz). However, if you
find Tomahawk a better candidate then we can go with it and we will work on
applying RTL to it within the same project.

So, do we agree? who / how / when can we move forward. Do we still need to
discuss this further?

Taher Alkhateeb

On Tue, Oct 28, 2014 at 10:03 AM, Julien NICOLAS <[hidden email]>
wrote:

> Thanks Erik,
>
> Welcome in the team :)
>
> Julien.
>
> Le 27/10/2014 17:21, Erik Schuessler a écrit :
>
>> Hey all, I worked on the tomahawk theme a while back with Bruno. I was
>> wanting to make a clean responsive version of ofbiz and would be able to
>> help out on a theme look and feel.
>>
>> Thanks
>> Erik
>>
>>
>>
>> ----- Original Message -----
>> From: "Julien NICOLAS" <[hidden email]>
>> To: [hidden email]
>> Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
>> Subject: Re: Theme bootstrap
>>
>> Hi Taher,
>>
>>
>>
>> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>>
>>> Hi Julien, everyone!
>>>
>>> I suggest we move forward in this project. First things first, we need to
>>> integrate bootstrap into the framework. So I think the following steps
>>> are
>>> to be done next:
>>>
>>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>>> include them in the base CommonScreens.xml
>>>
>> I think it could be better to use themes for that. The goal is to allow
>> including any others CSS/HTML framework (like Zurb framework).
>>
>>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
>>>
>> I don't know how the CSS pre-processor could work in OFBiz Framework.
>> Could you explain how we will use it ?
>>
>>> 3- Ensure that our jQuery dependencies are adequately met
>>>
>>> We can then have a few test screens to make sure everything is working
>>> more
>>> or less!
>>>
>>> Julien, can we proceed with the above suggested? Do we need to open the
>>> JIRA first, and who should do that?
>>>
>> I was thinking that we start with following points that you already
>> suggest as first steps :
>>
>> - Identify the major milestones or objectives
>> - Discuss and decide upon the best methodology for implementation of the
>> above objectives
>> - Decide on a collaboration platform (in addition to what exists) if any.
>> - Dive into code directly and just hand off tasks to volunteers who find
>> them interesting / appealing from the team
>>
>>
>> I think that we are already in the first step "Identify the major
>> milestones and objectives".
>>
>> It could be a good thing if any volunteers explain his opinion about
>> objectives.
>>
>> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
>> is the best way. I would prefer to work to allow any CSS/HTML framework
>> working with OFBiz thanks to themes manager (suggested by Richard
>> Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
>> can solve issues like this Jira
>> https://issues.apache.org/jira/browse/OFBIZ-5040.
>>
>> In my opinion, objectives are :
>>       - Identify how to modify framework to allow bootstrap working
>> (bootstrap included in a theme)
>>       - Create bootstrap basic theme
>>       - Modify framework for working with bootstrap (or other framework)
>>       - identify all screens that are not working and correct theme or
>> ofbiz framework.
>>
>>
>>  Taher Alkhateeb.
>>>
>>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>>> [hidden email]> wrote:
>>>
>>>  It is important to understand the screen widget architecture:
>>>>
>>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>>> or...)
>>>>
>>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>>> what type of output is being generated. So those artifacts do not need
>>>> to
>>>> be changed to support Bootstrap.
>>>>
>>>> The only things that need to be changed to support Bootstrap are the
>>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of
>>>> the
>>>> current OFBiz-specific HTML + CSS.
>>>>
>>>> You can still use the visual themes functionality, but they will be
>>>> different themes - since the HTML being styled is completely different.
>>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>>
>>>>  Hi Julien, Adrian, Community,
>>>>>
>>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>>
>>>>>  On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>>
>>>>>>  For this point I suggest to work on this way : Create tool to
>>>>>>> delegate
>>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>>> modifying the OFBiz framework.
>>>>>>> But we'll do it for bootstrap first.
>>>>>>>
>>>>>>>  You don't need to modify the framework. The screen widgets allow you
>>>>>> to substitute alternate macros for the rendering engine. See
>>>>>> widget.properties.
>>>>>>
>>>>>>
>>>>>> Adrian Crum
>>>>>>
>>>>>>  correct me if I'm wrong,
>>>>> but if we use widget's properties, we will not be able to provide a
>>>>> hot-swap between them, except by creating new output type.
>>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>>> type to the new one, as the CSV rendering.
>>>>> or am I missing the way that widget allow us to substitute macros
>>>>> rendering ?
>>>>>
>>>>> Regards,
>>>>> Florient.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

JulienNicolas
In reply to this post by Gavin Mabie-2
Gavin,

Le 27/10/2014 11:18, Gavin Mabie a écrit :

> Julien, Taher
>
> You're both making good points.  I like the generic approach proposed by
> Julien, but this could well be a longer term objective.  In fact starting
> with Bootstrap does not necessarily imply that other frameworks will be
> excluded. Also, inline with Adrian's comment, we should stay away from the
> core framework as far as possible for now and focus on the MacroLibraries
> as defined in widget.properties.  This is not to say that there will not be
> any modifications to the framework - there might well be.
> There is enough interest in Bootstrap to suggest that we start with it as a
> way forward.
I agree, create a new clean design pattern was a suggestion. When I
start bootstrap modifications, I don't think the team will grow as fast !
So for the first step we will focus on bootstrap and keep in mind about
others frameworks. Modifications must be done once. I mean if we change
something, take care to not do it specifically for bootstrap :)

>
> 1. I therefore agree with Taher that we create the following setup under
> the images app to begin with.
I'm not sure that putting bootstrap in the framework is a good thing.
Maybe it could be better to embedded bootstrap in the theme folder.

>    I believe that this will be within the
> frontendNewTheme branch alluded to by Jacques.
>
> bootstrap/
> ├── css/
> │   ├── bootstrap.css
> │   ├── bootstrap.min.css
> │   ├── bootstrap-theme.css
> │   └── bootstrap-theme.min.css
> ├── js/
> │   ├── bootstrap.js
> │   └── bootstrap.min.js
> └── fonts/
>      ├── glyphicons-halflings-regular.eot
>      ├── glyphicons-halflings-regular.svg
>      ├── glyphicons-halflings-regular.ttf
>      └── glyphicons-halflings-regular.woff
>
> 2. Create a new theme component as an Admin Template app - I suggest
> that we clone Tomahawk. Maybe we can call it Vanilla Bootstrap.
I prefer "Bootstrap basic" but that doesn't mind :)
>
> 3. Add screens and widgets to the new app - much like the current
> Example app.  This can be used as an admin template -See
> http://demo.onokumus.com/metis/.
>
> 4. Like the Example app we can use the Admin Template app to demo
> Ofbiz-Bootstrap.
I think it's a good idea, it could be very useful !
>
> 5.  The Admin Template app is used in the normal way, i.e, create jiras etc.
+1

Regards,

Julien.

>
> If this approach is acceptable then someone with the appropriate
> credentials can get the ball rolling by completing step 1.
>
> Regards
>
> Gavin
>
>
>
> On Mon, Oct 27, 2014 at 10:58 AM, Julien NICOLAS <[hidden email]>
> wrote:
>
>> Hi Taher,
>>
>>
>>
>> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>>
>>> Hi Julien, everyone!
>>>
>>> I suggest we move forward in this project. First things first, we need to
>>> integrate bootstrap into the framework. So I think the following steps are
>>> to be done next:
>>>
>>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>>> include them in the base CommonScreens.xml
>>>
>> I think it could be better to use themes for that. The goal is to allow
>> including any others CSS/HTML framework (like Zurb framework).
>>
>>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
>>>
>> I don't know how the CSS pre-processor could work in OFBiz Framework.
>> Could you explain how we will use it ?
>>
>>> 3- Ensure that our jQuery dependencies are adequately met
>>>
>>> We can then have a few test screens to make sure everything is working
>>> more
>>> or less!
>>>
>>> Julien, can we proceed with the above suggested? Do we need to open the
>>> JIRA first, and who should do that?
>>>
>> I was thinking that we start with following points that you already
>> suggest as first steps :
>>
>> - Identify the major milestones or objectives
>> - Discuss and decide upon the best methodology for implementation of the
>> above objectives
>> - Decide on a collaboration platform (in addition to what exists) if any.
>> - Dive into code directly and just hand off tasks to volunteers who find
>> them interesting / appealing from the team
>>
>>
>> I think that we are already in the first step "Identify the major
>> milestones and objectives".
>>
>> It could be a good thing if any volunteers explain his opinion about
>> objectives.
>>
>> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz is
>> the best way. I would prefer to work to allow any CSS/HTML framework
>> working with OFBiz thanks to themes manager (suggested by Richard Siddall
>> http://markmail.org/message/vn6ptu2izykvov6n). In this way we can solve
>> issues like this Jira https://issues.apache.org/jira/browse/OFBIZ-5040.
>>
>> In my opinion, objectives are :
>>      - Identify how to modify framework to allow bootstrap working
>> (bootstrap included in a theme)
>>      - Create bootstrap basic theme
>>      - Modify framework for working with bootstrap (or other framework)
>>      - identify all screens that are not working and correct theme or ofbiz
>> framework.
>>
>>
>>
>>
>>> Taher Alkhateeb.
>>>
>>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>>> [hidden email]> wrote:
>>>
>>>   It is important to understand the screen widget architecture:
>>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>>> or...)
>>>>
>>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>>> what type of output is being generated. So those artifacts do not need to
>>>> be changed to support Bootstrap.
>>>>
>>>> The only things that need to be changed to support Bootstrap are the
>>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of
>>>> the
>>>> current OFBiz-specific HTML + CSS.
>>>>
>>>> You can still use the visual themes functionality, but they will be
>>>> different themes - since the HTML being styled is completely different.
>>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>>
>>>>   Hi Julien, Adrian, Community,
>>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>>
>>>>>   On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>>   For this point I suggest to work on this way : Create tool to delegate
>>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>>> modifying the OFBiz framework.
>>>>>>> But we'll do it for bootstrap first.
>>>>>>>
>>>>>>>
>>>>>> You don't need to modify the framework. The screen widgets allow you
>>>>>> to substitute alternate macros for the rendering engine. See
>>>>>> widget.properties.
>>>>>>
>>>>>>
>>>>>> Adrian Crum
>>>>>>
>>>>>>   correct me if I'm wrong,
>>>>> but if we use widget's properties, we will not be able to provide a
>>>>> hot-swap between them, except by creating new output type.
>>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>>> type to the new one, as the CSV rendering.
>>>>> or am I missing the way that widget allow us to substitute macros
>>>>> rendering ?
>>>>>
>>>>> Regards,
>>>>> Florient.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>

Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

JulienNicolas
In reply to this post by taher
I just create a sub-task of OFBIZ-5040 :
https://issues.apache.org/jira/browse/OFBIZ-5840

No problem for me to start form flatgrey.

Julien.

Le 28/10/2014 08:38, Taher Alkhateeb a écrit :

> Hi Julien & Team,
>
> Okay so great ideas so far. We need to reach consensus now to move forward.
> If I may attempt to summarize we need to implement the following:
>
> 1- create a sub-directory called bootstrap under the image webapp to put
> the resources over there (js, css and fonts) as indicated earlier by Gavin.
> 2- check to make sure that the current version of jQuery is compatible with
> the installed version or upgrade it accordingly
> 3- Create a new theme based on one of the existing themes as suggested by
> Julien and Gavin
> 4- Test the theme by switching to it and handle major bugs / issues.
> 5- Start to make a few test screens utilizing Bootstrap
>
> To that end, we prefer the FlatGrey theme because it supports RTL (which is
> an advantage to us as we provide Arabic support in OFBiz). However, if you
> find Tomahawk a better candidate then we can go with it and we will work on
> applying RTL to it within the same project.
>
> So, do we agree? who / how / when can we move forward. Do we still need to
> discuss this further?
>
> Taher Alkhateeb
>
> On Tue, Oct 28, 2014 at 10:03 AM, Julien NICOLAS <[hidden email]>
> wrote:
>
>> Thanks Erik,
>>
>> Welcome in the team :)
>>
>> Julien.
>>
>> Le 27/10/2014 17:21, Erik Schuessler a écrit :
>>
>>> Hey all, I worked on the tomahawk theme a while back with Bruno. I was
>>> wanting to make a clean responsive version of ofbiz and would be able to
>>> help out on a theme look and feel.
>>>
>>> Thanks
>>> Erik
>>>
>>>
>>>
>>> ----- Original Message -----
>>> From: "Julien NICOLAS" <[hidden email]>
>>> To: [hidden email]
>>> Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
>>> Subject: Re: Theme bootstrap
>>>
>>> Hi Taher,
>>>
>>>
>>>
>>> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>>>
>>>> Hi Julien, everyone!
>>>>
>>>> I suggest we move forward in this project. First things first, we need to
>>>> integrate bootstrap into the framework. So I think the following steps
>>>> are
>>>> to be done next:
>>>>
>>>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>>>> include them in the base CommonScreens.xml
>>>>
>>> I think it could be better to use themes for that. The goal is to allow
>>> including any others CSS/HTML framework (like Zurb framework).
>>>
>>>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
>>>>
>>> I don't know how the CSS pre-processor could work in OFBiz Framework.
>>> Could you explain how we will use it ?
>>>
>>>> 3- Ensure that our jQuery dependencies are adequately met
>>>>
>>>> We can then have a few test screens to make sure everything is working
>>>> more
>>>> or less!
>>>>
>>>> Julien, can we proceed with the above suggested? Do we need to open the
>>>> JIRA first, and who should do that?
>>>>
>>> I was thinking that we start with following points that you already
>>> suggest as first steps :
>>>
>>> - Identify the major milestones or objectives
>>> - Discuss and decide upon the best methodology for implementation of the
>>> above objectives
>>> - Decide on a collaboration platform (in addition to what exists) if any.
>>> - Dive into code directly and just hand off tasks to volunteers who find
>>> them interesting / appealing from the team
>>>
>>>
>>> I think that we are already in the first step "Identify the major
>>> milestones and objectives".
>>>
>>> It could be a good thing if any volunteers explain his opinion about
>>> objectives.
>>>
>>> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
>>> is the best way. I would prefer to work to allow any CSS/HTML framework
>>> working with OFBiz thanks to themes manager (suggested by Richard
>>> Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
>>> can solve issues like this Jira
>>> https://issues.apache.org/jira/browse/OFBIZ-5040.
>>>
>>> In my opinion, objectives are :
>>>        - Identify how to modify framework to allow bootstrap working
>>> (bootstrap included in a theme)
>>>        - Create bootstrap basic theme
>>>        - Modify framework for working with bootstrap (or other framework)
>>>        - identify all screens that are not working and correct theme or
>>> ofbiz framework.
>>>
>>>
>>>   Taher Alkhateeb.
>>>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>>>> [hidden email]> wrote:
>>>>
>>>>   It is important to understand the screen widget architecture:
>>>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>>>> or...)
>>>>>
>>>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>>>> what type of output is being generated. So those artifacts do not need
>>>>> to
>>>>> be changed to support Bootstrap.
>>>>>
>>>>> The only things that need to be changed to support Bootstrap are the
>>>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of
>>>>> the
>>>>> current OFBiz-specific HTML + CSS.
>>>>>
>>>>> You can still use the visual themes functionality, but they will be
>>>>> different themes - since the HTML being styled is completely different.
>>>>>
>>>>> Adrian Crum
>>>>> Sandglass Software
>>>>> www.sandglass-software.com
>>>>>
>>>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>>>
>>>>>   Hi Julien, Adrian, Community,
>>>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>>>
>>>>>>   On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>>>   For this point I suggest to work on this way : Create tool to
>>>>>>>> delegate
>>>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>>>> modifying the OFBiz framework.
>>>>>>>> But we'll do it for bootstrap first.
>>>>>>>>
>>>>>>>>   You don't need to modify the framework. The screen widgets allow you
>>>>>>> to substitute alternate macros for the rendering engine. See
>>>>>>> widget.properties.
>>>>>>>
>>>>>>>
>>>>>>> Adrian Crum
>>>>>>>
>>>>>>>   correct me if I'm wrong,
>>>>>> but if we use widget's properties, we will not be able to provide a
>>>>>> hot-swap between them, except by creating new output type.
>>>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>>>> type to the new one, as the CSV rendering.
>>>>>> or am I missing the way that widget allow us to substitute macros
>>>>>> rendering ?
>>>>>>
>>>>>> Regards,
>>>>>> Florient.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>
>>>

Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

Jacques Le Roux
Administrator
In reply to this post by gomola
That would be very much appreciated, thanks Erik!

Jacques

Le 27/10/2014 17:21, Erik Schuessler a écrit :

> Hey all, I worked on the tomahawk theme a while back with Bruno. I was wanting to make a clean responsive version of ofbiz and would be able to help out on a theme look and feel.
>
> Thanks
> Erik
>
>
>
> ----- Original Message -----
> From: "Julien NICOLAS" <[hidden email]>
> To: [hidden email]
> Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
> Subject: Re: Theme bootstrap
>
> Hi Taher,
>
>
>
> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>> Hi Julien, everyone!
>>
>> I suggest we move forward in this project. First things first, we need to
>> integrate bootstrap into the framework. So I think the following steps are
>> to be done next:
>>
>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>> include them in the base CommonScreens.xml
> I think it could be better to use themes for that. The goal is to allow
> including any others CSS/HTML framework (like Zurb framework).
>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
> I don't know how the CSS pre-processor could work in OFBiz Framework.
> Could you explain how we will use it ?
>> 3- Ensure that our jQuery dependencies are adequately met
>>
>> We can then have a few test screens to make sure everything is working more
>> or less!
>>
>> Julien, can we proceed with the above suggested? Do we need to open the
>> JIRA first, and who should do that?
> I was thinking that we start with following points that you already
> suggest as first steps :
>
> - Identify the major milestones or objectives
> - Discuss and decide upon the best methodology for implementation of the
> above objectives
> - Decide on a collaboration platform (in addition to what exists) if any.
> - Dive into code directly and just hand off tasks to volunteers who find
> them interesting / appealing from the team
>
>
> I think that we are already in the first step "Identify the major
> milestones and objectives".
>
> It could be a good thing if any volunteers explain his opinion about
> objectives.
>
> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
> is the best way. I would prefer to work to allow any CSS/HTML framework
> working with OFBiz thanks to themes manager (suggested by Richard
> Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
> can solve issues like this Jira
> https://issues.apache.org/jira/browse/OFBIZ-5040.
>
> In my opinion, objectives are :
>       - Identify how to modify framework to allow bootstrap working
> (bootstrap included in a theme)
>       - Create bootstrap basic theme
>       - Modify framework for working with bootstrap (or other framework)
>       - identify all screens that are not working and correct theme or
> ofbiz framework.
>
>
>> Taher Alkhateeb.
>>
>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>> [hidden email]> wrote:
>>
>>> It is important to understand the screen widget architecture:
>>>
>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>> or...)
>>>
>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>> what type of output is being generated. So those artifacts do not need to
>>> be changed to support Bootstrap.
>>>
>>> The only things that need to be changed to support Bootstrap are the
>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of the
>>> current OFBiz-specific HTML + CSS.
>>>
>>> You can still use the visual themes functionality, but they will be
>>> different themes - since the HTML being styled is completely different.
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>
>>>> Hi Julien, Adrian, Community,
>>>>
>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>
>>>>> On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>
>>>>>> For this point I suggest to work on this way : Create tool to delegate
>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>> modifying the OFBiz framework.
>>>>>> But we'll do it for bootstrap first.
>>>>>>
>>>>> You don't need to modify the framework. The screen widgets allow you
>>>>> to substitute alternate macros for the rendering engine. See
>>>>> widget.properties.
>>>>>
>>>>>
>>>>> Adrian Crum
>>>>>
>>>> correct me if I'm wrong,
>>>> but if we use widget's properties, we will not be able to provide a
>>>> hot-swap between them, except by creating new output type.
>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>> type to the new one, as the CSV rendering.
>>>> or am I missing the way that widget allow us to substitute macros
>>>> rendering ?
>>>>
>>>> Regards,
>>>> Florient.
>>>>
>>>>
>>>>
>>>>
>>>>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

Jacques Le Roux
Administrator
In reply to this post by JulienNicolas
I really appreciate the common envisioned effort on this, and I see that lessons from the past have been learned by new comers, this is really a great
and promising start.

Even if I prefer the Tomahawk theme for convenience (I'm a bit daltonian, this might explain) I'm not against the FlatGrey theme and having RTL
support from start is certainly a must.
Just a request then, please replace the top menu by dropdown menus like in Tomahawk.  If you care why please read the last section of
http://markmail.org/message/i653srayddy2bkr7 about columns and newspapers
Also if at last we could alphabetically sort the menu entries that would be a great improvement :D. But of course this should be adjustable by
language (how to for RTL languages is a good question)

Jacques


Le 28/10/2014 09:05, Julien NICOLAS a écrit :

> I just create a sub-task of OFBIZ-5040 : https://issues.apache.org/jira/browse/OFBIZ-5840
>
> No problem for me to start form flatgrey.
>
> Julien.
>
> Le 28/10/2014 08:38, Taher Alkhateeb a écrit :
>> Hi Julien & Team,
>>
>> Okay so great ideas so far. We need to reach consensus now to move forward.
>> If I may attempt to summarize we need to implement the following:
>>
>> 1- create a sub-directory called bootstrap under the image webapp to put
>> the resources over there (js, css and fonts) as indicated earlier by Gavin.
>> 2- check to make sure that the current version of jQuery is compatible with
>> the installed version or upgrade it accordingly
>> 3- Create a new theme based on one of the existing themes as suggested by
>> Julien and Gavin
>> 4- Test the theme by switching to it and handle major bugs / issues.
>> 5- Start to make a few test screens utilizing Bootstrap
>>
>> To that end, we prefer the FlatGrey theme because it supports RTL (which is
>> an advantage to us as we provide Arabic support in OFBiz). However, if you
>> find Tomahawk a better candidate then we can go with it and we will work on
>> applying RTL to it within the same project.
>>
>> So, do we agree? who / how / when can we move forward. Do we still need to
>> discuss this further?
>>
>> Taher Alkhateeb
>>
>> On Tue, Oct 28, 2014 at 10:03 AM, Julien NICOLAS <[hidden email]>
>> wrote:
>>
>>> Thanks Erik,
>>>
>>> Welcome in the team :)
>>>
>>> Julien.
>>>
>>> Le 27/10/2014 17:21, Erik Schuessler a écrit :
>>>
>>>> Hey all, I worked on the tomahawk theme a while back with Bruno. I was
>>>> wanting to make a clean responsive version of ofbiz and would be able to
>>>> help out on a theme look and feel.
>>>>
>>>> Thanks
>>>> Erik
>>>>
>>>>
>>>>
>>>> ----- Original Message -----
>>>> From: "Julien NICOLAS" <[hidden email]>
>>>> To: [hidden email]
>>>> Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
>>>> Subject: Re: Theme bootstrap
>>>>
>>>> Hi Taher,
>>>>
>>>>
>>>>
>>>> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>>>>
>>>>> Hi Julien, everyone!
>>>>>
>>>>> I suggest we move forward in this project. First things first, we need to
>>>>> integrate bootstrap into the framework. So I think the following steps
>>>>> are
>>>>> to be done next:
>>>>>
>>>>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>>>>> include them in the base CommonScreens.xml
>>>>>
>>>> I think it could be better to use themes for that. The goal is to allow
>>>> including any others CSS/HTML framework (like Zurb framework).
>>>>
>>>>> 2- Repeat step 1 above to SASS (thank god Bootstrap move away from LESS)
>>>>>
>>>> I don't know how the CSS pre-processor could work in OFBiz Framework.
>>>> Could you explain how we will use it ?
>>>>
>>>>> 3- Ensure that our jQuery dependencies are adequately met
>>>>>
>>>>> We can then have a few test screens to make sure everything is working
>>>>> more
>>>>> or less!
>>>>>
>>>>> Julien, can we proceed with the above suggested? Do we need to open the
>>>>> JIRA first, and who should do that?
>>>>>
>>>> I was thinking that we start with following points that you already
>>>> suggest as first steps :
>>>>
>>>> - Identify the major milestones or objectives
>>>> - Discuss and decide upon the best methodology for implementation of the
>>>> above objectives
>>>> - Decide on a collaboration platform (in addition to what exists) if any.
>>>> - Dive into code directly and just hand off tasks to volunteers who find
>>>> them interesting / appealing from the team
>>>>
>>>>
>>>> I think that we are already in the first step "Identify the major
>>>> milestones and objectives".
>>>>
>>>> It could be a good thing if any volunteers explain his opinion about
>>>> objectives.
>>>>
>>>> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
>>>> is the best way. I would prefer to work to allow any CSS/HTML framework
>>>> working with OFBiz thanks to themes manager (suggested by Richard
>>>> Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
>>>> can solve issues like this Jira
>>>> https://issues.apache.org/jira/browse/OFBIZ-5040.
>>>>
>>>> In my opinion, objectives are :
>>>>        - Identify how to modify framework to allow bootstrap working
>>>> (bootstrap included in a theme)
>>>>        - Create bootstrap basic theme
>>>>        - Modify framework for working with bootstrap (or other framework)
>>>>        - identify all screens that are not working and correct theme or
>>>> ofbiz framework.
>>>>
>>>>
>>>>   Taher Alkhateeb.
>>>>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>>>>> [hidden email]> wrote:
>>>>>
>>>>>   It is important to understand the screen widget architecture:
>>>>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>>>>> or...)
>>>>>>
>>>>>> The Widget Models and Renderer are output agnostic - they don't "know"
>>>>>> what type of output is being generated. So those artifacts do not need
>>>>>> to
>>>>>> be changed to support Bootstrap.
>>>>>>
>>>>>> The only things that need to be changed to support Bootstrap are the
>>>>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead of
>>>>>> the
>>>>>> current OFBiz-specific HTML + CSS.
>>>>>>
>>>>>> You can still use the visual themes functionality, but they will be
>>>>>> different themes - since the HTML being styled is completely different.
>>>>>>
>>>>>> Adrian Crum
>>>>>> Sandglass Software
>>>>>> www.sandglass-software.com
>>>>>>
>>>>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>>>>
>>>>>>   Hi Julien, Adrian, Community,
>>>>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>>>>
>>>>>>>   On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>>>>   For this point I suggest to work on this way : Create tool to
>>>>>>>>> delegate
>>>>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>>>>> To be clear, I suggest to not integrate bootstrap only but modify the
>>>>>>>>> framework to allow any other HTML/CSS frameworks integration without
>>>>>>>>> modifying the OFBiz framework.
>>>>>>>>> But we'll do it for bootstrap first.
>>>>>>>>>
>>>>>>>>>   You don't need to modify the framework. The screen widgets allow you
>>>>>>>> to substitute alternate macros for the rendering engine. See
>>>>>>>> widget.properties.
>>>>>>>>
>>>>>>>>
>>>>>>>> Adrian Crum
>>>>>>>>
>>>>>>>>   correct me if I'm wrong,
>>>>>>> but if we use widget's properties, we will not be able to provide a
>>>>>>> hot-swap between them, except by creating new output type.
>>>>>>> It sounds like duplicate each actual view-map definition using 'screen'
>>>>>>> type to the new one, as the CSV rendering.
>>>>>>> or am I missing the way that widget allow us to substitute macros
>>>>>>> rendering ?
>>>>>>>
>>>>>>> Regards,
>>>>>>> Florient.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>
>>>>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Theme bootstrap

Thiep LE VAN
Hi Julien,

I'd like to work with you !

On Wed, Oct 29, 2014 at 4:40 AM, Jacques Le Roux <
[hidden email]> wrote:

> I really appreciate the common envisioned effort on this, and I see that
> lessons from the past have been learned by new comers, this is really a
> great and promising start.
>
> Even if I prefer the Tomahawk theme for convenience (I'm a bit daltonian,
> this might explain) I'm not against the FlatGrey theme and having RTL
> support from start is certainly a must.
> Just a request then, please replace the top menu by dropdown menus like in
> Tomahawk.  If you care why please read the last section of
> http://markmail.org/message/i653srayddy2bkr7 about columns and newspapers
> Also if at last we could alphabetically sort the menu entries that would
> be a great improvement :D. But of course this should be adjustable by
> language (how to for RTL languages is a good question)
>
> Jacques
>
>
> Le 28/10/2014 09:05, Julien NICOLAS a écrit :
>
>  I just create a sub-task of OFBIZ-5040 : https://issues.apache.org/
>> jira/browse/OFBIZ-5840
>>
>> No problem for me to start form flatgrey.
>>
>> Julien.
>>
>> Le 28/10/2014 08:38, Taher Alkhateeb a écrit :
>>
>>> Hi Julien & Team,
>>>
>>> Okay so great ideas so far. We need to reach consensus now to move
>>> forward.
>>> If I may attempt to summarize we need to implement the following:
>>>
>>> 1- create a sub-directory called bootstrap under the image webapp to put
>>> the resources over there (js, css and fonts) as indicated earlier by
>>> Gavin.
>>> 2- check to make sure that the current version of jQuery is compatible
>>> with
>>> the installed version or upgrade it accordingly
>>> 3- Create a new theme based on one of the existing themes as suggested by
>>> Julien and Gavin
>>> 4- Test the theme by switching to it and handle major bugs / issues.
>>> 5- Start to make a few test screens utilizing Bootstrap
>>>
>>> To that end, we prefer the FlatGrey theme because it supports RTL (which
>>> is
>>> an advantage to us as we provide Arabic support in OFBiz). However, if
>>> you
>>> find Tomahawk a better candidate then we can go with it and we will work
>>> on
>>> applying RTL to it within the same project.
>>>
>>> So, do we agree? who / how / when can we move forward. Do we still need
>>> to
>>> discuss this further?
>>>
>>> Taher Alkhateeb
>>>
>>> On Tue, Oct 28, 2014 at 10:03 AM, Julien NICOLAS <
>>> [hidden email]>
>>> wrote:
>>>
>>>  Thanks Erik,
>>>>
>>>> Welcome in the team :)
>>>>
>>>> Julien.
>>>>
>>>> Le 27/10/2014 17:21, Erik Schuessler a écrit :
>>>>
>>>>  Hey all, I worked on the tomahawk theme a while back with Bruno. I was
>>>>> wanting to make a clean responsive version of ofbiz and would be able
>>>>> to
>>>>> help out on a theme look and feel.
>>>>>
>>>>> Thanks
>>>>> Erik
>>>>>
>>>>>
>>>>>
>>>>> ----- Original Message -----
>>>>> From: "Julien NICOLAS" <[hidden email]>
>>>>> To: [hidden email]
>>>>> Sent: Monday, October 27, 2014 3:58:55 AM GMT -06:00 US/Canada Central
>>>>> Subject: Re: Theme bootstrap
>>>>>
>>>>> Hi Taher,
>>>>>
>>>>>
>>>>>
>>>>> Le 26/10/2014 12:50, Taher Alkhateeb a écrit :
>>>>>
>>>>>  Hi Julien, everyone!
>>>>>>
>>>>>> I suggest we move forward in this project. First things first, we
>>>>>> need to
>>>>>> integrate bootstrap into the framework. So I think the following steps
>>>>>> are
>>>>>> to be done next:
>>>>>>
>>>>>> 1- copy the resources to the images component (CSS, JS, and Fonts) and
>>>>>> include them in the base CommonScreens.xml
>>>>>>
>>>>>>  I think it could be better to use themes for that. The goal is to
>>>>> allow
>>>>> including any others CSS/HTML framework (like Zurb framework).
>>>>>
>>>>>  2- Repeat step 1 above to SASS (thank god Bootstrap move away from
>>>>>> LESS)
>>>>>>
>>>>>>  I don't know how the CSS pre-processor could work in OFBiz Framework.
>>>>> Could you explain how we will use it ?
>>>>>
>>>>>  3- Ensure that our jQuery dependencies are adequately met
>>>>>>
>>>>>> We can then have a few test screens to make sure everything is working
>>>>>> more
>>>>>> or less!
>>>>>>
>>>>>> Julien, can we proceed with the above suggested? Do we need to open
>>>>>> the
>>>>>> JIRA first, and who should do that?
>>>>>>
>>>>>>  I was thinking that we start with following points that you already
>>>>> suggest as first steps :
>>>>>
>>>>> - Identify the major milestones or objectives
>>>>> - Discuss and decide upon the best methodology for implementation of
>>>>> the
>>>>> above objectives
>>>>> - Decide on a collaboration platform (in addition to what exists) if
>>>>> any.
>>>>> - Dive into code directly and just hand off tasks to volunteers who
>>>>> find
>>>>> them interesting / appealing from the team
>>>>>
>>>>>
>>>>> I think that we are already in the first step "Identify the major
>>>>> milestones and objectives".
>>>>>
>>>>> It could be a good thing if any volunteers explain his opinion about
>>>>> objectives.
>>>>>
>>>>> I'm not sure to push bootstrap as the main CSS/HTML framework of OFBiz
>>>>> is the best way. I would prefer to work to allow any CSS/HTML framework
>>>>> working with OFBiz thanks to themes manager (suggested by Richard
>>>>> Siddall http://markmail.org/message/vn6ptu2izykvov6n). In this way we
>>>>> can solve issues like this Jira
>>>>> https://issues.apache.org/jira/browse/OFBIZ-5040.
>>>>>
>>>>> In my opinion, objectives are :
>>>>>        - Identify how to modify framework to allow bootstrap working
>>>>> (bootstrap included in a theme)
>>>>>        - Create bootstrap basic theme
>>>>>        - Modify framework for working with bootstrap (or other
>>>>> framework)
>>>>>        - identify all screens that are not working and correct theme or
>>>>> ofbiz framework.
>>>>>
>>>>>
>>>>>   Taher Alkhateeb.
>>>>>
>>>>>> On Fri, Oct 24, 2014 at 9:07 AM, Adrian Crum <
>>>>>> [hidden email]> wrote:
>>>>>>
>>>>>>   It is important to understand the screen widget architecture:
>>>>>>
>>>>>>> Widget Models -> Renderer -> FreeMarker Macros -> HTML + CSS (or CSV,
>>>>>>> or...)
>>>>>>>
>>>>>>> The Widget Models and Renderer are output agnostic - they don't
>>>>>>> "know"
>>>>>>> what type of output is being generated. So those artifacts do not
>>>>>>> need
>>>>>>> to
>>>>>>> be changed to support Bootstrap.
>>>>>>>
>>>>>>> The only things that need to be changed to support Bootstrap are the
>>>>>>> FreeMarker macros - so that they output Bootstrap HTML + CSS instead
>>>>>>> of
>>>>>>> the
>>>>>>> current OFBiz-specific HTML + CSS.
>>>>>>>
>>>>>>> You can still use the visual themes functionality, but they will be
>>>>>>> different themes - since the HTML being styled is completely
>>>>>>> different.
>>>>>>>
>>>>>>> Adrian Crum
>>>>>>> Sandglass Software
>>>>>>> www.sandglass-software.com
>>>>>>>
>>>>>>> On 10/23/2014 10:29 PM, Florient wrote:
>>>>>>>
>>>>>>>   Hi Julien, Adrian, Community,
>>>>>>>
>>>>>>>> Le 23/10/2014 08:46, Adrian Crum a écrit :
>>>>>>>>
>>>>>>>>   On 10/23/2014 7:12 AM, Julien NICOLAS wrote:
>>>>>>>>
>>>>>>>>>   For this point I suggest to work on this way : Create tool to
>>>>>>>>>
>>>>>>>>>> delegate
>>>>>>>>>> HTML widget structure (and other structure) into theme framework.
>>>>>>>>>> To be clear, I suggest to not integrate bootstrap only but modify
>>>>>>>>>> the
>>>>>>>>>> framework to allow any other HTML/CSS frameworks integration
>>>>>>>>>> without
>>>>>>>>>> modifying the OFBiz framework.
>>>>>>>>>> But we'll do it for bootstrap first.
>>>>>>>>>>
>>>>>>>>>>   You don't need to modify the framework. The screen widgets
>>>>>>>>>> allow you
>>>>>>>>>>
>>>>>>>>> to substitute alternate macros for the rendering engine. See
>>>>>>>>> widget.properties.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Adrian Crum
>>>>>>>>>
>>>>>>>>>   correct me if I'm wrong,
>>>>>>>>>
>>>>>>>> but if we use widget's properties, we will not be able to provide a
>>>>>>>> hot-swap between them, except by creating new output type.
>>>>>>>> It sounds like duplicate each actual view-map definition using
>>>>>>>> 'screen'
>>>>>>>> type to the new one, as the CSV rendering.
>>>>>>>> or am I missing the way that widget allow us to substitute macros
>>>>>>>> rendering ?
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Florient.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>
>>>>>
>>
>>
>>


--
*THIEP LE (Mr)*
*Developer*
*Email:* [hidden email] | *Mobile:* (+84) 1656 241 339

*OLBIUS., JSC*
*Tel:* (+84) 9 88 99 3333
*Address: *Room 2508, M3-M4 building, No 91, Nguyen Chi Thanh St., Ha Noi
City, VietNam
*Website:* http://olbius.com
12