Re: Users - [JIRA] Commented: (OFBIZ-898) ordermgr orderlist 'All' checkbox doesn't work(?)

[Charles Johnson-4]

>>

Si Chen (JIRA) wrote:

[ http://jira.undersunconsulting.com/browse/OFBIZ-898?page=comments#action_13507 ]
     
Si Chen commented on OFBIZ-898:
-------------------------------

Charles,

This is good.  The original feature was not broken though.  If you clicked on "All" it still displayed all orders--it just didn't show it on the form.  

I'm going to commit it with one reservation: if you click then unclick "All" you'd see no options clicked, but then if you did a search, you'd see a list of orders.  That's because the originally checked options (Created, Processing, Approved) are "default" options.

Si

PS in the future please do your $ svn diff from the ofbiz/ directory so it's easier to patch, esp. if you had multiple files.
 
>>

Actually on a swift perusal of framework/images/webapp/images/selectall.js, it looks as though something in there should be connected up. I've not had time to look at this again and shall be disappearing for a few days. There should probably be a standard pattern for this 'all or nothing' functionality, and i suspect the above file is part of an attempt to implement such a pattern. This ought to be explictly commented in any source i think so that the wheel is not reinvented (as perhaps i've just done ;-)

Shall diff from root in future, sorry.

CJ



 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users

[Si Chen-2]

Charles,

Can you please send in an Apache ICLA as soon as possible?  http://
www.apache.org/licenses/icla.txt

Apparently we don't have one from you yet, so if we don't get one in  
time, I may have to revert this commit.  Please see David's comments  
on the JIRA issue.

Si



On Jun 9, 2006, at 12:14 PM, Charles Johnson wrote:

>>>
>
> Si Chen (JIRA) wrote:
>
> [ http://jira.undersunconsulting.com/browse/OFBIZ-898?
> page=comments#action_13507 ]
>
> Si Chen commented on OFBIZ-898:
> -------------------------------
>
> Charles,
>
> This is good.  The original feature was not broken though.  If you  
> clicked on "All" it still displayed all orders--it just didn't show  
> it on the form.
>
> I'm going to commit it with one reservation: if you click then  
> unclick "All" you'd see no options clicked, but then if you did a  
> search, you'd see a list of orders.  That's because the originally  
> checked options (Created, Processing, Approved) are "default" options.
>
> Si
>
> PS in the future please do your $ svn diff from the ofbiz/  
> directory so it's easier to patch, esp. if you had multiple files.
>
>>>
>
> Actually on a swift perusal of framework/images/webapp/images/
> selectall.js, it looks as though something in there should be  
> connected up. I've not had time to look at this again and shall be  
> disappearing for a few days. There should probably be a standard  
> pattern for this 'all or nothing' functionality, and i suspect the  
> above file is part of an attempt to implement such a pattern. This  
> ought to be explictly commented in any source i think so that the  
> wheel is not reinvented (as perhaps i've just done ;-)
>
> Shall diff from root in future, sorry.
>
> CJ
>
>
>
>
> _______________________________________________
> Users mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/users

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users

[Charles Johnson-4]

Si Chen wrote:

>Charles,
>
>Can you please send in an Apache ICLA as soon as possible?  http://
>www.apache.org/licenses/icla.txt
>
>Apparently we don't have one from you yet, so if we don't get one in  
>time, I may have to revert this commit.  Please see David's comments  
>on the JIRA issue.
>
>Si
>  
>
>  
>

No problem - please find attached

CJ

 
_______________________________________________
Users mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/users