Re: [apache/ofbiz-plugins] Ofbiz 11451: add the license (#8)

[Pierre Smits-3]

@Jacopo I don't have a clue what you're talking about. Can you elaborate?

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer


On Fri, Mar 13, 2020 at 11:58 AM Jacopo Cappellato <[hidden email]>
wrote:

> The license should not contain references to themes and framework since
> these are not part of the plugins.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/ofbiz-plugins/pull/8#issuecomment-598666347>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA6ERMQ3UCUDMUQURW6U7L3RHIGWDANCNFSM4LG7PLUQ>
> .
>

[Jacopo Cappellato-3]

On Fri, Mar 13, 2020 at 12:01 PM Pierre Smits <[hidden email]>
wrote:

> @Jacopo I don't have a clue what you're talking about. Can you elaborate?


Yes, I have added my comments as a code review in the PR: however I
recommend that you spend some time learning how our license file is
composed before you contribute to it.
As a side note, if we add the LICENSE file to plugins then we will have to
remove it when we release the full package (framework+plugins) so we should
document this in our release guide.

Jacopo

[Pierre Smits-3]

IMO we should not confuse generating convenience packages (combining base
and plugins releases) with doing releases.


Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer


On Fri, Mar 13, 2020 at 12:10 PM Jacopo Cappellato <
[hidden email]> wrote:

> On Fri, Mar 13, 2020 at 12:01 PM Pierre Smits <[hidden email]>
> wrote:
>
> > @Jacopo I don't have a clue what you're talking about. Can you elaborate?
>
>
> Yes, I have added my comments as a code review in the PR: however I
> recommend that you spend some time learning how our license file is
> composed before you contribute to it.
> As a side note, if we add the LICENSE file to plugins then we will have to
> remove it when we release the full package (framework+plugins) so we should
> document this in our release guide.
>
> Jacopo
>

[Jacopo Cappellato-3]

On Fri, Mar 13, 2020 at 12:55 PM Pierre Smits <[hidden email]>
wrote:

> IMO we should not confuse generating convenience packages (combining base
> and plugins releases) with doing releases.
>

So far, all the official releases we have published are for the full
package.

Jacopo

[Pierre Smits-3]

Indeed that is what you did. But while convenient when everything was in
one repository, that paradigm doesn't work so well with
multiple repositories. See the thread about the confusion regarding
releases in the repos and missing verification artefact.

IIRW, our release strategy is currently a subject of discussion in other
threads.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer


On Fri, Mar 13, 2020 at 1:29 PM Jacopo Cappellato <
[hidden email]> wrote:

> On Fri, Mar 13, 2020 at 12:55 PM Pierre Smits <[hidden email]>
> wrote:
>
> > IMO we should not confuse generating convenience packages (combining base
> > and plugins releases) with doing releases.
> >
>
> So far, all the official releases we have published are for the full
> package.
>
> Jacopo
>

[Jacopo Cappellato-3]

On Fri, Mar 13, 2020 at 1:41 PM Pierre Smits <[hidden email]> wrote:

> Indeed that is what you did.


What *we* did, yes.


> But while convenient when everything was in
> one repository, that paradigm doesn't work so well with
> multiple repositories.


+1


> See the thread about the confusion regarding
> releases in the repos and missing verification artefact.
>

This has nothing to do with that confusion; that issue has been discussed
for other ASF projects, see for example:

https://issues.apache.org/jira/browse/LEGAL-438


> IIRW, our release strategy is currently a subject of discussion in other
> threads.
>

Indeed. I commented here simply in response to your message about it.

Jacopo