Re: buildbot exception in on ofbizTrunkFrameworkPlugins

[Jacques Le Roux]

Hi All,

OK, now we need to agree about tasks.checkstyleMain.maxErrors in build.gradle:

https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1041/steps/shell_1/logs/stdio

Locally with trunk and plugins HEAD I get
Checkstyle files with violations: 1039
Checkstyle violations by severity: [error:37854]

I still wonder why it's not, as in Buildbot
Checkstyle files with violations: 1039
Checkstyle violations by severity: [error:37787]

And why we have tasks.checkstyleMain.maxErrors = 37776 in code.

Here is the Buildbot config:
https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf

Could someone enlighten me?

Thanks

Jacques

Le 28/11/2019 à 09:25, [hidden email] a écrit :

> The Buildbot has detected a build exception on builder ofbizTrunkFrameworkPlugins while building . Full details are available at:
>      https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1041
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf947_ubuntu
>
> Build Reason: forced: by IRC user <jleroux> (privmsg): forces manual build waiting for INFRA-19443
> Build Source Stamp: HEAD
> Blamelist:
>
> BUILD FAILED: exception shell_1 upload_1
>
> Sincerely,
>   -The Buildbot
>
>
>
>

[Mathieu Lirzin]

Hello Jacques,

Jacques Le Roux <[hidden email]> writes:

> OK, now we need to agree about tasks.checkstyleMain.maxErrors in build.gradle:
>
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1041/steps/shell_1/logs/stdio
>
> Locally with trunk and plugins HEAD I get
> Checkstyle files with violations: 1039
> Checkstyle violations by severity: [error:37854]

Probably because you have an extra plugin installed and/or an different
version of the official plugins.

> I still wonder why it's not, as in Buildbot
> Checkstyle files with violations: 1039
> Checkstyle violations by severity: [error:37787]

With latest trunk from both framework/plugins repository I get the same
number on my machine.

> And why we have tasks.checkstyleMain.maxErrors = 37776 in code.

37787 - 37776 = 11 linting errors

This is the number of linting errors introduced by either Pawan Verma or
Nicolas Malin since commit a521de9ad8a0b5a0f9ceadab348c46d7961ff89a that
remains not fixed.

> Could someone enlighten me?

Does it help ? :-)

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Jacques Le Roux]

Le 28/11/2019 à 11:16, Mathieu Lirzin a écrit :

> Hello Jacques,
>
> Jacques Le Roux <[hidden email]> writes:
>
>> OK, now we need to agree about tasks.checkstyleMain.maxErrors in build.gradle:
>>
>> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1041/steps/shell_1/logs/stdio
>>
>> Locally with trunk and plugins HEAD I get
>> Checkstyle files with violations: 1039
>> Checkstyle violations by severity: [error:37854]
> Probably because you have an extra plugin installed and/or an different
> version of the official plugins.

Nope, I use the same than in Buildbot config: pullAllPluginsFromSource.
To be sure it was HEAD, before running check I made an svn up. And I have no extra plugins.

I guess it's a Windows thing. Because on my Ubuntu VM, on the same machine, I get the same number of errors than with Buildbot

Moreover, when I use Git Bash (ie a tool to run Bash on Windows) I get the same than with plain Windows, maybe because of EOLs

Anyway I now know that's there is a make difference and I rarely run the check task.

>
>> I still wonder why it's not, as in Buildbot
>> Checkstyle files with violations: 1039
>> Checkstyle violations by severity: [error:37787]
> With latest trunk from both framework/plugins repository I get the same
> number on my machine.
>
>> And why we have tasks.checkstyleMain.maxErrors = 37776 in code.
> 37787 - 37776 = 11 linting errors
>
> This is the number of linting errors introduced by either Pawan Verma or
> Nicolas Malin since commit a521de9ad8a0b5a0f9ceadab348c46d7961ff89a that
> remains not fixed.
>
>> Could someone enlighten me?
> Does it help ? :-)

Yes, thanks Mathieu

Jacques

[Jacques Le Roux]

Le 28/11/2019 à 12:53, Jacques Le Roux a écrit :
> I guess it's a Windows thing. Because on my Ubuntu VM, on the same machine, I get the same number of errors than with Buildbot

I just noticed that on Windows there are 97 files with 0 errors included in the report. But there is the same thing on Ubuntu

Also I need to make the report file generated by Buildbot accessible...

Jacques

[Jacques Le Roux]

Le 28/11/2019 à 13:00, Jacques Le Roux a écrit :
> Le 28/11/2019 à 12:53, Jacques Le Roux a écrit :
>> I guess it's a Windows thing. Because on my Ubuntu VM, on the same machine, I get the same number of errors than with Buildbot
>
> I just noticed that on Windows there are 97 files with 0 errors included in the report. But there is the same thing on Ubuntu
>
> Also I need to make the report file generated by Buildbot accessible...
>
> Jacques
>
Those are related to ofbiz-framework/build/reports/checkstyle/test.html

I don't know how it's useful

Jacques