Re: buildbot failure in on ofbizTrunkFramework

[Jacques Le Roux]

Indeed, there is a pb with OrderNotificationTests.groovy

It should be in ecommerce I guess, I'll check.

It's OK for ofbizTrunkFrameworkPlugins

Jacques

Le 08/10/2019 à 13:25, [hidden email] a écrit :

> The Buildbot has detected a new failure on builder ofbizTrunkFramework while building . Full details are available at:
>      https://ci.apache.org/builders/ofbizTrunkFramework/builds/1128
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf946_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'onTrunkFrameworkCommit' triggered this build
> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1868128
> Blamelist: jleroux
>
> BUILD FAILED: failed shell_2
>
> Sincerely,
>   -The Buildbot
>
>
>
>

[Jacques Le Roux]

Actually the problem is more that we have 7 references to

bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens

in applications (OrderDemoData.xml and OrderTestData.xml)

I see 2 options:

 1. Move OrderNotificationTests.groovy from order to ecommerce
 2. Move EmailOrderScreens from ecommerce to order

I don't know which one would be easier and I'm not sure yet which one would be better from a disentanglement perspective.

Which one would you prefer an why? I hope answers in a week, w/o any I'll pick one.

Thanks

Jacques


Le 10/10/2019 à 20:11, Jacques Le Roux a écrit :

> Indeed, there is a pb with OrderNotificationTests.groovy
>
> It should be in ecommerce I guess, I'll check.
>
> It's OK for ofbizTrunkFrameworkPlugins
>
> Jacques
>
> Le 08/10/2019 à 13:25, [hidden email] a écrit :
>> The Buildbot has detected a new failure on builder ofbizTrunkFramework while building . Full details are available at:
>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/1128
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: asf946_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named 'onTrunkFrameworkCommit' triggered this build
>> Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1868128
>> Blamelist: jleroux
>>
>> BUILD FAILED: failed shell_2
>>
>> Sincerely,
>>   -The Buildbot
>>
>>
>>
>>
>

[Mathieu Lirzin]

Hello Jacques,

Jacques Le Roux <[hidden email]> writes:

> Actually the problem is more that we have 7 references to
>
> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens
>
> in applications (OrderDemoData.xml and OrderTestData.xml)
>
> I see 2 options:
>
> 1. Move OrderNotificationTests.groovy from order to ecommerce
> 2. Move EmailOrderScreens from ecommerce to order
>
> I don't know which one would be easier and I'm not sure yet which one
> would be better from a disentanglement perspective.
>
> Which one would you prefer an why? I hope answers in a week, w/o any I'll pick one.

IMO moving the tests to the ecommerce plugin is a preferable option.

Thanks for investigating.

--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

[Jacques Le Roux]

Le 12/10/2019 à 15:25, Mathieu Lirzin a écrit :

> Hello Jacques,
>
> Jacques Le Roux <[hidden email]> writes:
>
>> Actually the problem is more that we have 7 references to
>>
>> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens
>>
>> in applications (OrderDemoData.xml and OrderTestData.xml)
>>
>> I see 2 options:
>>
>> 1. Move OrderNotificationTests.groovy from order to ecommerce
>> 2. Move EmailOrderScreens from ecommerce to order
>>
>> I don't know which one would be easier and I'm not sure yet which one
>> would be better from a disentanglement perspective.
>>
>> Which one would you prefer an why? I hope answers in a week, w/o any I'll pick one.
> IMO moving the tests to the ecommerce plugin is a preferable option.
>
> Thanks for investigating.

Thanks Mathieu,

Doesn't count you did not say why :p

Jacques

[Jacques Le Roux]

I had decided to make the necessary related cleaning. But it's a such mess that I don't see me diving in that right now.

For now, I'll simply move OrderNotificationTests.groovy from order to ecommerce to avoid the error in framework only tests.

I created OFBIZ-11255 for that

Jacques

Le 13/10/2019 à 10:56, Jacques Le Roux a écrit :

> Le 12/10/2019 à 15:25, Mathieu Lirzin a écrit :
>> Hello Jacques,
>>
>> Jacques Le Roux <[hidden email]> writes:
>>
>>> Actually the problem is more that we have 7 references to
>>>
>>> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens
>>>
>>> in applications (OrderDemoData.xml and OrderTestData.xml)
>>>
>>> I see 2 options:
>>>
>>> 1. Move OrderNotificationTests.groovy from order to ecommerce
>>> 2. Move EmailOrderScreens from ecommerce to order
>>>
>>> I don't know which one would be easier and I'm not sure yet which one
>>> would be better from a disentanglement perspective.
>>>
>>> Which one would you prefer an why? I hope answers in a week, w/o any I'll pick one.
>> IMO moving the tests to the ecommerce plugin is a preferable option.
>>
>> Thanks for investigating.
>
> Thanks Mathieu,
>
> Doesn't count you did not say why :p
>
> Jacques
>
>

[Jacques Le Roux]

Done

Le 18/10/2019 à 15:19, Jacques Le Roux a écrit :

> I had decided to make the necessary related cleaning. But it's a such mess that I don't see me diving in that right now.
>
> For now, I'll simply move OrderNotificationTests.groovy from order to ecommerce to avoid the error in framework only tests.
>
> I created OFBIZ-11255 for that
>
> Jacques
>
> Le 13/10/2019 à 10:56, Jacques Le Roux a écrit :
>> Le 12/10/2019 à 15:25, Mathieu Lirzin a écrit :
>>> Hello Jacques,
>>>
>>> Jacques Le Roux <[hidden email]> writes:
>>>
>>>> Actually the problem is more that we have 7 references to
>>>>
>>>> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens
>>>>
>>>> in applications (OrderDemoData.xml and OrderTestData.xml)
>>>>
>>>> I see 2 options:
>>>>
>>>> 1. Move OrderNotificationTests.groovy from order to ecommerce
>>>> 2. Move EmailOrderScreens from ecommerce to order
>>>>
>>>> I don't know which one would be easier and I'm not sure yet which one
>>>> would be better from a disentanglement perspective.
>>>>
>>>> Which one would you prefer an why? I hope answers in a week, w/o any I'll pick one.
>>> IMO moving the tests to the ecommerce plugin is a preferable option.
>>>
>>> Thanks for investigating.
>>
>> Thanks Mathieu,
>>
>> Doesn't count you did not say why :p
>>
>> Jacques
>>
>>
>