Re: buildbot failure in on ofbizTrunkFramework

[Jacques Le Roux]

Hi,

I try to understand the situation here (framework only) but it's not easy.

Tests also fail in FrameworkPlugins: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins
But there is no information at https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/ I manually launched again, to no avail.

Locally with FrameworkPlugin I get the same than in framework only, ie configurableServiceOrder-test fails
But when I locally run the test alone:
"ofbiz -test component=order --test suitename=shoppingcarttests --test case=configurableServiceOrder-test"
it succeeds

If I revert https://github.com/apache/ofbiz-framework/commit/0f9307c0711fff7b8aef5c795918c21b0b9243d8/
configurableServiceOrder-test passes integration tests. So it's the culprit but I can't yet see why.

There is also an issue with auto-accounting-transaction-tests-sales I'm chasing

Jacques

Le 27/06/2020 à 15:16, [hidden email] a écrit :

> The Buildbot has detected a new failure on builder ofbizTrunkFramework while building ofbiz-framework. Full details are available at:
>      https://ci.apache.org/builders/ofbizTrunkFramework/builds/1645
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf947_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'onTrunkFrameworkCommit' triggered this build
> Build Source Stamp: [branch trunk] 0f9307c0711fff7b8aef5c795918c21b0b9243d8
> Blamelist: Priya Sharma <[hidden email]>
>
> BUILD FAILED: failed testIntegration
>
> Sincerely,
>   -The Buildbot
>
>
>

[Jacques Le Roux]

Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
> There is also an issue with auto-accounting-transaction-tests-sales I'm chasing

It seems due to https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8

2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not committing transaction, status is No Transaction (6)
2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
org.apache.ofbiz.service.GenericServiceException: Service [firstDataCCAuth] target threw an unexpected exception (Illegal character in path at index
0: [TransactionUrl]/payments)

but reverting the commit does not fix it. So maybe another mixed stuff

Jacques

[Jacques Le Roux]

Actually that was it, had to clean and reload data.

Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :

> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
>> There is also an issue with auto-accounting-transaction-tests-sales I'm chasing
>
> It seems due to https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
>
> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not committing transaction, status is No Transaction (6)
> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
> org.apache.ofbiz.service.GenericServiceException: Service [firstDataCCAuth] target threw an unexpected exception (Illegal character in path at index
> 0: [TransactionUrl]/payments)
>
> but reverting the commit does not fix it. So maybe another mixed stuff
>
> Jacques
>

[Jacques Le Roux]

Weird again, running

"ofbiz --test component=accounting --test suitename=accountingtests --test case=auto-accounting-transaction-tests-sales"

Maybe a data issue when running integration tests, maybe in both case, ie for auto-accounting-transaction-tests-sales and configurableServiceOrder-test

I continue...

Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :

> Actually that was it, had to clean and reload data.
>
> Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
>> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
>>> There is also an issue with auto-accounting-transaction-tests-sales I'm chasing
>>
>> It seems due to https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
>>
>> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not committing transaction, status is No Transaction (6)
>> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
>> org.apache.ofbiz.service.GenericServiceException: Service [firstDataCCAuth] target threw an unexpected exception (Illegal character in path at
>> index 0: [TransactionUrl]/payments)
>>
>> but reverting the commit does not fix it. So maybe another mixed stuff
>>
>> Jacques
>>

[Pritam Kute]

Hello Jacques,

Should we remove the product store association in demo data for the first
data integration? I think it is causing this issue.

Kind Regards,
--
Pritam Kute

On Mon, Jun 29, 2020 at 1:16 PM Jacques Le Roux <
[hidden email]> wrote:

> Weird again, running
>
> "ofbiz --test component=accounting --test suitename=accountingtests --test
> case=auto-accounting-transaction-tests-sales"
>
> Maybe a data issue when running integration tests, maybe in both case, ie
> for auto-accounting-transaction-tests-sales and
> configurableServiceOrder-test
>
> I continue...
>
> Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :
> > Actually that was it, had to clean and reload data.
> >
> > Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
> >> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
> >>> There is also an issue with auto-accounting-transaction-tests-sales
> I'm chasing
> >>
> >> It seems due to
> https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
> >>
> >> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not
> committing transaction, status is No Transaction (6)
> >> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error
> occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
> >> org.apache.ofbiz.service.GenericServiceException: Service
> [firstDataCCAuth] target threw an unexpected exception (Illegal character
> in path at
> >> index 0: [TransactionUrl]/payments)
> >>
> >> but reverting the commit does not fix it. So maybe another mixed stuff
> >>
> >> Jacques
> >>
>

[Jacques Le Roux]

Thanks Pritam,

Trying to comment them out.

If it works, maybe we could move them to applications/commonext/data/OfbizSetupProductStoreData.xml or simply let them commented out and documenting it?

Let's see...

Jacques

Le 29/06/2020 à 10:04, Pritam Kute a écrit :

> Hello Jacques,
>
> Should we remove the product store association in demo data for the first
> data integration? I think it is causing this issue.
>
> Kind Regards,
> --
> Pritam Kute
>
> On Mon, Jun 29, 2020 at 1:16 PM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Weird again, running
>>
>> "ofbiz --test component=accounting --test suitename=accountingtests --test
>> case=auto-accounting-transaction-tests-sales"
>>
>> Maybe a data issue when running integration tests, maybe in both case, ie
>> for auto-accounting-transaction-tests-sales and
>> configurableServiceOrder-test
>>
>> I continue...
>>
>> Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :
>>> Actually that was it, had to clean and reload data.
>>>
>>> Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
>>>> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
>>>>> There is also an issue with auto-accounting-transaction-tests-sales
>> I'm chasing
>>>> It seems due to
>> https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
>>>> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not
>> committing transaction, status is No Transaction (6)
>>>> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error
>> occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
>>>> org.apache.ofbiz.service.GenericServiceException: Service
>> [firstDataCCAuth] target threw an unexpected exception (Illegal character
>> in path at
>>>> index 0: [TransactionUrl]/payments)
>>>>
>>>> but reverting the commit does not fix it. So maybe another mixed stuff
>>>>
>>>> Jacques
>>>>

[Pritam Kute]

Thanks, Jacques for confirming the same.

IMO, commenting it for now is better option. We should not move it to
applications. Soon or later we are going to move all 3rd party payment
gateway code outside applications may be as a separate 3rd party
integration plugins.

I am working on modifying the plugin further to support token-based
transactions and I will take care of documentation with that work.

Kind Regards,
--
Pritam Kute


On Mon, Jun 29, 2020 at 2:22 PM Jacques Le Roux <
[hidden email]> wrote:

> Thanks Pritam,
>
> Trying to comment them out.
>
> If it works, maybe we could move them to
> applications/commonext/data/OfbizSetupProductStoreData.xml or simply let
> them commented out and documenting it?
>
> Let's see...
>
> Jacques
>
> Le 29/06/2020 à 10:04, Pritam Kute a écrit :
> > Hello Jacques,
> >
> > Should we remove the product store association in demo data for the first
> > data integration? I think it is causing this issue.
> >
> > Kind Regards,
> > --
> > Pritam Kute
> >
> > On Mon, Jun 29, 2020 at 1:16 PM Jacques Le Roux <
> > [hidden email]> wrote:
> >
> >> Weird again, running
> >>
> >> "ofbiz --test component=accounting --test suitename=accountingtests
> --test
> >> case=auto-accounting-transaction-tests-sales"
> >>
> >> Maybe a data issue when running integration tests, maybe in both case,
> ie
> >> for auto-accounting-transaction-tests-sales and
> >> configurableServiceOrder-test
> >>
> >> I continue...
> >>
> >> Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :
> >>> Actually that was it, had to clean and reload data.
> >>>
> >>> Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
> >>>> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
> >>>>> There is also an issue with auto-accounting-transaction-tests-sales
> >> I'm chasing
> >>>> It seems due to
> >> https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
> >>>> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not
> >> committing transaction, status is No Transaction (6)
> >>>> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error
> >> occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
> >>>> org.apache.ofbiz.service.GenericServiceException: Service
> >> [firstDataCCAuth] target threw an unexpected exception (Illegal
> character
> >> in path at
> >>>> index 0: [TransactionUrl]/payments)
> >>>>
> >>>> but reverting the commit does not fix it. So maybe another mixed stuff
> >>>>
> >>>> Jacques
> >>>>
>

[Jacques Le Roux]

It works, I commented out the data loading.

Still the other unrelated failure, looking at it...

Jacques

Le 29/06/2020 à 11:05, Pritam Kute a écrit :

> Thanks, Jacques for confirming the same.
>
> IMO, commenting it for now is better option. We should not move it to
> applications. Soon or later we are going to move all 3rd party payment
> gateway code outside applications may be as a separate 3rd party
> integration plugins.
>
> I am working on modifying the plugin further to support token-based
> transactions and I will take care of documentation with that work.
>
> Kind Regards,
> --
> Pritam Kute
>
>
> On Mon, Jun 29, 2020 at 2:22 PM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Thanks Pritam,
>>
>> Trying to comment them out.
>>
>> If it works, maybe we could move them to
>> applications/commonext/data/OfbizSetupProductStoreData.xml or simply let
>> them commented out and documenting it?
>>
>> Let's see...
>>
>> Jacques
>>
>> Le 29/06/2020 à 10:04, Pritam Kute a écrit :
>>> Hello Jacques,
>>>
>>> Should we remove the product store association in demo data for the first
>>> data integration? I think it is causing this issue.
>>>
>>> Kind Regards,
>>> --
>>> Pritam Kute
>>>
>>> On Mon, Jun 29, 2020 at 1:16 PM Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>> Weird again, running
>>>>
>>>> "ofbiz --test component=accounting --test suitename=accountingtests
>> --test
>>>> case=auto-accounting-transaction-tests-sales"
>>>>
>>>> Maybe a data issue when running integration tests, maybe in both case,
>> ie
>>>> for auto-accounting-transaction-tests-sales and
>>>> configurableServiceOrder-test
>>>>
>>>> I continue...
>>>>
>>>> Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :
>>>>> Actually that was it, had to clean and reload data.
>>>>>
>>>>> Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
>>>>>> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
>>>>>>> There is also an issue with auto-accounting-transaction-tests-sales
>>>> I'm chasing
>>>>>> It seems due to
>>>> https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
>>>>>> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not
>>>> committing transaction, status is No Transaction (6)
>>>>>> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error
>>>> occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
>>>>>> org.apache.ofbiz.service.GenericServiceException: Service
>>>> [firstDataCCAuth] target threw an unexpected exception (Illegal
>> character
>>>> in path at
>>>>>> index 0: [TransactionUrl]/payments)
>>>>>>
>>>>>> but reverting the commit does not fix it. So maybe another mixed stuff
>>>>>>
>>>>>> Jacques
>>>>>>

[Jacques Le Roux]

For a reason, the results at https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/ stopped to update 3 days ago

I'll try to check why...

The Buildbot config changed 4 days ago, but I can't see a relation. I only changed "upload checkstyle" steps titles which are OK.

Also there are no failure uploading the failing test results:
https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1535

Le 29/06/2020 à 11:18, Jacques Le Roux a écrit :

> It works, I commented out the data loading.
>
> Still the other unrelated failure, looking at it...
>
> Jacques
>
> Le 29/06/2020 à 11:05, Pritam Kute a écrit :
>> Thanks, Jacques for confirming the same.
>>
>> IMO, commenting it for now is better option. We should not move it to
>> applications. Soon or later we are going to move all 3rd party payment
>> gateway code outside applications may be as a separate 3rd party
>> integration plugins.
>>
>> I am working on modifying the plugin further to support token-based
>> transactions and I will take care of documentation with that work.
>>
>> Kind Regards,
>> --
>> Pritam Kute
>>
>>
>> On Mon, Jun 29, 2020 at 2:22 PM Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Thanks Pritam,
>>>
>>> Trying to comment them out.
>>>
>>> If it works, maybe we could move them to
>>> applications/commonext/data/OfbizSetupProductStoreData.xml or simply let
>>> them commented out and documenting it?
>>>
>>> Let's see...
>>>
>>> Jacques
>>>
>>> Le 29/06/2020 à 10:04, Pritam Kute a écrit :
>>>> Hello Jacques,
>>>>
>>>> Should we remove the product store association in demo data for the first
>>>> data integration? I think it is causing this issue.
>>>>
>>>> Kind Regards,
>>>> --
>>>> Pritam Kute
>>>>
>>>> On Mon, Jun 29, 2020 at 1:16 PM Jacques Le Roux <
>>>> [hidden email]> wrote:
>>>>
>>>>> Weird again, running
>>>>>
>>>>> "ofbiz --test component=accounting --test suitename=accountingtests
>>> --test
>>>>> case=auto-accounting-transaction-tests-sales"
>>>>>
>>>>> Maybe a data issue when running integration tests, maybe in both case,
>>> ie
>>>>> for auto-accounting-transaction-tests-sales and
>>>>> configurableServiceOrder-test
>>>>>
>>>>> I continue...
>>>>>
>>>>> Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :
>>>>>> Actually that was it, had to clean and reload data.
>>>>>>
>>>>>> Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
>>>>>>> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
>>>>>>>> There is also an issue with auto-accounting-transaction-tests-sales
>>>>> I'm chasing
>>>>>>> It seems due to
>>>>> https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
>>>>>>> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not
>>>>> committing transaction, status is No Transaction (6)
>>>>>>> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error
>>>>> occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
>>>>>>> org.apache.ofbiz.service.GenericServiceException: Service
>>>>> [firstDataCCAuth] target threw an unexpected exception (Illegal
>>> character
>>>>> in path at
>>>>>>> index 0: [TransactionUrl]/payments)
>>>>>>>
>>>>>>> but reverting the commit does not fix it. So maybe another mixed stuff
>>>>>>>
>>>>>>> Jacques
>>>>>>>

[Jacques Le Roux]

Fixed, was an issue in the Buildbot config file

Le 29/06/2020 à 12:31, Jacques Le Roux a écrit :

> For a reason, the results at https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/ stopped to update 3 days ago
>
> I'll try to check why...
>
> The Buildbot config changed 4 days ago, but I can't see a relation. I only changed "upload checkstyle" steps titles which are OK.
>
> Also there are no failure uploading the failing test results:
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1535
>
> Le 29/06/2020 à 11:18, Jacques Le Roux a écrit :
>> It works, I commented out the data loading.
>>
>> Still the other unrelated failure, looking at it...
>>
>> Jacques
>>
>> Le 29/06/2020 à 11:05, Pritam Kute a écrit :
>>> Thanks, Jacques for confirming the same.
>>>
>>> IMO, commenting it for now is better option. We should not move it to
>>> applications. Soon or later we are going to move all 3rd party payment
>>> gateway code outside applications may be as a separate 3rd party
>>> integration plugins.
>>>
>>> I am working on modifying the plugin further to support token-based
>>> transactions and I will take care of documentation with that work.
>>>
>>> Kind Regards,
>>> --
>>> Pritam Kute
>>>
>>>
>>> On Mon, Jun 29, 2020 at 2:22 PM Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>>> Thanks Pritam,
>>>>
>>>> Trying to comment them out.
>>>>
>>>> If it works, maybe we could move them to
>>>> applications/commonext/data/OfbizSetupProductStoreData.xml or simply let
>>>> them commented out and documenting it?
>>>>
>>>> Let's see...
>>>>
>>>> Jacques
>>>>
>>>> Le 29/06/2020 à 10:04, Pritam Kute a écrit :
>>>>> Hello Jacques,
>>>>>
>>>>> Should we remove the product store association in demo data for the first
>>>>> data integration? I think it is causing this issue.
>>>>>
>>>>> Kind Regards,
>>>>> --
>>>>> Pritam Kute
>>>>>
>>>>> On Mon, Jun 29, 2020 at 1:16 PM Jacques Le Roux <
>>>>> [hidden email]> wrote:
>>>>>
>>>>>> Weird again, running
>>>>>>
>>>>>> "ofbiz --test component=accounting --test suitename=accountingtests
>>>> --test
>>>>>> case=auto-accounting-transaction-tests-sales"
>>>>>>
>>>>>> Maybe a data issue when running integration tests, maybe in both case,
>>>> ie
>>>>>> for auto-accounting-transaction-tests-sales and
>>>>>> configurableServiceOrder-test
>>>>>>
>>>>>> I continue...
>>>>>>
>>>>>> Le 28/06/2020 à 12:52, Jacques Le Roux a écrit :
>>>>>>> Actually that was it, had to clean and reload data.
>>>>>>>
>>>>>>> Le 28/06/2020 à 12:25, Jacques Le Roux a écrit :
>>>>>>>> Le 28/06/2020 à 12:01, Jacques Le Roux a écrit :
>>>>>>>>> There is also an issue with auto-accounting-transaction-tests-sales
>>>>>> I'm chasing
>>>>>>>> It seems due to
>>>>>> https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df753f8
>>>>>>>> 2020-06-28 11:59:36,699 |main |TransactionUtil               |W| Not
>>>>>> committing transaction, status is No Transaction (6)
>>>>>>>> 2020-06-28 11:59:36,699 |main |PaymentGatewayServices        |E| Error
>>>>>> occurred on: firstDataCCAuth, Order ID is: [DEMO10090]
>>>>>>>> org.apache.ofbiz.service.GenericServiceException: Service
>>>>>> [firstDataCCAuth] target threw an unexpected exception (Illegal
>>>> character
>>>>>> in path at
>>>>>>>> index 0: [TransactionUrl]/payments)
>>>>>>>>
>>>>>>>> but reverting the commit does not fix it. So maybe another mixed stuff
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>