Re: buildbot failure in on ofbizTrunkFrameworkPlugins

[Jacques Le Roux]

Hi Girish,

I had a quick look at this checkstyle issue, and it's weird.

It's due to https://github.com/apache/ofbiz-plugins/commit/42192da7d3cc8bd979711e72a47b104dda0c25a3/

And I see no reason why we get

[...]
 > Task :checkstyleTest FAILED
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleTest'.
 > Checkstyle rule violations were found. See the report at: file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/test.html
   Checkstyle files with violations: 1
   Checkstyle violations by severity: [error:2]

Also
https://ci.apache.org/projects/ofbiz/logs/trunk/checkstyle.html#f-/home/buildslave/slave/ofbizTrunkFrameworkPlugins/build/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/resources/OFBizServiceResource.java
is useless

I'll have a look later, if you beat me on it I'll not be offended ;)

Jacques

Le 10/09/2020 à 08:17, [hidden email] a écrit :

> The Buildbot has detected a new failure on builder ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are available at:
>      https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1750
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: asf945_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'onTrunkPluginsCommit' triggered this build
> Build Source Stamp: [branch trunk] 42192da7d3cc8bd979711e72a47b104dda0c25a3
> Blamelist: Girish Vasmatkar <[hidden email]>
>
> BUILD FAILED: failed check
>
> Sincerely,
>   -The Buildbot
>
>
>

[grv]

Hi Jacques

It is actually due to 2 errors reported under UtilHtmlTest.java. I just ran
it on my machine and it failed with this.
File
/Users/grv/workspace/OFBiz/community/ofbiz-framework/framework/base/src/test/java/org/apache/ofbiz/base/util/UtilHtmlTest.java
Error DescriptionLine
Name 'parseHtmlFragment_unclosedDiv' must match pattern
'^[a-z][a-zA-Z0-9]*$'. 30
Name 'parseHtmlFragment_multiRoot' must match pattern '^[a-z][a-zA-Z0-9]*$'.

Before committing, I did not face any build failure due to checkstyle.

Best Regards,
Girish


On Thu, Sep 10, 2020 at 3:16 PM Jacques Le Roux <
[hidden email]> wrote:

> Hi Girish,
>
> I had a quick look at this checkstyle issue, and it's weird.
>
> It's due to
> https://github.com/apache/ofbiz-plugins/commit/42192da7d3cc8bd979711e72a47b104dda0c25a3/
>
> And I see no reason why we get
>
> [...]
>  > Task :checkstyleTest FAILED
> FAILURE: Build failed with an exception.
>
> * What went wrong:
> Execution failed for task ':checkstyleTest'.
>  > Checkstyle rule violations were found. See the report at:
> file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/test.html
>    Checkstyle files with violations: 1
>    Checkstyle violations by severity: [error:2]
>
> Also
>
> https://ci.apache.org/projects/ofbiz/logs/trunk/checkstyle.html#f-/home/buildslave/slave/ofbizTrunkFrameworkPlugins/build/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/resources/OFBizServiceResource.java
> is useless
>
> I'll have a look later, if you beat me on it I'll not be offended ;)
>
> Jacques
>
> Le 10/09/2020 à 08:17, [hidden email] a écrit :
> > The Buildbot has detected a new failure on builder
> ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are
> available at:
> >
> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1750
> >
> > Buildbot URL: https://ci.apache.org/
> >
> > Buildslave for this Build: asf945_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named
> 'onTrunkPluginsCommit' triggered this build
> > Build Source Stamp: [branch trunk]
> 42192da7d3cc8bd979711e72a47b104dda0c25a3
> > Blamelist: Girish Vasmatkar <[hidden email]>
> >
> > BUILD FAILED: failed check
> >
> > Sincerely,
> >   -The Buildbot
> >
> >
> >
>

[Jacques Le Roux]

Thanks Girish,

Ah, I did not get those locally (Windows)

So Buildbot mixed things (anticipated, obviously a Buildbot bug) and the problem was rather
https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1751 not 1750

Anyway It's OK now

Jacques

Le 10/09/2020 à 12:05, Girish Vasmatkar a écrit :

> Hi Jacques
>
> It is actually due to 2 errors reported under UtilHtmlTest.java. I just ran
> it on my machine and it failed with this.
> File
> /Users/grv/workspace/OFBiz/community/ofbiz-framework/framework/base/src/test/java/org/apache/ofbiz/base/util/UtilHtmlTest.java
> Error DescriptionLine
> Name 'parseHtmlFragment_unclosedDiv' must match pattern
> '^[a-z][a-zA-Z0-9]*$'. 30
> Name 'parseHtmlFragment_multiRoot' must match pattern '^[a-z][a-zA-Z0-9]*$'.
>
> Before committing, I did not face any build failure due to checkstyle.
>
> Best Regards,
> Girish
>
>
> On Thu, Sep 10, 2020 at 3:16 PM Jacques Le Roux <
> [hidden email]> wrote:
>
>> Hi Girish,
>>
>> I had a quick look at this checkstyle issue, and it's weird.
>>
>> It's due to
>> https://github.com/apache/ofbiz-plugins/commit/42192da7d3cc8bd979711e72a47b104dda0c25a3/
>>
>> And I see no reason why we get
>>
>> [...]
>>   > Task :checkstyleTest FAILED
>> FAILURE: Build failed with an exception.
>>
>> * What went wrong:
>> Execution failed for task ':checkstyleTest'.
>>   > Checkstyle rule violations were found. See the report at:
>> file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/test.html
>>     Checkstyle files with violations: 1
>>     Checkstyle violations by severity: [error:2]
>>
>> Also
>>
>> https://ci.apache.org/projects/ofbiz/logs/trunk/checkstyle.html#f-/home/buildslave/slave/ofbizTrunkFrameworkPlugins/build/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/resources/OFBizServiceResource.java
>> is useless
>>
>> I'll have a look later, if you beat me on it I'll not be offended ;)
>>
>> Jacques
>>
>> Le 10/09/2020 à 08:17, [hidden email] a écrit :
>>> The Buildbot has detected a new failure on builder
>> ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are
>> available at:
>> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1750
>>> Buildbot URL: https://ci.apache.org/
>>>
>>> Buildslave for this Build: asf945_ubuntu
>>>
>>> Build Reason: The AnyBranchScheduler scheduler named
>> 'onTrunkPluginsCommit' triggered this build
>>> Build Source Stamp: [branch trunk]
>> 42192da7d3cc8bd979711e72a47b104dda0c25a3
>>> Blamelist: Girish Vasmatkar <[hidden email]>
>>>
>>> BUILD FAILED: failed check
>>>
>>> Sincerely,
>>>    -The Buildbot
>>>
>>>
>>>