Re: [jira] Commented: (OFBIZ-880) Replace calls to deprecated metho dsin OrderServices.java to avoid warnings during compilation.

[David E Jones]

> ------- Original Message -------
> From: "Scott Gray (JIRA)" <[hidden email]>
> To: [hidden email]
> Sent: 4/16/07, 2:45:15 AM
> Subject: [jira] Commented: (OFBIZ-880) Replace calls to deprecated methodsin OrderServices.java to avoid warnings during compilation.
>
>     [ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489033 ]
>
> Scott Gray commented on OFBIZ-880:
> ----------------------------------
>
> No. 1 looks good to me, I'd prefer to get rid of the Doubles and be done with it.  Is it ok to change service defs like this?

Yes this is fine and probably a better approach. Just search for the service name to catch all calls to it.

-David


>

[Scott Gray]

Thanks David I'll go ahead with it.

One question, how do I approach this line with updatedTotal being a
BigDecimal:

orderHeader.set("grandTotal", UtilFormatOut.formatPriceNumber
(updatedTotal));

UtilFormatOut doesn't take BigDecimals in any of it methods

Thanks
Scott

On 16/04/07, David E. Jones <[hidden email]> wrote:

>
>
>
> > ------- Original Message -------
> > From: "Scott Gray (JIRA)" <[hidden email]>
> > To: [hidden email]
> > Sent: 4/16/07, 2:45:15 AM
> > Subject: [jira] Commented: (OFBIZ-880) Replace calls to deprecated
> methodsin OrderServices.java to avoid warnings during compilation.
> >
> >     [
> https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489033]
> >
> > Scott Gray commented on OFBIZ-880:
> > ----------------------------------
> >
> > No. 1 looks good to me, I'd prefer to get rid of the Doubles and be done
> with it.  Is it ok to change service defs like this?
>
> Yes this is fine and probably a better approach. Just search for the
> service name to catch all calls to it.
>
> -David
>
>
> >
>

[Jacopo Cappellato]

Scott,

I think you should simply replace it with:

orderHeader.set("grandTotal", updatedTotal);

where updatedTotal is a BigDecimal

Jacopo




Scott Gray wrote:

> Thanks David I'll go ahead with it.
>
> One question, how do I approach this line with updatedTotal being a
> BigDecimal:
>
> orderHeader.set("grandTotal", UtilFormatOut.formatPriceNumber
> (updatedTotal));
>
> UtilFormatOut doesn't take BigDecimals in any of it methods
>
> Thanks
> Scott
>
> On 16/04/07, David E. Jones <[hidden email]> wrote:
>>
>>
>>
>> > ------- Original Message -------
>> > From: "Scott Gray (JIRA)" <[hidden email]>
>> > To: [hidden email]
>> > Sent: 4/16/07, 2:45:15 AM
>> > Subject: [jira] Commented: (OFBIZ-880) Replace calls to deprecated
>> methodsin OrderServices.java to avoid warnings during compilation.
>> >
>> >     [
>> https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489033]
>>
>> >
>> > Scott Gray commented on OFBIZ-880:
>> > ----------------------------------
>> >
>> > No. 1 looks good to me, I'd prefer to get rid of the Doubles and be
>> done
>> with it.  Is it ok to change service defs like this?
>>
>> Yes this is fine and probably a better approach. Just search for the
>> service name to catch all calls to it.
>>
>> -David
>>
>>
>> >
>>
>