Re: [ofbiz-framework] 02/02: Fixed: Update the SvnCheckout Gradle task to used Github svn repo (OFBIZ-11276)

[Gil Portenseigne]

Hello Jacques,

Could you provide a reference to the github feature you mentionned ?

Thanks

Gil

Le 19:02 - mercredi 06 nov., [hidden email] a écrit :

> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
> commit 4815de7d92cbd6acbcd88c8524f54dc884bd00d4
> Author: Jacques Le Roux <[hidden email]>
> AuthorDate: Wed Nov 6 17:26:47 2019 +0100
>
>     Fixed: Update the SvnCheckout Gradle task to used Github svn repo
>     (OFBIZ-11276)
>    
>     Relies on a Github specific feature which allows to use and automated
>     mirrored svn repo.
>    
>     (cherry picked from commit 0c489aa609d07acdcfe7ff41f167ca2040046c77)
> ---
>  build.gradle | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/build.gradle b/build.gradle
> index 3259468..700498d 100644
> --- a/build.gradle
> +++ b/build.gradle
> @@ -884,7 +884,7 @@ task pullPluginSource(group: ofbizPlugin, description: 'Download and install a p
>  
>      if (project.hasProperty('pluginId')) {
>          task pullPluginFromSvn(type: SvnCheckout) {
> -            svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/${pluginId}"
> +            svnUrl = "https://github.com/apache/ofbiz-plugins/trunk/${pluginId}"
>              workspaceDir = "${pluginsDir}/${pluginId}"
>          }
>          dependsOn pullPluginFromSvn
> @@ -901,7 +901,7 @@ task pullAllPluginsSource(group: ofbizPlugin,
>          doLast { delete "${pluginsDir}" }
>      }
>      task pullPluginsFromSvn(type: SvnCheckout, dependsOn: deleteBeforePulling) {
> -        svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk"
> +        svnUrl = "https://github.com/apache/ofbiz-plugins/trunk"
>          workspaceDir = "${pluginsDir}"
>      }
>      dependsOn pullPluginsFromSvn
>

[Jacques Le Roux]

Hi Gil,

Yes sure, here it is https://s.apache.org/lwptd

I said it's a temporary feature I used. But I begin to wonder now.

Since at the ASF the official Gitbox is tightly coupled with Github, I think we also are able to commit changes through this way.

So I wonder if we should rush into splitting the plugins in Git repos when we can still use svn as before...

I'll do one simple commit in ecommerce I need to do, to check this assertion.

Jacques

Le 08/11/2019 à 09:42, Gil Portenseigne a écrit :

> Hello Jacques,
>
> Could you provide a reference to the github feature you mentionned ?
>
> Thanks
>
> Gil
>
> Le 19:02 - mercredi 06 nov., [hidden email] a écrit :
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> jleroux pushed a commit to branch trunk
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>>
>> commit 4815de7d92cbd6acbcd88c8524f54dc884bd00d4
>> Author: Jacques Le Roux <[hidden email]>
>> AuthorDate: Wed Nov 6 17:26:47 2019 +0100
>>
>>      Fixed: Update the SvnCheckout Gradle task to used Github svn repo
>>      (OFBIZ-11276)
>>      
>>      Relies on a Github specific feature which allows to use and automated
>>      mirrored svn repo.
>>      
>>      (cherry picked from commit 0c489aa609d07acdcfe7ff41f167ca2040046c77)
>> ---
>>   build.gradle | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/build.gradle b/build.gradle
>> index 3259468..700498d 100644
>> --- a/build.gradle
>> +++ b/build.gradle
>> @@ -884,7 +884,7 @@ task pullPluginSource(group: ofbizPlugin, description: 'Download and install a p
>>  
>>       if (project.hasProperty('pluginId')) {
>>           task pullPluginFromSvn(type: SvnCheckout) {
>> -            svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/${pluginId}"
>> +            svnUrl = "https://github.com/apache/ofbiz-plugins/trunk/${pluginId}"
>>               workspaceDir = "${pluginsDir}/${pluginId}"
>>           }
>>           dependsOn pullPluginFromSvn
>> @@ -901,7 +901,7 @@ task pullAllPluginsSource(group: ofbizPlugin,
>>           doLast { delete "${pluginsDir}" }
>>       }
>>       task pullPluginsFromSvn(type: SvnCheckout, dependsOn: deleteBeforePulling) {
>> -        svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk"
>> +        svnUrl = "https://github.com/apache/ofbiz-plugins/trunk"
>>           workspaceDir = "${pluginsDir}"
>>       }
>>       dependsOn pullPluginsFromSvn
>>

[Jacques Le Roux]

This conveniently complete it

https://help.github.com/en/github/importing-your-projects-to-github/working-with-subversion-on-github

Jacques

Le 08/11/2019 à 10:47, Jacques Le Roux a écrit :

> Hi Gil,
>
> Yes sure, here it is https://s.apache.org/lwptd
>
> I said it's a temporary feature I used. But I begin to wonder now.
>
> Since at the ASF the official Gitbox is tightly coupled with Github, I think we also are able to commit changes through this way.
>
> So I wonder if we should rush into splitting the plugins in Git repos when we can still use svn as before...
>
> I'll do one simple commit in ecommerce I need to do, to check this assertion.
>
> Jacques
>
> Le 08/11/2019 à 09:42, Gil Portenseigne a écrit :
>> Hello Jacques,
>>
>> Could you provide a reference to the github feature you mentionned ?
>>
>> Thanks
>>
>> Gil
>>
>> Le 19:02 - mercredi 06 nov., [hidden email] a écrit :
>>> This is an automated email from the ASF dual-hosted git repository.
>>>
>>> jleroux pushed a commit to branch trunk
>>> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>>>
>>> commit 4815de7d92cbd6acbcd88c8524f54dc884bd00d4
>>> Author: Jacques Le Roux <[hidden email]>
>>> AuthorDate: Wed Nov 6 17:26:47 2019 +0100
>>>
>>>      Fixed: Update the SvnCheckout Gradle task to used Github svn repo
>>>      (OFBIZ-11276)
>>>           Relies on a Github specific feature which allows to use and automated
>>>      mirrored svn repo.
>>>           (cherry picked from commit 0c489aa609d07acdcfe7ff41f167ca2040046c77)
>>> ---
>>>   build.gradle | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/build.gradle b/build.gradle
>>> index 3259468..700498d 100644
>>> --- a/build.gradle
>>> +++ b/build.gradle
>>> @@ -884,7 +884,7 @@ task pullPluginSource(group: ofbizPlugin, description: 'Download and install a p
>>>         if (project.hasProperty('pluginId')) {
>>>           task pullPluginFromSvn(type: SvnCheckout) {
>>> -            svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/${pluginId}"
>>> +            svnUrl = "https://github.com/apache/ofbiz-plugins/trunk/${pluginId}"
>>>               workspaceDir = "${pluginsDir}/${pluginId}"
>>>           }
>>>           dependsOn pullPluginFromSvn
>>> @@ -901,7 +901,7 @@ task pullAllPluginsSource(group: ofbizPlugin,
>>>           doLast { delete "${pluginsDir}" }
>>>       }
>>>       task pullPluginsFromSvn(type: SvnCheckout, dependsOn: deleteBeforePulling) {
>>> -        svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk"
>>> +        svnUrl = "https://github.com/apache/ofbiz-plugins/trunk"
>>>           workspaceDir = "${pluginsDir}"
>>>       }
>>>       dependsOn pullPluginsFromSvn
>>>
>

[Gil Portenseigne]

Thanks Jacques, i understood it was temporary and tested it, i was just
curious :)

It is strange to see a git url in svnCheckout utility.

Gil

Le 10:47 - vendredi 08 nov., Jacques Le Roux a écrit :

> Hi Gil,
>
> Yes sure, here it is https://s.apache.org/lwptd
>
> I said it's a temporary feature I used. But I begin to wonder now.
>
> Since at the ASF the official Gitbox is tightly coupled with Github, I think we also are able to commit changes through this way.
>
> So I wonder if we should rush into splitting the plugins in Git repos when we can still use svn as before...
>
> I'll do one simple commit in ecommerce I need to do, to check this assertion.
>
> Jacques
>
> Le 08/11/2019 à 09:42, Gil Portenseigne a écrit :
> > Hello Jacques,
> >
> > Could you provide a reference to the github feature you mentionned ?
> >
> > Thanks
> >
> > Gil
> >
> > Le 19:02 - mercredi 06 nov., [hidden email] a écrit :
> > > This is an automated email from the ASF dual-hosted git repository.
> > >
> > > jleroux pushed a commit to branch trunk
> > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> > >
> > > commit 4815de7d92cbd6acbcd88c8524f54dc884bd00d4
> > > Author: Jacques Le Roux <[hidden email]>
> > > AuthorDate: Wed Nov 6 17:26:47 2019 +0100
> > >
> > >      Fixed: Update the SvnCheckout Gradle task to used Github svn repo
> > >      (OFBIZ-11276)
> > >      Relies on a Github specific feature which allows to use and automated
> > >      mirrored svn repo.
> > >      (cherry picked from commit 0c489aa609d07acdcfe7ff41f167ca2040046c77)
> > > ---
> > >   build.gradle | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/build.gradle b/build.gradle
> > > index 3259468..700498d 100644
> > > --- a/build.gradle
> > > +++ b/build.gradle
> > > @@ -884,7 +884,7 @@ task pullPluginSource(group: ofbizPlugin, description: 'Download and install a p
> > >       if (project.hasProperty('pluginId')) {
> > >           task pullPluginFromSvn(type: SvnCheckout) {
> > > -            svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk/${pluginId}"
> > > +            svnUrl = "https://github.com/apache/ofbiz-plugins/trunk/${pluginId}"
> > >               workspaceDir = "${pluginsDir}/${pluginId}"
> > >           }
> > >           dependsOn pullPluginFromSvn
> > > @@ -901,7 +901,7 @@ task pullAllPluginsSource(group: ofbizPlugin,
> > >           doLast { delete "${pluginsDir}" }
> > >       }
> > >       task pullPluginsFromSvn(type: SvnCheckout, dependsOn: deleteBeforePulling) {
> > > -        svnUrl = "https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk"
> > > +        svnUrl = "https://github.com/apache/ofbiz-plugins/trunk"
> > >           workspaceDir = "${pluginsDir}"
> > >       }
> > >       dependsOn pullPluginsFromSvn
> > >