Re: [ofbiz-framework] branch trunk updated: Improved: Moves Shipment Services files from sub-dirs to shipment dir (OFBIZ-11468)

[Pawan Verma]

Hi Jacques,

You missed correcting the location of these services, I've corrected it at
R#d355269.

--
Thanks & Regards
Pawan Verma
Technical Consultant
*HotWax Systems*
*Enterprise open source experts*
http://www.hotwaxsystems.com


On Sat, Jun 27, 2020 at 11:32 AM <[hidden email]> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
>      new 3926134  Improved: Moves Shipment Services files from sub-dirs to
> shipment dir (OFBIZ-11468)
> 3926134 is described below
>
> commit 392613495029e287c947d392636dbdf539358348
> Author: Jacques Le Roux <[hidden email]>
> AuthorDate: Sat Jun 27 07:56:06 2020 +0200
>
>     Improved: Moves Shipment Services files from sub-dirs to shipment dir
> (OFBIZ-11468)
>
>     In PR#150 Pierre Smits suggested to move this new Groovy files updir:
>
>     "There is no need to have subfolders defining where the services
> belong to when
>     such is already captured in the name of the file, e.g.:
>     folder /shipment/receipt/ when the filename has
> ShipmentReceiptServices.groovy
>     Similarly
>     /shipment/issuance/ when the filename has
> ShipmentIssuanceServices.groovy"
> ---
>  .../product/groovyScripts/shipment/{issuance => }/IssuanceServices.groovy
> | 0
>  .../product/groovyScripts/shipment/{picklist => }/PicklistServices.groovy
> | 0
>  .../groovyScripts/shipment/{receipt => }/ShipmentReceiptServices.groovy
>  | 0
>  .../product/groovyScripts/shipment/{shipment => }/ShipmentServices.groovy
> | 0
>  4 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git
> a/applications/product/groovyScripts/shipment/issuance/IssuanceServices.groovy
> b/applications/product/groovyScripts/shipment/IssuanceServices.groovy
> similarity index 100%
> rename from
> applications/product/groovyScripts/shipment/issuance/IssuanceServices.groovy
> rename to
> applications/product/groovyScripts/shipment/IssuanceServices.groovy
> diff --git
> a/applications/product/groovyScripts/shipment/picklist/PicklistServices.groovy
> b/applications/product/groovyScripts/shipment/PicklistServices.groovy
> similarity index 100%
> rename from
> applications/product/groovyScripts/shipment/picklist/PicklistServices.groovy
> rename to
> applications/product/groovyScripts/shipment/PicklistServices.groovy
> diff --git
> a/applications/product/groovyScripts/shipment/receipt/ShipmentReceiptServices.groovy
> b/applications/product/groovyScripts/shipment/ShipmentReceiptServices.groovy
> similarity index 100%
> rename from
> applications/product/groovyScripts/shipment/receipt/ShipmentReceiptServices.groovy
> rename to
> applications/product/groovyScripts/shipment/ShipmentReceiptServices.groovy
> diff --git
> a/applications/product/groovyScripts/shipment/shipment/ShipmentServices.groovy
> b/applications/product/groovyScripts/shipment/ShipmentServices.groovy
> similarity index 100%
> rename from
> applications/product/groovyScripts/shipment/shipment/ShipmentServices.groovy
> rename to
> applications/product/groovyScripts/shipment/ShipmentServices.groovy
>
>

[Jacques Le Roux]

Indeed, thanks Pawan

Le 27/06/2020 à 09:36, Pawan Verma a écrit :
> Hi Jacques,
>
> You missed correcting the location of these services, I've corrected it at
> R#d355269.
>