Re: [ofbiz-framework] branch trunk updated: Improved: no functional change

[Michael Brohl-3]

Hi Jacques,

I think the comment was correct, more precise would have been
javadoc.options.links though.

Regards,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 24.02.20 um 21:50 schrieb [hidden email]:

> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
>       new ca91212  Improved: no functional change
> ca91212 is described below
>
> commit ca9121227a928cda6654f9aecf47f254f0deeb34
> Author: Jacques Le Roux <[hidden email]>
> AuthorDate: Mon Feb 24 21:48:56 2020 +0100
>
>      Improved: no functional change
>      
>      At http://svn.apache.org/viewvc?view=revision&revision=1855675
>      the javadoc.options block was renamed javadoc but this comment was not updated
>      Nothing else is needed https://tomcat.apache.org/tomcat-9.0-doc/servletapi/
>      shows Apache Tomcat 9.0.31 documentation
> ---
>   build.gradle | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/build.gradle b/build.gradle
> index c11d7ce..e5bfb3e 100644
> --- a/build.gradle
> +++ b/build.gradle
> @@ -181,13 +181,13 @@ dependencies {
>       implementation 'org.apache.shiro:shiro-core:1.4.1'
>       implementation 'org.apache.sshd:sshd-core:1.7.0'
>       implementation 'org.apache.tika:tika-parsers:1.22'
> -    implementation 'org.apache.tomcat:tomcat-catalina-ha:9.0.31' // Remember to change the version number in javadoc.options block
> +    implementation 'org.apache.tomcat:tomcat-catalina-ha:9.0.31' // Remember to change the version number in javadoc block
>       implementation 'org.apache.tomcat:tomcat-jasper:9.0.31'
>       implementation 'org.apache.axis2:axis2-kernel:1.7.9'
>       implementation 'org.apache.xmlgraphics:fop:2.3'
>       implementation 'org.apache.xmlrpc:xmlrpc-client:3.1.3'
>       implementation 'org.apache.xmlrpc:xmlrpc-server:3.1.3'
> -    implementation 'org.codehaus.groovy:groovy-all:2.5.8' // Remember to change the version number in javadoc.options block
> +    implementation 'org.codehaus.groovy:groovy-all:2.5.8' // Remember to change the version number in javadoc block
>       implementation 'org.freemarker:freemarker:2.3.29' // Remember to change the version number in FreeMarkerWorker class when upgrading. See OFBIZ-10019 if >= 2.4
>       implementation 'org.owasp.esapi:esapi:2.2.0.0'
>       implementation 'org.springframework:spring-test:5.2.0.RELEASE'
>

[Jacques Le Roux]

Hi Michael,

The idea is you search it in a text editor or IDE. You can't look for javadoc.options nor javadoc.options.links

Jacques

Le 25/02/2020 à 08:46, Michael Brohl a écrit :

> Hi Jacques,
>
> I think the comment was correct, more precise would have been javadoc.options.links though.
>
> Regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 24.02.20 um 21:50 schrieb [hidden email]:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> jleroux pushed a commit to branch trunk
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>>
>>
>> The following commit(s) were added to refs/heads/trunk by this push:
>>       new ca91212  Improved: no functional change
>> ca91212 is described below
>>
>> commit ca9121227a928cda6654f9aecf47f254f0deeb34
>> Author: Jacques Le Roux <[hidden email]>
>> AuthorDate: Mon Feb 24 21:48:56 2020 +0100
>>
>>      Improved: no functional change
>>           At http://svn.apache.org/viewvc?view=revision&revision=1855675
>>      the javadoc.options block was renamed javadoc but this comment was not updated
>>      Nothing else is needed https://tomcat.apache.org/tomcat-9.0-doc/servletapi/
>>      shows Apache Tomcat 9.0.31 documentation
>> ---
>>   build.gradle | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/build.gradle b/build.gradle
>> index c11d7ce..e5bfb3e 100644
>> --- a/build.gradle
>> +++ b/build.gradle
>> @@ -181,13 +181,13 @@ dependencies {
>>       implementation 'org.apache.shiro:shiro-core:1.4.1'
>>       implementation 'org.apache.sshd:sshd-core:1.7.0'
>>       implementation 'org.apache.tika:tika-parsers:1.22'
>> -    implementation 'org.apache.tomcat:tomcat-catalina-ha:9.0.31' // Remember to change the version number in javadoc.options block
>> +    implementation 'org.apache.tomcat:tomcat-catalina-ha:9.0.31' // Remember to change the version number in javadoc block
>>       implementation 'org.apache.tomcat:tomcat-jasper:9.0.31'
>>       implementation 'org.apache.axis2:axis2-kernel:1.7.9'
>>       implementation 'org.apache.xmlgraphics:fop:2.3'
>>       implementation 'org.apache.xmlrpc:xmlrpc-client:3.1.3'
>>       implementation 'org.apache.xmlrpc:xmlrpc-server:3.1.3'
>> -    implementation 'org.codehaus.groovy:groovy-all:2.5.8' // Remember to change the version number in javadoc.options block
>> +    implementation 'org.codehaus.groovy:groovy-all:2.5.8' // Remember to change the version number in javadoc block
>>       implementation 'org.freemarker:freemarker:2.3.29' // Remember to change the version number in FreeMarkerWorker class when upgrading. See
>> OFBIZ-10019 if >= 2.4
>>       implementation 'org.owasp.esapi:esapi:2.2.0.0'
>>       implementation 'org.springframework:spring-test:5.2.0.RELEASE'
>>
>