OFBiz › OFBiz - Dev

Re: [ofbiz-plugins] branch trunk updated: Implemented: Have a Country Dimension (OFBIZ-10954)

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 3 messages Options
Michael Brohl-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [ofbiz-plugins] branch trunk updated: Implemented: Have a Country Dimension (OFBIZ-10954)

Michael Brohl-3
Hi Pawan, all,

I really don't see any reason to introduce tables into the codebase
which are not used anywhere in the current functionality.

I would recommend to wait until there is substantial functioanality
which use these table. As Piere stated in some of the *Dimension Jiras:
"The component would benefit from a ... dimension for future fact tables
and star schema view entities".

What do others think?

Thanks,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 30.01.20 um 10:15 schrieb [hidden email]:

> This is an automated email from the ASF dual-hosted git repository.
>
> pawan pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
>       new ccb6219  Implemented: Have a Country Dimension (OFBIZ-10954)
> ccb6219 is described below
>
> commit ccb6219954a0b523b8ff854da5954af2feaab8d0
> Author: Pawan Verma <[hidden email]>
> AuthorDate: Thu Jan 30 14:45:25 2020 +0530
>
>      Implemented: Have a Country Dimension
>      (OFBIZ-10954)
>      
>      Added new CountryDimension entity in olap.
>      
>      Thanks: Pierre Smits for your contribution.
> ---
>   bi/entitydef/entitygroup.xml |  1 +
>   bi/entitydef/entitymodel.xml | 25 +++++++++++++++++++++++++
>   2 files changed, 26 insertions(+)
>
> diff --git a/bi/entitydef/entitygroup.xml b/bi/entitydef/entitygroup.xml
> index 2d34fe7..670405c 100644
> --- a/bi/entitydef/entitygroup.xml
> +++ b/bi/entitydef/entitygroup.xml
> @@ -24,6 +24,7 @@ under the License.
>       <!-- ========================================================= -->
>       <!-- Dimensions                                                     -->
>       <!-- ========================================================= -->
> +    <entity-group group="org.apache.ofbiz.olap" entity="CountryDimension"/>
>       <entity-group group="org.apache.ofbiz.olap" entity="CurrencyDimension"/>
>       <entity-group group="org.apache.ofbiz.olap" entity="DateDimension"/>
>       <entity-group group="org.apache.ofbiz.olap" entity="ProductDimension"/>
> diff --git a/bi/entitydef/entitymodel.xml b/bi/entitydef/entitymodel.xml
> index 57c0868..7bdfe25 100644
> --- a/bi/entitydef/entitymodel.xml
> +++ b/bi/entitydef/entitymodel.xml
> @@ -29,6 +29,31 @@ under the License.
>       <!-- ========================================================= -->
>       <!-- Dimensions                                                -->
>       <!-- ========================================================= -->
> +    <entity entity-name="CountryDimension" package-name="org.apache.ofbiz.bi.dimension" title="Country Dimension">
> +        <description>Country dimension. Based on ISO 3166-1. The natural key is [geoId]</description>
> +        <field name="dimensionId" type="id">
> +            <description>Unique identifier of the Date dimension record</description>
> +        </field>
> +        <field name="geoId" type="id">
> +            <description>The natural key, based on ISO 3166-1 alpha-3</description>
> +        </field>
> +        <field name="geoName" type="name">
> +            <description>The name of the country, based on ISO 3166</description>
> +        </field>
> +        <field name="geoCode" type="short-varchar">
> +            <description>The ISO 3166-1 alpha-2 code of the country</description>
> +        </field>
> +        <field name="abbreviation" type="short-varchar">
> +            <description>Based on the ISO 3166-1 alpha-3 code of the country</description>
> +        </field>
> +        <field name="telCountryCode" type="short-varchar">
> +            <description>The telephone country code. Based on ITU.E123 and ITU.164</description>
> +        </field>
> +        <field name="ccTld" type="short-varchar">
> +            <description>The country code top-level domain for the country. Base on IANA rfc1591</description>
> +        </field>
> +        <prim-key field="dimensionId"/>
> +    </entity>
>       <entity entity-name="DateDimension" package-name="org.apache.ofbiz.bi.dimension" title="Date Dimension">
>           <description>Date (days) dimension. The natural key is [dateValue]</description>
>           <field name="dimensionId" type="id">
>


smime.p7s (5K) Download Attachment
Nicolas Malin-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [ofbiz-plugins] branch trunk updated: Implemented: Have a Country Dimension (OFBIZ-10954)

Nicolas Malin-2
Hi,

On 30/01/2020 16:51, Michael Brohl wrote:

> Hi Pawan, all,
>
> I really don't see any reason to introduce tables into the codebase
> which are not used anywhere in the current functionality.
>
> I would recommend to wait until there is substantial functioanality
> which use these table. As Piere stated in some of the *Dimension
> Jiras: "The component would benefit from a ... dimension for future
> fact tables and star schema view entities".
>
> What do others think?
I'm not opposed to introduce some new dimension, if we have service to
populate them, as bi api.

Otherwise the added valuable would be small because not really easy to use.

After use a dimension with fact element are, for me, just an example how
we can use this dimension

Nicolas

>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 30.01.20 um 10:15 schrieb [hidden email]:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> pawan pushed a commit to branch trunk
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
>>
>>
>> The following commit(s) were added to refs/heads/trunk by this push:
>>       new ccb6219  Implemented: Have a Country Dimension (OFBIZ-10954)
>> ccb6219 is described below
>>
>> commit ccb6219954a0b523b8ff854da5954af2feaab8d0
>> Author: Pawan Verma <[hidden email]>
>> AuthorDate: Thu Jan 30 14:45:25 2020 +0530
>>
>>      Implemented: Have a Country Dimension
>>      (OFBIZ-10954)
>>           Added new CountryDimension entity in olap.
>>           Thanks: Pierre Smits for your contribution.
>> ---
>>   bi/entitydef/entitygroup.xml |  1 +
>>   bi/entitydef/entitymodel.xml | 25 +++++++++++++++++++++++++
>>   2 files changed, 26 insertions(+)
>>
>> diff --git a/bi/entitydef/entitygroup.xml b/bi/entitydef/entitygroup.xml
>> index 2d34fe7..670405c 100644
>> --- a/bi/entitydef/entitygroup.xml
>> +++ b/bi/entitydef/entitygroup.xml
>> @@ -24,6 +24,7 @@ under the License.
>>       <!-- ========================================================= -->
>>       <!--
>> Dimensions                                                     -->
>>       <!-- ========================================================= -->
>> +    <entity-group group="org.apache.ofbiz.olap"
>> entity="CountryDimension"/>
>>       <entity-group group="org.apache.ofbiz.olap"
>> entity="CurrencyDimension"/>
>>       <entity-group group="org.apache.ofbiz.olap"
>> entity="DateDimension"/>
>>       <entity-group group="org.apache.ofbiz.olap"
>> entity="ProductDimension"/>
>> diff --git a/bi/entitydef/entitymodel.xml b/bi/entitydef/entitymodel.xml
>> index 57c0868..7bdfe25 100644
>> --- a/bi/entitydef/entitymodel.xml
>> +++ b/bi/entitydef/entitymodel.xml
>> @@ -29,6 +29,31 @@ under the License.
>>       <!-- ========================================================= -->
>>       <!-- Dimensions                                                -->
>>       <!-- ========================================================= -->
>> +    <entity entity-name="CountryDimension"
>> package-name="org.apache.ofbiz.bi.dimension" title="Country Dimension">
>> +        <description>Country dimension. Based on ISO 3166-1. The
>> natural key is [geoId]</description>
>> +        <field name="dimensionId" type="id">
>> +            <description>Unique identifier of the Date dimension
>> record</description>
>> +        </field>
>> +        <field name="geoId" type="id">
>> +            <description>The natural key, based on ISO 3166-1
>> alpha-3</description>
>> +        </field>
>> +        <field name="geoName" type="name">
>> +            <description>The name of the country, based on ISO
>> 3166</description>
>> +        </field>
>> +        <field name="geoCode" type="short-varchar">
>> +            <description>The ISO 3166-1 alpha-2 code of the
>> country</description>
>> +        </field>
>> +        <field name="abbreviation" type="short-varchar">
>> +            <description>Based on the ISO 3166-1 alpha-3 code of the
>> country</description>
>> +        </field>
>> +        <field name="telCountryCode" type="short-varchar">
>> +            <description>The telephone country code. Based on
>> ITU.E123 and ITU.164</description>
>> +        </field>
>> +        <field name="ccTld" type="short-varchar">
>> +            <description>The country code top-level domain for the
>> country. Base on IANA rfc1591</description>
>> +        </field>
>> +        <prim-key field="dimensionId"/>
>> +    </entity>
>>       <entity entity-name="DateDimension"
>> package-name="org.apache.ofbiz.bi.dimension" title="Date Dimension">
>>           <description>Date (days) dimension. The natural key is
>> [dateValue]</description>
>>           <field name="dimensionId" type="id">
>>
>

pEpkey.asc (2K) Download Attachment
Pierre Smits-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [ofbiz-plugins] branch trunk updated: Implemented: Have a Country Dimension (OFBIZ-10954)

Pierre Smits-3
Nicolas,

A ticket regarding the service to populate the dimension is available in
JIRA. See OFBIZ-10954. In that ticket I suggested a solution approach for
the assignee (or anyone else) to evaluate before I submit a pull request.

Best regards,

Pierre Smits

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer


On Wed, Feb 5, 2020 at 7:00 PM Nicolas Malin <[hidden email]>
wrote:

> Hi,
>
> On 30/01/2020 16:51, Michael Brohl wrote:
> > Hi Pawan, all,
> >
> > I really don't see any reason to introduce tables into the codebase
> > which are not used anywhere in the current functionality.
> >
> > I would recommend to wait until there is substantial functioanality
> > which use these table. As Piere stated in some of the *Dimension
> > Jiras: "The component would benefit from a ... dimension for future
> > fact tables and star schema view entities".
> >
> > What do others think?
>
> I'm not opposed to introduce some new dimension, if we have service to
> populate them, as bi api.
>
> Otherwise the added valuable would be small because not really easy to use.
>
> After use a dimension with fact element are, for me, just an example how
> we can use this dimension
>
> Nicolas
>
> >
> > Thanks,
> >
> > Michael Brohl
> >
> > ecomify GmbH - www.ecomify.de
> >
> >
> > Am 30.01.20 um 10:15 schrieb [hidden email]:
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> pawan pushed a commit to branch trunk
> >> in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/trunk by this push:
> >>       new ccb6219  Implemented: Have a Country Dimension (OFBIZ-10954)
> >> ccb6219 is described below
> >>
> >> commit ccb6219954a0b523b8ff854da5954af2feaab8d0
> >> Author: Pawan Verma <[hidden email]>
> >> AuthorDate: Thu Jan 30 14:45:25 2020 +0530
> >>
> >>      Implemented: Have a Country Dimension
> >>      (OFBIZ-10954)
> >>           Added new CountryDimension entity in olap.
> >>           Thanks: Pierre Smits for your contribution.
> >> ---
> >>   bi/entitydef/entitygroup.xml |  1 +
> >>   bi/entitydef/entitymodel.xml | 25 +++++++++++++++++++++++++
> >>   2 files changed, 26 insertions(+)
> >>
> >> diff --git a/bi/entitydef/entitygroup.xml b/bi/entitydef/entitygroup.xml
> >> index 2d34fe7..670405c 100644
> >> --- a/bi/entitydef/entitygroup.xml
> >> +++ b/bi/entitydef/entitygroup.xml
> >> @@ -24,6 +24,7 @@ under the License.
> >>       <!-- ========================================================= -->
> >>       <!--
> >> Dimensions                                                     -->
> >>       <!-- ========================================================= -->
> >> +    <entity-group group="org.apache.ofbiz.olap"
> >> entity="CountryDimension"/>
> >>       <entity-group group="org.apache.ofbiz.olap"
> >> entity="CurrencyDimension"/>
> >>       <entity-group group="org.apache.ofbiz.olap"
> >> entity="DateDimension"/>
> >>       <entity-group group="org.apache.ofbiz.olap"
> >> entity="ProductDimension"/>
> >> diff --git a/bi/entitydef/entitymodel.xml b/bi/entitydef/entitymodel.xml
> >> index 57c0868..7bdfe25 100644
> >> --- a/bi/entitydef/entitymodel.xml
> >> +++ b/bi/entitydef/entitymodel.xml
> >> @@ -29,6 +29,31 @@ under the License.
> >>       <!-- ========================================================= -->
> >>       <!-- Dimensions                                                -->
> >>       <!-- ========================================================= -->
> >> +    <entity entity-name="CountryDimension"
> >> package-name="org.apache.ofbiz.bi.dimension" title="Country Dimension">
> >> +        <description>Country dimension. Based on ISO 3166-1. The
> >> natural key is [geoId]</description>
> >> +        <field name="dimensionId" type="id">
> >> +            <description>Unique identifier of the Date dimension
> >> record</description>
> >> +        </field>
> >> +        <field name="geoId" type="id">
> >> +            <description>The natural key, based on ISO 3166-1
> >> alpha-3</description>
> >> +        </field>
> >> +        <field name="geoName" type="name">
> >> +            <description>The name of the country, based on ISO
> >> 3166</description>
> >> +        </field>
> >> +        <field name="geoCode" type="short-varchar">
> >> +            <description>The ISO 3166-1 alpha-2 code of the
> >> country</description>
> >> +        </field>
> >> +        <field name="abbreviation" type="short-varchar">
> >> +            <description>Based on the ISO 3166-1 alpha-3 code of the
> >> country</description>
> >> +        </field>
> >> +        <field name="telCountryCode" type="short-varchar">
> >> +            <description>The telephone country code. Based on
> >> ITU.E123 and ITU.164</description>
> >> +        </field>
> >> +        <field name="ccTld" type="short-varchar">
> >> +            <description>The country code top-level domain for the
> >> country. Base on IANA rfc1591</description>
> >> +        </field>
> >> +        <prim-key field="dimensionId"/>
> >> +    </entity>
> >>       <entity entity-name="DateDimension"
> >> package-name="org.apache.ofbiz.bi.dimension" title="Date Dimension">
> >>           <description>Date (days) dimension. The natural key is
> >> [dateValue]</description>
> >>           <field name="dimensionId" type="id">
> >>
> >
>
Free forum by Nabble Edit this page