Re: svn commit: r1005861 - in /ofbiz/trunk: applications/product/script/org/ofbiz/product/price/ applications/product/servicedef/ applications/product/webapp/catalog/WEB-INF/ applications/product/webapp/catalog/WEB-INF/actions/price/ applications/product/w...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1005861 - in /ofbiz/trunk: applications/product/script/org/ofbiz/product/price/ applications/product/servicedef/ applications/product/webapp/catalog/WEB-INF/ applications/product/webapp/catalog/WEB-INF/actions/price/ applications/product/w...

Jacopo Cappellato-4
Jacques,

would it be possible to move the setPriceRulesCondEventJs.ftl out of the framework?

Regards,

Jacopo

On Oct 8, 2010, at 5:33 PM, [hidden email] wrote:

> Author: jleroux
> Date: Fri Oct  8 15:33:03 2010
> New Revision: 1005861
>
> URL: http://svn.apache.org/viewvc?rev=1005861&view=rev
> Log:
> New Price Rules screen.
> I tried to make it look better by having only one Value column but I found that a field inserted by Prototype was not taken into account when submitted. As it's not possible to rename a DOM element I finally gave up and used use-when + hide/show instead. I will see if we can do better with jQuery...
> I kept the old Screen + Groovy + FTL files, not for nostalgics, but in case someone has to quickly deal with fields with a lot of values (to avoid drop-down saturation). Then the Id will still be used. Note that it's also possible to do so with the new screen: you need only to put the field type in setPriceRulesCondEventJs.ftl and at top of getAssociatedPriceRulesConds service implementation in order to handle it as an Id with an input field (like it's done OOTB for Quantity and List Price)
>
> I'd like to use the same mechanism for Promo Rules. I will do that later, hopefully before merging jQuery...
>
> BTW, I like the now clear separation with Ajax onComplete event.
>
>
> Added:
>    ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/price/EditProductPriceRules_old.groovy   (with props)
>    ofbiz/trunk/framework/common/webcommon/includes/setPriceRulesCondEventJs.ftl   (with props)
> Modified:
>    ofbiz/trunk/applications/product/script/org/ofbiz/product/price/PriceServices.xml
>    ofbiz/trunk/applications/product/servicedef/services_pricepromo.xml
>    ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/price/EditProductPriceRules.groovy
>    ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml
>    ofbiz/trunk/applications/product/widget/catalog/CatalogMenus.xml
>    ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml
>    ofbiz/trunk/applications/product/widget/catalog/PriceScreens.xml
>    ofbiz/trunk/framework/common/webcommon/includes/setDependentDropdownValuesJs.ftl
>    ofbiz/trunk/framework/images/webapp/images/getDependentDropdownValues.js
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1005861 - in /ofbiz/trunk: applications/product/script/org/ofbiz/product/price/ applications/product/servicedef/ applications/product/webapp/catalog/WEB-INF/ applications/product/webapp/catalog/WEB-INF/actions/price/ applications/product/w

Jacques Le Roux
Administrator
Hi Jacopo,

Yes sure, there are no good reasons to be there actually :/ I guess I just followed the way I did for the more general
setDependentDropdownValuesJs.

I will handle it...

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Jacques,
>
> would it be possible to move the setPriceRulesCondEventJs.ftl out of the framework?
>
> Regards,
>
> Jacopo
>
> On Oct 8, 2010, at 5:33 PM, [hidden email] wrote:
>
>> Author: jleroux
>> Date: Fri Oct  8 15:33:03 2010
>> New Revision: 1005861
>>
>> URL: http://svn.apache.org/viewvc?rev=1005861&view=rev
>> Log:
>> New Price Rules screen.
>> I tried to make it look better by having only one Value column but I found that a field inserted by Prototype was not taken into
>> account when submitted. As it's not possible to rename a DOM element I finally gave up and used use-when + hide/show instead. I
>> will see if we can do better with jQuery...
>> I kept the old Screen + Groovy + FTL files, not for nostalgics, but in case someone has to quickly deal with fields with a lot of
>> values (to avoid drop-down saturation). Then the Id will still be used. Note that it's also possible to do so with the new
>> screen: you need only to put the field type in setPriceRulesCondEventJs.ftl and at top of getAssociatedPriceRulesConds service
>> implementation in order to handle it as an Id with an input field (like it's done OOTB for Quantity and List Price)
>>
>> I'd like to use the same mechanism for Promo Rules. I will do that later, hopefully before merging jQuery...
>>
>> BTW, I like the now clear separation with Ajax onComplete event.
>>
>>
>> Added:
>>    ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/price/EditProductPriceRules_old.groovy   (with props)
>>    ofbiz/trunk/framework/common/webcommon/includes/setPriceRulesCondEventJs.ftl   (with props)
>> Modified:
>>    ofbiz/trunk/applications/product/script/org/ofbiz/product/price/PriceServices.xml
>>    ofbiz/trunk/applications/product/servicedef/services_pricepromo.xml
>>    ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/price/EditProductPriceRules.groovy
>>    ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/controller.xml
>>    ofbiz/trunk/applications/product/widget/catalog/CatalogMenus.xml
>>    ofbiz/trunk/applications/product/widget/catalog/PriceForms.xml
>>    ofbiz/trunk/applications/product/widget/catalog/PriceScreens.xml
>>    ofbiz/trunk/framework/common/webcommon/includes/setDependentDropdownValuesJs.ftl
>>    ofbiz/trunk/framework/images/webapp/images/getDependentDropdownValues.js
>>
>
>