Re: svn commit: r1034138 - /ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy

[Adam Heath-2]

On 11/11/2010 03:19 PM, [hidden email] wrote:
> Author: apatel
> Date: Thu Nov 11 21:19:49 2010
> New Revision: 1034138
>
> URL: http://svn.apache.org/viewvc?rev=1034138&view=rev
> Log:
> Fix typo error.

What is the typo error?  Would be nice to list the before/after.  The
diff of the change isn't always included with the log(it's only here
in this email for convience).  This way, if someone saw an NPE in the
log, and then they knew what the missing variable was, it would be
easier to scan the log to find the correct fix to cherry-pick.

>
> Modified:
>      ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy
>
> Modified: ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy?rev=1034138&r1=1034137&r2=1034138&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy (original)
> +++ ofbiz/trunk/applications/accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy Thu Nov 11 21:19:49 2010
> @@ -117,7 +117,7 @@ transactionTotals = [];
>   balanceTotal = BigDecimal.ZERO;
>   List contraRevenueAndExprs = FastList.newInstance(mainAndExprs);
>   contraRevenueAndExprs.add(EntityCondition.makeCondition("glAccountClassId", EntityOperator.IN, contraRevenueAccountClassIds));
> -transactionTotals = delegator.findList("AcctgTransEntrySums", EntityCondition.makeCondition(cogsExpenseAndExprs, EntityOperator.AND), UtilMisc.toSet("glAccountId", "accountName", "accountCode", "debitCreditFlag", "amount"), UtilMisc.toList("glAccountId"), null, false);
> +transactionTotals = delegator.findList("AcctgTransEntrySums", EntityCondition.makeCondition(contraRevenueAndExprs, EntityOperator.AND), UtilMisc.toSet("glAccountId", "accountName", "accountCode", "debitCreditFlag", "amount"), UtilMisc.toList("glAccountId"), null, false);
>   if (transactionTotals) {
>       Map transactionTotalsMap = [:];
>       balanceTotalCredit = BigDecimal.ZERO;
>
>