Re: svn commit: r1045337 - /ofbiz/trunk/framework/widget/dtd/widget-screen.xsd

[Bruno Busco]

A variable name as enumeration value?
Sorry but I have never seen this pattern.
What's different in conf-mode and use-private from all other expandable
boolean attributes?

-Bruno


2010/12/13 <[hidden email]>

> Author: erwan
> Date: Mon Dec 13 19:44:54 2010
> New Revision: 1045337
>
> URL: http://svn.apache.org/viewvc?rev=1045337&view=rev
> Log:
> Adding enumerations for the conf-mode and use-private elements. Those are
> used for include-portal-page. This way we can use the parameters and the
> file is still valid
>
> Modified:
>    ofbiz/trunk/framework/widget/dtd/widget-screen.xsd
>
> Modified: ofbiz/trunk/framework/widget/dtd/widget-screen.xsd
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-screen.xsd?rev=1045337&r1=1045336&r2=1045337&view=diff
>
> ==============================================================================
> --- ofbiz/trunk/framework/widget/dtd/widget-screen.xsd (original)
> +++ ofbiz/trunk/framework/widget/dtd/widget-screen.xsd Mon Dec 13 19:44:54
> 2010
> @@ -1101,6 +1101,7 @@ under the License.
>                 <xs:restriction base="xs:token">
>                     <xs:enumeration value="true"/>
>                     <xs:enumeration value="false"/>
> +                    <xs:enumeration value="${parameters.confMode}"/>
>                 </xs:restriction>
>             </xs:simpleType>
>         </xs:attribute>
> @@ -1110,6 +1111,7 @@ under the License.
>                 <xs:restriction base="xs:token">
>                     <xs:enumeration value="true"/>
>                     <xs:enumeration value="false"/>
> +                    <xs:enumeration value="${parameters.usePrivate}"/>
>                 </xs:restriction>
>             </xs:simpleType>
>         </xs:attribute>
>
>
>

[Erwan de FERRIERES]

Le 14/12/2010 07:37, Bruno Busco a écrit :
> A variable name as enumeration value?
> Sorry but I have never seen this pattern.
> What's different in conf-mode and use-private from all other expandable
> boolean attributes?
>
> -Bruno
>

Hi Bruno and Scott,

Ok, this was not pretty. Those variables were introduced at this rev,
could you tell me how to handle it in the DTD ?

https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1023286

Cheers,

--
Erwan de FERRIERES
www.nereide.biz

[Scott Gray-2]

On 14/12/2010, at 9:16 PM, Erwan de FERRIERES wrote:

> Le 14/12/2010 07:37, Bruno Busco a écrit :
>> A variable name as enumeration value?
>> Sorry but I have never seen this pattern.
>> What's different in conf-mode and use-private from all other expandable
>> boolean attributes?
>>
>> -Bruno
>>
>
> Hi Bruno and Scott,
>
> Ok, this was not pretty. Those variables were introduced at this rev, could you tell me how to handle it in the DTD ?
>
> https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1023286
>

We have this pattern in a few places so I don't have a problem with that, it's just the parameters map prefix that I hadn't seen before.

Regards
Scott

[Erwan de FERRIERES]

Le 14/12/2010 09:35, Scott Gray a écrit :

> On 14/12/2010, at 9:16 PM, Erwan de FERRIERES wrote:
>
>> Le 14/12/2010 07:37, Bruno Busco a écrit :
>>> A variable name as enumeration value?
>>> Sorry but I have never seen this pattern.
>>> What's different in conf-mode and use-private from all other expandable
>>> boolean attributes?
>>>
>>> -Bruno
>>>
>>
>> Hi Bruno and Scott,
>>
>> Ok, this was not pretty. Those variables were introduced at this rev, could you tell me how to handle it in the DTD ?
>>
>> https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1023286
>>
>
> We have this pattern in a few places so I don't have a problem with that, it's just the parameters map prefix that I hadn't seen before.
>
> Regards
> Scott
>

So, just a revert will be the solution ? My point was just that
validation wasn't done because of those parameters. maybe there is
something else we can do ?

--
Erwan de FERRIERES
www.nereide.biz

[Bruno Busco]

Could we use perhaps some <xs:pattern ?

2010/12/14 Erwan de FERRIERES <[hidden email]>

> Le 14/12/2010 09:35, Scott Gray a écrit :
>
>  On 14/12/2010, at 9:16 PM, Erwan de FERRIERES wrote:
>>
>>  Le 14/12/2010 07:37, Bruno Busco a écrit :
>>>
>>>> A variable name as enumeration value?
>>>> Sorry but I have never seen this pattern.
>>>> What's different in conf-mode and use-private from all other expandable
>>>> boolean attributes?
>>>>
>>>> -Bruno
>>>>
>>>>
>>> Hi Bruno and Scott,
>>>
>>> Ok, this was not pretty. Those variables were introduced at this rev,
>>> could you tell me how to handle it in the DTD ?
>>>
>>> https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1023286
>>>
>>>
>> We have this pattern in a few places so I don't have a problem with that,
>> it's just the parameters map prefix that I hadn't seen before.
>>
>> Regards
>> Scott
>>
>>  So, just a revert will be the solution ? My point was just that
> validation wasn't done because of those parameters. maybe there is something
> else we can do ?
>
>
> --
> Erwan de FERRIERES
> www.nereide.biz
>