Re: svn commit: r1059362 - in /ofbiz/trunk/applications: accounting/config/AccountingErrorUiLabels.xml accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java order/config/OrderErrorUiLabels.xml

[Adam Heath-2]

On 01/15/2011 09:59 AM, [hidden email] wrote:

> Author: mrisaliti
> Date: Sat Jan 15 15:59:14 2011
> New Revision: 1059362
>
> URL: http://svn.apache.org/viewvc?rev=1059362&view=rev
> Log:
> Internationalization of ServiceUtil.returnSuccess, ServiceUtil.returnFailure, ServiceUtil.returnError (OFBIZ-4091)
>
> Modified:
>      ofbiz/trunk/applications/accounting/config/AccountingErrorUiLabels.xml
>      ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java
>      ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml
>
> Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java?rev=1059362&r1=1059361&r2=1059362&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java (original)
> +++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/payment/GiftCertificateServices.java Sat Jan 15 15:59:14 2011
> @@ -129,8 +129,8 @@ public class GiftCertificateServices {
>               // do something tricky here: run as the "system" user
>               // that can actually create a financial account transaction
>               GenericValue permUserLogin = delegator.findByPrimaryKeyCache("UserLogin", UtilMisc.toMap("userLoginId", "system"));
> -            refNum = createTransaction(delegator, dispatcher, permUserLogin, initialAmount,
> -                                    productStoreId, partyId, currencyUom, deposit, finAccountId);
> +            refNum = createTransaction(delegator, dispatcher, permUserLogin, initialAmount, productStoreId,
> +                    partyId, currencyUom, deposit, finAccountId, locale);
>
>           } catch (GenericEntityException e) {
>               Debug.logError(e, module);

This patch hunk does not affect internalization.  Why was it included?

Don't reformat code at the same time as changing the workflow.  It
makes it harder to figure out when things actually change.