Re: svn commit: r1061192 - in /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java

[Chirag Manocha-3]

Thanks Vikas,
More improvements are there.
In ShoppingCart.java
--> public String addProductPromoCode(String productPromoCodeId, ShoppingCart cart, LocalDispatcher dispatcher) {
No need to get cart object in parameter list.

In ShoppingCartEvents.java
--> String checkResult = cart.addProductPromoCode(productPromoCodeId, cart, dispatcher);
Calling method on cart so no need to pass cart in the method as parameter. Corresponding changes are done above in ShoppingCart.java


Regards
--
Chirag Manocha
Emforium Software Pvt. Ltd. | ALL-IN Software
[phone] | [phone]
Please don't print this Email unless you really need to - this will preserve trees on planet earth.




From: "Vikas Mayur" <[hidden email]>
To: [hidden email]
Sent: Thursday, January 20, 2011 5:16:16 PM
Subject: Re: svn commit: r1061192 - in /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java

Thanks Chirag!

Improvements committed to trunk in r1061239

Regards
Vikas

On Thu, Jan 20, 2011 at 4:09 PM, Chirag Manocha <[hidden email]>wrote:

> Hi Vikas,
> I am bit confused with the method addProductPromoCode in ShoppingCart
> class.
> In ShoppingCartEvent you are calling this method on cart object and passing
> the cart object as parameter too.
> There is no need of passing the cart object, you can use keyword this
> instead.
>
> Regards
> --
> Chirag Manocha
> Emforium Software Pvt. Ltd. | ALL-IN Software
> [phone] | [phone]
> Please don't print this Email unless you really need to - this will
> preserve trees on planet earth.
>
>
>
>
> From: [hidden email]
> To: [hidden email]
> Sent: Thursday, January 20, 2011 3:54:21 PM
> Subject: svn commit: r1061192 - in
> /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart:
> ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java
>
> Author: mor
> Date: Thu Jan 20 10:24:20 2011
> New Revision: 1061192
>
> URL: http://svn.apache.org/viewvc?rev=1061192&view=rev 
> Log:
> Bug fix: In a multiple store app now onwards a coupon code belonging to a
> particular store will not be accepted if used on a different store. If user
> attempts to do it, the
> system will notify user that it is an invalid coupon code. Earlier the
> coupon code was accepted but wasn't applied. Also it was preventing the user
> to add
> a correct coupon code.
>
>

[Chirag Manocha-3]

oops, I didnt get your commit message till I sent the message. Sorry for extra message ;)

Regards
--
Chirag Manocha
Emforium Software Pvt. Ltd. | ALL-IN Software
[phone] | [phone]
Please don't print this Email unless you really need to - this will preserve trees on planet earth.




From: "Chirag Manocha" <[hidden email]>
To: [hidden email]
Sent: Thursday, January 20, 2011 5:51:46 PM
Subject: Re: svn commit: r1061192 - in /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java

Thanks Vikas,
More improvements are there.
In ShoppingCart.java
--> public String addProductPromoCode(String productPromoCodeId, ShoppingCart cart, LocalDispatcher dispatcher) {
No need to get cart object in parameter list.

In ShoppingCartEvents.java
--> String checkResult = cart.addProductPromoCode(productPromoCodeId, cart, dispatcher);
Calling method on cart so no need to pass cart in the method as parameter. Corresponding changes are done above in ShoppingCart.java


Regards
--
Chirag Manocha
Emforium Software Pvt. Ltd. | ALL-IN Software
[phone] | [phone]
Please don't print this Email unless you really need to - this will preserve trees on planet earth.




From: "Vikas Mayur" <[hidden email]>
To: [hidden email]
Sent: Thursday, January 20, 2011 5:16:16 PM
Subject: Re: svn commit: r1061192 - in /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java

Thanks Chirag!

Improvements committed to trunk in r1061239

Regards
Vikas

On Thu, Jan 20, 2011 at 4:09 PM, Chirag Manocha <[hidden email]>wrote:

> Hi Vikas,
> I am bit confused with the method addProductPromoCode in ShoppingCart
> class.
> In ShoppingCartEvent you are calling this method on cart object and passing
> the cart object as parameter too.
> There is no need of passing the cart object, you can use keyword this
> instead.
>
> Regards
> --
> Chirag Manocha
> Emforium Software Pvt. Ltd. | ALL-IN Software
> [phone] | [phone]
> Please don't print this Email unless you really need to - this will
> preserve trees on planet earth.
>
>
>
>
> From: [hidden email]
> To: [hidden email]
> Sent: Thursday, January 20, 2011 3:54:21 PM
> Subject: svn commit: r1061192 - in
> /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart:
> ShoppingCart.java ShoppingCartEvents.java product/ProductPromoWorker.java
>
> Author: mor
> Date: Thu Jan 20 10:24:20 2011
> New Revision: 1061192
>
> URL: http://svn.apache.org/viewvc?rev=1061192&view=rev 
> Log:
> Bug fix: In a multiple store app now onwards a coupon code belonging to a
> particular store will not be accepted if used on a different store. If user
> attempts to do it, the
> system will notify user that it is an invalid coupon code. Earlier the
> coupon code was accepted but wasn't applied. Also it was preventing the user
> to add
> a correct coupon code.
>
>