Re: svn commit: r1063459 - in /ofbiz/trunk/specialpurpose/eb
Locked
Re: svn commit: r1063459 - in /ofbiz/trunk/specialpurpose/eb
 
|
Hi Marco,
Could please try and avoid including formatting changes in with actual code changes? It makes review much more difficult. Many thanks Scott HotWax Media http://www.hotwaxmedia.com On 26/01/2011, at 10:00 AM, [hidden email] wrote: > Author: mrisaliti > Date: Tue Jan 25 21:00:03 2011 > New Revision: 1063459 > > URL: http://svn.apache.org/viewvc?rev=1063459&view=rev > Log: > Internationalization of java services for ebay component and remove a java compile warning (OFBIZ-4091) > > Modified: > ofbiz/trunk/specialpurpose/ebay/config/EbayUiLabels.xml > ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java > ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ImportOrdersFromEbay.java > Modified: ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java > URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java?rev=1063459&r1=1063458&r2=1063459&view=diff > ============================================================================== > --- ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java (original) > +++ ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java Tue Jan 25 21:00:03 2011 > @@ -1119,9 +1119,9 @@ public class EbayOrderServices { > EbayHelper.correctCityStateCountry(dispatcher, shippingAddressCtx, city, state, country); > > List<GenericValue> shipInfo = > - PartyWorker.findMatchingPersonPostalAddresses > - (delegator, > - shippingAddressCtx.get("shippingAddressStreet1").toString(), > + PartyWorker.findMatchingPersonPostalAddresses > + (delegator, > + shippingAddressCtx.get("shippingAddressStreet1").toString(), > (UtilValidate.isEmpty(shippingAddressCtx.get("shippingAddressStreet2")) ? null : shippingAddressCtx.get("shippingAddressStreet2").toString()), > shippingAddressCtx.get("city").toString(), > (UtilValidate.isEmpty(shippingAddressCtx.get("stateProvinceGeoId")) ? null : shippingAddressCtx.get("stateProvinceGeoId").toString()), |
smime.p7s (3K)
Re: svn commit: r1063459 - in /ofbiz/trunk/specialpurpose/eb
|
|
Re: svn commit: r1063459 - in /ofbiz/trunk/specialpurpose/eb
|
|
The problem is that when you mix code changes with formatting changes reviewers then have inspect every chunk closely in order to figure out what (if anything) changed in those lines.
I can't force you to do anything but if you want your code reviewed properly then I'd really recommend splitting the two types of changes. Regards Scott On 27/01/2011, at 9:33 AM, [hidden email] wrote: > Hi Scott, > > we discuss on the dev mailing list that when we change something in the code and we found long lines stripped we could replace it with long lines. > In this case It was what I would like to do it but I forgot to do it, probably in this case there was a tab and I have simply replaced it with 4 spaces. > > Thanks > Marco > > Il giorno 26/gen/2011, alle ore 21.24, Scott Gray ha scritto: > >> Hi Marco, >> >> Could please try and avoid including formatting changes in with actual code changes? It makes review much more difficult. >> >> Many thanks >> Scott >> >> HotWax Media >> http://www.hotwaxmedia.com >> >> On 26/01/2011, at 10:00 AM, [hidden email] wrote: >> >>> Author: mrisaliti >>> Date: Tue Jan 25 21:00:03 2011 >>> New Revision: 1063459 >>> >>> URL: http://svn.apache.org/viewvc?rev=1063459&view=rev >>> Log: >>> Internationalization of java services for ebay component and remove a java compile warning (OFBIZ-4091) >>> >>> Modified: >>> ofbiz/trunk/specialpurpose/ebay/config/EbayUiLabels.xml >>> ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java >>> ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/ImportOrdersFromEbay.java >> >> [snip] >> >>> Modified: ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java?rev=1063459&r1=1063458&r2=1063459&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java (original) >>> +++ ofbiz/trunk/specialpurpose/ebay/src/org/ofbiz/ebay/EbayOrderServices.java Tue Jan 25 21:00:03 2011 >>> @@ -1119,9 +1119,9 @@ public class EbayOrderServices { >>> EbayHelper.correctCityStateCountry(dispatcher, shippingAddressCtx, city, state, country); >>> >>> List<GenericValue> shipInfo = >>> - PartyWorker.findMatchingPersonPostalAddresses >>> - (delegator, >>> - shippingAddressCtx.get("shippingAddressStreet1").toString(), >>> + PartyWorker.findMatchingPersonPostalAddresses >>> + (delegator, >>> + shippingAddressCtx.get("shippingAddressStreet1").toString(), >>> (UtilValidate.isEmpty(shippingAddressCtx.get("shippingAddressStreet2")) ? null : shippingAddressCtx.get("shippingAddressStreet2").toString()), >>> shippingAddressCtx.get("city").toString(), >>> (UtilValidate.isEmpty(shippingAddressCtx.get("stateProvinceGeoId")) ? null : shippingAddressCtx.get("stateProvinceGeoId").toString()), >> >> [snip] > |
Re: svn commit: r1063459 - in /ofbiz/trunk/specialpurpose/eb
|
|
| Free forum by Nabble | Edit this page |