Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

Adrian Crum-3
Just a reminder that you are hiding the problem - not fixing it.

-Adrian

On 3/4/2011 10:26 AM, [hidden email] wrote:

> Author: mrisaliti
> Date: Fri Mar  4 18:26:16 2011
> New Revision: 1078088
>
> URL: http://svn.apache.org/viewvc?rev=1078088&view=rev
> Log:
> Remove a warning in OfbizContentTransform (OFBIZ-4102)
>
> Modified:
>      ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>
> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088&r1=1078087&r2=1078088&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java (original)
> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java Fri Mar  4 18:26:16 2011
> @@ -63,6 +63,7 @@ public class OfbizContentTransform imple
>           return result;
>       }
>
> +    @SuppressWarnings("unchecked")
>       public Writer getWriter(final Writer out, Map args) {
>           final StringBuilder buf = new StringBuilder();
>           final String imgSize = OfbizContentTransform.getArg(args, "variant");
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

risalitim@gmail.com
Hi Adrian,

I'm agree with you but in this case the method getWriter of interface TemplateTransformModel of Freemarker does not accept to specify which type of Map you will use.
So until new version of Freemarker will accept parametrized Map I think it's better to use @SuppressWarnings("unchecked").

What did you think of it ?

Thanks
Marco

Il giorno 04/mar/2011, alle ore 19.47, Adrian Crum ha scritto:

> Just a reminder that you are hiding the problem - not fixing it.
>
> -Adrian
>
> On 3/4/2011 10:26 AM, [hidden email] wrote:
>> Author: mrisaliti
>> Date: Fri Mar  4 18:26:16 2011
>> New Revision: 1078088
>>
>> URL: http://svn.apache.org/viewvc?rev=1078088&view=rev
>> Log:
>> Remove a warning in OfbizContentTransform (OFBIZ-4102)
>>
>> Modified:
>>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>>
>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088&r1=1078087&r2=1078088&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java (original)
>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java Fri Mar  4 18:26:16 2011
>> @@ -63,6 +63,7 @@ public class OfbizContentTransform imple
>>          return result;
>>      }
>>
>> +    @SuppressWarnings("unchecked")
>>      public Writer getWriter(final Writer out, Map args) {
>>          final StringBuilder buf = new StringBuilder();
>>          final String imgSize = OfbizContentTransform.getArg(args, "variant");
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

Adrian Crum-3
Okay, I did not realize that was an external API method. Never mind.
Sorry to bother you. Carry on. ;-)

-Adrian

On 3/4/2011 10:58 AM, [hidden email] wrote:

> Hi Adrian,
>
> I'm agree with you but in this case the method getWriter of interface TemplateTransformModel of Freemarker does not accept to specify which type of Map you will use.
> So until new version of Freemarker will accept parametrized Map I think it's better to use @SuppressWarnings("unchecked").
>
> What did you think of it ?
>
> Thanks
> Marco
>
> Il giorno 04/mar/2011, alle ore 19.47, Adrian Crum ha scritto:
>
>> Just a reminder that you are hiding the problem - not fixing it.
>>
>> -Adrian
>>
>> On 3/4/2011 10:26 AM, [hidden email] wrote:
>>> Author: mrisaliti
>>> Date: Fri Mar  4 18:26:16 2011
>>> New Revision: 1078088
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1078088&view=rev
>>> Log:
>>> Remove a warning in OfbizContentTransform (OFBIZ-4102)
>>>
>>> Modified:
>>>      ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>>>
>>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088&r1=1078087&r2=1078088&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java (original)
>>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java Fri Mar  4 18:26:16 2011
>>> @@ -63,6 +63,7 @@ public class OfbizContentTransform imple
>>>           return result;
>>>       }
>>>
>>> +    @SuppressWarnings("unchecked")
>>>       public Writer getWriter(final Writer out, Map args) {
>>>           final StringBuilder buf = new StringBuilder();
>>>           final String imgSize = OfbizContentTransform.getArg(args, "variant");
>>>
>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1078088 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java

risalitim@gmail.com
No problem Adrian, it's better 4 eyes than only 2 and particularly for this migration.

Thanks to look at it.
Marco

Il giorno 04/mar/2011, alle ore 20.10, Adrian Crum ha scritto:

> Okay, I did not realize that was an external API method. Never mind. Sorry to bother you. Carry on. ;-)
>
> -Adrian
>
> On 3/4/2011 10:58 AM, [hidden email] wrote:
>> Hi Adrian,
>>
>> I'm agree with you but in this case the method getWriter of interface TemplateTransformModel of Freemarker does not accept to specify which type of Map you will use.
>> So until new version of Freemarker will accept parametrized Map I think it's better to use @SuppressWarnings("unchecked").
>>
>> What did you think of it ?
>>
>> Thanks
>> Marco
>>
>> Il giorno 04/mar/2011, alle ore 19.47, Adrian Crum ha scritto:
>>
>>> Just a reminder that you are hiding the problem - not fixing it.
>>>
>>> -Adrian
>>>
>>> On 3/4/2011 10:26 AM, [hidden email] wrote:
>>>> Author: mrisaliti
>>>> Date: Fri Mar  4 18:26:16 2011
>>>> New Revision: 1078088
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1078088&view=rev
>>>> Log:
>>>> Remove a warning in OfbizContentTransform (OFBIZ-4102)
>>>>
>>>> Modified:
>>>>     ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>>>>
>>>> Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java?rev=1078088&r1=1078087&r2=1078088&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java (original)
>>>> +++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/ftl/OfbizContentTransform.java Fri Mar  4 18:26:16 2011
>>>> @@ -63,6 +63,7 @@ public class OfbizContentTransform imple
>>>>          return result;
>>>>      }
>>>>
>>>> +    @SuppressWarnings("unchecked")
>>>>      public Writer getWriter(final Writer out, Map args) {
>>>>          final StringBuilder buf = new StringBuilder();
>>>>          final String imgSize = OfbizContentTransform.getArg(args, "variant");
>>>>
>>>>
>>