Re: svn commit: r1138569 - /ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl

[Adrian Crum-3]

Jacques,

I will look into this. If my commit broke it, then it's my
responsibility to fix it.

-Adrian


On 6/22/2011 7:01 PM, [hidden email] wrote:

> Author: jleroux
> Date: Wed Jun 22 18:01:52 2011
> New Revision: 1138569
>
> URL: http://svn.apache.org/viewvc?rev=1138569&view=rev
> Log:
> By moving formName and fieldFormName in parameters order r1138485 broke the current OOTB code which still uses htmlTemplate.lookupField
>
> There is still an issue: the lookup button does not show
>
> Modified:
>      ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>
> Modified: ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl?rev=1138569&r1=1138568&r2=1138569&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl (original)
> +++ ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl Wed Jun 22 18:01:52 2011
> @@ -46,7 +46,7 @@ under the License.
>           <#else>
>               <#local readonly = false />
>           </#if>
> -<@renderLookupField className alert name value size maxlength id event action readonly autocomplete descriptionFieldName formName fieldFormName targetParameterIter imgSrc ajaxUrl ajaxEnabled presentation width height position fadeBackground clearText showDescription initiallyCollapsed/>
> +<@renderLookupField className formName fieldFormName alert name value size maxlength id event action readonly autocomplete descriptionFieldName targetParameterIter imgSrc ajaxUrl ajaxEnabled presentation width height position fadeBackground clearText showDescription initiallyCollapsed/>
>   </#macro>
>
>   <#macro nextPrev commonUrl="" ajaxEnabled=false javaScriptEnabled=false paginateStyle="nav-pager" paginateFirstStyle="nav-first" viewIndex=0 highIndex=0 listSize=0 viewSize=1 ajaxFirstUrl="" firstUrl="" paginateFirstLabel="" paginatePreviousStyle="nav-previous" ajaxPreviousUrl="" previousUrl="" paginatePreviousLabel="" pageLabel="" ajaxSelectUrl="" selectUrl="" ajaxSelectSizeUrl="" selectSizeUrl="" commonDisplaying="" paginateNextStyle="nav-next" ajaxNextUrl="" nextUrl="" paginateNextLabel="" paginateLastStyle="nav-last" ajaxLastUrl="" lastUrl="" paginateLastLabel="" paginateViewSizeLabel="">
>
>

[Adrian Crum-3]

Fixed in rev 1138575. Btw, I couldn't find where the lookupField macro
was being used OOTB.

-Adrian


On 6/22/2011 7:05 PM, Adrian Crum wrote:

> Jacques,
>
> I will look into this. If my commit broke it, then it's my
> responsibility to fix it.
>
> -Adrian
>
>
> On 6/22/2011 7:01 PM, [hidden email] wrote:
>> Author: jleroux
>> Date: Wed Jun 22 18:01:52 2011
>> New Revision: 1138569
>>
>> URL: http://svn.apache.org/viewvc?rev=1138569&view=rev
>> Log:
>> By moving formName and fieldFormName in parameters order r1138485
>> broke the current OOTB code which still uses htmlTemplate.lookupField
>>
>> There is still an issue: the lookup button does not show
>>
>> Modified:
>>      ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>>
>> Modified:
>> ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl?rev=1138569&r1=1138568&r2=1138569&view=diff
>> ==============================================================================
>>
>> --- ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>> (original)
>> +++ ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>> Wed Jun 22 18:01:52 2011
>> @@ -46,7 +46,7 @@ under the License.
>> <#else>
>> <#local readonly = false />
>> </#if>
>> -<@renderLookupField className alert name value size maxlength id
>> event action readonly autocomplete descriptionFieldName formName
>> fieldFormName targetParameterIter imgSrc ajaxUrl ajaxEnabled
>> presentation width height position fadeBackground clearText
>> showDescription initiallyCollapsed/>
>> +<@renderLookupField className formName fieldFormName alert name
>> value size maxlength id event action readonly autocomplete
>> descriptionFieldName targetParameterIter imgSrc ajaxUrl ajaxEnabled
>> presentation width height position fadeBackground clearText
>> showDescription initiallyCollapsed/>
>> </#macro>
>>
>> <#macro nextPrev commonUrl="" ajaxEnabled=false
>> javaScriptEnabled=false paginateStyle="nav-pager"
>> paginateFirstStyle="nav-first" viewIndex=0 highIndex=0 listSize=0
>> viewSize=1 ajaxFirstUrl="" firstUrl="" paginateFirstLabel=""
>> paginatePreviousStyle="nav-previous" ajaxPreviousUrl=""
>> previousUrl="" paginatePreviousLabel="" pageLabel="" ajaxSelectUrl=""
>> selectUrl="" ajaxSelectSizeUrl="" selectSizeUrl=""
>> commonDisplaying="" paginateNextStyle="nav-next" ajaxNextUrl=""
>> nextUrl="" paginateNextLabel="" paginateLastStyle="nav-last"
>> ajaxLastUrl="" lastUrl="" paginateLastLabel="" paginateViewSizeLabel="">
>>
>>

[Jacques Le Roux]

Adrian,

Look for <@htmlTemplate.lookupField in ftl files. There are at least 74 cases.

Jacques

From: "Adrian Crum" <[hidden email]>

> Fixed in rev 1138575. Btw, I couldn't find where the lookupField macro was being used OOTB.
>
> -Adrian
>
>
> On 6/22/2011 7:05 PM, Adrian Crum wrote:
>> Jacques,
>>
>> I will look into this. If my commit broke it, then it's my responsibility to fix it.
>>
>> -Adrian
>>
>>
>> On 6/22/2011 7:01 PM, [hidden email] wrote:
>>> Author: jleroux
>>> Date: Wed Jun 22 18:01:52 2011
>>> New Revision: 1138569
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1138569&view=rev
>>> Log:
>>> By moving formName and fieldFormName in parameters order r1138485 broke the current OOTB code which still uses
>>> htmlTemplate.lookupField
>>>
>>> There is still an issue: the lookup button does not show
>>>
>>> Modified:
>>>      ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>>>
>>> Modified: ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl?rev=1138569&r1=1138568&r2=1138569&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl (original)
>>> +++ ofbiz/trunk/framework/common/webcommon/includes/htmlTemplate.ftl Wed Jun 22 18:01:52 2011
>>> @@ -46,7 +46,7 @@ under the License.
>>> <#else>
>>> <#local readonly = false />
>>> </#if>
>>> -<@renderLookupField className alert name value size maxlength id event action readonly autocomplete descriptionFieldName
>>> formName fieldFormName targetParameterIter imgSrc ajaxUrl ajaxEnabled presentation width height position fadeBackground
>>> clearText showDescription initiallyCollapsed/>
>>> +<@renderLookupField className formName fieldFormName alert name value size maxlength id event action readonly autocomplete
>>> descriptionFieldName targetParameterIter imgSrc ajaxUrl ajaxEnabled presentation width height position fadeBackground clearText
>>> showDescription initiallyCollapsed/>
>>> </#macro>
>>>
>>> <#macro nextPrev commonUrl="" ajaxEnabled=false javaScriptEnabled=false paginateStyle="nav-pager" paginateFirstStyle="nav-first"
>>> viewIndex=0 highIndex=0 listSize=0 viewSize=1 ajaxFirstUrl="" firstUrl="" paginateFirstLabel=""
>>> paginatePreviousStyle="nav-previous" ajaxPreviousUrl="" previousUrl="" paginatePreviousLabel="" pageLabel="" ajaxSelectUrl=""
>>> selectUrl="" ajaxSelectSizeUrl="" selectSizeUrl="" commonDisplaying="" paginateNextStyle="nav-next" ajaxNextUrl="" nextUrl=""
>>> paginateNextLabel="" paginateLastStyle="nav-last" ajaxLastUrl="" lastUrl="" paginateLastLabel="" paginateViewSizeLabel="">
>>>
>>>