Re: svn commit: r1198629 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml

[Adrian Crum-3]

If the <field> element is changing the type, then wouldn't it be better
to fix the element?

-Adrian

On 11/7/2011 6:12 AM, [hidden email] wrote:

> Author: hansbak
> Date: Mon Nov  7 06:12:38 2011
> New Revision: 1198629
>
> URL: http://svn.apache.org/viewvc?rev=1198629&view=rev
> Log:
> repeat type of veriable, looks like minilanguage does not remember the rype assigned before.
>
> Modified:
>      ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>
> Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=1198629&r1=1198628&r2=1198629&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml (original)
> +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml Mon Nov  7 06:12:38 2011
> @@ -194,7 +194,7 @@ under the License.
>                           <set field="actual" value="true" type="Boolean"/>
>                           <call-class-method method-name="getPaymentNotApplied" class-name="org.ofbiz.accounting.payment.PaymentWorker" ret-field="notAppliedPayment">
>                               <field field="payment" type="GenericValue"/>
> -<field field="actual"/>
> +<field field="actual" type="Boolean"/>
>                           </call-class-method>
>                       </if-compare-field>
>                   </then>
>
>

[hans_bakker]

Yes Adrian, that is why i phrased the log message that way. I was hoping
that the framework specialists, like you would pick this up? We merely
focus on the applications as you may know?

Regards, Hans

On 11/07/2011 03:58 PM, Adrian Crum wrote:

> If the <field> element is changing the type, then wouldn't it be
> better to fix the element?
>
> -Adrian
>
> On 11/7/2011 6:12 AM, [hidden email] wrote:
>> Author: hansbak
>> Date: Mon Nov  7 06:12:38 2011
>> New Revision: 1198629
>>
>> URL: http://svn.apache.org/viewvc?rev=1198629&view=rev
>> Log:
>> repeat type of veriable, looks like minilanguage does not remember
>> the rype assigned before.
>>
>> Modified:
>>      
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=1198629&r1=1198628&r2=1198629&view=diff
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>> (original)
>> +++
>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>> Mon Nov  7 06:12:38 2011
>> @@ -194,7 +194,7 @@ under the License.
>> <set field="actual" value="true" type="Boolean"/>
>> <call-class-method method-name="getPaymentNotApplied"
>> class-name="org.ofbiz.accounting.payment.PaymentWorker"
>> ret-field="notAppliedPayment">
>> <field field="payment" type="GenericValue"/>
>> -<field field="actual"/>
>> +<field field="actual" type="Boolean"/>
>> </call-class-method>
>> </if-compare-field>
>> </then>
>>
>>

[Adrian Crum-3]

It might be better to create a Jira issue. Depending on a "framework
specialist" to pick up a hint from a commit message is not a reliable
form of communication.

-Adrian

On 11/7/2011 9:22 AM, Hans Bakker wrote:

> Yes Adrian, that is why i phrased the log message that way. I was
> hoping that the framework specialists, like you would pick this up? We
> merely focus on the applications as you may know?
>
> Regards, Hans
>
> On 11/07/2011 03:58 PM, Adrian Crum wrote:
>> If the <field> element is changing the type, then wouldn't it be
>> better to fix the element?
>>
>> -Adrian
>>
>> On 11/7/2011 6:12 AM, [hidden email] wrote:
>>> Author: hansbak
>>> Date: Mon Nov  7 06:12:38 2011
>>> New Revision: 1198629
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1198629&view=rev
>>> Log:
>>> repeat type of veriable, looks like minilanguage does not remember
>>> the rype assigned before.
>>>
>>> Modified:
>>>      
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?rev=1198629&r1=1198628&r2=1198629&view=diff
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
>>> Mon Nov  7 06:12:38 2011
>>> @@ -194,7 +194,7 @@ under the License.
>>> <set field="actual" value="true" type="Boolean"/>
>>> <call-class-method method-name="getPaymentNotApplied"
>>> class-name="org.ofbiz.accounting.payment.PaymentWorker"
>>> ret-field="notAppliedPayment">
>>> <field field="payment" type="GenericValue"/>
>>> -<field field="actual"/>
>>> +<field field="actual" type="Boolean"/>
>>> </call-class-method>
>>> </if-compare-field>
>>> </then>
>>>
>>>
>