Re: svn commit: r1212706 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

[Jacques Le Roux]

Hi Hans,

Actually this is continuously failing since r1212266 http://ci.apache.org/builders/ofbiz-trunk
Please revert it

I will not be available before Tuesday evening (vacation)

Jacques

From: <[hidden email]>

> Author: hansbak
> Date: Sat Dec 10 01:24:44 2011
> New Revision: 1212706
>
> URL: http://svn.apache.org/viewvc?rev=1212706&view=rev
> Log:
> revert 1212673 because of compile error
>
> Modified:
>    ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java
>
> Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java?rev=1212706&r1=1212705&r2=1212706&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java (original)
> +++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java Sat Dec 10 01:24:44 2011
> @@ -223,14 +223,13 @@ public class StringUtil {
>     /**
>      * Creates a Map from an encoded name/value pair string
>      * @param str The string to decode and format
> -     * @param delim the delimiter character(s) to join on (null will split on whitespace)
>      * @param trim Trim whitespace off fields
>      * @return a Map of name/value pairs
>      */
> -    public static Map<String, String> strToMap(String str, String delim, boolean trim) {
> +    public static Map<String, String> strToMap(String str, boolean trim) {
>         if (str == null) return null;
>         Map<String, String> decodedMap = FastMap.newInstance();
> -        List<String> elements = split(str, delim);
> +        List<String> elements = split(str, "|");
>
>         for (String s: elements) {
>             List<String> e = split(s, "=");
> @@ -264,16 +263,7 @@ public class StringUtil {
>      * @return a Map of name/value pairs
>      */
>     public static Map<String, String> strToMap(String str) {
> -        return strToMap(str, "|", false);
> -    }
> -
> -    /**
> -     * Creates a Map from an encoded name/value pair string
> -     * @param str The string to decode and format
> -     * @return a Map of name/value pairs
> -     */
> -    public static Map<String, String> strToMap(String str, String delim) {
> -        return strToMap(str, delim, false);
> +        return strToMap(str, false);
>     }
>
>     /**
>
>