Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

[Jacques Le Roux]

Hi,

on XP 32bits here (*French context*), using

java version "1.6.0_29"
Java(TM) SE Runtime Environment (build 1.6.0_29-b11)
Java HotSpot(TM) Client VM (build 20.4-b02, mixed mode, sharing)

with
svn up (r1215035)
ant clean-all run-install run-tests I get

BUILD FAILED
D:\workspace\ofbizClean\build.xml:857: Test run was unsuccessful

Tests Failures Errors Success rate Time
869     17         0         98.04%     401.827
Note: failures are anticipated and checked for with assertions while errors are unanticipated.

Details:
baseteststestWithVerbosityFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>

junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testWithVerbosity(FlexibleStringExpanderTests.java:264)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
1.031 baseteststestQuietlyFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>

junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testQuietly(FlexibleStringExpanderTests.java:268)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
0.219 baseteststestFlexibleMapAccessorFailurefoo:get expected:<The total is $12,345,678.90.> but was:<The total is 12 345 678,90
$US.>

junit.framework.AssertionFailedError: foo:get expected: but was:
at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:343)
at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.fmaTest(FlexibleMapAccessorTests.java:86)
at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.testFlexibleMapAccessor(FlexibleMapAccessorTests.java:141)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
0.000 baseteststestReadWriteObjectFailurewrite stream java.lang.Boolean expected:<......> but was:<... ...>

junit.framework.ComparisonFailure: write stream java.lang.Boolean expected:<......> but was:<...
...>
at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:147)
at org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:155)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
0.000 invoicetestsauto-invoice-tests.testInvoiceWorkerGetInvoiceTotalFailureAssertion failed: [invoiceTotal=323.54] equals
[amount=323] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=323.54] equals [amount=323] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)
Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal

junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)

HTH

Jacques

From: "Adrian Crum" <[hidden email]>

>I agree with Scott. A number of us have tried running the tests with no problem, so it must be a local issue. Let's get them
>enabled again.
>
> -Adrian
>
> On 12/15/2011 10:56 PM, Scott Gray wrote:
>> My vote would be to re-enable them regardless, the whole point of the tests is to ensure stability and disabling tests that
>> (allegedly) fail does nothing to further that goal.
>>
>> The correct approach is to find the commit that caused the failure and make a lot of noise to that committer.  I'm pretty sure
>> that everyone agrees that we have a responsibility as committers to ensure that we won't cause the tests to fail.
>>
>> Regards
>> Scott
>>
>> On 15/12/2011, at 6:46 AM, Jacopo Cappellato wrote:
>>
>>> No problem: can I re-enable the tests in the meantime?
>>>
>>> Jacopo
>>>
>>> On Dec 15, 2011, at 2:30 PM, Hans Bakker wrote:
>>>
>>>> At the moment pretty busy with other things, will have time this weekend or next week,
>>>>
>>>> On 12/15/2011 08:28 PM, Jacopo Cappellato wrote:
>>>>> Hi Hans,
>>>>>
>>>>> any update on this?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jacopo
>>>>>
>>>>> On Dec 14, 2011, at 9:37 AM, Jacopo Cappellato wrote:
>>>>>
>>>>>> Hi Hans,
>>>>>>
>>>>>> please see inline:
>>>>>>
>>>>>> On Dec 14, 2011, at 8:55 AM, Hans Bakker wrote:
>>>>>>
>>>>>>> Hi Jacopo,
>>>>>>>
>>>>>>> thank you for looking into this.
>>>>>>>
>>>>>>> yes sure i did run ./ant run-install
>>>>>>>
>>>>>>> The test below needs some OrderItemBilling records for order DEMO10091 which specifies an invoiceId.
>>>>>>> these records are however not there and therefore the invoiceId is missing.
>>>>>>> I can also not find them anywhere in demo or test data....
>>>>>> I think the invoice (and OrderItemBilling record) is created by the chain of events caused by the test before that one:
>>>>>> testAcctgTransOnPoReceipts (receipt-->shipment-->invoice)
>>>>>>
>>>>>>> Then i disabled only the test below, and then all following tests in the same file are failing.
>>>>>> Of course they are, because the tests in that group rely on each other.
>>>>>>
>>>>>>> Then I went back to a much earlier revision where the tests are failing too....A revision where i found them working is
>>>>>>> 892749 from 2009-12-21 . So they seem to be working before...
>>>>>>>
>>>>>>> did you try to run the ./ant run-tests locally ? It looks like buildbot is missing these tests....
>>>>>>>
>>>>>> Yes, I tested the tests locally:
>>>>>> ant clean-all
>>>>>> ant run-install
>>>>>> ant run-tests
>>>>>>
>>>>>> Jacopo
>>>>>>
>>>>>>> Regards,
>>>>>>> Hans
>>>>>>>
>>>>>>> On 12/14/2011 01:56 PM, Jacopo Cappellato wrote:
>>>>>>>> Hans,
>>>>>>>>
>>>>>>>> did you run "ant run-install" before "ant run-tests"?
>>>>>>>>
>>>>>>>> I suspect that you are getting this error because in your db the order DEMO10091 is not found.
>>>>>>>>
>>>>>>>> Jacopo
>>>>>>>>
>>>>>>>> On Dec 13, 2011, at 4:56 PM, Hans Bakker wrote:
>>>>>>>>
>>>>>>>>> Hi Jacopo,
>>>>>>>>>
>>>>>>>>> this is what is reported:
>>>>>>>>>
>>>>>>>>> Error Message
>>>>>>>>>
>>>>>>>>> ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes and shipping charges and posting to
>>>>>>>>> GL
>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>> 00:11:52.971(java.sql.Timestamp)][lastU
>>>>>>>>> pdatedTxStamp,2011-12-13
>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>
>>>>>>>>> Stacktrace
>>>>>>>>>
>>>>>>>>> junit.framework.AssertionFailedError: ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes
>>>>>>>>> and shipping charges and posting to GL
>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>> 0
>>>>>>>>> 0:11:52.971(java.sql.Timestamp)][lastUpdatedTxStamp,2011-12-13
>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:93)
>>>>>>>>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>>>>>>>>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>>>>>>>>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>>>>>>>>> at org.ofbiz.base.start.Start.start(Start.java:289)
>>>>>>>>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Hans
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 12/13/2011 10:52 PM, Jacopo Cappellato wrote:
>>>>>>>>>> Hans,
>>>>>>>>>>
>>>>>>>>>> could you please be more specific on the errors/failures you are getting?
>>>>>>>>>> It seems I was able to run successfully all the tests.
>>>>>>>>>>
>>>>>>>>>> Jacopo
>>>>>>>>>>
>>>>>>>>>> On Dec 13, 2011, at 3:41 PM, Hans Bakker wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Yes a good idea:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4624
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Regards,
>>>>>>>>>>> Hans
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 12/13/2011 09:21 PM, Erwan de FERRIERES wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hans,
>>>>>>>>>>>>
>>>>>>>>>>>> could you create an associated Jira issue, so this won't be forgotten ?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>
>>>>>>>>>>>> 2011/12/13
>>>>>>>>>>>> <[hidden email]>
>>>>>>>>>>>> :
>>>>>>>>>>>>
>>>>>>>>>>>>> Author: hansbak
>>>>>>>>>>>>> Date: Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>> New Revision: 1213650
>>>>>>>>>>>>>
>>>>>>>>>>>>> URL:
>>>>>>>>>>>>> http://svn.apache.org/viewvc?rev=1213650&view=rev
>>>>>>>>>>>>>
>>>>>>>>>>>>> Log:
>>>>>>>>>>>>> commented out accounting auto tests which did not work for a long time
>>>>>>>>>>>>>
>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>   ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>
>>>>>>>>>>>>> Modified: ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>> URL:
>>>>>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/testdef/accountingtests.xml?rev=1213650&r1=1213649&r2=1213650&view=diff
>>>>>>>>>>>>>
>>>>>>>>>>>>> ==============================================================================
>>>>>>>>>>>>> --- ofbiz/trunk/applications/accounting/testdef/accountingtests.xml (original)
>>>>>>>>>>>>> +++ ofbiz/trunk/applications/accounting/testdef/accountingtests.xml Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>> @@ -29,7 +29,8 @@
>>>>>>>>>>>>>
>>>>>>>>>>>>>    <test-case case-name="accounting-tests"><junit-test-suite
>>>>>>>>>>>>> class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>
>>>>>>>>>>>>>
>>>>>>>>>>>>> -<test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>> +<!-- commented out for now...test data seems to be missing and i wondered if theyu ever worked, went back to rev:
>>>>>>>>>>>>> 903431 and ever there the same problem -->
>>>>>>>>>>>>> +<!-- test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>        <simple-method-test
>>>>>>>>>>>>> location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
>>>>>>>>>>>>> -</test-case>
>>>>>>>>>>>>> +</test-case-->
>>>>>>>>>>>>> </test-suite>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>

[Jacopo Cappellato-4]

ok, this is useful... it is a locale related issue and I am working on it.

Jacopo

On Dec 16, 2011, at 5:45 AM, Jacques Le Roux wrote:

> Hi,
>
> on XP 32bits here (*French context*), using
>
> java version "1.6.0_29"
> Java(TM) SE Runtime Environment (build 1.6.0_29-b11)
> Java HotSpot(TM) Client VM (build 20.4-b02, mixed mode, sharing)
>
> with
> svn up (r1215035)
> ant clean-all run-install run-tests I get
>
> BUILD FAILED
> D:\workspace\ofbizClean\build.xml:857: Test run was unsuccessful
>
> Tests Failures Errors Success rate Time
> 869     17         0         98.04%     401.827
> Note: failures are anticipated and checked for with assertions while errors are unanticipated.
>
> Details:
> baseteststestWithVerbosityFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>
> junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testWithVerbosity(FlexibleStringExpanderTests.java:264)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> 1.031 baseteststestQuietlyFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>
> junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testQuietly(FlexibleStringExpanderTests.java:268)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> 0.219 baseteststestFlexibleMapAccessorFailurefoo:get expected:<The total is $12,345,678.90.> but was:<The total is 12 345 678,90
> $US.>
>
> junit.framework.AssertionFailedError: foo:get expected: but was:
> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:343)
> at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.fmaTest(FlexibleMapAccessorTests.java:86)
> at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.testFlexibleMapAccessor(FlexibleMapAccessorTests.java:141)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> 0.000 baseteststestReadWriteObjectFailurewrite stream java.lang.Boolean expected:<......> but was:<... ...>
>
> junit.framework.ComparisonFailure: write stream java.lang.Boolean expected:<......> but was:<...
> ...>
> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
> at org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:147)
> at org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:155)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> 0.000 invoicetestsauto-invoice-tests.testInvoiceWorkerGetInvoiceTotalFailureAssertion failed: [invoiceTotal=323.54] equals
> [amount=323] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=323.54] equals [amount=323] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
> Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
>
> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
> at org.ofbiz.base.start.Start.start(Start.java:289)
> at org.ofbiz.base.start.Start.main(Start.java:119)
>
> HTH
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> I agree with Scott. A number of us have tried running the tests with no problem, so it must be a local issue. Let's get them
>> enabled again.
>>
>> -Adrian
>>
>> On 12/15/2011 10:56 PM, Scott Gray wrote:
>>> My vote would be to re-enable them regardless, the whole point of the tests is to ensure stability and disabling tests that
>>> (allegedly) fail does nothing to further that goal.
>>>
>>> The correct approach is to find the commit that caused the failure and make a lot of noise to that committer.  I'm pretty sure
>>> that everyone agrees that we have a responsibility as committers to ensure that we won't cause the tests to fail.
>>>
>>> Regards
>>> Scott
>>>
>>> On 15/12/2011, at 6:46 AM, Jacopo Cappellato wrote:
>>>
>>>> No problem: can I re-enable the tests in the meantime?
>>>>
>>>> Jacopo
>>>>
>>>> On Dec 15, 2011, at 2:30 PM, Hans Bakker wrote:
>>>>
>>>>> At the moment pretty busy with other things, will have time this weekend or next week,
>>>>>
>>>>> On 12/15/2011 08:28 PM, Jacopo Cappellato wrote:
>>>>>> Hi Hans,
>>>>>>
>>>>>> any update on this?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Jacopo
>>>>>>
>>>>>> On Dec 14, 2011, at 9:37 AM, Jacopo Cappellato wrote:
>>>>>>
>>>>>>> Hi Hans,
>>>>>>>
>>>>>>> please see inline:
>>>>>>>
>>>>>>> On Dec 14, 2011, at 8:55 AM, Hans Bakker wrote:
>>>>>>>
>>>>>>>> Hi Jacopo,
>>>>>>>>
>>>>>>>> thank you for looking into this.
>>>>>>>>
>>>>>>>> yes sure i did run ./ant run-install
>>>>>>>>
>>>>>>>> The test below needs some OrderItemBilling records for order DEMO10091 which specifies an invoiceId.
>>>>>>>> these records are however not there and therefore the invoiceId is missing.
>>>>>>>> I can also not find them anywhere in demo or test data....
>>>>>>> I think the invoice (and OrderItemBilling record) is created by the chain of events caused by the test before that one:
>>>>>>> testAcctgTransOnPoReceipts (receipt-->shipment-->invoice)
>>>>>>>
>>>>>>>> Then i disabled only the test below, and then all following tests in the same file are failing.
>>>>>>> Of course they are, because the tests in that group rely on each other.
>>>>>>>
>>>>>>>> Then I went back to a much earlier revision where the tests are failing too....A revision where i found them working is
>>>>>>>> 892749 from 2009-12-21 . So they seem to be working before...
>>>>>>>>
>>>>>>>> did you try to run the ./ant run-tests locally ? It looks like buildbot is missing these tests....
>>>>>>>>
>>>>>>> Yes, I tested the tests locally:
>>>>>>> ant clean-all
>>>>>>> ant run-install
>>>>>>> ant run-tests
>>>>>>>
>>>>>>> Jacopo
>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Hans
>>>>>>>>
>>>>>>>> On 12/14/2011 01:56 PM, Jacopo Cappellato wrote:
>>>>>>>>> Hans,
>>>>>>>>>
>>>>>>>>> did you run "ant run-install" before "ant run-tests"?
>>>>>>>>>
>>>>>>>>> I suspect that you are getting this error because in your db the order DEMO10091 is not found.
>>>>>>>>>
>>>>>>>>> Jacopo
>>>>>>>>>
>>>>>>>>> On Dec 13, 2011, at 4:56 PM, Hans Bakker wrote:
>>>>>>>>>
>>>>>>>>>> Hi Jacopo,
>>>>>>>>>>
>>>>>>>>>> this is what is reported:
>>>>>>>>>>
>>>>>>>>>> Error Message
>>>>>>>>>>
>>>>>>>>>> ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes and shipping charges and posting to
>>>>>>>>>> GL
>>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>>> 00:11:52.971(java.sql.Timestamp)][lastU
>>>>>>>>>> pdatedTxStamp,2011-12-13
>>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>>
>>>>>>>>>> Stacktrace
>>>>>>>>>>
>>>>>>>>>> junit.framework.AssertionFailedError: ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes
>>>>>>>>>> and shipping charges and posting to GL
>>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>>> 0
>>>>>>>>>> 0:11:52.971(java.sql.Timestamp)][lastUpdatedTxStamp,2011-12-13
>>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:93)
>>>>>>>>>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>>>>>>>>>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>>>>>>>>>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>>>>>>>>>> at org.ofbiz.base.start.Start.start(Start.java:289)
>>>>>>>>>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Regards,
>>>>>>>>>> Hans
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 12/13/2011 10:52 PM, Jacopo Cappellato wrote:
>>>>>>>>>>> Hans,
>>>>>>>>>>>
>>>>>>>>>>> could you please be more specific on the errors/failures you are getting?
>>>>>>>>>>> It seems I was able to run successfully all the tests.
>>>>>>>>>>>
>>>>>>>>>>> Jacopo
>>>>>>>>>>>
>>>>>>>>>>> On Dec 13, 2011, at 3:41 PM, Hans Bakker wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Yes a good idea:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4624
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Regards,
>>>>>>>>>>>> Hans
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On 12/13/2011 09:21 PM, Erwan de FERRIERES wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hans,
>>>>>>>>>>>>>
>>>>>>>>>>>>> could you create an associated Jira issue, so this won't be forgotten ?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>
>>>>>>>>>>>>> 2011/12/13
>>>>>>>>>>>>> <[hidden email]>
>>>>>>>>>>>>> :
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Author: hansbak
>>>>>>>>>>>>>> Date: Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>>> New Revision: 1213650
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>> http://svn.apache.org/viewvc?rev=1213650&view=rev
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Log:
>>>>>>>>>>>>>> commented out accounting auto tests which did not work for a long time
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>  ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Modified: ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/testdef/accountingtests.xml?rev=1213650&r1=1213649&r2=1213650&view=diff
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> ==============================================================================
>>>>>>>>>>>>>> --- ofbiz/trunk/applications/accounting/testdef/accountingtests.xml (original)
>>>>>>>>>>>>>> +++ ofbiz/trunk/applications/accounting/testdef/accountingtests.xml Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>>> @@ -29,7 +29,8 @@
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>   <test-case case-name="accounting-tests"><junit-test-suite
>>>>>>>>>>>>>> class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> -<test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>> +<!-- commented out for now...test data seems to be missing and i wondered if theyu ever worked, went back to rev:
>>>>>>>>>>>>>> 903431 and ever there the same problem -->
>>>>>>>>>>>>>> +<!-- test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>>       <simple-method-test
>>>>>>>>>>>>>> location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
>>>>>>>>>>>>>> -</test-case>
>>>>>>>>>>>>>> +</test-case-->
>>>>>>>>>>>>>> </test-suite>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>

[Jacopo Cappellato-4]

Jacques, Hans,

could you please try if with the below modifications the tests are successful?

Thanks,

Jacopo





Index: applications/accounting/testdef/accountingtests.xml
===================================================================
--- applications/accounting/testdef/accountingtests.xml (revision 1215052)
+++ applications/accounting/testdef/accountingtests.xml (working copy)
@@ -30,7 +30,7 @@
     <test-case case-name="accounting-tests"><junit-test-suite class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>
 
     <!-- commented out for now...test data seems to be missing and i wondered if theyu ever worked, went back to rev: 903431 and ever there the same problem -->
-    <!-- test-case case-name="auto-accounting-transaction-tests">
+    <test-case case-name="auto-accounting-transaction-tests">
         <simple-method-test location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
-    </test-case-->
+    </test-case>
 </test-suite>
Index: build.xml
===================================================================
--- build.xml (revision 1215052)
+++ build.xml (working copy)
@@ -28,6 +28,7 @@
     <property name="memory.max.param" value="-Xmx512M"/>
     <property name="pos.memory.max.param" value="-Xmx512M"/>
     <property name="memory.maxpermsize.param" value="-XX:MaxPermSize=512m"/>
+    <property name="user.language.param" value="-Duser.language=en"/>
 
     <available file="applications/build.xml" property="applications.present"/>
     <available file="specialpurpose/build.xml" property="specialpurpose.present"/>
@@ -844,6 +845,7 @@
             <jvmarg value="${memory.initial.param}"/>
             <jvmarg value="${memory.max.param}"/>
             <jvmarg value="${memory.maxpermsize.param}"/>
+            <jvmarg value="${user.language.param}"/>
             <arg value="test"/>
             <env key="LC_ALL" value="C"/>
         </java>




On Dec 16, 2011, at 8:59 AM, Jacopo Cappellato wrote:

> ok, this is useful... it is a locale related issue and I am working on it.
>
> Jacopo
>
> On Dec 16, 2011, at 5:45 AM, Jacques Le Roux wrote:
>
>> Hi,
>>
>> on XP 32bits here (*French context*), using
>>
>> java version "1.6.0_29"
>> Java(TM) SE Runtime Environment (build 1.6.0_29-b11)
>> Java HotSpot(TM) Client VM (build 20.4-b02, mixed mode, sharing)
>>
>> with
>> svn up (r1215035)
>> ant clean-all run-install run-tests I get
>>
>> BUILD FAILED
>> D:\workspace\ofbizClean\build.xml:857: Test run was unsuccessful
>>
>> Tests Failures Errors Success rate Time
>> 869     17         0         98.04%     401.827
>> Note: failures are anticipated and checked for with assertions while errors are unanticipated.
>>
>> Details:
>> baseteststestWithVerbosityFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>>
>> junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testWithVerbosity(FlexibleStringExpanderTests.java:264)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 1.031 baseteststestQuietlyFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>>
>> junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testQuietly(FlexibleStringExpanderTests.java:268)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 0.219 baseteststestFlexibleMapAccessorFailurefoo:get expected:<The total is $12,345,678.90.> but was:<The total is 12 345 678,90
>> $US.>
>>
>> junit.framework.AssertionFailedError: foo:get expected: but was:
>> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:343)
>> at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.fmaTest(FlexibleMapAccessorTests.java:86)
>> at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.testFlexibleMapAccessor(FlexibleMapAccessorTests.java:141)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 0.000 baseteststestReadWriteObjectFailurewrite stream java.lang.Boolean expected:<......> but was:<... ...>
>>
>> junit.framework.ComparisonFailure: write stream java.lang.Boolean expected:<......> but was:<...
>> ...>
>> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
>> at org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:147)
>> at org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:155)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 0.000 invoicetestsauto-invoice-tests.testInvoiceWorkerGetInvoiceTotalFailureAssertion failed: [invoiceTotal=323.54] equals
>> [amount=323] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=323.54] equals [amount=323] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>
>> HTH
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> I agree with Scott. A number of us have tried running the tests with no problem, so it must be a local issue. Let's get them
>>> enabled again.
>>>
>>> -Adrian
>>>
>>> On 12/15/2011 10:56 PM, Scott Gray wrote:
>>>> My vote would be to re-enable them regardless, the whole point of the tests is to ensure stability and disabling tests that
>>>> (allegedly) fail does nothing to further that goal.
>>>>
>>>> The correct approach is to find the commit that caused the failure and make a lot of noise to that committer.  I'm pretty sure
>>>> that everyone agrees that we have a responsibility as committers to ensure that we won't cause the tests to fail.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 15/12/2011, at 6:46 AM, Jacopo Cappellato wrote:
>>>>
>>>>> No problem: can I re-enable the tests in the meantime?
>>>>>
>>>>> Jacopo
>>>>>
>>>>> On Dec 15, 2011, at 2:30 PM, Hans Bakker wrote:
>>>>>
>>>>>> At the moment pretty busy with other things, will have time this weekend or next week,
>>>>>>
>>>>>> On 12/15/2011 08:28 PM, Jacopo Cappellato wrote:
>>>>>>> Hi Hans,
>>>>>>>
>>>>>>> any update on this?
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jacopo
>>>>>>>
>>>>>>> On Dec 14, 2011, at 9:37 AM, Jacopo Cappellato wrote:
>>>>>>>
>>>>>>>> Hi Hans,
>>>>>>>>
>>>>>>>> please see inline:
>>>>>>>>
>>>>>>>> On Dec 14, 2011, at 8:55 AM, Hans Bakker wrote:
>>>>>>>>
>>>>>>>>> Hi Jacopo,
>>>>>>>>>
>>>>>>>>> thank you for looking into this.
>>>>>>>>>
>>>>>>>>> yes sure i did run ./ant run-install
>>>>>>>>>
>>>>>>>>> The test below needs some OrderItemBilling records for order DEMO10091 which specifies an invoiceId.
>>>>>>>>> these records are however not there and therefore the invoiceId is missing.
>>>>>>>>> I can also not find them anywhere in demo or test data....
>>>>>>>> I think the invoice (and OrderItemBilling record) is created by the chain of events caused by the test before that one:
>>>>>>>> testAcctgTransOnPoReceipts (receipt-->shipment-->invoice)
>>>>>>>>
>>>>>>>>> Then i disabled only the test below, and then all following tests in the same file are failing.
>>>>>>>> Of course they are, because the tests in that group rely on each other.
>>>>>>>>
>>>>>>>>> Then I went back to a much earlier revision where the tests are failing too....A revision where i found them working is
>>>>>>>>> 892749 from 2009-12-21 . So they seem to be working before...
>>>>>>>>>
>>>>>>>>> did you try to run the ./ant run-tests locally ? It looks like buildbot is missing these tests....
>>>>>>>>>
>>>>>>>> Yes, I tested the tests locally:
>>>>>>>> ant clean-all
>>>>>>>> ant run-install
>>>>>>>> ant run-tests
>>>>>>>>
>>>>>>>> Jacopo
>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Hans
>>>>>>>>>
>>>>>>>>> On 12/14/2011 01:56 PM, Jacopo Cappellato wrote:
>>>>>>>>>> Hans,
>>>>>>>>>>
>>>>>>>>>> did you run "ant run-install" before "ant run-tests"?
>>>>>>>>>>
>>>>>>>>>> I suspect that you are getting this error because in your db the order DEMO10091 is not found.
>>>>>>>>>>
>>>>>>>>>> Jacopo
>>>>>>>>>>
>>>>>>>>>> On Dec 13, 2011, at 4:56 PM, Hans Bakker wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Jacopo,
>>>>>>>>>>>
>>>>>>>>>>> this is what is reported:
>>>>>>>>>>>
>>>>>>>>>>> Error Message
>>>>>>>>>>>
>>>>>>>>>>> ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes and shipping charges and posting to
>>>>>>>>>>> GL
>>>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>>>> 00:11:52.971(java.sql.Timestamp)][lastU
>>>>>>>>>>> pdatedTxStamp,2011-12-13
>>>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>>>
>>>>>>>>>>> Stacktrace
>>>>>>>>>>>
>>>>>>>>>>> junit.framework.AssertionFailedError: ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes
>>>>>>>>>>> and shipping charges and posting to GL
>>>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>>>> 0
>>>>>>>>>>> 0:11:52.971(java.sql.Timestamp)][lastUpdatedTxStamp,2011-12-13
>>>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:93)
>>>>>>>>>>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>>>>>>>>>>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>>>>>>>>>>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>>>>>>>>>>> at org.ofbiz.base.start.Start.start(Start.java:289)
>>>>>>>>>>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Regards,
>>>>>>>>>>> Hans
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 12/13/2011 10:52 PM, Jacopo Cappellato wrote:
>>>>>>>>>>>> Hans,
>>>>>>>>>>>>
>>>>>>>>>>>> could you please be more specific on the errors/failures you are getting?
>>>>>>>>>>>> It seems I was able to run successfully all the tests.
>>>>>>>>>>>>
>>>>>>>>>>>> Jacopo
>>>>>>>>>>>>
>>>>>>>>>>>> On Dec 13, 2011, at 3:41 PM, Hans Bakker wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Yes a good idea:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4624
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>> Hans
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 12/13/2011 09:21 PM, Erwan de FERRIERES wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hans,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> could you create an associated Jira issue, so this won't be forgotten ?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 2011/12/13
>>>>>>>>>>>>>> <[hidden email]>
>>>>>>>>>>>>>> :
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Author: hansbak
>>>>>>>>>>>>>>> Date: Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>>>> New Revision: 1213650
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>> http://svn.apache.org/viewvc?rev=1213650&view=rev
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Log:
>>>>>>>>>>>>>>> commented out accounting auto tests which did not work for a long time
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>> ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Modified: ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/testdef/accountingtests.xml?rev=1213650&r1=1213649&r2=1213650&view=diff
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ==============================================================================
>>>>>>>>>>>>>>> --- ofbiz/trunk/applications/accounting/testdef/accountingtests.xml (original)
>>>>>>>>>>>>>>> +++ ofbiz/trunk/applications/accounting/testdef/accountingtests.xml Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>>>> @@ -29,7 +29,8 @@
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>  <test-case case-name="accounting-tests"><junit-test-suite
>>>>>>>>>>>>>>> class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> -<test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>>> +<!-- commented out for now...test data seems to be missing and i wondered if theyu ever worked, went back to rev:
>>>>>>>>>>>>>>> 903431 and ever there the same problem -->
>>>>>>>>>>>>>>> +<!-- test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>>>      <simple-method-test
>>>>>>>>>>>>>>> location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
>>>>>>>>>>>>>>> -</test-case>
>>>>>>>>>>>>>>> +</test-case-->
>>>>>>>>>>>>>>> </test-suite>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>

[Jacques Le Roux]

Hi Jacopo,

Unfortunately not all, still

BUILD FAILED
D:\workspace\ofbizClean\build.xml:859: Test run was unsuccessful

But with only one failure

basetests testReadWriteObject Failure write stream java.lang.Boolean expected:<......> but was:<... ...>

junit.framework.ComparisonFailure: write stream java.lang.Boolean expected:<......> but was:<...
...>
at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
at org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:147)
at org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:155)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
at org.ofbiz.base.start.Start.start(Start.java:289)
at org.ofbiz.base.start.Start.main(Start.java:119)

Weird though, the lines are

checkBasicReadWriteObject(Boolean.TRUE, "java.lang.Boolean:true\n");
calling
assertEquals("write stream " + value.getClass().getName(), text, new String(baos.toByteArray(), "UTF-8"));

I wondered if it could be due to http://svn.apache.org/viewvc?rev=1214124&view=rev but I got no chance to look further (and would be
surprised because r1214124 is safe in buildbot)

HTH


Jacques

----- Original Message -----
From: "Jacopo Cappellato" <[hidden email]>
To: <[hidden email]>
Sent: Friday, December 16, 2011 10:12 AM
Subject: Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml


Jacques, Hans,

could you please try if with the below modifications the tests are successful?

Thanks,

Jacopo




--------------------------------------------------------------------------------





Index: applications/accounting/testdef/accountingtests.xml
===================================================================
--- applications/accounting/testdef/accountingtests.xml (revision 1215052)
+++ applications/accounting/testdef/accountingtests.xml (working copy)
@@ -30,7 +30,7 @@
     <test-case case-name="accounting-tests"><junit-test-suite class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>

     <!-- commented out for now...test data seems to be missing and i wondered if theyu ever worked, went back to rev: 903431 and
ever there the same problem -->
-    <!-- test-case case-name="auto-accounting-transaction-tests">
+    <test-case case-name="auto-accounting-transaction-tests">
         <simple-method-test location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
-    </test-case-->
+    </test-case>
 </test-suite>
Index: build.xml
===================================================================
--- build.xml (revision 1215052)
+++ build.xml (working copy)
@@ -28,6 +28,7 @@
     <property name="memory.max.param" value="-Xmx512M"/>
     <property name="pos.memory.max.param" value="-Xmx512M"/>
     <property name="memory.maxpermsize.param" value="-XX:MaxPermSize=512m"/>
+    <property name="user.language.param" value="-Duser.language=en"/>

     <available file="applications/build.xml" property="applications.present"/>
     <available file="specialpurpose/build.xml" property="specialpurpose.present"/>
@@ -844,6 +845,7 @@
             <jvmarg value="${memory.initial.param}"/>
             <jvmarg value="${memory.max.param}"/>
             <jvmarg value="${memory.maxpermsize.param}"/>
+            <jvmarg value="${user.language.param}"/>
             <arg value="test"/>
             <env key="LC_ALL" value="C"/>
         </java>




On Dec 16, 2011, at 8:59 AM, Jacopo Cappellato wrote:

> ok, this is useful... it is a locale related issue and I am working on it.
>
> Jacopo
>
> On Dec 16, 2011, at 5:45 AM, Jacques Le Roux wrote:
>
>> Hi,
>>
>> on XP 32bits here (*French context*), using
>>
>> java version "1.6.0_29"
>> Java(TM) SE Runtime Environment (build 1.6.0_29-b11)
>> Java HotSpot(TM) Client VM (build 20.4-b02, mixed mode, sharing)
>>
>> with
>> svn up (r1215035)
>> ant clean-all run-install run-tests I get
>>
>> BUILD FAILED
>> D:\workspace\ofbizClean\build.xml:857: Test run was unsuccessful
>>
>> Tests Failures Errors Success rate Time
>> 869     17         0         98.04%     401.827
>> Note: failures are anticipated and checked for with assertions while errors are unanticipated.
>>
>> Details:
>> baseteststestWithVerbosityFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>>
>> junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testWithVerbosity(FlexibleStringExpanderTests.java:264)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 1.031 baseteststestQuietlyFailurenested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>>
>> junit.framework.ComparisonFailure: nested UEL integration(return BigDecimal) expected:<...,234,567....> but was:<... 234 567,...>
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.doFseTest(FlexibleStringExpanderTests.java:136)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.fseTest(FlexibleStringExpanderTests.java:196)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.everythingTest(FlexibleStringExpanderTests.java:338)
>> at org.ofbiz.base.util.string.test.FlexibleStringExpanderTests.testQuietly(FlexibleStringExpanderTests.java:268)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 0.219 baseteststestFlexibleMapAccessorFailurefoo:get expected:<The total is $12,345,678.90.> but was:<The total is 12 345 678,90
>> $US.>
>>
>> junit.framework.AssertionFailedError: foo:get expected: but was:
>> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:343)
>> at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.fmaTest(FlexibleMapAccessorTests.java:86)
>> at org.ofbiz.base.util.collections.test.FlexibleMapAccessorTests.testFlexibleMapAccessor(FlexibleMapAccessorTests.java:141)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 0.000 baseteststestReadWriteObjectFailurewrite stream java.lang.Boolean expected:<......> but was:<... ...>
>>
>> junit.framework.ComparisonFailure: write stream java.lang.Boolean expected:<......> but was:<...
>> ...>
>> at org.ofbiz.base.test.GenericTestCaseBase.assertEquals(GenericTestCaseBase.java:313)
>> at org.ofbiz.base.util.test.UtilIOTests.checkBasicReadWriteObject(UtilIOTests.java:147)
>> at org.ofbiz.base.util.test.UtilIOTests.testReadWriteObject(UtilIOTests.java:155)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> 0.000 invoicetestsauto-invoice-tests.testInvoiceWorkerGetInvoiceTotalFailureAssertion failed: [invoiceTotal=323.54] equals
>> [amount=323] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=323.54] equals [amount=323] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=56.99] equals [amount=56] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=543.23] equals [amount=543] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=511.23] equals [amount=511] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=33.99] equals [amount=33] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=46.43] equals [amount=46] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=36.43] equals [amount=36] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=127.09] equals [amount=127] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>> Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
>>
>> junit.framework.AssertionFailedError: Assertion failed: [invoiceTotal=179.97] equals [amount=179] as BigDecimal
>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:100)
>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>> at org.ofbiz.base.start.Start.start(Start.java:289)
>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>
>> HTH
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> I agree with Scott. A number of us have tried running the tests with no problem, so it must be a local issue. Let's get them
>>> enabled again.
>>>
>>> -Adrian
>>>
>>> On 12/15/2011 10:56 PM, Scott Gray wrote:
>>>> My vote would be to re-enable them regardless, the whole point of the tests is to ensure stability and disabling tests that
>>>> (allegedly) fail does nothing to further that goal.
>>>>
>>>> The correct approach is to find the commit that caused the failure and make a lot of noise to that committer.  I'm pretty sure
>>>> that everyone agrees that we have a responsibility as committers to ensure that we won't cause the tests to fail.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> On 15/12/2011, at 6:46 AM, Jacopo Cappellato wrote:
>>>>
>>>>> No problem: can I re-enable the tests in the meantime?
>>>>>
>>>>> Jacopo
>>>>>
>>>>> On Dec 15, 2011, at 2:30 PM, Hans Bakker wrote:
>>>>>
>>>>>> At the moment pretty busy with other things, will have time this weekend or next week,
>>>>>>
>>>>>> On 12/15/2011 08:28 PM, Jacopo Cappellato wrote:
>>>>>>> Hi Hans,
>>>>>>>
>>>>>>> any update on this?
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jacopo
>>>>>>>
>>>>>>> On Dec 14, 2011, at 9:37 AM, Jacopo Cappellato wrote:
>>>>>>>
>>>>>>>> Hi Hans,
>>>>>>>>
>>>>>>>> please see inline:
>>>>>>>>
>>>>>>>> On Dec 14, 2011, at 8:55 AM, Hans Bakker wrote:
>>>>>>>>
>>>>>>>>> Hi Jacopo,
>>>>>>>>>
>>>>>>>>> thank you for looking into this.
>>>>>>>>>
>>>>>>>>> yes sure i did run ./ant run-install
>>>>>>>>>
>>>>>>>>> The test below needs some OrderItemBilling records for order DEMO10091 which specifies an invoiceId.
>>>>>>>>> these records are however not there and therefore the invoiceId is missing.
>>>>>>>>> I can also not find them anywhere in demo or test data....
>>>>>>>> I think the invoice (and OrderItemBilling record) is created by the chain of events caused by the test before that one:
>>>>>>>> testAcctgTransOnPoReceipts (receipt-->shipment-->invoice)
>>>>>>>>
>>>>>>>>> Then i disabled only the test below, and then all following tests in the same file are failing.
>>>>>>>> Of course they are, because the tests in that group rely on each other.
>>>>>>>>
>>>>>>>>> Then I went back to a much earlier revision where the tests are failing too....A revision where i found them working is
>>>>>>>>> 892749 from 2009-12-21 . So they seem to be working before...
>>>>>>>>>
>>>>>>>>> did you try to run the ./ant run-tests locally ? It looks like buildbot is missing these tests....
>>>>>>>>>
>>>>>>>> Yes, I tested the tests locally:
>>>>>>>> ant clean-all
>>>>>>>> ant run-install
>>>>>>>> ant run-tests
>>>>>>>>
>>>>>>>> Jacopo
>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Hans
>>>>>>>>>
>>>>>>>>> On 12/14/2011 01:56 PM, Jacopo Cappellato wrote:
>>>>>>>>>> Hans,
>>>>>>>>>>
>>>>>>>>>> did you run "ant run-install" before "ant run-tests"?
>>>>>>>>>>
>>>>>>>>>> I suspect that you are getting this error because in your db the order DEMO10091 is not found.
>>>>>>>>>>
>>>>>>>>>> Jacopo
>>>>>>>>>>
>>>>>>>>>> On Dec 13, 2011, at 4:56 PM, Hans Bakker wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Jacopo,
>>>>>>>>>>>
>>>>>>>>>>> this is what is reported:
>>>>>>>>>>>
>>>>>>>>>>> Error Message
>>>>>>>>>>>
>>>>>>>>>>> ERROR: Could not complete the Test case for Purchase Invoices: editing, adding taxes and shipping charges and posting to
>>>>>>>>>>> GL
>>>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13
>>>>>>>>>>> 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>>>> 00:11:52.971(java.sql.Timestamp)][lastU
>>>>>>>>>>> pdatedTxStamp,2011-12-13
>>>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>>>
>>>>>>>>>>> Stacktrace
>>>>>>>>>>>
>>>>>>>>>>> junit.framework.AssertionFailedError: ERROR: Could not complete the Test case for Purchase Invoices: editing, adding
>>>>>>>>>>> taxes
>>>>>>>>>>> and shipping charges and posting to GL
>>>>>>>>>>> [file:/data/jenkins/trunk/applications/accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml#testAcctgTransOnEditPoInvoice
>>>>>>>>>>> ] process [problem invoking the [setInvoiceStatus] service with the map named [serviceCtx] containing
>>>>>>>>>>> [{userLogin=[GenericEntity:UserLogin][createdStamp,2011-12-13
>>>>>>>>>>> 00:10:24.573(java.sql.Timestamp)][createdTxStamp,2011-12-13
>>>>>>>>>>> 00:10:24.348(java.sql.Timestamp)][currentPassword,null()][disabledDateTime,null()][enabled,N(java.lang.String)][externalAuthId,null()][hasLoggedOut,null()][isSystem,Y(java.lang.String)][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2011-12-13
>>>>>>>>>>> 0
>>>>>>>>>>> 0:11:52.971(java.sql.Timestamp)][lastUpdatedTxStamp,2011-12-13
>>>>>>>>>>> 00:11:52.86(java.sql.Timestamp)][partyId,system(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,system(java.lang.String)],
>>>>>>>>>>> statusId=INVOICE_READY, locale=en_US}]: The following required parameter is missing: [IN] [setInvoiceStatus.invoiceId]]
>>>>>>>>>>> at org.ofbiz.testtools.SimpleMethodTest.run(SimpleMethodTest.java:93)
>>>>>>>>>>> at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
>>>>>>>>>>> at org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:230)
>>>>>>>>>>> at org.ofbiz.base.start.Start.startStartLoaders(Start.java:310)
>>>>>>>>>>> at org.ofbiz.base.start.Start.start(Start.java:289)
>>>>>>>>>>> at org.ofbiz.base.start.Start.main(Start.java:119)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Regards,
>>>>>>>>>>> Hans
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 12/13/2011 10:52 PM, Jacopo Cappellato wrote:
>>>>>>>>>>>> Hans,
>>>>>>>>>>>>
>>>>>>>>>>>> could you please be more specific on the errors/failures you are getting?
>>>>>>>>>>>> It seems I was able to run successfully all the tests.
>>>>>>>>>>>>
>>>>>>>>>>>> Jacopo
>>>>>>>>>>>>
>>>>>>>>>>>> On Dec 13, 2011, at 3:41 PM, Hans Bakker wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Yes a good idea:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4624
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Regards,
>>>>>>>>>>>>> Hans
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 12/13/2011 09:21 PM, Erwan de FERRIERES wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hans,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> could you create an associated Jira issue, so this won't be forgotten ?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> 2011/12/13
>>>>>>>>>>>>>> <[hidden email]>
>>>>>>>>>>>>>> :
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Author: hansbak
>>>>>>>>>>>>>>> Date: Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>>>> New Revision: 1213650
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>> http://svn.apache.org/viewvc?rev=1213650&view=rev
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Log:
>>>>>>>>>>>>>>> commented out accounting auto tests which did not work for a long time
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Modified:
>>>>>>>>>>>>>>> ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Modified: ofbiz/trunk/applications/accounting/testdef/accountingtests.xml
>>>>>>>>>>>>>>> URL:
>>>>>>>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/testdef/accountingtests.xml?rev=1213650&r1=1213649&r2=1213650&view=diff
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> ==============================================================================
>>>>>>>>>>>>>>> --- ofbiz/trunk/applications/accounting/testdef/accountingtests.xml (original)
>>>>>>>>>>>>>>> +++ ofbiz/trunk/applications/accounting/testdef/accountingtests.xml Tue Dec 13 11:04:57 2011
>>>>>>>>>>>>>>> @@ -29,7 +29,8 @@
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>  <test-case case-name="accounting-tests"><junit-test-suite
>>>>>>>>>>>>>>> class-name="org.ofbiz.accounting.test.FinAccountTests"/></test-case>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> -<test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>>> +<!-- commented out for now...test data seems to be missing and i wondered if theyu ever worked, went back to rev:
>>>>>>>>>>>>>>> 903431 and ever there the same problem -->
>>>>>>>>>>>>>>> +<!-- test-case case-name="auto-accounting-transaction-tests">
>>>>>>>>>>>>>>>      <simple-method-test
>>>>>>>>>>>>>>> location="component://accounting/script/org/ofbiz/accounting/test/AutoAcctgTransTests.xml"/>
>>>>>>>>>>>>>>> -</test-case>
>>>>>>>>>>>>>>> +</test-case-->
>>>>>>>>>>>>>>> </test-suite>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>

[Adrian Crum-3]

Jacopo,

Setting the language on the command line should not have any effect
because OFBiz sets the language when it starts up. See the
ofbiz.locale.default setting in start.properties.

I can duplicate the test failures by changing that setting to some other
locale. That is why I thought it is a local issue - the tests are based
on OOTB settings, and if you change the settings the tests will fail.

-Adrian


On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
> Jacques, Hans,
>
> could you please try if with the below modifications the tests are successful?
>
> Thanks,
>
> Jacopo
>

[hans_bakker]

tests fail here with OOTB settings

On 12/16/2011 05:14 PM, Adrian Crum wrote:

> Jacopo,
>
> Setting the language on the command line should not have any effect
> because OFBiz sets the language when it starts up. See the
> ofbiz.locale.default setting in start.properties.
>
> I can duplicate the test failures by changing that setting to some
> other locale. That is why I thought it is a local issue - the tests
> are based on OOTB settings, and if you change the settings the tests
> will fail.
>
> -Adrian
>
>
> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>> Jacques, Hans,
>>
>> could you please try if with the below modifications the tests are
>> successful?
>>
>> Thanks,
>>
>> Jacopo
>>

[Jacopo Cappellato-4]

Adrian,

I doubt that that code is executed when run-tests is called.

Jacopo

On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:

> Jacopo,
>
> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>
> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>
> -Adrian
>
>
> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>> Jacques, Hans,
>>
>> could you please try if with the below modifications the tests are successful?
>>
>> Thanks,
>>
>> Jacopo
>>

[Jacopo Cappellato-4]

I am pretty sure it happens because of the locale in your pc: I guess you are not using "en", right?

Jacopo

On Dec 16, 2011, at 11:27 AM, Hans Bakker wrote:

> tests fail here with OOTB settings
>
> On 12/16/2011 05:14 PM, Adrian Crum wrote:
>> Jacopo,
>>
>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>
>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>
>> -Adrian
>>
>>
>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>> Jacques, Hans,
>>>
>>> could you please try if with the below modifications the tests are successful?
>>>
>>> Thanks,
>>>
>>> Jacopo
>>>
>

[Jacopo Cappellato-4]

Hans,

please also confirm that the tests are failing even after you have disabled accounting tests...

Thanks,

Jacopo

On Dec 16, 2011, at 11:27 AM, Hans Bakker wrote:

> tests fail here with OOTB settings
>
> On 12/16/2011 05:14 PM, Adrian Crum wrote:
>> Jacopo,
>>
>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>
>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>
>> -Adrian
>>
>>
>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>> Jacques, Hans,
>>>
>>> could you please try if with the below modifications the tests are successful?
>>>
>>> Thanks,
>>>
>>> Jacopo
>>>
>

[Adrian Crum-3]

Huh? Start.java is not executed when run-tests is called??!!

-Adrian

On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:

> Adrian,
>
> I doubt that that code is executed when run-tests is called.
>
> Jacopo
>
> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>
>> Jacopo,
>>
>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>
>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>
>> -Adrian
>>
>>
>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>> Jacques, Hans,
>>>
>>> could you please try if with the below modifications the tests are successful?
>>>
>>> Thanks,
>>>
>>> Jacopo
>>>

[Jacques Le Roux]

Actually if you look at my last results you will see all locale related issues have disappeared using Jacopo's fix

Only remains the weird Boolean stuff I reported

HTH

Jacques

From: "Adrian Crum" <[hidden email]>

> Huh? Start.java is not executed when run-tests is called??!!
>
> -Adrian
>
> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>> Adrian,
>>
>> I doubt that that code is executed when run-tests is called.
>>
>> Jacopo
>>
>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>
>>> Jacopo,
>>>
>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the
>>> ofbiz.locale.default setting in start.properties.
>>>
>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the
>>> tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>
>>> -Adrian
>>>
>>>
>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>> Jacques, Hans,
>>>>
>>>> could you please try if with the below modifications the tests are successful?
>>>>
>>>> Thanks,
>>>>
>>>> Jacopo
>>>>

[Adrian Crum-3]

Maybe the problem is due to a missing ofbiz.locale.default setting in
test.properties.

-Adrian

On 12/16/2011 12:23 PM, Jacques Le Roux wrote:

> Actually if you look at my last results you will see all locale
> related issues have disappeared using Jacopo's fix
>
> Only remains the weird Boolean stuff I reported
>
> HTH
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> Huh? Start.java is not executed when run-tests is called??!!
>>
>> -Adrian
>>
>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>> Adrian,
>>>
>>> I doubt that that code is executed when run-tests is called.
>>>
>>> Jacopo
>>>
>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>
>>>> Jacopo,
>>>>
>>>> Setting the language on the command line should not have any effect
>>>> because OFBiz sets the language when it starts up. See the
>>>> ofbiz.locale.default setting in start.properties.
>>>>
>>>> I can duplicate the test failures by changing that setting to some
>>>> other locale. That is why I thought it is a local issue - the
>>>> tests are based on OOTB settings, and if you change the settings
>>>> the tests will fail.
>>>>
>>>> -Adrian
>>>>
>>>>
>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>> Jacques, Hans,
>>>>>
>>>>> could you please try if with the below modifications the tests are
>>>>> successful?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jacopo
>>>>>

[Jacopo Cappellato-4]

No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am investigating into this now

Jacopo

On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:

> Huh? Start.java is not executed when run-tests is called??!!
>
> -Adrian
>
> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>> Adrian,
>>
>> I doubt that that code is executed when run-tests is called.
>>
>> Jacopo
>>
>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>
>>> Jacopo,
>>>
>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>>
>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>
>>> -Adrian
>>>
>>>
>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>> Jacques, Hans,
>>>>
>>>> could you please try if with the below modifications the tests are successful?
>>>>
>>>> Thanks,
>>>>
>>>> Jacopo
>>>>

[Adrian Crum-3]

There is no need to investigate - I wrote that code and I can assure you
the locale and time zone is always set when OFBiz starts. The problem is
an incorrect (or missing) setting in one of the properties files - see
my previous reply to Jacques.

-Adrian

On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:

> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am investigating into this now
>
> Jacopo
>
> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>
>> Huh? Start.java is not executed when run-tests is called??!!
>>
>> -Adrian
>>
>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>> Adrian,
>>>
>>> I doubt that that code is executed when run-tests is called.
>>>
>>> Jacopo
>>>
>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>
>>>> Jacopo,
>>>>
>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>>>
>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>
>>>> -Adrian
>>>>
>>>>
>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>> Jacques, Hans,
>>>>>
>>>>> could you please try if with the below modifications the tests are successful?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jacopo
>>>>>

[Jacopo Cappellato-4]

Yes, right, a few minutes ago I have committed the fix you suggested.
I doubt it will fix the issue Jacques reported... but that may be unrelated to locale.... Jacques, is there any chance that you have some local modifications?

Jacopo

On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:

> There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques.
>
> -Adrian
>
> On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
>> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am investigating into this now
>>
>> Jacopo
>>
>> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>>
>>> Huh? Start.java is not executed when run-tests is called??!!
>>>
>>> -Adrian
>>>
>>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>>> Adrian,
>>>>
>>>> I doubt that that code is executed when run-tests is called.
>>>>
>>>> Jacopo
>>>>
>>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>>
>>>>> Jacopo,
>>>>>
>>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>>>>
>>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>>
>>>>> -Adrian
>>>>>
>>>>>
>>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>>> Jacques, Hans,
>>>>>>
>>>>>> could you please try if with the below modifications the tests are successful?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Jacopo
>>>>>>

[Adrian Crum-3]

I believe the base test failures are a timing issue, but I can't be sure
because I haven't looked into it thoroughly. I am confident they have
nothing to do with locale, however.

-Adrian

On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:

> Yes, right, a few minutes ago I have committed the fix you suggested.
> I doubt it will fix the issue Jacques reported... but that may be unrelated to locale.... Jacques, is there any chance that you have some local modifications?
>
> Jacopo
>
> On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
>
>> There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques.
>>
>> -Adrian
>>
>> On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
>>> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am investigating into this now
>>>
>>> Jacopo
>>>
>>> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>>>
>>>> Huh? Start.java is not executed when run-tests is called??!!
>>>>
>>>> -Adrian
>>>>
>>>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>>>> Adrian,
>>>>>
>>>>> I doubt that that code is executed when run-tests is called.
>>>>>
>>>>> Jacopo
>>>>>
>>>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>>>
>>>>>> Jacopo,
>>>>>>
>>>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties.
>>>>>>
>>>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>>>
>>>>>> -Adrian
>>>>>>
>>>>>>
>>>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>>>> Jacques, Hans,
>>>>>>>
>>>>>>> could you please try if with the below modifications the tests are successful?
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Jacopo
>>>>>>>

[Jacques Le Roux]

OK Guys,

I will check that tonight...

Thanks for the effort!

Jacques

From: "Adrian Crum" <[hidden email]>

>I believe the base test failures are a timing issue, but I can't be sure because I haven't looked into it thoroughly. I am
>confident they have nothing to do with locale, however.
>
> -Adrian
>
> On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
>> Yes, right, a few minutes ago I have committed the fix you suggested.
>> I doubt it will fix the issue Jacques reported... but that may be unrelated to locale.... Jacques, is there any chance that you
>> have some local modifications?
>>
>> Jacopo
>>
>> On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
>>
>>> There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz
>>> starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques.
>>>
>>> -Adrian
>>>
>>> On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
>>>> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am
>>>> investigating into this now
>>>>
>>>> Jacopo
>>>>
>>>> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>>>>
>>>>> Huh? Start.java is not executed when run-tests is called??!!
>>>>>
>>>>> -Adrian
>>>>>
>>>>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>>>>> Adrian,
>>>>>>
>>>>>> I doubt that that code is executed when run-tests is called.
>>>>>>
>>>>>> Jacopo
>>>>>>
>>>>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>>>>
>>>>>>> Jacopo,
>>>>>>>
>>>>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See
>>>>>>> the ofbiz.locale.default setting in start.properties.
>>>>>>>
>>>>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue -
>>>>>>> the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>>>>
>>>>>>> -Adrian
>>>>>>>
>>>>>>>
>>>>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>>>>> Jacques, Hans,
>>>>>>>>
>>>>>>>> could you please try if with the below modifications the tests are successful?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>>
>>>>>>>> Jacopo
>>>>>>>>

[Jacques Le Roux]

Same Boolean issue as expected

Jacques

From: "Jacques Le Roux" <[hidden email]>

> OK Guys,
>
> I will check that tonight...
>
> Thanks for the effort!
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>>I believe the base test failures are a timing issue, but I can't be sure because I haven't looked into it thoroughly. I am
>>confident they have nothing to do with locale, however.
>>
>> -Adrian
>>
>> On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
>>> Yes, right, a few minutes ago I have committed the fix you suggested.
>>> I doubt it will fix the issue Jacques reported... but that may be unrelated to locale.... Jacques, is there any chance that you
>>> have some local modifications?
>>>
>>> Jacopo
>>>
>>> On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
>>>
>>>> There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz
>>>> starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques.
>>>>
>>>> -Adrian
>>>>
>>>> On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
>>>>> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am
>>>>> investigating into this now
>>>>>
>>>>> Jacopo
>>>>>
>>>>> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>>>>>
>>>>>> Huh? Start.java is not executed when run-tests is called??!!
>>>>>>
>>>>>> -Adrian
>>>>>>
>>>>>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>>>>>> Adrian,
>>>>>>>
>>>>>>> I doubt that that code is executed when run-tests is called.
>>>>>>>
>>>>>>> Jacopo
>>>>>>>
>>>>>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>>>>>
>>>>>>>> Jacopo,
>>>>>>>>
>>>>>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See
>>>>>>>> the ofbiz.locale.default setting in start.properties.
>>>>>>>>
>>>>>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local
>>>>>>>> issue -
>>>>>>>> the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>>>>>
>>>>>>>> -Adrian
>>>>>>>>
>>>>>>>>
>>>>>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>>>>>> Jacques, Hans,
>>>>>>>>>
>>>>>>>>> could you please try if with the below modifications the tests are successful?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>>
>>>>>>>>> Jacopo
>>>>>>>>>

[Jacopo Cappellato-4]

Hi Jacques,

I suspect this is a problem with the end of line... are you running on Windows? Could you please try if the patch below fixes the test?

Thanks,

Jacopo

Index: framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java
===================================================================
--- framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (revision 1215052)
+++ framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (working copy)
@@ -39,6 +39,7 @@
 
 @SourceMonitored
 public class UtilIOTests extends GenericTestCaseBase {
+    private String lineSeparator = System.getProperty("line.separator");
     private static final byte[] trademarkBytes = new byte[] {
         (byte) 0xE2, (byte) 0x84, (byte) 0xA2
     };
@@ -152,7 +153,7 @@
     }
 
     public void testReadWriteObject() throws Exception {
-        checkBasicReadWriteObject(Boolean.TRUE, "java.lang.Boolean:true\n");
+        checkBasicReadWriteObject(Boolean.TRUE, "java.lang.Boolean:true" + lineSeparator);
         checkBasicReadWriteObject(Byte.valueOf("1"), "java.lang.Byte:1\n");
         checkBasicReadWriteObject(Double.valueOf("1.0"), "java.lang.Double:1.0\n");
         checkBasicReadWriteObject(Float.valueOf("1.0"), "java.lang.Float:1.0\n");



On Dec 16, 2011, at 5:51 PM, Jacques Le Roux wrote:

> Same Boolean issue as expected
>
> Jacques
>
> From: "Jacques Le Roux" <[hidden email]>
>> OK Guys,
>>
>> I will check that tonight...
>>
>> Thanks for the effort!
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> I believe the base test failures are a timing issue, but I can't be sure because I haven't looked into it thoroughly. I am
>>> confident they have nothing to do with locale, however.
>>>
>>> -Adrian
>>>
>>> On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
>>>> Yes, right, a few minutes ago I have committed the fix you suggested.
>>>> I doubt it will fix the issue Jacques reported... but that may be unrelated to locale.... Jacques, is there any chance that you
>>>> have some local modifications?
>>>>
>>>> Jacopo
>>>>
>>>> On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
>>>>
>>>>> There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz
>>>>> starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques.
>>>>>
>>>>> -Adrian
>>>>>
>>>>> On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
>>>>>> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am
>>>>>> investigating into this now
>>>>>>
>>>>>> Jacopo
>>>>>>
>>>>>> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>>>>>>
>>>>>>> Huh? Start.java is not executed when run-tests is called??!!
>>>>>>>
>>>>>>> -Adrian
>>>>>>>
>>>>>>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>>>>>>> Adrian,
>>>>>>>>
>>>>>>>> I doubt that that code is executed when run-tests is called.
>>>>>>>>
>>>>>>>> Jacopo
>>>>>>>>
>>>>>>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>>>>>>
>>>>>>>>> Jacopo,
>>>>>>>>>
>>>>>>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See
>>>>>>>>> the ofbiz.locale.default setting in start.properties.
>>>>>>>>>
>>>>>>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue -
>>>>>>>>> the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>>>>>>
>>>>>>>>> -Adrian
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>>>>>>> Jacques, Hans,
>>>>>>>>>>
>>>>>>>>>> could you please try if with the below modifications the tests are successful?
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>>
>>>>>>>>>> Jacopo

[Jacques Le Roux]

Hi Jacopo,

Unfortunately not: same error, pretty vicious thing, sorry no time to help today :/

Jacques

From: "Jacopo Cappellato" <[hidden email]>

> Hi Jacques,
>
> I suspect this is a problem with the end of line... are you running on Windows? Could you please try if the patch below fixes the
> test?
>
> Thanks,
>
> Jacopo
>
> Index: framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java
> ===================================================================
> --- framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (revision 1215052)
> +++ framework/base/src/org/ofbiz/base/util/test/UtilIOTests.java (working copy)
> @@ -39,6 +39,7 @@
>
> @SourceMonitored
> public class UtilIOTests extends GenericTestCaseBase {
> +    private String lineSeparator = System.getProperty("line.separator");
>     private static final byte[] trademarkBytes = new byte[] {
>         (byte) 0xE2, (byte) 0x84, (byte) 0xA2
>     };
> @@ -152,7 +153,7 @@
>     }
>
>     public void testReadWriteObject() throws Exception {
> -        checkBasicReadWriteObject(Boolean.TRUE, "java.lang.Boolean:true\n");
> +        checkBasicReadWriteObject(Boolean.TRUE, "java.lang.Boolean:true" + lineSeparator);
>         checkBasicReadWriteObject(Byte.valueOf("1"), "java.lang.Byte:1\n");
>         checkBasicReadWriteObject(Double.valueOf("1.0"), "java.lang.Double:1.0\n");
>         checkBasicReadWriteObject(Float.valueOf("1.0"), "java.lang.Float:1.0\n");
>
>
>
> On Dec 16, 2011, at 5:51 PM, Jacques Le Roux wrote:
>
>> Same Boolean issue as expected
>>
>> Jacques
>>
>> From: "Jacques Le Roux" <[hidden email]>
>>> OK Guys,
>>>
>>> I will check that tonight...
>>>
>>> Thanks for the effort!
>>>
>>> Jacques
>>>
>>> From: "Adrian Crum" <[hidden email]>
>>>> I believe the base test failures are a timing issue, but I can't be sure because I haven't looked into it thoroughly. I am
>>>> confident they have nothing to do with locale, however.
>>>>
>>>> -Adrian
>>>>
>>>> On 12/16/2011 2:25 PM, Jacopo Cappellato wrote:
>>>>> Yes, right, a few minutes ago I have committed the fix you suggested.
>>>>> I doubt it will fix the issue Jacques reported... but that may be unrelated to locale.... Jacques, is there any chance that
>>>>> you
>>>>> have some local modifications?
>>>>>
>>>>> Jacopo
>>>>>
>>>>> On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote:
>>>>>
>>>>>> There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz
>>>>>> starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques.
>>>>>>
>>>>>> -Adrian
>>>>>>
>>>>>> On 12/16/2011 1:43 PM, Jacopo Cappellato wrote:
>>>>>>> No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am
>>>>>>> investigating into this now
>>>>>>>
>>>>>>> Jacopo
>>>>>>>
>>>>>>> On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote:
>>>>>>>
>>>>>>>> Huh? Start.java is not executed when run-tests is called??!!
>>>>>>>>
>>>>>>>> -Adrian
>>>>>>>>
>>>>>>>> On 12/16/2011 11:15 AM, Jacopo Cappellato wrote:
>>>>>>>>> Adrian,
>>>>>>>>>
>>>>>>>>> I doubt that that code is executed when run-tests is called.
>>>>>>>>>
>>>>>>>>> Jacopo
>>>>>>>>>
>>>>>>>>> On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote:
>>>>>>>>>
>>>>>>>>>> Jacopo,
>>>>>>>>>>
>>>>>>>>>> Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up.
>>>>>>>>>> See
>>>>>>>>>> the ofbiz.locale.default setting in start.properties.
>>>>>>>>>>
>>>>>>>>>> I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local
>>>>>>>>>> issue -
>>>>>>>>>> the tests are based on OOTB settings, and if you change the settings the tests will fail.
>>>>>>>>>>
>>>>>>>>>> -Adrian
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 12/16/2011 9:12 AM, Jacopo Cappellato wrote:
>>>>>>>>>>> Jacques, Hans,
>>>>>>>>>>>
>>>>>>>>>>> could you please try if with the below modifications the tests are successful?
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>>
>>>>>>>>>>> Jacopo
>
>