Re: svn commit: r1243116 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1243116 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

Jacques Le Roux
Administrator
Not really a problem for me (I don't see any risks) but this is not really a bug fix and I see backports in 10 and 11 versions ;o)

Jacques

From: <[hidden email]>

> Author: apatel
> Date: Sat Feb 11 18:30:25 2012
> New Revision: 1243116
>
> URL: http://svn.apache.org/viewvc?rev=1243116&view=rev
> Log:
> Set partyId and roleTypeId for invoiced Party. This helps to figure out glAccount associated with Party.
>
> Modified:
>    ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>
> Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1243116&r1=1243115&r2=1243116&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml (original)
> +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml Sat Feb 11 18:30:25 2012
> @@ -2321,6 +2321,8 @@ under the License.
>             <set field="createAcctgTransAndEntriesInMap.glFiscalTypeId" value="ACTUAL"/>
>             <set field="createAcctgTransAndEntriesInMap.acctgTransTypeId" value="SALES_INVOICE"/>
>             <set field="createAcctgTransAndEntriesInMap.invoiceId" from-field="parameters.invoiceId"/>
> +            <set field="createAcctgTransAndEntriesInMap.partyId" from-field="invoice.partyId"/>
> +            <set field="createAcctgTransAndEntriesInMap.roleTypeId" value="BILL_TO_CUSTOMER"/>
>             <set field="createAcctgTransAndEntriesInMap.acctgTransEntries" from-field="acctgTransEntries"/>
>             <set field="createAcctgTransAndEntriesInMap.transactionDate" from-field="invoice.invoiceDate"/>
>             <call-service service-name="createAcctgTransAndEntries" in-map-name="createAcctgTransAndEntriesInMap">
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1243116 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

Anil Patel-3
Jacques,
This is a bug fix. The Service, createAcctgTransAndEntries should post entry to GlAccount associated with Party if there is one. Please see comment at line #502 when you get chance. My commit fixes this issue for sales invoice.

I am sure there is similar bug in posting purchaseInvoice as well. I'll take a look at it sometime soon.
 
Thanks and Regards
Anil Patel
HotWax Media Inc

On Feb 12, 2012, at 4:37 AM, Jacques Le Roux wrote:

> Not really a problem for me (I don't see any risks) but this is not really a bug fix and I see backports in 10 and 11 versions ;o)
>
> Jacques
>
> From: <[hidden email]>
>> Author: apatel
>> Date: Sat Feb 11 18:30:25 2012
>> New Revision: 1243116
>>
>> URL: http://svn.apache.org/viewvc?rev=1243116&view=rev
>> Log:
>> Set partyId and roleTypeId for invoiced Party. This helps to figure out glAccount associated with Party.
>>
>> Modified:
>>   ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>
>> Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1243116&r1=1243115&r2=1243116&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml (original)
>> +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml Sat Feb 11 18:30:25 2012
>> @@ -2321,6 +2321,8 @@ under the License.
>>            <set field="createAcctgTransAndEntriesInMap.glFiscalTypeId" value="ACTUAL"/>
>>            <set field="createAcctgTransAndEntriesInMap.acctgTransTypeId" value="SALES_INVOICE"/>
>>            <set field="createAcctgTransAndEntriesInMap.invoiceId" from-field="parameters.invoiceId"/>
>> +            <set field="createAcctgTransAndEntriesInMap.partyId" from-field="invoice.partyId"/>
>> +            <set field="createAcctgTransAndEntriesInMap.roleTypeId" value="BILL_TO_CUSTOMER"/>
>>            <set field="createAcctgTransAndEntriesInMap.acctgTransEntries" from-field="acctgTransEntries"/>
>>            <set field="createAcctgTransAndEntriesInMap.transactionDate" from-field="invoice.invoiceDate"/>
>>            <call-service service-name="createAcctgTransAndEntries" in-map-name="createAcctgTransAndEntriesInMap">
>>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1243116 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml

Jacques Le Roux
Administrator
Thanks for comment Anil,

It quite clear for me now

Jacques

From: "Anil Patel" <[hidden email]>

> Jacques,
> This is a bug fix. The Service, createAcctgTransAndEntries should post entry to GlAccount associated with Party if there is one.
> Please see comment at line #502 when you get chance. My commit fixes this issue for sales invoice.
>
> I am sure there is similar bug in posting purchaseInvoice as well. I'll take a look at it sometime soon.
>
> Thanks and Regards
> Anil Patel
> HotWax Media Inc
>
> On Feb 12, 2012, at 4:37 AM, Jacques Le Roux wrote:
>
>> Not really a problem for me (I don't see any risks) but this is not really a bug fix and I see backports in 10 and 11 versions
>> ;o)
>>
>> Jacques
>>
>> From: <[hidden email]>
>>> Author: apatel
>>> Date: Sat Feb 11 18:30:25 2012
>>> New Revision: 1243116
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1243116&view=rev
>>> Log:
>>> Set partyId and roleTypeId for invoiced Party. This helps to figure out glAccount associated with Party.
>>>
>>> Modified:
>>>   ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>>
>>> Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1243116&r1=1243115&r2=1243116&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml (original)
>>> +++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml Sat Feb 11 18:30:25 2012
>>> @@ -2321,6 +2321,8 @@ under the License.
>>>            <set field="createAcctgTransAndEntriesInMap.glFiscalTypeId" value="ACTUAL"/>
>>>            <set field="createAcctgTransAndEntriesInMap.acctgTransTypeId" value="SALES_INVOICE"/>
>>>            <set field="createAcctgTransAndEntriesInMap.invoiceId" from-field="parameters.invoiceId"/>
>>> +            <set field="createAcctgTransAndEntriesInMap.partyId" from-field="invoice.partyId"/>
>>> +            <set field="createAcctgTransAndEntriesInMap.roleTypeId" value="BILL_TO_CUSTOMER"/>
>>>            <set field="createAcctgTransAndEntriesInMap.acctgTransEntries" from-field="acctgTransEntries"/>
>>>            <set field="createAcctgTransAndEntriesInMap.transactionDate" from-field="invoice.invoiceDate"/>
>>>            <call-service service-name="createAcctgTransAndEntries" in-map-name="createAcctgTransAndEntriesInMap">
>>>
>
>