Re: svn commit: r1307302 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java

[Jacques Le Roux]

Hi Hans,

Interesting, I was trying to check https://issues.apache.org/jira/browse/OFBIZ-1866  recently. I will have a new try (of course I
will not be annoyed if someone beats me on it ;o)

Jacques

From: <[hidden email]>

> Author: hansbak
> Date: Fri Mar 30 08:25:41 2012
> New Revision: 1307302
>
> URL: http://svn.apache.org/viewvc?rev=1307302&view=rev
> Log:
> promotions not added to ordertotal: corrected
>
> Modified:
>    ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
>
> Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java?rev=1307302&r1=1307301&r2=1307302&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java (original)
> +++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderReadHelper.java Fri Mar 30 08:25:41 2012
> @@ -2593,7 +2593,7 @@ public class OrderReadHelper {
>         List<GenericValue> newOrderAdjustmentsList = FastList.newInstance();
>
>         if (UtilValidate.isNotEmpty(adjustments)) {
> -            for(GenericValue orderAdjustment : newOrderAdjustmentsList) {
> +            for(GenericValue orderAdjustment : adjustments) {
>                 boolean includeAdjustment = false;
>
>                 if ("SALES_TAX".equals(orderAdjustment.getString("orderAdjustmentTypeId")) ||
>
>