Re: svn commit: r1328517 - /ofbiz/branches/release10.04/framework/base/config/test-containers.xml

[Adam Heath-2]

On 04/20/2012 04:33 PM, [hidden email] wrote:
> Author: erwan
> Date: Fri Apr 20 21:33:02 2012
> New Revision: 1328517
>
> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
> Log:
> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)

Um, no, don't do this.

>
> Modified:
>     ofbiz/branches/release10.04/framework/base/config/test-containers.xml
>
> Modified: ofbiz/branches/release10.04/framework/base/config/test-containers.xml
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/framework/base/config/test-containers.xml?rev=1328517&r1=1328516&r2=1328517&view=diff
> ==============================================================================
> --- ofbiz/branches/release10.04/framework/base/config/test-containers.xml (original)
> +++ ofbiz/branches/release10.04/framework/base/config/test-containers.xml Fri Apr 20 21:33:02 2012
> @@ -31,14 +31,14 @@ under the License.
>  
>      <!-- load the naming (JNDI) server -->
>      <container name="naming-container" class="org.ofbiz.base.container.NamingServiceContainer">
> -        <property name="port" value="1099"/>
> +        <property name="port" value="1100"/>
>      </container>
>  
>      <!-- RMI Service Dispatcher -->
>      <container name="rmi-dispatcher" class="org.ofbiz.service.rmi.RmiServiceContainer">
>          <property name="bound-name" value="RMIDispatcher"/>
>          <property name="bound-host" value="127.0.0.1"/>
> -        <property name="bound-port" value="1099"/>
> +        <property name="bound-port" value="1100"/>
>          <property name="delegator-name" value="test"/>
>          <property name="client-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLClientSocketFactory"/>
>          <property name="server-factory" value="org.ofbiz.service.rmi.socket.ssl.SSLServerSocketFactory"/>
> @@ -127,7 +127,7 @@ under the License.
>              <property name="maxSpareThreads" value="50"/>
>              <property name="maxThreads" value="200"/>
>              <property name="minSpareThreads" value="4"/>
> -            <property name="port" value="8009"/>
> +            <property name="port" value="8010"/>
>              <property name="tcpNoDelay" value="true"/>
>              <property name="soTimeout" value="60000"/>
>              <property name="tomcatAuthentication" value="true"/>
> @@ -162,7 +162,7 @@ under the License.
>              <property name="maxThreads" value="100"/>
>              <property name="minSpareThreads" value="4"/>
>              <property name="noCompressionUserAgents" value=""/>
> -            <property name="port" value="8080"/>
> +            <property name="port" value="8081"/>
>              <property name="restrictedUserAgents" value=""/>
>              <property name="server" value=""/>
>              <property name="socketBuffer" value="9000"/>
> @@ -200,7 +200,7 @@ under the License.
>              <property name="maxThreads" value="100"/>
>              <property name="minSpareThreads" value="4"/>
>              <property name="noCompressionUserAgents" value=""/>
> -            <property name="port" value="8443"/>
> +            <property name="port" value="8444"/>
>              <property name="restrictedUserAgents" value=""/>
>              <property name="server" value=""/>
>              <property name="socketBuffer" value="9000"/>
>
>

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 04/20/2012 04:33 PM, [hidden email] wrote:
>> Author: erwan
>> Date: Fri Apr 20 21:33:02 2012
>> New Revision: 1328517
>>
>> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
>> Log:
>> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)
>
> Um, no, don't do this.

There have been already a discussion about that see in a comment  of https://issues.apache.org/jira/browse/OFBIZ-4794
Also related https://issues.apache.org/jira/browse/OFBIZ-4763

Last message for tonight...

Jacques

[Adam Heath-2]

On 04/20/2012 05:47 PM, Jacques Le Roux wrote:

> From: "Adam Heath" <[hidden email]>
>> On 04/20/2012 04:33 PM, [hidden email] wrote:
>>> Author: erwan
>>> Date: Fri Apr 20 21:33:02 2012
>>> New Revision: 1328517
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
>>> Log:
>>> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)
>>
>> Um, no, don't do this.
>
> There have been already a discussion about that see in a comment  of
> https://issues.apache.org/jira/browse/OFBIZ-4794
> Also related https://issues.apache.org/jira/browse/OFBIZ-4763

Just because someone requests it doesn't mean it is right.

End-users can have this already deployed, other applications already
configured to use these ports.  We can absolutely *not* change the
ports in a *release* branch.  Period.  Even in test-containers.xml.

[Pierre Smits]

It is even more likely that other applications are configured to run the
standard ports 1099, 8009, 8080,8443.



Op 21 april 2012 01:03 schreef Adam Heath <[hidden email]> het
volgende:

> On 04/20/2012 05:47 PM, Jacques Le Roux wrote:
> > From: "Adam Heath" <[hidden email]>
> >> On 04/20/2012 04:33 PM, [hidden email] wrote:
> >>> Author: erwan
> >>> Date: Fri Apr 20 21:33:02 2012
> >>> New Revision: 1328517
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
> >>> Log:
> >>> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)
> >>
> >> Um, no, don't do this.
> >
> > There have been already a discussion about that see in a comment  of
> > https://issues.apache.org/jira/browse/OFBIZ-4794
> > Also related https://issues.apache.org/jira/browse/OFBIZ-4763
>
> Just because someone requests it doesn't mean it is right.
>
> End-users can have this already deployed, other applications already
> configured to use these ports.  We can absolutely *not* change the
> ports in a *release* branch.  Period.  Even in test-containers.xml.
>

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 04/20/2012 05:47 PM, Jacques Le Roux wrote:
>> From: "Adam Heath" <[hidden email]>
>>> On 04/20/2012 04:33 PM, [hidden email] wrote:
>>>> Author: erwan
>>>> Date: Fri Apr 20 21:33:02 2012
>>>> New Revision: 1328517
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
>>>> Log:
>>>> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)
>>>
>>> Um, no, don't do this.
>>
>> There have been already a discussion about that see in a comment  of
>> https://issues.apache.org/jira/browse/OFBIZ-4794
>> Also related https://issues.apache.org/jira/browse/OFBIZ-4763
>
> Just because someone requests it doesn't mean it is right.
>
> End-users can have this already deployed, other applications already
> configured to use these ports.  We can absolutely *not* change the
> ports in a *release* branch.  Period.  Even in test-containers.xml.

Ha sorry, was too late I did not thought about the release aspect.
I was speaking about trunk only, indeed.
I second, this is an improvement and should not have been backported

Jacques

[Jacques Le Roux]

From: "Pierre Smits" <[hidden email]>
> It is even more likely that other applications are configured to run the
> standard ports 1099, 8009, 8080,8443.

Yes, but this can't be considered a bug, hence no backport
Please Erwan revert

Thanks

Jacques
 

>
>
> Op 21 april 2012 01:03 schreef Adam Heath <[hidden email]> het
> volgende:
>
>> On 04/20/2012 05:47 PM, Jacques Le Roux wrote:
>> > From: "Adam Heath" <[hidden email]>
>> >> On 04/20/2012 04:33 PM, [hidden email] wrote:
>> >>> Author: erwan
>> >>> Date: Fri Apr 20 21:33:02 2012
>> >>> New Revision: 1328517
>> >>>
>> >>> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
>> >>> Log:
>> >>> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)
>> >>
>> >> Um, no, don't do this.
>> >
>> > There have been already a discussion about that see in a comment  of
>> > https://issues.apache.org/jira/browse/OFBIZ-4794
>> > Also related https://issues.apache.org/jira/browse/OFBIZ-4763
>>
>> Just because someone requests it doesn't mean it is right.
>>
>> End-users can have this already deployed, other applications already
>> configured to use these ports.  We can absolutely *not* change the
>> ports in a *release* branch.  Period.  Even in test-containers.xml.
>>
>

[Erwan de FERRIERES]

Le 20/04/2012 23:59, Adam Heath a écrit :

> On 04/20/2012 04:33 PM, [hidden email] wrote:
>> Author: erwan
>> Date: Fri Apr 20 21:33:02 2012
>> New Revision: 1328517
>>
>> URL: http://svn.apache.org/viewvc?rev=1328517&view=rev
>> Log:
>> OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins)
>
> Um, no, don't do this.
>
>

reverted.

--
Erwan de FERRIERES
www.nereide.biz