Re: svn commit: r1334326 - in /ofbiz/branches/release11.04: .classpath LICENSE framework/entity/lib/commons-dbcp-1.3-20091113-r835956.jar framework/entity/lib/commons-dbcp-1.4.jar

[Jacques Le Roux]

I have also backported to R10.04 at r1334583

Tests passed successfully here
BUILD SUCCESSFUL
Total time: 7 minutes 58 seconds

I believe the crashes we got today and yesterday on stable demo were due to an issue with DBCP:


2012-05-05 19:55:54,807 (org.ofbiz.service.job.JobPoller@49ecee7a) [         JobManager.java:187:ERROR]
---- exception report ----------------------------------------------------------
Error in polling JobSandbox: [org.ofbiz.entity.GenericDataSourceException: Generic Entity Exception occured in updateByCondition
(SQL Exception while executing the following:UPDATE OFBIZ.JOB_SANDBOX SET RUN_BY_INSTANCE_ID = ?, STATUS_ID = ? WHERE ((RUN_TIME <=
'2012-05-05 18:51:16.131' AND START_DATE_TIME IS NULL AND CANCEL_DATE_TIME IS NULL AND RUN_BY_INSTANCE_ID IS NULL) AND (POOL_ID IS
NULL OR POOL_ID = 'pool')) (Cannot create an instance of generated class
org.apache.derby.exe.accf7642f5x0137x17dax61a7xffffa94ec81a1ac.))]. Rolling back transaction.
Exception: org.ofbiz.entity.GenericDataSourceException
Message: Generic Entity Exception occured in updateByCondition (SQL Exception while executing the following:UPDATE OFBIZ.JOB_SANDBOX
SET RUN_BY_INSTANCE_ID = ?, STATUS_ID = ? WHERE ((RUN_TIME <= '2012-05-05 18:51:16.131' AND START_DATE_TIME IS NULL AND
CANCEL_DATE_TIME IS NULL AND RUN_BY_INSTANCE_ID IS NULL) AND (POOL_ID IS NULL OR POOL_ID = 'pool')) (Cannot create an instance of
generated class org.apache.derby.exe.accf7642f5x0137x17dax61a7xffffa94ec81a1ac.))
---- cause ---------------------------------------------------------------------
Exception: org.ofbiz.entity.GenericDataSourceException
Message: SQL Exception while executing the following:UPDATE OFBIZ.JOB_SANDBOX SET RUN_BY_INSTANCE_ID = ?, STATUS_ID = ? WHERE
((RUN_TIME <= '2012-05-05 18:51:16.131' AND START_DATE_TIME IS NULL AND CANCEL_DATE_TIME IS NULL AND RUN_BY_INSTANCE_ID IS NULL) AND
(POOL_ID IS NULL OR POOL_ID = 'pool')) (Cannot create an instance of generated class
org.apache.derby.exe.accf7642f5x0137x17dax61a7xffffa94ec81a1ac.)
---- cause ---------------------------------------------------------------------
Exception: java.sql.SQLException
Message: Cannot create an instance of generated class org.apache.derby.exe.accf7642f5x0137x17dax61a7xffffa94ec81a1ac.
---- cause ---------------------------------------------------------------------
Exception: org.apache.derby.impl.jdbc.EmbedSQLException
Message: Cannot create an instance of generated class org.apache.derby.exe.accf7642f5x0137x17dax61a7xffffa94ec81a1ac.
---- cause ---------------------------------------------------------------------
Exception: org.apache.derby.impl.jdbc.EmbedSQLException
Message: Java exception: '(class: org/apache/derby/exe/accf7642f5x0137x17dax61a7xffffa94ec81a1ac, method: setStalePlanCheckInterval
signature: (I)V) Illegal constant pool index: java.lang.VerifyError'.
---- cause ---------------------------------------------------------------------
Exception: java.lang.VerifyError
Message: (class: org/apache/derby/exe/accf7642f5x0137x17dax61a7xffffa94ec81a1ac, method: setStalePlanCheckInterval signature: (I)V)
Illegal constant pool index
---- stack trace ---------------------------------------------------------------
java.lang.VerifyError: (class: org/apache/derby/exe/accf7642f5x0137x17dax61a7xffffa94ec81a1ac, method: setStalePlanCheckInterval
signature: (I)V) Illegal constant pool index
java.lang.Class.getDeclaredConstructors0(Native Method)
java.lang.Class.privateGetDeclaredConstructors(Class.java:2389)
java.lang.Class.getConstructor0(Class.java:2699)
java.lang.Class.getConstructor(Class.java:1657)
org.apache.derby.iapi.services.loader.ClassInfo.getNewInstance(Unknown Source)
org.apache.derby.impl.services.reflect.LoadedGeneratedClass.newInstance(Unknown Source)
org.apache.derby.impl.services.reflect.ReflectGeneratedClass.newInstance(Unknown Source)
org.apache.derby.impl.sql.GenericActivationHolder.<init>(Unknown Source)
org.apache.derby.impl.sql.GenericPreparedStatement.getActivation(Unknown Source)
org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(Unknown Source)
org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(Unknown Source)
org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(Unknown Source)
org.apache.derby.impl.jdbc.EmbedPreparedStatement40.<init>(Unknown Source)
org.apache.derby.jdbc.Driver40.newEmbedPreparedStatement(Unknown Source)
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source)
org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source)
org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:277)
org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:277)
org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:365)
org.ofbiz.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:326)
org.ofbiz.entity.datasource.GenericDAO.updateByCondition(GenericDAO.java:326)
org.ofbiz.entity.datasource.GenericDAO.updateByCondition(GenericDAO.java:291)
org.ofbiz.entity.datasource.GenericHelperDAO.storeByCondition(GenericHelperDAO.java:185)
org.ofbiz.entity.GenericDelegator.storeByCondition(GenericDelegator.java:1267)
org.ofbiz.entity.GenericDelegator.storeByCondition(GenericDelegator.java:1242)
org.ofbiz.service.job.JobManager.poll(JobManager.java:157)
org.ofbiz.service.job.JobPoller.run(JobPoller.java:90)
java.lang.Thread.run(Thread.java:662)

Anyway it's certainly safer to use a released version of DBCP...

Jacques

From: <[hidden email]>

> Author: jacopoc
> Date: Sat May  5 06:43:39 2012
> New Revision: 1334326
>
> URL: http://svn.apache.org/viewvc?rev=1334326&view=rev
> Log:
> Backported rev. 1324685:
> Upgrade DBCP from snapshot version of 1.3 to the new release 1.4
> For license reasons we should always try to package our releases with unmodified jars; the greatly enhanced handling of
> synchronization in 1.4 also has proven to resolve serious issues in sites suffering from heavy traffic.
>
>
> Added:
>    ofbiz/branches/release11.04/framework/entity/lib/commons-dbcp-1.4.jar   (with props)
> Removed:
>    ofbiz/branches/release11.04/framework/entity/lib/commons-dbcp-1.3-20091113-r835956.jar
> Modified:
>    ofbiz/branches/release11.04/.classpath
>    ofbiz/branches/release11.04/LICENSE
>
> Modified: ofbiz/branches/release11.04/.classpath
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release11.04/.classpath?rev=1334326&r1=1334325&r2=1334326&view=diff
> ==============================================================================
> --- ofbiz/branches/release11.04/.classpath (original)
> +++ ofbiz/branches/release11.04/.classpath Sat May  5 06:43:39 2012
> @@ -133,7 +133,7 @@
>  <classpathentry kind="lib" path="framework/catalina/lib/tomcat-6.0.35-tomcat-coyote.jar"/>
>  <classpathentry kind="lib" path="framework/catalina/lib/tomcat-6.0.35-tomcat-dbcp.jar"/>
>  <classpathentry kind="lib" path="framework/catalina/lib/tomcat-6.0.35-tomcat-juli.jar"/>
> - <classpathentry kind="lib" path="framework/entity/lib/commons-dbcp-1.3-20091113-r835956.jar"/>
> + <classpathentry kind="lib" path="framework/entity/lib/commons-dbcp-1.4.jar"/>
>  <classpathentry kind="lib" path="framework/entity/lib/ofbiz-minerva.jar"/>
>  <classpathentry kind="lib" path="framework/geronimo/lib/geronimo-connector-2.1.1.jar"/>
>  <classpathentry kind="lib" path="framework/geronimo/lib/geronimo-transaction-2.1.1.jar"/>
>
> Modified: ofbiz/branches/release11.04/LICENSE
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release11.04/LICENSE?rev=1334326&r1=1334325&r2=1334326&view=diff
> ==============================================================================
> --- ofbiz/branches/release11.04/LICENSE (original)
> +++ ofbiz/branches/release11.04/LICENSE Sat May  5 06:43:39 2012
> @@ -84,7 +84,7 @@ ofbiz/trunk/framework/catalina/lib/tomca
> ofbiz/trunk/framework/catalina/lib/tomcat-6.0.35-tomcat-coyote.jar
> ofbiz/trunk/framework/catalina/lib/tomcat-6.0.35-tomcat-dbcp.jar
> ofbiz/trunk/framework/catalina/lib/tomcat-6.0.35-tomcat-juli.jar
> -ofbiz/trunk/framework/entity/lib/commons-dbcp-1.3-20091113-r835956.jar
> +ofbiz/trunk/framework/entity/lib/commons-dbcp-1.4.jar
> ofbiz/trunk/framework/entity/lib/jdbc/derby-10.7.1.1.jar
> ofbiz/trunk/framework/entity/lib/jdbc/derbytools-10.7.1.1.jar
> ofbiz/trunk/framework/jetty/lib/ant-1.6.5.jar
>
> Added: ofbiz/branches/release11.04/framework/entity/lib/commons-dbcp-1.4.jar
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release11.04/framework/entity/lib/commons-dbcp-1.4.jar?rev=1334326&view=auto
> ==============================================================================
> Binary file - no diff available.
>
> Propchange: ofbiz/branches/release11.04/framework/entity/lib/commons-dbcp-1.4.jar
> ------------------------------------------------------------------------------
>    svn:mime-type = application/octet-stream
>
>