Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

[Adam Heath-2]

On 05/10/2012 11:05 AM, [hidden email] wrote:
> Author: doogie
> Date: Thu May 10 16:05:00 2012
> New Revision: 1336768
>
> URL: http://svn.apache.org/viewvc?rev=1336768&view=rev
> Log:
> FIX: s/run-install/load-demo/

I'm surprised I actually had to do this.  It implies that the scripts
are not being used to backport changes.  I thought we had decided to
use these scripts for just that purpose.

>
> Modified:
>     ofbiz/branches/release12.04/mergefromtrunk.bat
>     ofbiz/branches/release12.04/mergefromtrunk.sh
>
> Modified: ofbiz/branches/release12.04/mergefromtrunk.bat
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release12.04/mergefromtrunk.bat?rev=1336768&r1=1336767&r2=1336768&view=diff
> ==============================================================================
> --- ofbiz/branches/release12.04/mergefromtrunk.bat (original)
> +++ ofbiz/branches/release12.04/mergefromtrunk.bat Thu May 10 16:05:00 2012
> @@ -56,7 +56,7 @@ goto exit
>  :tests
>  echo on
>  ant clean-all
> -ant run-install
> +ant load-demo
>  ant run-tests
>  echo off
>  
>
> Modified: ofbiz/branches/release12.04/mergefromtrunk.sh
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release12.04/mergefromtrunk.sh?rev=1336768&r1=1336767&r2=1336768&view=diff
> ==============================================================================
> --- ofbiz/branches/release12.04/mergefromtrunk.sh (original)
> +++ ofbiz/branches/release12.04/mergefromtrunk.sh Thu May 10 16:05:00 2012
> @@ -94,7 +94,7 @@ case "$cmd" in
>   ;;
>   (test)
>   ant clean-all
> - ant run-install
> + ant load-demo
>   ant run-tests
>   ;;
>   (commit)
>
>

[Adrian Crum-3]

The scripts are helpful if you have a Subversion client that runs from
the command line. Some of us use a graphical Subversion client - like
Tortoise, or the Eclipse plugin.

-Adrian

On 5/10/2012 5:07 PM, Adam Heath wrote:

> On 05/10/2012 11:05 AM, [hidden email] wrote:
>> Author: doogie
>> Date: Thu May 10 16:05:00 2012
>> New Revision: 1336768
>>
>> URL: http://svn.apache.org/viewvc?rev=1336768&view=rev
>> Log:
>> FIX: s/run-install/load-demo/
> I'm surprised I actually had to do this.  It implies that the scripts
> are not being used to backport changes.  I thought we had decided to
> use these scripts for just that purpose.
>
>
>> Modified:
>>      ofbiz/branches/release12.04/mergefromtrunk.bat
>>      ofbiz/branches/release12.04/mergefromtrunk.sh
>>
>> Modified: ofbiz/branches/release12.04/mergefromtrunk.bat
>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release12.04/mergefromtrunk.bat?rev=1336768&r1=1336767&r2=1336768&view=diff
>> ==============================================================================
>> --- ofbiz/branches/release12.04/mergefromtrunk.bat (original)
>> +++ ofbiz/branches/release12.04/mergefromtrunk.bat Thu May 10 16:05:00 2012
>> @@ -56,7 +56,7 @@ goto exit
>>   :tests
>>   echo on
>>   ant clean-all
>> -ant run-install
>> +ant load-demo
>>   ant run-tests
>>   echo off
>>
>>
>> Modified: ofbiz/branches/release12.04/mergefromtrunk.sh
>> URL: http://svn.apache.org/viewvc/ofbiz/branches/release12.04/mergefromtrunk.sh?rev=1336768&r1=1336767&r2=1336768&view=diff
>> ==============================================================================
>> --- ofbiz/branches/release12.04/mergefromtrunk.sh (original)
>> +++ ofbiz/branches/release12.04/mergefromtrunk.sh Thu May 10 16:05:00 2012
>> @@ -94,7 +94,7 @@ case "$cmd" in
>>   ;;
>>   (test)
>>   ant clean-all
>> - ant run-install
>> + ant load-demo
>>   ant run-tests
>>   ;;
>>   (commit)
>>
>>

[Adam Heath-2]

On 05/10/2012 11:16 AM, Adrian Crum wrote:
> The scripts are helpful if you have a Subversion client that runs from
> the command line. Some of us use a graphical Subversion client - like
> Tortoise, or the Eclipse plugin.

Which brings up another thought I had.  Maybe converting these to a
series of ant build.xml snippets.

[Jacopo Cappellato-4]

On May 10, 2012, at 6:23 PM, Adam Heath wrote:

> On 05/10/2012 11:16 AM, Adrian Crum wrote:
>> The scripts are helpful if you have a Subversion client that runs from
>> the command line. Some of us use a graphical Subversion client - like
>> Tortoise, or the Eclipse plugin.
>
> Which brings up another thought I had.  Maybe converting these to a
> series of ant build.xml snippets.
>

I really like the idea: ideally we should only keep two platform dependent scripts, "ant" and "ant.bat" (even if it would be nice to rename them "ofbiz" or similar to avoid the risk of running a different version of ant), and all the remaining tools can be implemented as ant targets.

Jacopo

[Jacques Le Roux]

+1

Though I'd like to keep revert.bat, it's easier to change path (and not forget) with new release than have to search in build.xml,
not a big deal though...

I like the idea of having ofbiz instead of ant to avoid confusion

Jacques

From: "Jacopo Cappellato" <[hidden email]>

>
> On May 10, 2012, at 6:23 PM, Adam Heath wrote:
>
>> On 05/10/2012 11:16 AM, Adrian Crum wrote:
>>> The scripts are helpful if you have a Subversion client that runs from
>>> the command line. Some of us use a graphical Subversion client - like
>>> Tortoise, or the Eclipse plugin.
>>
>> Which brings up another thought I had.  Maybe converting these to a
>> series of ant build.xml snippets.
>>
>
> I really like the idea: ideally we should only keep two platform dependent scripts, "ant" and "ant.bat" (even if it would be nice
> to rename them "ofbiz" or similar to avoid the risk of running a different version of ant), and all the remaining tools can be
> implemented as ant targets.
>
> Jacopo

[Adam Heath-2]

On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:

>
> On May 10, 2012, at 6:23 PM, Adam Heath wrote:
>
>> On 05/10/2012 11:16 AM, Adrian Crum wrote:
>>> The scripts are helpful if you have a Subversion client that runs from
>>> the command line. Some of us use a graphical Subversion client - like
>>> Tortoise, or the Eclipse plugin.
>>
>> Which brings up another thought I had.  Maybe converting these to a
>> series of ant build.xml snippets.
>>
>
> I really like the idea: ideally we should only keep two platform dependent scripts, "ant" and "ant.bat" (even if it would be nice to rename them "ofbiz" or similar to avoid the risk of running a different version of ant), and all the remaining tools can be implemented as ant targets.

startofbiz.sh(and stop) should remain shell scripts.  java is not
exactly light-weight, and using ant would have 2 javas running.

[Adam Heath-2]

On 05/12/2012 05:15 AM, Jacques Le Roux wrote:
> +1
>
> Though I'd like to keep revert.bat, it's easier to change path (and not
> forget) with new release than have to search in build.xml, not a big
> deal though...

tools/ant-revert.xml:

./ant revert
./ant -f tools/ant-revert.xml revert

both commands being the same.

[Jacques Le Roux]

I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release.
Forget it, sometimes I'm too lazy :o)

Jacques

From: "Adam Heath" <[hidden email]>

> On 05/12/2012 05:15 AM, Jacques Le Roux wrote:
>> +1
>>
>> Though I'd like to keep revert.bat, it's easier to change path (and not
>> forget) with new release than have to search in build.xml, not a big
>> deal though...
>
> tools/ant-revert.xml:
>
> ./ant revert
> ./ant -f tools/ant-revert.xml revert
>
> both commands being the same.

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
>>
>> On May 10, 2012, at 6:23 PM, Adam Heath wrote:
>>
>>> On 05/10/2012 11:16 AM, Adrian Crum wrote:
>>>> The scripts are helpful if you have a Subversion client that runs from
>>>> the command line. Some of us use a graphical Subversion client - like
>>>> Tortoise, or the Eclipse plugin.
>>>
>>> Which brings up another thought I had.  Maybe converting these to a
>>> series of ant build.xml snippets.
>>>
>>
>> I really like the idea: ideally we should only keep two platform dependent scripts, "ant" and "ant.bat" (even if it would be nice
>> to rename them "ofbiz" or similar to avoid the risk of running a different version of ant), and all the remaining tools can be
>> implemented as ant targets.
>
> startofbiz.sh(and stop) should remain shell scripts.  java is not exactly light-weight, and using ant would have 2 javas running.

I'm not agains keeping them, but here it's only 45MB for the java process called by ant (1.6.0_22 on Win XP). Not a big deal with
nowadays memories, around 1.125 % for a standard box (4GB)...

Jacques

[Adam Heath-2]

On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
> I just meant it's easier to edit revert.bat than to seek for it in the
> build.xml when you have to update the path for a new release. Forget it,
> sometimes I'm too lazy :o)

I mean the definition for the ant revert command should be in a separate
file, inside the tools directory, so that it is still easy to change.

[Adam Heath-2]

On 05/12/2012 03:39 PM, Jacques Le Roux wrote:

> From: "Adam Heath" <[hidden email]>
>> On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
>>>
>>> On May 10, 2012, at 6:23 PM, Adam Heath wrote:
>>>
>>>> On 05/10/2012 11:16 AM, Adrian Crum wrote:
>>>>> The scripts are helpful if you have a Subversion client that runs from
>>>>> the command line. Some of us use a graphical Subversion client - like
>>>>> Tortoise, or the Eclipse plugin.
>>>>
>>>> Which brings up another thought I had. Maybe converting these to a
>>>> series of ant build.xml snippets.
>>>>
>>>
>>> I really like the idea: ideally we should only keep two platform
>>> dependent scripts, "ant" and "ant.bat" (even if it would be nice
>>> to rename them "ofbiz" or similar to avoid the risk of running a
>>> different version of ant), and all the remaining tools can be
>>> implemented as ant targets.
>>
>> startofbiz.sh(and stop) should remain shell scripts. java is not
>> exactly light-weight, and using ant would have 2 javas running.
>
> I'm not agains keeping them, but here it's only 45MB for the java
> process called by ant (1.6.0_22 on Win XP). Not a big deal with
> nowadays memories, around 1.125 % for a standard box (4GB)...

We have ofbiz virtual instances running with 384M or 512M.  45M just for
ant is a *huge* overhead.

Don't compare the size of the ant/java process to the *total* ram, but
to the size of the process it is controlling(ofbiz/java).

[Jacques Le Roux-3]

From: "Adam Heath" <[hidden email]>
> On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
>> I just meant it's easier to edit revert.bat than to seek for it in the
>> build.xml when you have to update the path for a new release. Forget it,
>> sometimes I'm too lazy :o)
>
> I mean the definition for the ant revert command should be in a separate
> file, inside the tools directory, so that it is still easy to change.

Hu? It is already ;o)

Jacques

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>

> On 05/12/2012 03:39 PM, Jacques Le Roux wrote:
>> From: "Adam Heath" <[hidden email]>
>>> On 05/12/2012 04:01 AM, Jacopo Cappellato wrote:
>>>>
>>>> On May 10, 2012, at 6:23 PM, Adam Heath wrote:
>>>>
>>>>> On 05/10/2012 11:16 AM, Adrian Crum wrote:
>>>>>> The scripts are helpful if you have a Subversion client that runs from
>>>>>> the command line. Some of us use a graphical Subversion client - like
>>>>>> Tortoise, or the Eclipse plugin.
>>>>>
>>>>> Which brings up another thought I had. Maybe converting these to a
>>>>> series of ant build.xml snippets.
>>>>>
>>>>
>>>> I really like the idea: ideally we should only keep two platform
>>>> dependent scripts, "ant" and "ant.bat" (even if it would be nice
>>>> to rename them "ofbiz" or similar to avoid the risk of running a
>>>> different version of ant), and all the remaining tools can be
>>>> implemented as ant targets.
>>>
>>> startofbiz.sh(and stop) should remain shell scripts. java is not
>>> exactly light-weight, and using ant would have 2 javas running.
>>
>> I'm not agains keeping them, but here it's only 45MB for the java
>> process called by ant (1.6.0_22 on Win XP). Not a big deal with
>> nowadays memories, around 1.125 % for a standard box (4GB)...
>
> We have ofbiz virtual instances running with 384M or 512M.  45M just for
> ant is a *huge* overhead.
>
> Don't compare the size of the ant/java process to the *total* ram, but
> to the size of the process it is controlling(ofbiz/java).

Anyway sincerely I think we all tweak those 2 scripts in our own production areas...
It's ok with me to keep them, and actually +1

Jacques

[Adam Heath-2]

On 05/12/2012 04:04 PM, Jacques Le Roux wrote:

> From: "Adam Heath" <[hidden email]>
>> On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
>>> I just meant it's easier to edit revert.bat than to seek for it in the
>>> build.xml when you have to update the path for a new release. Forget it,
>>> sometimes I'm too lazy :o)
>>
>> I mean the definition for the ant revert command should be in a
>> separate file, inside the tools directory, so that it is still easy to
>> change.
>
> Hu? It is already ;o)

If revert.bat is converted to ant xml commands, I am suggesting that it
is placed into tools/revert.xml, and could be called from the top level.

[Jacques Le Roux-3]

From: "Adam Heath" <[hidden email]>

> On 05/12/2012 04:04 PM, Jacques Le Roux wrote:
>> From: "Adam Heath" <[hidden email]>
>>> On 05/12/2012 03:36 PM, Jacques Le Roux wrote:
>>>> I just meant it's easier to edit revert.bat than to seek for it in the
>>>> build.xml when you have to update the path for a new release. Forget it,
>>>> sometimes I'm too lazy :o)
>>>
>>> I mean the definition for the ant revert command should be in a
>>> separate file, inside the tools directory, so that it is still easy to
>>> change.
>>
>> Hu? It is already ;o)
>
> If revert.bat is converted to ant xml commands, I am suggesting that it
> is placed into tools/revert.xml, and could be called from the top level.

I see, +1