Re: svn commit: r1338400 - in /ofbiz/trunk/framework/entity/src/org/ofbiz/entity: Delegator.java GenericDelegator.java

[Adrian Crum-3]

On 5/14/2012 9:59 PM, [hidden email] wrote:

> Author: doogie
> Date: Mon May 14 20:59:20 2012
> New Revision: 1338400
>
> URL: http://svn.apache.org/viewvc?rev=1338400&view=rev
> Log:
> DEPRECATION: Add new findByAnd variant, that has a boolean useCache
> parameter; this is the same similiar pattern that other methods have.
>
> After all code has been modified to use this new method, the older
> methods will be deprecated(and eventually replaced).
>
> Modified:
>      ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java
>      ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>
> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java?rev=1338400&r1=1338399&r2=1338400&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java (original)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java Mon May 14 20:59:20 2012
> @@ -363,6 +363,26 @@ public interface Delegator {
>       public List<GenericValue>  findByAndCache(String entityName, Map<String, ? extends Object>  fields, List<String>  orderBy) throws GenericEntityException;
>
>       /**
> +     * Finds Generic Entity records by all of the specified fields (ie: combined
> +     * using AND), looking first in the cache; uses orderBy for lookup, but only
> +     * keys results on the entityName and fields NOTE 20080502: 56 references

Umm... A new method has a note from 2008? I sense a temporal distortion.

-Adrian

[Adam Heath-2]

That is a cut-n-paste from the method above, whoops. It should be removed. I'll do it much later tonight, or tomorrow.
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Adrian Crum <[hidden email]> wrote:

On 5/14/2012 9:59 PM, [hidden email] wrote:

> Author: doogie
> Date: Mon May 14 20:59:20 2012
> New Revision: 1338400
>
> URL: http://svn.apache.org/viewvc?rev=1338400&view=rev
> Log:
> DEPRECATION: Add new findByAnd variant, that has a boolean useCache
> parameter; this is the same similiar pattern that other methods have.
>
> After all code has been modified to use this new method, the older
> methods will be deprecated(and eventually replaced).
>
> Modified:
> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java
> ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java
>
> Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java?rev=1338400&r1=1338399&r2=1338400&view=diff
>_____________________________________________

> --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java (original)
> +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/Delegator.java Mon May 14 20:59:20 2012
> @@ -363,6 +363,26 @@ public interface Delegator {
> public List<GenericValue> findByAndCache(String entityName, Map<String, ? extends Object> fields, List<String> orderBy) throws GenericEntityException;
>
> /**
> + * Finds Generic Entity records by all of the specified fields (ie: combined
> + * using AND), looking first in the cache; uses orderBy for lookup, but only
> + * keys results on the entityName and fields NOTE 20080502: 56 references

Umm... A new method has a note from 2008? I sense a temporal distortion.

-Adrian