Re: svn commit: r1502093 - in /ofbiz/trunk: ./ applications/accounting/config/ applications/accounting/data/ applications/accounting/entitydef/ applications/accounting/servicedef/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accou...

[Christian Geisert]

Am 11.07.2013 05:14, schrieb [hidden email]:

> Author: hansbak
> Date: Thu Jul 11 03:14:30 2013
> New Revision: 1502093
>
> URL: http://svn.apache.org/r1502093
> Log:
> add a csv import/export invoices at an organizational level with partyid and productid translation functions, more imports/exports will follow
>
> Added:
>      ofbiz/trunk/framework/base/lib/commons/commons-csv-1.0.jar   (with props)

Hans,

I much as I like this new feature, pushing it to the repository without
any discussion is not the way to go.

And btw, you still haven't addressed Adrians concerns regarding the
usage of screenlets...

Christian

[Adrian Crum-3]

Christian,

Thank you for bringing this up. OFBiz needs a well designed CSV
import/export feature to replace all of the ad-hoc CSV code it uses
currently.

-Adrian

On 7/11/2013 8:27 AM, Christian Geisert wrote:

> Am 11.07.2013 05:14, schrieb [hidden email]:
>> Author: hansbak
>> Date: Thu Jul 11 03:14:30 2013
>> New Revision: 1502093
>>
>> URL: http://svn.apache.org/r1502093
>> Log:
>> add a csv import/export invoices at an organizational level with
>> partyid and productid translation functions, more imports/exports
>> will follow
>>
>> Added:
>> ofbiz/trunk/framework/base/lib/commons/commons-csv-1.0.jar (with props)
>
> Hans,
>
> I much as I like this new feature, pushing it to the repository
> without any discussion is not the way to go.
>
> And btw, you still haven't addressed Adrians concerns regarding the
> usage of screenlets...
>
> Christian
>

[hans_bakker]

Adrian, feel free to improve my implementation. By the way, export is
fine using forms, and the only csv imports are this one and the address
match in party.....do not really see if these are ad-hoc?

Regards,
Hans

On 07/11/2013 11:13 PM, Adrian Crum wrote:

> Christian,
>
> Thank you for bringing this up. OFBiz needs a well designed CSV
> import/export feature to replace all of the ad-hoc CSV code it uses
> currently.
>
> -Adrian
>
> On 7/11/2013 8:27 AM, Christian Geisert wrote:
>> Am 11.07.2013 05:14, schrieb [hidden email]:
>>> Author: hansbak
>>> Date: Thu Jul 11 03:14:30 2013
>>> New Revision: 1502093
>>>
>>> URL: http://svn.apache.org/r1502093
>>> Log:
>>> add a csv import/export invoices at an organizational level with
>>> partyid and productid translation functions, more imports/exports
>>> will follow
>>>
>>> Added:
>>> ofbiz/trunk/framework/base/lib/commons/commons-csv-1.0.jar (with props)
>>
>> Hans,
>>
>> I much as I like this new feature, pushing it to the repository
>> without any discussion is not the way to go.
>>
>> And btw, you still haven't addressed Adrians concerns regarding the
>> usage of screenlets...
>>
>> Christian
>>
>