Administrator
|
Is this rather not hidding the warning?
Is a FIXME (moreover in xml code) better? Do you intent to fix it soon? Jacques [hidden email] wrote: > Author: adrianc > Date: Wed Sep 25 19:57:13 2013 > New Revision: 1526276 > > URL: http://svn.apache.org/r1526276 > Log: > Fixed a warning caused by a framework dependency on the Party component. > > Modified: > ofbiz/trunk/framework/common/servicedef/services.xml > > Modified: ofbiz/trunk/framework/common/servicedef/services.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff > ============================================================================== > --- ofbiz/trunk/framework/common/servicedef/services.xml (original) > +++ ofbiz/trunk/framework/common/servicedef/services.xml Wed Sep 25 19:57:13 2013 > @@ -181,9 +181,9 @@ under the License. > <description>Create a CustomTimePeriod record</description> > <auto-attributes mode="OUT" include="pk" optional="false"/> > <auto-attributes mode="IN" include="nonpk" optional="true"/> > + <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on > Party component --> <override name="fromDate" optional="false"/> > <override name="thruDate" optional="false"/> > - <override name="organizationPartyId" optional="false"/> > <override name="periodTypeId" optional="false"/> > </service> > <service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple" |
I have put dozens of FIXME comments in the project. No, I don't have
time to fix them all. Adrian Crum Sandglass Software www.sandglass-software.com On 9/25/2013 2:37 PM, Jacques Le Roux wrote: > Is this rather not hidding the warning? > Is a FIXME (moreover in xml code) better? > Do you intent to fix it soon? > > Jacques > > [hidden email] wrote: >> Author: adrianc >> Date: Wed Sep 25 19:57:13 2013 >> New Revision: 1526276 >> >> URL: http://svn.apache.org/r1526276 >> Log: >> Fixed a warning caused by a framework dependency on the Party component. >> >> Modified: >> ofbiz/trunk/framework/common/servicedef/services.xml >> >> Modified: ofbiz/trunk/framework/common/servicedef/services.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff >> ============================================================================== >> --- ofbiz/trunk/framework/common/servicedef/services.xml (original) >> +++ ofbiz/trunk/framework/common/servicedef/services.xml Wed Sep 25 19:57:13 2013 >> @@ -181,9 +181,9 @@ under the License. >> <description>Create a CustomTimePeriod record</description> >> <auto-attributes mode="OUT" include="pk" optional="false"/> >> <auto-attributes mode="IN" include="nonpk" optional="true"/> >> + <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on >> Party component --> <override name="fromDate" optional="false"/> >> <override name="thruDate" optional="false"/> >> - <override name="organizationPartyId" optional="false"/> >> <override name="periodTypeId" optional="false"/> >> </service> >> <service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple" |
Administrator
|
I did not ask about all of them, just this one...
Jacques Adrian Crum wrote: > I have put dozens of FIXME comments in the project. No, I don't have > time to fix them all. > > Adrian Crum > Sandglass Software > www.sandglass-software.com > > On 9/25/2013 2:37 PM, Jacques Le Roux wrote: >> Is this rather not hidding the warning? >> Is a FIXME (moreover in xml code) better? >> Do you intent to fix it soon? >> >> Jacques >> >> [hidden email] wrote: >>> Author: adrianc >>> Date: Wed Sep 25 19:57:13 2013 >>> New Revision: 1526276 >>> >>> URL: http://svn.apache.org/r1526276 >>> Log: >>> Fixed a warning caused by a framework dependency on the Party component. >>> >>> Modified: >>> ofbiz/trunk/framework/common/servicedef/services.xml >>> >>> Modified: ofbiz/trunk/framework/common/servicedef/services.xml >>> URL: >>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff >>> ============================================================================== --- >>> ofbiz/trunk/framework/common/servicedef/services.xml (original) +++ ofbiz/trunk/framework/common/servicedef/services.xml Wed >>> Sep 25 19:57:13 2013 @@ -181,9 +181,9 @@ under the License. >>> <description>Create a CustomTimePeriod record</description> >>> <auto-attributes mode="OUT" include="pk" optional="false"/> >>> <auto-attributes mode="IN" include="nonpk" optional="true"/> >>> + <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on >>> Party component --> <override name="fromDate" optional="false"/> >>> <override name="thruDate" optional="false"/> >>> - <override name="organizationPartyId" optional="false"/> >>> <override name="periodTypeId" optional="false"/> >>> </service> >>> <service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple" |
Free forum by Nabble | Edit this page |