Re: svn commit: r1542530 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java

[Adrian Crum-3]

The updated link is wrong. The problem is Confluence keeps changing the
format of its anchor names. Consequently, all of the internal links in
that page are now broken.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 11/16/2013 11:18 AM, [hidden email] wrote:

> Author: jleroux
> Date: Sat Nov 16 16:18:12 2013
> New Revision: 1542530
>
> URL: http://svn.apache.org/r1542530
> Log:
> No functional changes, updates a link in a comment
>
> Modified:
>      ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>
> Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java?rev=1542530&r1=1542529&r2=1542530&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java (original)
> +++ ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java Sat Nov 16 16:18:12 2013
> @@ -38,8 +38,8 @@ import org.w3c.dom.Element;
>
>   /**
>    * Implements the <if-regexp> element.
> - *
> - * @see <a href="https://cwiki.apache.org/OFBADMIN/mini-language-reference.html#Mini-languageReference-{{%3Cifregexp%3E}}">Mini-language Reference</a>
> + *
> + * @see <a href="https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}">Mini-language Reference</a>
>    */
>   public class RegexpCondition extends MethodOperation implements Conditional {
>
> @@ -146,7 +146,7 @@ public class RegexpCondition extends Met
>       }
>
>       /**
> -     * A &lt;if-regexp&gt; element factory.
> +     * A &lt;if-regexp&gt; element factory.
>        */
>       public static final class RegexpConditionFactory extends ConditionalFactory<RegexpCondition> implements Factory<RegexpCondition> {
>           @Override
>
>

[Jacques Le Roux]

With https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}
I get to the correct position in the page. And it also works inside Javadoc (API link from main page).

It's not an anchor name change but a sub-domain one.

So in Javadoc (source) we should change all
https://cwiki.apache.org/OFBADMIN/
by
https://cwiki.apache.org/confluence/display/OFBADMIN/

Only minilang component is concerned (I mean we could only use the https://cwiki.apache.org, but adding OFBADMIN will preserve the change below)

Jacques

On Saturday, November 16, 2013 7:28 PM Adrian Crum <[hidden email]> wrote:

> The updated link is wrong. The problem is Confluence keeps changing the
> format of its anchor names. Consequently, all of the internal links in
> that page are now broken.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 11/16/2013 11:18 AM, [hidden email] wrote:
>> Author: jleroux
>> Date: Sat Nov 16 16:18:12 2013
>> New Revision: 1542530
>>
>> URL: http://svn.apache.org/r1542530
>> Log:
>> No functional changes, updates a link in a comment
>>
>> Modified:
>>      ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>
>> Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java?rev=1542530&r1=1542529&r2=1542530&view=diff
>> ============================================================================== ---
>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java (original) +++
>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java Sat Nov 16 16:18:12 2013 @@ -38,8
>> +38,8 @@ import org.w3c.dom.Element;
>>
>>   /**
>>    * Implements the &lt;if-regexp&gt; element.
>> - *
>> - * @see <a
>> href="https://cwiki.apache.org/OFBADMIN/mini-language-reference.html#Mini-languageReference-{{%3Cifregexp%3E}}">Mini-language
>> Reference</a> + * + * @see <a
>>  
>>  
>> href="https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}">Mini-language
>> Reference</a> */ public class RegexpCondition extends MethodOperation implements Conditional {  
>>
>> @@ -146,7 +146,7 @@ public class RegexpCondition extends Met
>>       }
>>
>>       /**
>> -     * A &lt;if-regexp&gt; element factory.
>> +     * A &lt;if-regexp&gt; element factory.
>>        */
>>       public static final class RegexpConditionFactory extends ConditionalFactory<RegexpCondition> implements
>>           Factory<RegexpCondition> { @Override

[Jacques Le Roux]

It was a bit more than that, actually
https://cwiki.apache.org/OFBADMIN/mini-language-reference.html
to
https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference

BTW, great job Adrian on, not only refactoring the minilang API, but also documenting it many details, thanks!

Jacques

On Saturday, November 16, 2013 11:09 PM Jacques Le Roux <[hidden email]> wrote:

> With https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}
> I get to the correct position in the page. And it also works inside Javadoc (API link from main page).
>
> It's not an anchor name change but a sub-domain one.
>
> So in Javadoc (source) we should change all
> https://cwiki.apache.org/OFBADMIN/
> by
> https://cwiki.apache.org/confluence/display/OFBADMIN/
>
> Only minilang component is concerned (I mean we could only use the https://cwiki.apache.org, but adding OFBADMIN will preserve
> the change below)
>
> Jacques
>
> On Saturday, November 16, 2013 7:28 PM Adrian Crum <[hidden email]> wrote:
>> The updated link is wrong. The problem is Confluence keeps changing the
>> format of its anchor names. Consequently, all of the internal links in
>> that page are now broken.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 11/16/2013 11:18 AM, [hidden email] wrote:
>>> Author: jleroux
>>> Date: Sat Nov 16 16:18:12 2013
>>> New Revision: 1542530
>>>
>>> URL: http://svn.apache.org/r1542530
>>> Log:
>>> No functional changes, updates a link in a comment
>>>
>>> Modified:
>>>      ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>>
>>> Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java?rev=1542530&r1=1542529&r2=1542530&view=diff
>>> ============================================================================== ---
>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java (original) +++
>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java Sat Nov 16 16:18:12 2013 @@ -38,8
>>> +38,8 @@ import org.w3c.dom.Element;
>>>
>>>   /**
>>>    * Implements the &lt;if-regexp&gt; element.
>>> - *
>>> - * @see <a
>>> href="https://cwiki.apache.org/OFBADMIN/mini-language-reference.html#Mini-languageReference-{{%3Cifregexp%3E}}">Mini-language
>>> Reference</a> + * + * @see <a
>>>
>>>
>>> href="https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}">Mini-language
>>> Reference</a> */ public class RegexpCondition extends MethodOperation implements Conditional {
>>>
>>> @@ -146,7 +146,7 @@ public class RegexpCondition extends Met
>>>       }
>>>
>>>       /**
>>> -     * A &lt;if-regexp&gt; element factory.
>>> +     * A &lt;if-regexp&gt; element factory.
>>>        */
>>>       public static final class RegexpConditionFactory extends ConditionalFactory<RegexpCondition> implements
>>>           Factory<RegexpCondition> { @Override

[Adrian Crum-3]

Keep in mind the new Mini-language has a setting that will convert your
source code over to the new grammar.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 11/17/2013 9:25 AM, Jacques Le Roux wrote:

> It was a bit more than that, actually
> https://cwiki.apache.org/OFBADMIN/mini-language-reference.html
> to
> https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference
>
> BTW, great job Adrian on, not only refactoring the minilang API, but also documenting it many details, thanks!
>
> Jacques
>
> On Saturday, November 16, 2013 11:09 PM Jacques Le Roux <[hidden email]> wrote:
>> With https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}
>> I get to the correct position in the page. And it also works inside Javadoc (API link from main page).
>>
>> It's not an anchor name change but a sub-domain one.
>>
>> So in Javadoc (source) we should change all
>> https://cwiki.apache.org/OFBADMIN/
>> by
>> https://cwiki.apache.org/confluence/display/OFBADMIN/
>>
>> Only minilang component is concerned (I mean we could only use the https://cwiki.apache.org, but adding OFBADMIN will preserve
>> the change below)
>>
>> Jacques
>>
>> On Saturday, November 16, 2013 7:28 PM Adrian Crum <[hidden email]> wrote:
>>> The updated link is wrong. The problem is Confluence keeps changing the
>>> format of its anchor names. Consequently, all of the internal links in
>>> that page are now broken.
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 11/16/2013 11:18 AM, [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Sat Nov 16 16:18:12 2013
>>>> New Revision: 1542530
>>>>
>>>> URL: http://svn.apache.org/r1542530
>>>> Log:
>>>> No functional changes, updates a link in a comment
>>>>
>>>> Modified:
>>>>       ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>>>
>>>> Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java?rev=1542530&r1=1542529&r2=1542530&view=diff
>>>> ============================================================================== ---
>>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java (original) +++
>>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java Sat Nov 16 16:18:12 2013 @@ -38,8
>>>> +38,8 @@ import org.w3c.dom.Element;
>>>>
>>>>    /**
>>>>     * Implements the &lt;if-regexp&gt; element.
>>>> - *
>>>> - * @see <a
>>>> href="https://cwiki.apache.org/OFBADMIN/mini-language-reference.html#Mini-languageReference-{{%3Cifregexp%3E}}">Mini-language
>>>> Reference</a> + * + * @see <a
>>>>
>>>>
>>>> href="https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}">Mini-language
>>>> Reference</a> */ public class RegexpCondition extends MethodOperation implements Conditional {
>>>>
>>>> @@ -146,7 +146,7 @@ public class RegexpCondition extends Met
>>>>        }
>>>>
>>>>        /**
>>>> -     * A &lt;if-regexp&gt; element factory.
>>>> +     * A &lt;if-regexp&gt; element factory.
>>>>         */
>>>>        public static final class RegexpConditionFactory extends ConditionalFactory<RegexpCondition> implements
>>>>            Factory<RegexpCondition> { @Override

[Jacques Le Roux]

I don't see the relation with this change, is there one?

Jacques

On Sunday, November 17, 2013 5:07 PM Adrian Crum <[hidden email]> wrote:

> Keep in mind the new Mini-language has a setting that will convert your
> source code over to the new grammar.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 11/17/2013 9:25 AM, Jacques Le Roux wrote:
>> It was a bit more than that, actually
>> https://cwiki.apache.org/OFBADMIN/mini-language-reference.html
>> to
>> https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference
>>
>> BTW, great job Adrian on, not only refactoring the minilang API, but also documenting it many details, thanks!
>>
>> Jacques
>>
>> On Saturday, November 16, 2013 11:09 PM Jacques Le Roux <[hidden email]> wrote:
>>> With https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}
>>> I get to the correct position in the page. And it also works inside Javadoc (API link from main page).
>>>
>>> It's not an anchor name change but a sub-domain one.
>>>
>>> So in Javadoc (source) we should change all
>>> https://cwiki.apache.org/OFBADMIN/
>>> by
>>> https://cwiki.apache.org/confluence/display/OFBADMIN/
>>>
>>> Only minilang component is concerned (I mean we could only use the https://cwiki.apache.org, but adding OFBADMIN will preserve
>>> the change below)
>>>
>>> Jacques
>>>
>>> On Saturday, November 16, 2013 7:28 PM Adrian Crum <[hidden email]> wrote:
>>>> The updated link is wrong. The problem is Confluence keeps changing the
>>>> format of its anchor names. Consequently, all of the internal links in
>>>> that page are now broken.
>>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 11/16/2013 11:18 AM, [hidden email] wrote:
>>>>> Author: jleroux
>>>>> Date: Sat Nov 16 16:18:12 2013
>>>>> New Revision: 1542530
>>>>>
>>>>> URL: http://svn.apache.org/r1542530
>>>>> Log:
>>>>> No functional changes, updates a link in a comment
>>>>>
>>>>> Modified:
>>>>>       ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>>>>
>>>>> Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java?rev=1542530&r1=1542529&r2=1542530&view=diff
>>>>> ============================================================================== ---
>>>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java (original) +++
>>>>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/conditional/RegexpCondition.java Sat Nov 16 16:18:12 2013 @@
>>>>> -38,8 +38,8 @@ import org.w3c.dom.Element;
>>>>>
>>>>>    /**
>>>>>     * Implements the &lt;if-regexp&gt; element.
>>>>> - *
>>>>> - * @see <a
>>>>> href="https://cwiki.apache.org/OFBADMIN/mini-language-reference.html#Mini-languageReference-{{%3Cifregexp%3E}}">Mini-language
>>>>> Reference</a> + * + * @see <a
>>>>>
>>>>>
>>>>> href="https://cwiki.apache.org/confluence/display/OFBADMIN/Mini-language+Reference#Mini-languageReference-{{<ifregexp>}}">Mini-language
>>>>> Reference</a> */ public class RegexpCondition extends MethodOperation implements Conditional {
>>>>>
>>>>> @@ -146,7 +146,7 @@ public class RegexpCondition extends Met
>>>>>        }
>>>>>
>>>>>        /**
>>>>> -     * A &lt;if-regexp&gt; element factory.
>>>>> +     * A &lt;if-regexp&gt; element factory.
>>>>>         */
>>>>>        public static final class RegexpConditionFactory extends ConditionalFactory<RegexpCondition> implements
>>>>>            Factory<RegexpCondition> { @Override