Re: svn commit: r1585033 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1585033 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Jacopo Cappellato-4
On Apr 5, 2014, at 3:46 AM, [hidden email] wrote:

> +                return new java.sql.Date(parsedDate.getYear(), parsedDate.getMonth(), parsedDate.getDay());

This constructor is deprecated.

"Deprecated. instead use the constructor Date(long date)"

Jacopo

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1585033 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Adrian Crum-3
I was aware of that, but the long argument contains the time component.

-Adrian


Quoting Jacopo Cappellato <[hidden email]>:

> On Apr 5, 2014, at 3:46 AM, [hidden email] wrote:
>
>> +                return new java.sql.Date(parsedDate.getYear(),  
>> parsedDate.getMonth(), parsedDate.getDay());
>
> This constructor is deprecated.
>
> "Deprecated. instead use the constructor Date(long date)"
>
> Jacopo
>
>



Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1585033 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Jacopo Cappellato-4
I understand this, but I think that we should not add new code that calls deprecated API.

Jacopo

On Apr 5, 2014, at 8:07 AM, [hidden email] wrote:

> I was aware of that, but the long argument contains the time component.
>
> -Adrian
>
>
> Quoting Jacopo Cappellato <[hidden email]>:
>
>> On Apr 5, 2014, at 3:46 AM, [hidden email] wrote:
>>
>>> +                return new java.sql.Date(parsedDate.getYear(), parsedDate.getMonth(), parsedDate.getDay());
>>
>> This constructor is deprecated.
>>
>> "Deprecated. instead use the constructor Date(long date)"
>>
>> Jacopo
>>
>>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1585033 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/conversion/DateTimeConverters.java

Jacopo Cappellato-4
Adrian,

thanks for fixing this in rev. 1585958

Jacopo

On Apr 5, 2014, at 8:34 AM, Jacopo Cappellato <[hidden email]> wrote:

> I understand this, but I think that we should not add new code that calls deprecated API.
>
> Jacopo
>
> On Apr 5, 2014, at 8:07 AM, [hidden email] wrote:
>
>> I was aware of that, but the long argument contains the time component.
>>
>> -Adrian
>>
>>
>> Quoting Jacopo Cappellato <[hidden email]>:
>>
>>> On Apr 5, 2014, at 3:46 AM, [hidden email] wrote:
>>>
>>>> +                return new java.sql.Date(parsedDate.getYear(), parsedDate.getMonth(), parsedDate.getDay());
>>>
>>> This constructor is deprecated.
>>>
>>> "Deprecated. instead use the constructor Date(long date)"
>>>
>>> Jacopo
>>>
>>>
>>
>>
>>
>