At r1624886 I have committed a more complicated but, in my opinion, better solution.
I still want to backport it to releases, but since it's not a simple change I'd like to have the agreements of the community. This change is not
functional from a business or framework perspective.
Jacques
Le 12/09/2014 16:14, Jacques Le Roux a écrit :
> If nobody is against that, I'd like to backport it to releases. Of course it's a no functional (core or business) change with no implications in code.
> The main reason is it's an easy way to check things on demos, but not only there.
>
> To have a better looking date-time I could use something like
>
> <tstamp>
> <format property="now" pattern="yyyy/MM/dd HH:mm:ss:sss zzz"/>
> </tstamp>
> <echo message=" - Release-revision : ${releasePath}-r${info.entry.commit(revision)} @ ${now}" file="runtime/svninfo.ftl"/>
>
> But it would not be the last commit date, only the build/deployment date
> Without other opinions I will go with this last solution, after all the last commit date matters less.
>
> Jacques
>
> Le 11/09/2014 15:10,
[hidden email] a écrit :
>> Author: jleroux
>> Date: Thu Sep 11 13:10:02 2014
>> New Revision: 1624278
>>
>> URL:
http://svn.apache.org/r1624278>> Log:
>> Ant svninfo target adds now a date (in a raw format) after the Release.revision.
>> Nobody seems against and I have no idea on how to format the date there
>>
>> Modified:
>> ofbiz/trunk/build.xml
>>
>> Modified: ofbiz/trunk/build.xml
>> URL:
http://svn.apache.org/viewvc/ofbiz/trunk/build.xml?rev=1624278&r1=1624277&r2=1624278&view=diff>> ==============================================================================
>> --- ofbiz/trunk/build.xml (original)
>> +++ ofbiz/trunk/build.xml Thu Sep 11 13:10:02 2014
>> @@ -219,7 +219,7 @@ under the License.
>> <xmlproperty file="runtime/svninfo_tmp.xml"/>
>> <echo message="Rev:${info.entry.commit(revision)}"/>
>> <basename property="releasePath" file="${info.entry.url}"/>
>> - <echo message=" - Release-revision : ${releasePath}-r${info.entry.commit(revision)}" file="runtime/svninfo.ftl"/>
>> + <echo message=" - Release-revision : ${releasePath}-r${info.entry.commit(revision)} @ ${info.entry.commit.date}" file="runtime/svninfo.ftl"/>
>> <delete file="runtime/svninfo_tmp.xml"/>
>> <echo message="Done!"/>
>> </target>
>>
>>
>>
>
>
Locked
