Re: svn commit: r1646917 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1646917 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java

Adrian Crum-3
boolean distinct = "Y".equals(context.get("distinct"));

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 12/20/2014 5:48 AM, [hidden email] wrote:

> Author: ashish
> Date: Sat Dec 20 05:48:51 2014
> New Revision: 1646917
>
> URL: http://svn.apache.org/r1646917
> Log:
> Bug fix, one small conditional check got missed in OFBIZ-5844 - Convert java files to EntityQuery.
>
> Modified:
>      ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java
>
> Modified: ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java?rev=1646917&r1=1646916&r2=1646917&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java (original)
> +++ ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java Sat Dec 20 05:48:51 2014
> @@ -603,6 +603,7 @@ public class FindServices {
>           EntityConditionList<EntityCondition> entityConditionList = UtilGenerics.cast(context.get("entityConditionList"));
>           List<String> orderByList = checkList(context.get("orderByList"), String.class);
>           boolean noConditionFind = "Y".equals(context.get("noConditionFind"));
> +        boolean distinct = "Y".equals(context.get("distinct"))? true : false;
>           List<String> fieldList =  UtilGenerics.checkList(context.get("fieldList"));
>           Locale locale = (Locale) context.get("locale");
>           Set<String> fieldSet = null;
> @@ -624,7 +625,7 @@ public class FindServices {
>                                       .orderBy(orderByList)
>                                       .cursorScrollInsensitive()
>                                       .maxRows(maxRows)
> -                                    .distinct()
> +                                    .distinct(distinct)
>                                       .queryIterator();
>                   listSize = listIt.getResultsSizeAfterPartialList();
>               }
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r1646917 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java

Ashish Vijaywargiya
Thanks Adrian. Improved code in trunk at r1647239.

--
Ashish

On Sat, Dec 20, 2014 at 9:35 PM, Adrian Crum <
[hidden email]> wrote:

> boolean distinct = "Y".equals(context.get("distinct"));
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
>
> On 12/20/2014 5:48 AM, [hidden email] wrote:
>
>> Author: ashish
>> Date: Sat Dec 20 05:48:51 2014
>> New Revision: 1646917
>>
>> URL: http://svn.apache.org/r1646917
>> Log:
>> Bug fix, one small conditional check got missed in OFBIZ-5844 - Convert
>> java files to EntityQuery.
>>
>> Modified:
>>      ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java
>>
>> Modified: ofbiz/trunk/framework/common/src/org/ofbiz/common/
>> FindServices.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/
>> src/org/ofbiz/common/FindServices.java?rev=1646917&
>> r1=1646916&r2=1646917&view=diff
>> ============================================================
>> ==================
>> --- ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java
>> (original)
>> +++ ofbiz/trunk/framework/common/src/org/ofbiz/common/FindServices.java
>> Sat Dec 20 05:48:51 2014
>> @@ -603,6 +603,7 @@ public class FindServices {
>>           EntityConditionList<EntityCondition> entityConditionList =
>> UtilGenerics.cast(context.get("entityConditionList"));
>>           List<String> orderByList = checkList(context.get("orderByList"),
>> String.class);
>>           boolean noConditionFind = "Y".equals(context.get("
>> noConditionFind"));
>> +        boolean distinct = "Y".equals(context.get("distinct"))? true :
>> false;
>>           List<String> fieldList =  UtilGenerics.checkList(
>> context.get("fieldList"));
>>           Locale locale = (Locale) context.get("locale");
>>           Set<String> fieldSet = null;
>> @@ -624,7 +625,7 @@ public class FindServices {
>>                                       .orderBy(orderByList)
>>                                       .cursorScrollInsensitive()
>>                                       .maxRows(maxRows)
>> -                                    .distinct()
>> +                                    .distinct(distinct)
>>                                       .queryIterator();
>>                   listSize = listIt.getResultsSizeAfterPartialList();
>>               }
>>
>>
>>