Re: svn commit: r1650821 - /ofbiz/trunk/framework/widget/
Locked
Re: svn commit: r1650821 - /ofbiz/trunk/framework/widget/
 
|
Hi Adrian;
In this commit, you deleted auto-parameters-service, auto-parameters-entity and parameter but they still used by link element ! Le 10/01/2015 23:18, [hidden email] a écrit : > Author: adrianc > Date: Sat Jan 10 22:18:31 2015 > New Revision: 1650821 > > URL: http://svn.apache.org/r1650821 > Log: > FIXME comment in screen widget schema, no functional change. > > Modified: > ofbiz/trunk/framework/widget/dtd/widget-screen.xsd > > Modified: ofbiz/trunk/framework/widget/dtd/widget-screen.xsd > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-screen.xsd?rev=1650821&r1=1650820&r2=1650821&view=diff > ============================================================================== > --- ofbiz/trunk/framework/widget/dtd/widget-screen.xsd (original) > +++ ofbiz/trunk/framework/widget/dtd/widget-screen.xsd Sat Jan 10 22:18:31 2015 > @@ -335,6 +335,7 @@ under the License. > </xs:enumeration> > <xs:enumeration value="anchor" /> > <xs:enumeration value="hidden-form" /> > + <!-- FIXME: This is not a link type. It indicates the target window should be a popup dialog. --> > <xs:enumeration value="ajax-window" /> > </xs:restriction> > </xs:simpleType> > @@ -375,67 +376,6 @@ under the License. > </xs:attribute> > </xs:complexType> > </xs:element> > - <xs:element name="parameter"> > - <xs:complexType> > - <xs:attribute type="xs:string" name="param-name" use="required" /> > - <xs:attribute type="xs:string" name="from-field" /> > - <xs:attribute type="xs:string" name="value" /> > - </xs:complexType> > - </xs:element> > - <xs:element name="auto-parameters-service"> > - <xs:complexType> > - <xs:sequence> > - <xs:element minOccurs="0" maxOccurs="unbounded" ref="exclude" /> > - </xs:sequence> > - <xs:attribute name="service-name" type="xs:string" use="required"> > - <xs:annotation> > - <xs:documentation>The service name used to resolve parameters. If empty, use form defaultServiceName. Flexible string allowed.</xs:documentation> > - </xs:annotation> > - </xs:attribute> > - <xs:attribute name="send-if-empty" default="true"> > - <xs:simpleType> > - <xs:restriction base="xs:token"> > - <xs:enumeration value="true" /> > - <xs:enumeration value="false" /> > - </xs:restriction> > - </xs:simpleType> > - </xs:attribute> > - </xs:complexType> > - </xs:element> > - <xs:element name="auto-parameters-entity"> > - <xs:complexType> > - <xs:sequence> > - <xs:element minOccurs="0" maxOccurs="unbounded" ref="exclude" /> > - </xs:sequence> > - <xs:attribute name="entity-name" type="xs:string" use="required"> > - <xs:annotation> > - <xs:documentation>The entity name used to resolve parameters. If empty use form defaultEntityName attribute. Flexible string allowed.</xs:documentation> > - </xs:annotation> > - </xs:attribute> > - <xs:attribute name="include" default="pk"> > - <xs:simpleType> > - <xs:restriction base="xs:token"> > - <xs:enumeration value="pk" /> > - <xs:enumeration value="nonpk" /> > - <xs:enumeration value="all" /> > - </xs:restriction> > - </xs:simpleType> > - </xs:attribute> > - <xs:attribute name="send-if-empty" default="true"> > - <xs:simpleType> > - <xs:restriction base="xs:token"> > - <xs:enumeration value="true" /> > - <xs:enumeration value="false" /> > - </xs:restriction> > - </xs:simpleType> > - </xs:attribute> > - </xs:complexType> > - </xs:element> > - <xs:element name="exclude"> > - <xs:complexType> > - <xs:attribute name="field-name" type="xs:string" use="required" /> > - </xs:complexType> > - </xs:element> > > <xs:element name="screenlet" substitutionGroup="AllWidgets"> > <xs:complexType> > > |
Re: svn commit: r1650821 - /ofbiz/trunk/framework/widget/
|
|
Thanks Youssef,
With the Adrian's commit log, I think it's an error, I restore it on revision 1652312. Nicolas Le 16/01/2015 00:24, Youssef Khaye a écrit : > Hi Adrian; > > In this commit, you deleted auto-parameters-service, > auto-parameters-entity and parameter but they still used by link > element ! > > Le 10/01/2015 23:18, [hidden email] a écrit : >> Author: adrianc >> Date: Sat Jan 10 22:18:31 2015 >> New Revision: 1650821 >> >> URL: http://svn.apache.org/r1650821 >> Log: >> FIXME comment in screen widget schema, no functional change. >> >> Modified: >> ofbiz/trunk/framework/widget/dtd/widget-screen.xsd >> >> Modified: ofbiz/trunk/framework/widget/dtd/widget-screen.xsd >> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-screen.xsd?rev=1650821&r1=1650820&r2=1650821&view=diff >> ============================================================================== >> >> --- ofbiz/trunk/framework/widget/dtd/widget-screen.xsd (original) >> +++ ofbiz/trunk/framework/widget/dtd/widget-screen.xsd Sat Jan 10 >> 22:18:31 2015 >> @@ -335,6 +335,7 @@ under the License. >> </xs:enumeration> >> <xs:enumeration value="anchor" /> >> <xs:enumeration value="hidden-form" /> >> + <!-- FIXME: This is not a link type. It >> indicates the target window should be a popup dialog. --> >> <xs:enumeration value="ajax-window" /> >> </xs:restriction> >> </xs:simpleType> >> @@ -375,67 +376,6 @@ under the License. >> </xs:attribute> >> </xs:complexType> >> </xs:element> >> - <xs:element name="parameter"> >> - <xs:complexType> >> - <xs:attribute type="xs:string" name="param-name" >> use="required" /> >> - <xs:attribute type="xs:string" name="from-field" /> >> - <xs:attribute type="xs:string" name="value" /> >> - </xs:complexType> >> - </xs:element> >> - <xs:element name="auto-parameters-service"> >> - <xs:complexType> >> - <xs:sequence> >> - <xs:element minOccurs="0" maxOccurs="unbounded" >> ref="exclude" /> >> - </xs:sequence> >> - <xs:attribute name="service-name" type="xs:string" >> use="required"> >> - <xs:annotation> >> - <xs:documentation>The service name used to >> resolve parameters. If empty, use form defaultServiceName. Flexible >> string allowed.</xs:documentation> >> - </xs:annotation> >> - </xs:attribute> >> - <xs:attribute name="send-if-empty" default="true"> >> - <xs:simpleType> >> - <xs:restriction base="xs:token"> >> - <xs:enumeration value="true" /> >> - <xs:enumeration value="false" /> >> - </xs:restriction> >> - </xs:simpleType> >> - </xs:attribute> >> - </xs:complexType> >> - </xs:element> >> - <xs:element name="auto-parameters-entity"> >> - <xs:complexType> >> - <xs:sequence> >> - <xs:element minOccurs="0" maxOccurs="unbounded" >> ref="exclude" /> >> - </xs:sequence> >> - <xs:attribute name="entity-name" type="xs:string" >> use="required"> >> - <xs:annotation> >> - <xs:documentation>The entity name used to >> resolve parameters. If empty use form defaultEntityName attribute. >> Flexible string allowed.</xs:documentation> >> - </xs:annotation> >> - </xs:attribute> >> - <xs:attribute name="include" default="pk"> >> - <xs:simpleType> >> - <xs:restriction base="xs:token"> >> - <xs:enumeration value="pk" /> >> - <xs:enumeration value="nonpk" /> >> - <xs:enumeration value="all" /> >> - </xs:restriction> >> - </xs:simpleType> >> - </xs:attribute> >> - <xs:attribute name="send-if-empty" default="true"> >> - <xs:simpleType> >> - <xs:restriction base="xs:token"> >> - <xs:enumeration value="true" /> >> - <xs:enumeration value="false" /> >> - </xs:restriction> >> - </xs:simpleType> >> - </xs:attribute> >> - </xs:complexType> >> - </xs:element> >> - <xs:element name="exclude"> >> - <xs:complexType> >> - <xs:attribute name="field-name" type="xs:string" >> use="required" /> >> - </xs:complexType> >> - </xs:element> >> <xs:element name="screenlet" substitutionGroup="AllWidgets"> >> <xs:complexType> >> >> > |
Re: svn commit: r1650821 - /ofbiz/trunk/framework/widget/
|
|
Thanks Nicolas!
If you don't mind, I would prefer to fix my own mistakes. I truly appreciate your interest in the framework code, and I don't intend to offend you, but is is important to me that I take ownership of my changes and fix the things I break. :) Adrian Crum Sandglass Software www.sandglass-software.com On 1/15/2015 3:47 PM, Nicolas Malin wrote: > Thanks Youssef, > > With the Adrian's commit log, I think it's an error, I restore it on > revision 1652312. > > Nicolas > > Le 16/01/2015 00:24, Youssef Khaye a écrit : >> Hi Adrian; >> >> In this commit, you deleted auto-parameters-service, >> auto-parameters-entity and parameter but they still used by link >> element ! >> >> Le 10/01/2015 23:18, [hidden email] a écrit : >>> Author: adrianc >>> Date: Sat Jan 10 22:18:31 2015 >>> New Revision: 1650821 >>> >>> URL: http://svn.apache.org/r1650821 >>> Log: >>> FIXME comment in screen widget schema, no functional change. >>> >>> Modified: >>> ofbiz/trunk/framework/widget/dtd/widget-screen.xsd >>> >>> Modified: ofbiz/trunk/framework/widget/dtd/widget-screen.xsd >>> URL: >>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-screen.xsd?rev=1650821&r1=1650820&r2=1650821&view=diff >>> >>> ============================================================================== >>> >>> --- ofbiz/trunk/framework/widget/dtd/widget-screen.xsd (original) >>> +++ ofbiz/trunk/framework/widget/dtd/widget-screen.xsd Sat Jan 10 >>> 22:18:31 2015 >>> @@ -335,6 +335,7 @@ under the License. >>> </xs:enumeration> >>> <xs:enumeration value="anchor" /> >>> <xs:enumeration value="hidden-form" /> >>> + <!-- FIXME: This is not a link type. It >>> indicates the target window should be a popup dialog. --> >>> <xs:enumeration value="ajax-window" /> >>> </xs:restriction> >>> </xs:simpleType> >>> @@ -375,67 +376,6 @@ under the License. >>> </xs:attribute> >>> </xs:complexType> >>> </xs:element> >>> - <xs:element name="parameter"> >>> - <xs:complexType> >>> - <xs:attribute type="xs:string" name="param-name" >>> use="required" /> >>> - <xs:attribute type="xs:string" name="from-field" /> >>> - <xs:attribute type="xs:string" name="value" /> >>> - </xs:complexType> >>> - </xs:element> >>> - <xs:element name="auto-parameters-service"> >>> - <xs:complexType> >>> - <xs:sequence> >>> - <xs:element minOccurs="0" maxOccurs="unbounded" >>> ref="exclude" /> >>> - </xs:sequence> >>> - <xs:attribute name="service-name" type="xs:string" >>> use="required"> >>> - <xs:annotation> >>> - <xs:documentation>The service name used to >>> resolve parameters. If empty, use form defaultServiceName. Flexible >>> string allowed.</xs:documentation> >>> - </xs:annotation> >>> - </xs:attribute> >>> - <xs:attribute name="send-if-empty" default="true"> >>> - <xs:simpleType> >>> - <xs:restriction base="xs:token"> >>> - <xs:enumeration value="true" /> >>> - <xs:enumeration value="false" /> >>> - </xs:restriction> >>> - </xs:simpleType> >>> - </xs:attribute> >>> - </xs:complexType> >>> - </xs:element> >>> - <xs:element name="auto-parameters-entity"> >>> - <xs:complexType> >>> - <xs:sequence> >>> - <xs:element minOccurs="0" maxOccurs="unbounded" >>> ref="exclude" /> >>> - </xs:sequence> >>> - <xs:attribute name="entity-name" type="xs:string" >>> use="required"> >>> - <xs:annotation> >>> - <xs:documentation>The entity name used to >>> resolve parameters. If empty use form defaultEntityName attribute. >>> Flexible string allowed.</xs:documentation> >>> - </xs:annotation> >>> - </xs:attribute> >>> - <xs:attribute name="include" default="pk"> >>> - <xs:simpleType> >>> - <xs:restriction base="xs:token"> >>> - <xs:enumeration value="pk" /> >>> - <xs:enumeration value="nonpk" /> >>> - <xs:enumeration value="all" /> >>> - </xs:restriction> >>> - </xs:simpleType> >>> - </xs:attribute> >>> - <xs:attribute name="send-if-empty" default="true"> >>> - <xs:simpleType> >>> - <xs:restriction base="xs:token"> >>> - <xs:enumeration value="true" /> >>> - <xs:enumeration value="false" /> >>> - </xs:restriction> >>> - </xs:simpleType> >>> - </xs:attribute> >>> - </xs:complexType> >>> - </xs:element> >>> - <xs:element name="exclude"> >>> - <xs:complexType> >>> - <xs:attribute name="field-name" type="xs:string" >>> use="required" /> >>> - </xs:complexType> >>> - </xs:element> >>> <xs:element name="screenlet" substitutionGroup="AllWidgets"> >>> <xs:complexType> >>> >>> >> > |
Re: svn commit: r1650821 - /ofbiz/trunk/framework/widget/
|
|
Le 16/01/2015 04:54, Adrian Crum a écrit :
> Thanks Nicolas! > > If you don't mind, I would prefer to fix my own mistakes. I truly > appreciate your interest in the framework code, and I don't intend to > offend you, but is is important to me that I take ownership of my > changes and fix the things I break. :) Don't worries Adrian, I hesitated to commit a quick fix or wait your correction. I privileged a quick correction with the risk that you will be angry and I know well the delete code because I'm at the origin of this code .... WHAT ? you delete my code ! :) Your mistakes reassures me, you are human ;) and I never do this on other case without sharing you before. Nicolas > > Adrian Crum > Sandglass Software > www.sandglass-software.com > > On 1/15/2015 3:47 PM, Nicolas Malin wrote: >> Thanks Youssef, >> >> With the Adrian's commit log, I think it's an error, I restore it on >> revision 1652312. >> >> Nicolas >> >> Le 16/01/2015 00:24, Youssef Khaye a écrit : >>> Hi Adrian; >>> >>> In this commit, you deleted auto-parameters-service, >>> auto-parameters-entity and parameter but they still used by link >>> element ! >>> >>> Le 10/01/2015 23:18, [hidden email] a écrit : >>>> Author: adrianc >>>> Date: Sat Jan 10 22:18:31 2015 >>>> New Revision: 1650821 >>>> >>>> URL: http://svn.apache.org/r1650821 >>>> Log: >>>> FIXME comment in screen widget schema, no functional change. >>>> >>>> Modified: >>>> ofbiz/trunk/framework/widget/dtd/widget-screen.xsd >>>> >>>> Modified: ofbiz/trunk/framework/widget/dtd/widget-screen.xsd >>>> URL: >>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/dtd/widget-screen.xsd?rev=1650821&r1=1650820&r2=1650821&view=diff >>>> >>>> >>>> ============================================================================== >>>> >>>> >>>> --- ofbiz/trunk/framework/widget/dtd/widget-screen.xsd (original) >>>> +++ ofbiz/trunk/framework/widget/dtd/widget-screen.xsd Sat Jan 10 >>>> 22:18:31 2015 >>>> @@ -335,6 +335,7 @@ under the License. >>>> </xs:enumeration> >>>> <xs:enumeration value="anchor" /> >>>> <xs:enumeration value="hidden-form" /> >>>> + <!-- FIXME: This is not a link type. It >>>> indicates the target window should be a popup dialog. --> >>>> <xs:enumeration value="ajax-window" /> >>>> </xs:restriction> >>>> </xs:simpleType> >>>> @@ -375,67 +376,6 @@ under the License. >>>> </xs:attribute> >>>> </xs:complexType> >>>> </xs:element> >>>> - <xs:element name="parameter"> >>>> - <xs:complexType> >>>> - <xs:attribute type="xs:string" name="param-name" >>>> use="required" /> >>>> - <xs:attribute type="xs:string" name="from-field" /> >>>> - <xs:attribute type="xs:string" name="value" /> >>>> - </xs:complexType> >>>> - </xs:element> >>>> - <xs:element name="auto-parameters-service"> >>>> - <xs:complexType> >>>> - <xs:sequence> >>>> - <xs:element minOccurs="0" maxOccurs="unbounded" >>>> ref="exclude" /> >>>> - </xs:sequence> >>>> - <xs:attribute name="service-name" type="xs:string" >>>> use="required"> >>>> - <xs:annotation> >>>> - <xs:documentation>The service name used to >>>> resolve parameters. If empty, use form defaultServiceName. Flexible >>>> string allowed.</xs:documentation> >>>> - </xs:annotation> >>>> - </xs:attribute> >>>> - <xs:attribute name="send-if-empty" default="true"> >>>> - <xs:simpleType> >>>> - <xs:restriction base="xs:token"> >>>> - <xs:enumeration value="true" /> >>>> - <xs:enumeration value="false" /> >>>> - </xs:restriction> >>>> - </xs:simpleType> >>>> - </xs:attribute> >>>> - </xs:complexType> >>>> - </xs:element> >>>> - <xs:element name="auto-parameters-entity"> >>>> - <xs:complexType> >>>> - <xs:sequence> >>>> - <xs:element minOccurs="0" maxOccurs="unbounded" >>>> ref="exclude" /> >>>> - </xs:sequence> >>>> - <xs:attribute name="entity-name" type="xs:string" >>>> use="required"> >>>> - <xs:annotation> >>>> - <xs:documentation>The entity name used to >>>> resolve parameters. If empty use form defaultEntityName attribute. >>>> Flexible string allowed.</xs:documentation> >>>> - </xs:annotation> >>>> - </xs:attribute> >>>> - <xs:attribute name="include" default="pk"> >>>> - <xs:simpleType> >>>> - <xs:restriction base="xs:token"> >>>> - <xs:enumeration value="pk" /> >>>> - <xs:enumeration value="nonpk" /> >>>> - <xs:enumeration value="all" /> >>>> - </xs:restriction> >>>> - </xs:simpleType> >>>> - </xs:attribute> >>>> - <xs:attribute name="send-if-empty" default="true"> >>>> - <xs:simpleType> >>>> - <xs:restriction base="xs:token"> >>>> - <xs:enumeration value="true" /> >>>> - <xs:enumeration value="false" /> >>>> - </xs:restriction> >>>> - </xs:simpleType> >>>> - </xs:attribute> >>>> - </xs:complexType> >>>> - </xs:element> >>>> - <xs:element name="exclude"> >>>> - <xs:complexType> >>>> - <xs:attribute name="field-name" type="xs:string" >>>> use="required" /> >>>> - </xs:complexType> >>>> - </xs:element> >>>> <xs:element name="screenlet" substitutionGroup="AllWidgets"> >>>> <xs:complexType> >>>> >>>> >>> >> |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |